New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Released
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:

Blocking:
issue 7677



Sign in to add a comment
link

Issue 7886: Implement TShirt sizing for changes in the dashboard and change-view

Reported by kaspern@google.com, Nov 30 2017 Project Member

Issue description

<eom>
 

Comment 1 by kaspern@google.com, Nov 30 2017

Project Member
Blocking: 7677

Comment 2 by kaspern@google.com, Dec 18 2017

Project Member
Labels: -Triaged-Yes Triaged-No
Owner: ----
Unassigning from me and putting into triage queue -- I don't think we ever really discussed implementing this beyond the abstract "let's do it, it would be nice to have".

Comment 3 by logan@google.com, Jan 2 2018

Project Member
Labels: -Triaged-No Triaged-Yes
Owner: vikt...@google.com
We definitely want to move to to-shirt sizing for the overall change. We can keep the size definition simple, like Critique.

Comment 4 by vikt...@google.com, Feb 14 2018

Project Member
Do we have mocks for this?

Comment 5 by vikt...@google.com, Feb 14 2018

Project Member
Cc: arnabb@google.com

Comment 6 by vikt...@google.com, Feb 14 2018

Project Member
I'm mostly concerned about dashboard view, which is already heavily crowded.

Comment 7 by vikt...@google.com, Feb 14 2018

Project Member
Status: AwaitingInformation (was: Accepted)

Comment 8 by kaspern@google.com, Feb 14 2018

Project Member
Status: Accepted (was: AwaitingInformation)
We do, yes. See the latest mocks in Gallery (Google internal only). It's up to us to define the sizes.

Comment 9 by vikt...@google.com, Feb 14 2018

Project Member
Ah, found it. Thanks!

Basically, it's to replace concrete numbers with a generic S, M, L, XL etc

Comment 10 by vikt...@google.com, Feb 14 2018

Project Member
So, TShirt sizing is based on the following paper:
http://dirkriehle.com/wp-content/uploads/2008/09/hicss-42-csdistr-final-web.pdf

And here's the first approximation, lines changed to the size:
0 => U
9 => XS
49 => S
249 => M
999 => L
else => XL

Comment 11 by vikt...@google.com, Feb 14 2018

Project Member
Also, can't find mocks for change-view with the sizing - is this still relevant?

Comment 12 by kaspern@google.com, Feb 14 2018

Project Member
It is definitely still relevant. You should consult with Arnab as to where this should go, and what it should look like.

Comment 13 by vikt...@google.com, Feb 22 2018

Project Member
We've discussed this with Arnab and here's the plan:
1. Sizing as per Comment 10 looks good for the start - ideally we should tune it
2. Dashboards should have TShirt sizing
3. Change view makes less sense to use TShirt sizing, especially when comparing different patchsets, so that might need a bit more thought.

Comment 14 by vikt...@google.com, Apr 6 2018

Project Member
Status: Released (was: Accepted)
Released quite some time ago.

Comment 15 by david.pu...@gmail.com, Nov 20

Labels: FixedIn-2.16

Sign in to add a comment