New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 7886 link

Starred by 2 users

Issue metadata

Status: Released
Owner:
Closed: Apr 2018
Cc:
Components:

Blocking:
issue 7677



Sign in to add a comment

Implement TShirt sizing for changes in the dashboard and change-view

Project Member Reported by kaspern@google.com, Nov 30 2017

Issue description

<eom>

 
Project Member

Comment 1 by kaspern@google.com, Nov 30 2017

Blocking: 7677
Project Member

Comment 2 by kaspern@google.com, Dec 18 2017

Labels: -Triaged-Yes Triaged-No
Owner: ----
Unassigning from me and putting into triage queue -- I don't think we ever really discussed implementing this beyond the abstract "let's do it, it would be nice to have".
Project Member

Comment 3 by logan@google.com, Jan 2 2018

Labels: -Triaged-No Triaged-Yes
Owner: vikt...@google.com
We definitely want to move to to-shirt sizing for the overall change. We can keep the size definition simple, like Critique.
Project Member

Comment 4 by vikt...@google.com, Feb 14 2018

Do we have mocks for this?
Project Member

Comment 5 by vikt...@google.com, Feb 14 2018

Cc: arnabb@google.com
Project Member

Comment 6 by vikt...@google.com, Feb 14 2018

I'm mostly concerned about dashboard view, which is already heavily crowded.
Project Member

Comment 7 by vikt...@google.com, Feb 14 2018

Status: AwaitingInformation (was: Accepted)
Project Member

Comment 8 by kaspern@google.com, Feb 14 2018

Status: Accepted (was: AwaitingInformation)
We do, yes. See the latest mocks in Gallery (Google internal only). It's up to us to define the sizes.
Project Member

Comment 9 by vikt...@google.com, Feb 14 2018

Ah, found it. Thanks!

Basically, it's to replace concrete numbers with a generic S, M, L, XL etc
Project Member

Comment 10 by vikt...@google.com, Feb 14 2018

So, TShirt sizing is based on the following paper:
http://dirkriehle.com/wp-content/uploads/2008/09/hicss-42-csdistr-final-web.pdf

And here's the first approximation, lines changed to the size:
0 => U
9 => XS
49 => S
249 => M
999 => L
else => XL

Project Member

Comment 11 by vikt...@google.com, Feb 14 2018

Also, can't find mocks for change-view with the sizing - is this still relevant?
Project Member

Comment 12 by kaspern@google.com, Feb 14 2018

It is definitely still relevant. You should consult with Arnab as to where this should go, and what it should look like.
Project Member

Comment 13 by vikt...@google.com, Feb 22 2018

We've discussed this with Arnab and here's the plan:
1. Sizing as per Comment 10 looks good for the start - ideally we should tune it
2. Dashboards should have TShirt sizing
3. Change view makes less sense to use TShirt sizing, especially when comparing different patchsets, so that might need a bit more thought.
Project Member

Comment 14 by vikt...@google.com, Apr 6 2018

Status: Released (was: Accepted)
Released quite some time ago.
Labels: FixedIn-2.16

Sign in to add a comment