New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Released
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
ReleasedIn: 422.0



Sign in to add a comment
link

Issue 7815: Unbind Up/Down from navigating the file list.

Reported by dominickn@chromium.org, Nov 21 2017 Project Member

Issue description

What steps will reproduce the problem?
1. Open a code review
2. Use Up/Down keys

What is the expected output?

The page moves up and down


What do you see instead?

Nothing. It doesn't work. Or worse, it will move up and down the file list, jumping from wherever I happen to be on the page.

Also, when diffs are open and I'm trying to review code, I'll often instinctively use Up/Down or j/k to try and move around a small increment (unlike Page Up/Page Down, which move a lot). It would be nice if j/k kept their current mapping and Up/Down were unbound so they did what you would expect them to on an ordinary page. :)
 

Comment 1 by jrn@google.com, Nov 24 2017

Project Member
Components: PolyGerrit

Comment 2 by logan@google.com, Nov 27 2017

Project Member
Labels: -Priority-3 Hotlist-FileList Triaged-Yes Priority-2
Owner: beckysiegel@google.com
Status: Accepted (was: New)

Comment 3 by beckysiegel@google.com, Nov 29 2017

Project Member
Status: ChangeUnderReview (was: Accepted)
https://gerrit-review.googlesource.com/c/gerrit/+/145351

Comment 4 by beckysiegel@google.com, Dec 5 2017

Project Member
ReleasedIn: 422.0
Status: Released (was: ChangeUnderReview)

Comment 5 by dominickn@chromium.org, Dec 5 2017

Thanks very much!

Comment 6 by wyatta@google.com, Mar 19 2018

Project Member
 Issue 8563  has been merged into this issue.

Comment 7 by david.pu...@gmail.com, Apr 11 2018

Labels: FixedIn-2.15.2

Comment 8 by david.pu...@gmail.com, Apr 11 2018

Status: Submitted (was: Released)
Accidentally set to released because a search for label:FixedIn-2.15 also includes the ones with FixedIn-2.15.2

Comment 9 by logan@google.com, Apr 11 2018

Project Member
Status: Released (was: Submitted)

Comment 10 by luca.mil...@gmail.com, Nov 20

Project Member
Labels: FixedIn-2.16

Sign in to add a comment