New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 7773 link

Starred by 4 users

Issue metadata

Status: Released
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
ReleasedIn: 475.0



Sign in to add a comment

Don't make the submit button one click submit

Reported by winsonc@google.com, Nov 15 2017

Issue description

Using polygerrit.  I just accidentally submitted a CL where I meant to push the reply button instead of the submit button because they are both the same color and placed right beside each other!  It's super easy to hit the wrong button and there should be some sort of guard, especially if there are un-replied comments that you don't automatically submit the CL.

Perhaps it should prompt to confirm you actually want to submit if:
a) it's not your own CL
or 
b) you have non submitted replies to the cl
 
Screenshot from 2017-11-15 11:45:04.png
15.7 KB View Download
Project Member

Comment 1 by logan@google.com, Nov 20 2017

Labels: Triaged-Yes Hotlist-ChangeActions Priority-3
Status: Accepted (was: New)
We fixed the adjacency of these buttons for  issue 7731  (soon to be deployed), but it would also be nice to have some sort of confirmation step. We could even offer a preview of what all will be submitted (and why).
Project Member

Comment 2 by wyatta@google.com, Mar 27 2018

Labels: -Priority-3 Priority-2
Owner: wyatta@google.com
Project Member

Comment 3 by wyatta@google.com, Mar 27 2018

Status: Started (was: Accepted)
Project Member

Comment 4 by wyatta@google.com, Mar 27 2018

Status: ChangeUnderReview (was: Started)
https://gerrit-review.googlesource.com/c/gerrit/+/168671
Project Member

Comment 5 by wyatta@google.com, Mar 28 2018

Status: Submitted (was: ChangeUnderReview)
Project Member

Comment 6 by logan@google.com, Mar 29 2018

ReleasedIn: 475.0
Status: Released (was: Submitted)
Labels: FixedIn-2.16

Sign in to add a comment