New issue
Advanced search Search tips

Issue 7053 link

Starred by 7 users

Issue metadata

Status: Released
Owner:
Closed: Nov 2017
Cc:
Components:
ReleasedIn: 419.0



Sign in to add a comment

Searching by author doesn't work.

Project Member Reported by erikc...@chromium.org, Aug 18 2017

Issue description

https://chromium-review.googlesource.com/q/author:%2522Erik+Chen+%253Cerikchen%2540chromium.org%253E%2522

I type in:
1) author:erikchen@chromium.org
2) There is a single autocomplete entry. When I press enter, the autocopmlete entry is substituted in.
3) The results are incomplete.

4) If I cancel the autocomplete entry by pressing "esc", and then press "enter", the results are complete.
 
Screen Shot 2017-08-18 at 4.46.29 PM.png
12.3 KB View Download
Screen Shot 2017-08-18 at 4.45.48 PM.png
400 KB View Download
Screen Shot 2017-08-18 at 4.45.33 PM.png
297 KB View Download
Project Member

Comment 1 by thomasmu...@yahoo.com, Aug 19 2017

Components: PolyGerrit
Project Member

Comment 2 by wyatta@google.com, Aug 21 2017

Status: AwaitingInformation (was: New)
> 3) The results are incomplete.

Do you have an example of a change which should appear in the results but doesn't?

I do see more results if I search using "owner:" instead of "author:".
There are two screenshots. The first shows expected results [cancel autocomplete]. The second shows actual results.

Exmple CL: https://chromium-review.googlesource.com/c/617646
Project Member

Comment 4 by wyatta@google.com, Aug 21 2017

Status: Accepted (was: AwaitingInformation)
Thank you. (I see now I should have figured that out from the screenshots.)

It looks like, when your full name is included in the query, it doesn't catch commits where your full name doesn't appear in the author line [1] whereas the ones that are identified by the query do include your full name [2].

If this is a search bug, then we might remove the PG component. But if this is a case where the suggestions are bad, maybe PG shouldn't suggest username queries.

[1] https://chromium-review.googlesource.com/c/617646/3//COMMIT_MSG#2
[2] https://chromium-review.googlesource.com/c/619649/7//COMMIT_MSG#2
Project Member

Comment 5 by dborowitz@google.com, Aug 21 2017

Based on #4, these search results seem correct. I feel like PG should not be suggesting usernames in author/committer searches.

(Separate question is how can we make the distinction between owner and author more obvious or at least less confusing.)
Project Member

Comment 6 by wyatta@google.com, Aug 21 2017

Labels: Milestone-Chromium-Afterglow
Project Member

Comment 7 by jrn@google.com, Nov 14 2017

 Issue 7736  has been merged into this issue.
Project Member

Comment 8 by jrn@google.com, Nov 14 2017

Is there a plan for how to solve this? Will polygerrit autocomplete to just the email, will change search treat 'Name <email>' as an OR, or something else?
Project Member

Comment 9 by jrn@google.com, Nov 14 2017

See https://gerrit-review.googlesource.com/c/gerrit/+/97237 for some discussion on why it currently uses AND instead of OR.
Project Member

Comment 10 by logan@google.com, Nov 14 2017

Labels: Triaged-No
Project Member

Comment 11 by logan@google.com, Nov 20 2017

Labels: -Triaged-No Hotlist-Search Triaged-Yes
Project Member

Comment 12 by logan@google.com, Nov 20 2017

Owner: kaspern@google.com
Project Member

Comment 13 by kaspern@google.com, Nov 21 2017

Status: ChangeUnderReview (was: Accepted)
https://gerrit-review.googlesource.com/c/gerrit/+/143550
Project Member

Comment 14 by kaspern@google.com, Nov 22 2017

Status: Submitted (was: ChangeUnderReview)
Project Member

Comment 15 by wyatta@google.com, Nov 29 2017

ReleasedIn: 419.0
Status: Released (was: Submitted)
Project Member

Comment 16 by logan@google.com, Sep 20

 Issue 9733  has been merged into this issue.
Labels: FixedIn-2.15.4

Sign in to add a comment