New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users

Issue metadata

Status: Released
Owner:
Last visit 21 days ago
Closed: Nov 20
Cc:
Components:



Sign in to add a comment
link

Issue 6984: "Discard" button on review comments is destructive, doesn't have a confirmation prompt and no undo

Reported by thakis@chromium.org, Aug 9 2017 Project Member

Issue description

Affected Version:

What steps will reproduce the problem?
1. Write some comment on a CL
2. Try to hit "Save", miss, and hit "Discard" accidentally

What is the expected output?

I should be able to get my carefully written comment back.


What do you see instead?

The comment contents are destroyed, I need to retype everything. For longer comments, that can cost several minutes.


Please provide any additional information below.
 

Comment 1 by logan@google.com, Sep 5 2017

Project Member
Labels: Triaged-Yes Hotlist-Comments Milestone-Chromium-Afterglow Priority-2
Owner: wyatta@google.com

Comment 2 by wyatta@google.com, Oct 18 2017

Project Member
Status: Started (was: New)

Comment 3 by wyatta@google.com, Oct 18 2017

Project Member
Status: ChangeUnderReview (was: Started)
https://gerrit-review.googlesource.com/c/gerrit/+/134413

Comment 4 by wyatta@google.com, Oct 19 2017

Project Member
Status: Submitted (was: ChangeUnderReview)

Comment 5 by gertvdijk@gmail.com, Oct 20 2017

Project Member
Just tested this with the latest 2.15 build. Works very well, thanks!

Maybe worth noting that it also displays the confirmation dialog after initially saving the comment. :-)

Comment 6 by wyatta@google.com, Oct 25 2017

Project Member
 Issue 7548  has been merged into this issue.

Comment 7 by kaspern@google.com, Oct 25 2017

Project Member
Status: Released (was: Submitted)

Comment 8 by dborowitz@google.com, Oct 26 2017

Project Member
Sorry to be a downer, but I strongly dislike the current confirmation dialog. I frequently discard comments as I'm developing a code review, and having to move my mouse far away from the discard button is quite annoying. For me personally, the ratio of intentionally to unintentionally discarded drafts is high.

I completely sympathize with the original problem, however, that discard is unnecessarily destructive. Rather than a confirmation dialog, I would prefer some kind of undo mechanism, such as:
* A toast with an undo button.
* A short inline thing with an undo button
* Prepopulate a new comment box with the old text if you recreate a comment on the same line.

Comment 9 by wyatta@google.com, Oct 26 2017

Project Member
Status: Accepted (was: Released)

Comment 10 by wyatta@google.com, Dec 1 2017

Project Member
The plan is to replace the confirmation with some kind of unobtrusive undo toast.

Comment 11 by luca.mil...@gmail.com, Nov 20

Project Member
Status: Released (was: Accepted)

Comment 12 by david.pu...@gmail.com, Nov 20

Labels: FixedIn-2.16

Sign in to add a comment