New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 6198 link

Starred by 16 users

Issue metadata

Status: Released
Owner:
Last visit > 30 days ago
Closed: Sep 26
Cc:
Components:

Blocking:
issue 4314



Sign in to add a comment

Can't set preference to control whitespace diff in new UI

Reported by vlovich@google.com, May 11 2017

Issue description

Affected Version:
2.14-773-gd9d2de7604

What steps will reproduce the problem?
1.  dos2unix a file with CRLF line-endings
2.  View in gerrit diff

What is the expected output?
I expect to be able to ignore line-ending changes in the new UI like in the old.

What do you see instead?
The ignore trailing whitespace option appears to have no effect.

Please provide any additional information below.
Would also be neat to have the full set of whitespace control options as in the old UI (all whitespace, leading, trailing, leading & trailing, etc).

 
Project Member

Comment 1 by wyatta@google.com, May 19 2017

Status: Accepted (was: New)
The ignore_whitespace preference hasn't been implemented in PolyGerrit. See the tracking- issue 4314  for preferences parity.
Project Member

Comment 2 by kaspern@google.com, Oct 16 2017

 Issue 7364  has been merged into this issue.
Project Member

Comment 3 by wyatta@google.com, Nov 1 2017

Blocking: 4314
Project Member

Comment 4 by logan@google.com, Nov 1 2017

 Issue 7584  has been merged into this issue.
Project Member

Comment 5 by logan@google.com, Nov 1 2017

Labels: Triaged-Yes Priority-3 Hotlist-GWT
Project Member

Comment 6 by logan@google.com, Jan 5 2018

Labels: -Priority-3 -Triaged-Yes Triaged-Undecided Hotlist-Settings Priority-2 Hotlist-Diff
Project Member

Comment 7 by wyatta@google.com, Jan 8 2018

Labels: -Triaged-Undecided Triaged-Yes
Owner: wyatta@google.com
Project Member

Comment 8 by wyatta@google.com, Feb 12 2018

 Issue 8297  has been merged into this issue.
Project Member

Comment 9 by wyatta@google.com, Mar 19 2018

 Issue 8549  has been merged into this issue.
Project Member

Comment 10 by logan@google.com, May 7 2018

 Issue 8925  has been merged into this issue.
Project Member

Comment 11 by kaspern@google.com, May 18 2018

 Issue 9035  has been merged into this issue.
Project Member

Comment 12 by kaspern@google.com, Jun 6

 Issue 9181  has been merged into this issue.
Project Member

Comment 13 by kaspern@google.com, Jun 15

 Issue 9281  has been merged into this issue.
Looks like this has been open for over a year. Are there any plans for fixing this? Seems like a huge regression given how hard it is to review code now.
I'd also love to see this feature return.
Project Member

Comment 16 by wyatta@google.com, Jul 2

 Issue 9374  has been merged into this issue.
Project Member

Comment 17 by wyatta@google.com, Aug 20

Status: Started (was: Accepted)
Project Member

Comment 18 by gertvdijk@gmail.com, Sep 11

 Issue 9708  has been merged into this issue.
Project Member

Comment 19 by wyatta@google.com, Sep 14

Status: ChangeUnderReview (was: Started)
https://gerrit-review.googlesource.com/c/gerrit/+/193591
Project Member

Comment 20 by kaspern@google.com, Sep 26

Status: Released (was: ChangeUnderReview)
Labels: FixedIn-2.16
One more small request here:

If a file diff consists *only* of whitespace changes, the current UI just shows blank file contents for both files. It feels like a bug until you realize that there are only whitespace changes. Can this view be changed to contain a message like "Whitespace changes only. Disable 'ignore whitespace' setting to see the changes" ?
Project Member

Comment 23 by gertvdijk@gmail.com, Nov 20

@svv: That sounds a bit like Issue 7993 (although that's about auto-merge, I think it might be the same implementation to indicate the diff is zero).
Thanks, it is possible, although I've never seen the auto-merge CLs so I haven't experienced that particular problem.

Sign in to add a comment