New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 5946 link

Starred by 11 users

Issue metadata

Status: Accepted
Owner:
Cc:
Components:



Sign in to add a comment

Simplify comparing a patch set with the latest patch set

Project Member Reported by sop@google.com, Apr 5 2017

Issue description

Currently in PolyGerrit, when I click the link for a comment, the default view shows the diff between Base and the patch set with the comment. I almost always click the comment links when I want to see the changes the author applied in response to the comment. It makes more sense to me to display the Comment -> Latest Patch Set diff by default. (If the comment is on the latest, then it still should be Base -> Comment of course.)

It would also be helpful to have "diff with Base" and "diff with Latest" links. Fiddling with the patch set drop-down menus to change from Base -> N to N -> Latest is way too painful (especially when I accidentally click the Base drop-down first, because I can't select N until the right-hand side has been moved from N to Latest).
 
Project Member

Comment 1 by wyatta@google.com, Apr 6 2017

Labels: Type-Feature Milestone-Chromium-Afterglow Priority-2
Status: Accepted (was: New)
Project Member

Comment 2 by kaspern@google.com, Jun 28 2017

Owner: kaspern@google.com
Project Member

Comment 3 by logan@google.com, Sep 11 2017

 Issue 7172  has been merged into this issue.
Project Member

Comment 4 by kaspern@google.com, Oct 31 2017

Labels: Hotlist-PatchRange
Project Member

Comment 5 by logan@google.com, Nov 1 2017

 Issue 7613  has been merged into this issue.
Project Member

Comment 6 by logan@google.com, Nov 14 2017

Issue 7746 has been merged into this issue.
Project Member

Comment 7 by logan@google.com, Nov 27 2017

Labels: UX-Requirement
Project Member

Comment 8 by logan@google.com, Nov 28 2017

Labels: -ux-requirement UX-Current
Project Member

Comment 9 by logan@google.com, Dec 28 2017

Labels: Triaged-Yes
Project Member

Comment 10 by kaspern@google.com, Apr 18

 Issue 8788  has been merged into this issue.
Project Member

Comment 11 by kaspern@google.com, Apr 18

From 8788:
I often have this workflow:
* CL author uploads patch set 1
* I comment on patch set 1
* Author replies the comment, uploads a new patch set
* I open the comment thread on patch set 1 to read the reply
* Now I want to compare the last patch set to the one I commented on.

So, essentially I want to switch from a base..1 diff to 1..2 (assuming 2 is the latest patch set), but it currently requires two interactions (base..1 -> base..2 -> 1..2), they have to be in the correct order because Gerrit doesn't allow the same patch set on both sides, and I have to remember the old patch set number because the intermediate step loses that information. Having a single button to do this would be very nice :)

Sign in to add a comment