Monorail Project: gerrit Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 547 Sanity check ChangeIDs on push
Starred by 20 users Project Member Reported by jaysoff...@gmail.com, Apr 27 2010 Back to list
Status: Accepted
Owner: ----



Sign in to add a comment
Affected Version: 2.1.2.2

What steps will reproduce the problem?
Gerrit doesn't currently do any sanity checking of the ChangeID on pushes to a branch. A 
developer tried to submit a patch through gerrit, got a conflict, and then tried to deal with the 
conflict in git via merge. Somehow they ended up pushing two separate commits with the same 
ChangeID

What is the expected output? What do you see instead?
When a commit is being pushed to a branch (not to the special refs/for space) and the commit 
has a ChangeID footer:

Gerrit should block the push unless it knows of the ChangeID AND the change is open and 
approved/valid.

This should be an optional permission. I can envision a scenario were you might want to merge 
in a commit from an upstream source (also using gerrit) that has ChangeID unknown to the local 
gerrit installation.


 
Comment 1 by sop@google.com, Apr 27 2010
Status: Accepted
Project Member Comment 2 by jaysoff...@gmail.com, Apr 27 2010
I got as far as I could before I ran into a wall https://review.source.android.com/14447
Project Member Comment 3 by nas...@codeaurora.org, Feb 17 2012
Is this still an issue in 2.2.2 and/or tip?
Project Member Comment 4 by logan@google.com, Aug 17 2016
Labels: Priority-3
Sign in to add a comment