Issue 5433: New UI does not have selectable SHAs

[[ Restricting the issue because of the screenshot for an internal tool. ]]

The screenshot is not an image of PolyGerrit. If it's presented as an example of how to present commit and parent SHAs, I can't find them in that UI.

If weblinks are configured (e.g. Gitiles) we do present the SHA of individual patches as links at the top of the file list (albeit abbreviated SHAs, but the full SHA appears in the href).

The parent SHA is typically not shown because the final value of the parent reference depends partially on how the change is merged.

Oh wow.  That was totally the wrong screenshot.  Trying again.

Notice the "commit" and "parent" SHAs below the commit message.

Sure, the final value of the parent SHA changes, but it should be updated when the patch lands.  Before then, the parent at the point when the patch was uploaded is shown.

Please reopen.

Deleted: Screenshot 2017-02-03 at 10.40.43.png 449 KB

	Screenshot 2017-02-03 at 10.40.43.png 449 KB View Download

Just today I would have liked to get the parent id to check if a given patch introduced a regression (without necessarily checking out m/master which had advanced significantly in the mean time).

 Issue 5474  has been merged into this issue.

 Issue 5510  has been merged into this issue.

 Issue 5684  has been merged into this issue.

 Issue 5889  has been merged into this issue.

Is this being worked on?

On the one hand my precise mouse selection skills (see  issue 5474 ) are dramatically improving, on the other hand I still miss this feature...

Thanks ,-)

This issue is slated for the afterglow milestone, so work on it is planned.

I still miss this feature ,-(

When is "afterglow" planned?

We're currently working on afterglow features. Upping the priority.

Done in https://gerrit-review.googlesource.com/c/119091/

 Issue 7327  has been merged into this issue.

 Issue 7833  has been merged into this issue.

A few notes from discussion with UX designers:

1. We should add a copy-to-clipboard button next to SHA1s we display. The full SHA1 should be copied, but only the abbreviated SHA1 should be displayed.

2. The need to display the parent SHA1(s) isn't clearly explained here, so we should start with just decorating the SHA1s we currently display. Having access to the patch set's SHA1 is a good start, parents are easily accessible from there on the git command line.

P2 still feels right for this issue, but it needs an owner.

> The need to display the parent SHA1(s) isn't clearly explained here […] parents are easily accessible from there on the git command line.

In principle everything is accessible from the git command line, but that doesn't obviate a usable Web UI.

Showing parent commits in the UI, and making it possible to copy their SHAs, is useful for navigating related commits in Gerrit, both before and after they're submitted.

 Issue 7983  has been merged into this issue.

 Issue 8119  has been merged into this issue.