New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 5433 link

Starred by 15 users

Issue metadata

Status: Released
Owner:
Closed: Dec 2017
Cc:
Components:
ReleasedIn: 432.0



Sign in to add a comment

New UI does not have selectable SHAs

Project Member Reported by djkurtz@chromium.org, Feb 3 2017

Issue description

Affected Version: 2.13.5-2589-g0c8afabf25

What steps will reproduce the problem?
1. View CL
2. Try to find Parent SHA
3.

What is the expected output?

Full SHA of commit and parent are shown near top of page, and are click-to-selectable.

What do you see instead?

Way at the bottom a URL link with an abbreviated SHA.

Please provide any additional information below.

A one click 'select' operation of CL & parent SHAs are very useful when using gerrit along with other git tools.
 
Project Member

Comment 1 by wyatta@google.com, Feb 3 2017

Labels: Restrict-View-Google
Status: WontFix (was: New)
[[ Restricting the issue because of the screenshot for an internal tool. ]]

The screenshot is not an image of PolyGerrit. If it's presented as an example of how to present commit and parent SHAs, I can't find them in that UI.

If weblinks are configured (e.g. Gitiles) we do present the SHA of individual patches as links at the top of the file list (albeit abbreviated SHAs, but the full SHA appears in the href).

The parent SHA is typically not shown because the final value of the parent reference depends partially on how the change is merged.
Oh wow.  That was totally the wrong screenshot.  Trying again.

Notice the "commit" and "parent" SHAs below the commit message.

Sure, the final value of the parent SHA changes, but it should be updated when the patch lands.  Before then, the parent at the point when the patch was uploaded is shown.

Please reopen.
Screenshot 2017-02-03 at 10.40.43.png
449 KB View Download
Just today I would have liked to get the parent id to check if a given patch introduced a regression (without necessarily checking out m/master which had advanced significantly in the mean time).
Project Member

Comment 4 by logan@google.com, Feb 8 2017

 Issue 5474  has been merged into this issue.
Project Member

Comment 5 by logan@google.com, Feb 8 2017

Labels: -Restrict-View-Google Milestone-Chromium-Afterglow Priority-3
Status: Accepted (was: WontFix)
Project Member

Comment 6 by wyatta@google.com, Feb 8 2017

 Issue 5510  has been merged into this issue.
Project Member

Comment 7 by logan@google.com, Mar 2 2017

 Issue 5684  has been merged into this issue.
Project Member

Comment 8 by logan@google.com, Mar 29 2017

 Issue 5889  has been merged into this issue.
Is this being worked on?

On the one hand my precise mouse selection skills (see  issue 5474 ) are dramatically improving, on the other hand I still miss this feature...

Thanks ,-)
Project Member

Comment 10 by wyatta@google.com, Apr 24 2017

This issue is slated for the afterglow milestone, so work on it is planned.
I still miss this feature ,-(

When is "afterglow" planned?
Project Member

Comment 12 by wyatta@google.com, Aug 7 2017

Labels: -Priority-3 Priority-2
We're currently working on afterglow features. Upping the priority.

Comment 13 Deleted

Project Member

Comment 14 by thomasmu...@yahoo.com, Aug 10 2017

Project Member

Comment 15 by thomasmu...@yahoo.com, Sep 23 2017

Status: ChangeUnderReview (was: Accepted)
Project Member

Comment 16 by kaspern@google.com, Oct 10 2017

Cc: kaspern@google.com
 Issue 7327  has been merged into this issue.
Project Member

Comment 17 by logan@google.com, Nov 27 2017

Labels: Triaged-Undecided
Project Member

Comment 18 by logan@google.com, Nov 27 2017

 Issue 7833  has been merged into this issue.
Project Member

Comment 19 by logan@google.com, Nov 27 2017

Labels: UX-NeedsTriage
Project Member

Comment 20 by logan@google.com, Nov 28 2017

Labels: -UX-NeedsTriage UX-Info
Project Member

Comment 21 by logan@google.com, Nov 28 2017

Labels: -ux-info UX-Acked
Project Member

Comment 22 by logan@google.com, Dec 4 2017

Labels: Hotlist-ChangeMetadata Hotlist-GWT
A few notes from discussion with UX designers:

1. We should add a copy-to-clipboard button next to SHA1s we display. The full SHA1 should be copied, but only the abbreviated SHA1 should be displayed.

2. The need to display the parent SHA1(s) isn't clearly explained here, so we should start with just decorating the SHA1s we currently display. Having access to the patch set's SHA1 is a good start, parents are easily accessible from there on the git command line.

P2 still feels right for this issue, but it needs an owner.
> The need to display the parent SHA1(s) isn't clearly explained here […] parents are easily accessible from there on the git command line.

In principle everything is accessible from the git command line, but that doesn't obviate a usable Web UI.

Showing parent commits in the UI, and making it possible to copy their SHAs, is useful for navigating related commits in Gerrit, both before and after they're submitted.
Project Member

Comment 24 by beckysiegel@google.com, Dec 5 2017

Status: New (was: ChangeUnderReview)
Project Member

Comment 25 by logan@google.com, Dec 11 2017

Labels: -Triaged-Undecided Triaged-Yes
Owner: vikt...@google.com
Status: Accepted (was: New)
Project Member

Comment 26 by vikt...@google.com, Dec 11 2017

Status: ChangeUnderReview (was: Accepted)
Project Member

Comment 27 by vikt...@google.com, Dec 13 2017

Status: Submitted (was: ChangeUnderReview)
Project Member

Comment 28 by logan@google.com, Dec 14 2017

 Issue 7983  has been merged into this issue.
Project Member

Comment 29 by beckysiegel@google.com, Dec 15 2017

ReleasedIn: 430.0
Project Member

Comment 30 by beckysiegel@google.com, Dec 19 2017

ReleasedIn: 431.0
Project Member

Comment 31 by logan@google.com, Dec 20 2017

ReleasedIn: 432.0
Status: Released (was: Submitted)
Project Member

Comment 32 by logan@google.com, Jan 22 2018

 Issue 8119  has been merged into this issue.
Labels: FixedIn-2.16

Sign in to add a comment