New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Released
Owner: ----
Closed: Apr 2018
Cc:



Sign in to add a comment
link

Issue 5181: Assignee suggestion should only suggest accounts that can see the change

Reported by ekempin@google.com, Dec 20 2016 Project Member

Issue description

Affected Version: master (commit 709627f8)

What steps will reproduce the problem?
1. Create a change for a project with restricted read access
2. Go to the change screen and start typing the name of a user who can't see the change in the assignee input box.

What is the expected output?
Users which can't see the change are not suggested as assignee.


What do you see instead?
User that can't see the change is suggested as assignee.


Please provide any additional information below.
Trying to add the user that can't see the change as assignee fails (as expected since the change is not visible to that user).
 

Comment 1 by ekempin@google.com, Dec 30 2016

Project Member
I've implemented two alternative solutions for this:
1. https://gerrit-review.googlesource.com/93476
2. https://gerrit-review.googlesource.com/93462

Comment 2 by ekempin@google.com, Dec 30 2016

Project Member
Status: ChangeUnderReview (was: New)

Comment 3 by david.pu...@gmail.com, Mar 25 2018

Labels: FixedIn-2.14.8
Status: Submitted (was: ChangeUnderReview)

Comment 4 by ekempin@google.com, Mar 26 2018

Project Member
Components: PolyGerrit
Status: New (was: Submitted)
For the GWT UI this was fixed by:
https://gerrit-review.googlesource.com/c/gerrit/+/165671

A similar fix still needs to be done for PolyGerrit.

Comment 5 by david.pu...@gmail.com, Mar 27 2018

Cc: thomasmu...@yahoo.com

Comment 6 by david.pu...@gmail.com, Apr 10 2018

Components: -PolyGerrit
Status: Submitted (was: New)
I have raised a new issue for fixing the PG part.  See  issue 8722 .

Comment 7 by david.pu...@gmail.com, Apr 20 2018

Status: Released (was: Submitted)

Comment 8 by luca.mil...@gmail.com, Nov 20

Project Member
Labels: FixedIn-2.16

Sign in to add a comment