New issue
Advanced search Search tips

Issue 505 link

Starred by 26 users

Issue metadata

Status: Released
Owner: ----
Closed: Sep 2014



Sign in to add a comment

Allow reviewer to make code changes

Reported by alexeagle@google.com, Mar 20 2010

Issue description

I just talked to Tyler about this feature I've always wanted. He showed me 
Gerrit and it looks like this might be something Gerrit could do.

I'd like the reviewer to be able to make code changes. Maybe there's a 
minor style nitpick, and they could just make the change instead of writing 
instructions for the reviewee to do it. Or, they might make a substantive 
comment about an alternate implementation and want to explain it in 
terms of code rather than writing it out as a narrative.

The changes made by the reviewer should appear as just another patch set, 
with their name next to it in the revision history list.

I blogged a longer version of the reasoning for this here: 
http://jakeherringbone.com/2009/08/what-code-reviews-ought-to-be/
 

Comment 1 by sop@google.com, Mar 20 2010

Status: Accepted
We might be able to embed Bespin or something.

Comment 2 by nasser@chromium.org, Mar 23 2010

You should also note that reviewers are (generally) allowed to upload a new patch set 
to someone else's change (unlike Rietveld where they'd need to create a new review).

Comment 3 by sop@google.com, Mar 23 2010

Which is one reason why its OK for us to also offer an online
editor directly in the browser.  After the edit is complete the
reviewer has just "uploaded" a new patch set onto the review.

:-)
Hi,
It seems that this feature (Allow reviewer to make code changes) is available in gerrit.
Can you please let me know the link to change which was submitted for this feature.
Thanks.

Comment 5 by neufe...@gmail.com, Jun 16 2014

Imho even the review-screens in 2.9 don't allow you to edit sourcecode-files directly. See: https://gerrit-documentation.storage.googleapis.com/Documentation/2.9/user-review-ui.html
Project Member

Comment 7 by david.os...@gmail.com, Sep 10 2014

Labels: FixedIn-2.11
Status: Submitted
Status: Released

Sign in to add a comment