New issue
Advanced search Search tips
Starred by 3 users
Status: Released
Owner: ----
Closed: Dec 2016



Sign in to add a comment
Gerrit-2.13.2 doesn't support gitweb hyperlinks for parent commit on Change Screen
Reported by gardenia...@gmail.com, Nov 10 2016 Back to list
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version:

What steps will reproduce the problem?
1.upgrade gerrit from 2.12.4 to 2.13.2
2.modify gerrit.config,add "type = gitweb" at section gitweb

[gitweb]
	cgi = /usr/local/httpd-2.4.4/htdocs/gitweb.cgi
	type = gitweb
3.start gerrit and click any change


What is the expected output?

commit and parent commit both display gitweb hyperlinks on Change Screen

What do you see instead?

Parent commit doesn't have gitweb hyperlinks.


Please provide any additional information below.

on Gerrit-2.12.4, gitweb hyperlinks works fine, but once upgraded to 2.13.2, parent commit's hyperlinks doesn't work any more. please see attachments


 
gerrit-2.12.4.jpg
53.4 KB View Download
gerrit-2.13.2.jpg
55.3 KB View Download
Cc: sop@google.com
It looks like this was intentionally removed:

https://gerrit-review.googlesource.com/#/c/78640/

yeah, but keeping the parent's hyperlink is more convenient and useful and i suggest that new version should recover this feature.
We also use this at Wikimedia, useful too. Could we re add the support please?
I doint understand why we removed the links from parent links?

We should just re add the support.
Comment 5 Deleted
Project Member Comment 7 by huga...@gmail.com, Dec 9 2016
Status: ChangeUnderReview
Cc: -sop@google.com
Labels: FixedIn-2.13.4
Status: Released
https://gerrit-review.googlesource.com/#/c/92850/
Sign in to add a comment