Monorail Project: gerrit Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 4715 Change reviewer suggests members without project access since 2.13
Starred by 5 users Reported by jerome.o...@gmail.com, Oct 6 2016 Back to list
Status: Released
Owner: ----
Closed: Dec 2016



Sign in to add a comment
After upgrading to 2.13, I started noticing that the "Add Reviewer" dialog
started suggesting users that were not suggested before, in particular
users without access to the related project.

Affected Version: 2.13.1

What steps will reproduce the problem?

 1. Have a setup with different user groups allowing access to different
    projects, ex group "internals" for internal_project and group
    "externals" for external_project.

 2. Open a change in internal_project, Add Reviewer, start typing.

 3. Observe suggestion of all Externals member.


What is the expected output?

 I don't think members of a group without access to a project appeared 
 before gerrit 2.13. It would make sense they don't appear.


What do you see instead?

 A list of all accounts matching the typed text, even those without 
 access to the project.

Please provide any additional information below.

 n/a

 
Project Member Comment 1 by luca.mil...@gmail.com, Dec 18 2016
Project Member Comment 2 by ekempin@google.com, Dec 19 2016
 Issue 5160  has been merged into this issue.
Same issue appears to be a problem for the assignee field.

Project Member Comment 4 by ekempin@google.com, Dec 20 2016
 > Same issue appears to be a problem for the assignee field.

Right, but this requires a different fix. I filed issue 5181 to track this separately.
Project Member Comment 5 by ekempin@google.com, Dec 20 2016
Labels: FixedIn-2.13.5
Status: Submitted
Status: Released
Sign in to add a comment