Monorail Project: gerrit Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 4 users
Status: Released
Owner: ----
Closed: Nov 2016
Cc:



Sign in to add a comment
SSH key is broken on schema upgrade
Reported by org...@gmail.com, Sep 27 2016 Back to list
Affected Version: 2.13

What steps will reproduce the problem?
1. Upgrade from 2.12 to 2.13

What is the expected output?
All SSH keys should be imported properly.

What do you see instead?
Some of the keys are not.

Please provide any additional information below.
The initial import of my keys looks like this (in All-Users.git). I replaced all the addresses and characters in the key: https://gist.github.com/orgads/ac48122677014253562e4193e5bb613a

Notice one of the lines is split into 4 lines. All of these 4 are considered invalid.

I might have pasted this key once from somewhere with multiple lines, although I can't find any evidence for \n in the corresponding 2.12 DB entry.
 
Project Member Comment 3 by thomasmu...@yahoo.com, Oct 1 2016
But i have no idea how to fix it, or if that was intentional.
Hi,

I feel that we saw the same issue for several people in my company.
Their ssh key was working correctly, but then after the upgrade of Gerrit from 2.12 to 2.13, there were like 3, 4 other keys and they were not considered valid.

Are you working on this issue ? They could access Gerrit by re-putting their keys, but that was weird ^^"
Comment 6 by org...@gmail.com, Nov 21 2016
Any news?
Cc: ekempin@google.com
RFC change uploaded:

https://gerrit-review.googlesource.com/#/c/91815/

but I haven't tested with a live server yet.  I need to find a way to get a 2.12 server running with SSH keys containing line breaks.

Project Member Comment 9 by ekempin@google.com, Nov 24 2016
Labels: FixedIn-2.12.3
Status: Submitted
Project Member Comment 10 by ekempin@google.com, Nov 24 2016
Labels: -FixedIn-2.12.3 FixedIn-2.13.3
Status: Released
Sign in to add a comment