Monorail Project: gerrit Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 4633 Emails are sent for watched project despite "New Changes" being unchecked
Starred by 3 users Reported by org...@gmail.com, Sep 25 2016 Back to list
Status: Released
Owner: ----
Closed: Oct 26



Sign in to add a comment
Affected Version: 2.13

What steps will reproduce the problem?
1. Watch a project with some condition
2. Uncheck New Changes notification
3. (As another user) push a change that *does not* satisfy the condition

What is the expected output?
You should not be notified by email

What do you see instead?
You are

Please provide any additional information below.
There are 2 bugs here:

1. New Changes is unchecked.
2. The condition is not satisfied, so even if I would have checked New Changes I shouldn't have received these emails.

The is:watched query does work as expected (filters by the condition).
 
Comment 1 by org...@gmail.com, Sep 29 2016
Can anyone have a look? This is really frustrating...
Well, I tried to investigate it and found that there's a difference between getWatchersFromIndex and getWatchersFromDb.

getWatchersFromIndex seems to scan through all the watched project, not only the project with the current change.

Fix pending: https://gerrit-review.googlesource.com/90013
Project Member Comment 3 by ekempin@google.com, Oct 26
Labels: FixedIn-2.13.3
Status: Submitted
Issue 4830 has been merged into this issue.
Status: Released
Sign in to add a comment