New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users

Issue metadata

Status: Released
Owner: ----
Closed: Oct 2016

Sign in to add a comment

OAuth extension point: NPE when user name is not set

Project Member Reported by, Sep 24 2016

Issue description

Affected Version: 2.13.1 (and master)

What steps will reproduce the problem?
1. Upgrade to 2.13.1 on site with working gerrit-oauth-provider plugin (Google OAuth)
3. Try to login

What is the expected output?

Login is successful, as it was the case before the upgrade

What do you see instead?

NPE: [1]

Please provide any additional information below.

This is caused by: [2] and prevents upgrade to 2.13. Some OAuth2 providers don't require user name to be set. Most notably it's usually not set for Google OAuth accounts.


Project Member

Comment 1 by, Sep 24 2016

Status: Accepted (was: New)
Project Member

Comment 4 by, Sep 28 2016

In case you need emergency fix for that, working Gerrit release with Google-OAuth provider, based on 2.13.1 + 3 commits reverted was uploaded here:
Labels: FixedIn-2.13.2
Status: Submitted (was: Accepted)
Status: Released (was: Submitted)

Sign in to add a comment