Monorail Project: gerrit Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 4627 OAuth extension point: NPE when user name is not set
Starred by 6 users Project Member Reported by david.os...@gmail.com, Sep 24 2016 Back to list
Status: Submitted
Owner: ----
Closed: Oct 2016
Cc:



Sign in to add a comment

Affected Version: 2.13.1 (and master)

What steps will reproduce the problem?
1. Upgrade to 2.13.1 on site with working gerrit-oauth-provider plugin (Google OAuth)
3. Try to login

What is the expected output?

Login is successful, as it was the case before the upgrade

What do you see instead?

NPE: [1]

Please provide any additional information below.

This is caused by: [2] and prevents upgrade to 2.13. Some OAuth2 providers don't require user name to be set. Most notably it's usually not set for Google OAuth accounts.

[1] http://paste.openstack.org/show/582849
[2] https://gerrit-review.googlesource.com/73753

 
Project Member Comment 1 by david.os...@gmail.com, Sep 24 2016
Cc: ziv...@gmail.com
Status: Accepted
Project Member Comment 4 by david.os...@gmail.com, Sep 28 2016
In case you need emergency fix for that, working Gerrit release with Google-OAuth provider, based on 2.13.1 + 3 commits reverted was uploaded here:

https://github.com/davido/gerrit-oauth-provider/releases/tag/v2.13.1
Labels: FixedIn-2.13.2
Status: Submitted
https://gerrit-review.googlesource.com/#/c/87330/
Sign in to add a comment