New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Released
Owner:
Closed: Oct 2016
Cc:
Components:



Sign in to add a comment

Emails should be batched when being sent to multiple reviewers/cc

Project Member Reported by andyb...@chromium.org, Sep 14 2016

Issue description

Currently, when you specify multiple reviewers in the reply dialog, an individual email is sent to each one.

It should behave like an email compose dialog, with one email being sent to all recipients. This would allow users to see who else is on the review based on just the email.
 
Project Member

Comment 1 by andyb...@chromium.org, Oct 4 2016

Cc: hie...@google.com
Labels: Milestone-Chromium-Fishfood
Owner: wyatta@google.com
Basically, we should be emulating Critique’s behavior.
Project Member

Comment 2 by wyatta@google.com, Oct 11 2016

When I look at emails I receive from Gerrit-review, I see all the reviewers listed in the To and CC lines.

Sometimes the salutation only includes one name (sometimes it's mine, but not always). This may give the impression that the email is individual when it isn't.

I may be missing something, though. Are un-batched emails still definitely being sent?
Project Member

Comment 3 by andyb...@chromium.org, Oct 11 2016

I’ve seen threads where another email was created for each person when I can’t imagine the author opened the reply dialog that many times.

The salutation also makes it seem worse, yeah.
Project Member

Comment 4 by wyatta@google.com, Oct 11 2016

In the GWT UI one still needs to add each reviewer individually. Perhaps these bursts come from a non-PG user.

I will create a separate ticket for the salutation bug.
Project Member

Comment 5 by wyatta@google.com, Oct 28 2016

Status: Started (was: Accepted)
Project Member

Comment 6 by wyatta@google.com, Oct 28 2016

Status: ChangeUnderReview (was: Started)
https://gerrit-review.googlesource.com/c/90390/
Status: Submitted (was: ChangeUnderReview)
Project Member

Comment 8 by wyatta@google.com, Oct 30 2016

Status: Started (was: Submitted)
Rolled back because of build failures. Standby.
Project Member

Comment 9 by wyatta@google.com, Oct 31 2016

Status: Submitted (was: Started)
https://gerrit-review.googlesource.com/c/90450/
Project Member

Comment 10 by kaspern@google.com, Feb 2 2017

Status: Released (was: Submitted)

Sign in to add a comment