New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Released
Owner: ----
Closed: Sep 2016



Sign in to add a comment

Improve error message when Change-Id missing

Reported by matt...@unsolvable.org, Sep 2 2016 Back to list

Issue description

When you push to Gerrit, Gerrit checks that all new commits have a Change-Id. If any new commit is missing the Change-Id, the push is rejected with an error message that include the following text:

"missing Change-Id in commit message footer
Processing changes: refs: 1
Processing changes: refs: 1, done    
ERROR: missing Change-Id in commit message footer"

What happens then is that the developer looks at the change they just attempted to push, verifies that the Change-Id is there, and goes "what??". I get called, and it turns out that an EARLIER change was missing the Change-Id.

Can I suggest that the reject message be changed to say:
ERROR: missing Change-Id in commit message footer for commit <SHA1>.

That makes it explicit which commit message Gerrit is unhappy with, and for developers who are not experts in Gerrit, it draws their attention to that fact that the problem commit message might not be for the top commit.

I haven't looked at the code, but instinct tells me this should be a straightforward change.

 
Labels: FixedIn-2.13
Status: Submitted
This was already done [1] and will be in version 2.13.

[1] https://gerrit-review.googlesource.com/#/c/75914/

Great! I missed that.
Project Member

Comment 4 by huga...@gmail.com, Sep 22 2016

Status: Released

Sign in to add a comment