New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 4437 link

Starred by 34 users

Issue metadata

Status: Released
Owner:
Closed: Jan 2018
Cc:
Components:
ReleasedIn: 445.0

Blocking:
issue 5457
issue 8131



Sign in to add a comment

Implement inline edit in PolyGerrit

Project Member Reported by vikt...@google.com, Aug 24 2016

Issue description

Project Member

Comment 1 by andyb...@chromium.org, Aug 25 2016

Status: Accepted (was: New)

Comment 2 by rmis...@google.com, Sep 6 2016

I was just about to file a similar issue. Can this be a P2? it is starred by 5 users (so far).
Project Member

Comment 3 by andyb...@chromium.org, Sep 6 2016

 Issue 3914  has been merged into this issue.
Project Member

Comment 4 by andyb...@chromium.org, Sep 6 2016

Priorities are re-evaluated continuously depending on the goals of the quarter. This will likely have an owner soon so priority will be bumped up when it does.

Comment 5 by vapier@chromium.org, Dec 16 2016

i think the question is about the Milestone.  the GWT UI provides it, so Polygerrit can't seriously replace GWT until it has edit capabilities.  i know a number of CrOS devs use it ... not sure if you can pull those stats out from the history though.
Project Member

Comment 6 by andyb...@chromium.org, Dec 16 2016

Labels: -Priority-3 Milestone-Chromium-Afterglow Priority-2
This will be implemented. We won't be regressing this functionality from the GWT UI and never had plans to.
Project Member

Comment 7 by logan@google.com, Feb 8 2017

Blocking: 5457
Project Member

Comment 8 by kaspern@google.com, Apr 18 2017

 Issue 6027  has been merged into this issue.
Project Member

Comment 9 by david.os...@gmail.com, Apr 30 2017

Status: ChangeUnderReview (was: Accepted)
https://gerrit-review.googlesource.com/105104
Project Member

Comment 10 by jrn@google.com, May 4 2017

 Issue 4591  has been merged into this issue.
Project Member

Comment 11 by wyatta@google.com, May 11 2017

 Issue 6192  has been merged into this issue.
Project Member

Comment 12 by wyatta@google.com, Jun 24 2017

 Issue 6570  has been merged into this issue.
Project Member

Comment 13 by kaspern@google.com, Jul 11 2017

Owner: kaspern@google.com
Status: Accepted (was: ChangeUnderReview)
Project Member

Comment 14 by logan@google.com, Jul 13 2017

 Issue 6722  has been merged into this issue.
Project Member

Comment 15 by logan@google.com, Jul 14 2017

 Issue 6735  has been merged into this issue.
Project Member

Comment 16 by thomasmu...@yahoo.com, Jul 28 2017

Labels: Blocking-2.15
Project Member

Comment 17 by kaspern@google.com, Sep 14 2017

Cc: kaspern@google.com
 Issue 7213  has been merged into this issue.
Project Member

Comment 18 by logan@google.com, Sep 26 2017

Labels: -Blocking-2.15
Discussed with dborowitz@, we decided these aren't 2.15 blockers.
Project Member

Comment 19 by thomasmu...@yahoo.com, Sep 26 2017

I wonder could this be backported to stable-2.15 once it is done even if there is a 2.15.x release? please.
Project Member

Comment 20 by logan@google.com, Sep 26 2017

We can see how feasible it is to backport when the time comes, but first we have to implement it. It's going to be a large series of changes that touch a lot of code, which will simultaneously be receiving a lot of style and layout changes. 
Project Member

Comment 21 by logan@google.com, Sep 30 2017

Labels: Hotlist-GWT
Project Member

Comment 22 by kaspern@google.com, Oct 10 2017

 Issue 7284  has been merged into this issue.
Project Member

Comment 23 by wyatta@google.com, Oct 13 2017

 Issue 7427  has been merged into this issue.
Project Member

Comment 24 by logan@google.com, Nov 27 2017

 Issue 7855  has been merged into this issue.
Project Member

Comment 25 by kaspern@google.com, Dec 8 2017

 Issue 7946  has been merged into this issue.
Hey all, is there an ETA on this being implemented?
Project Member

Comment 27 by kaspern@google.com, Dec 8 2017

It's a P1 OKR for our team this quarter, and is in progress right now. I'd estimate it should be live on Google3 by EOY, but that's subject to change.

Current status is that a large amount of the functionality is supported (all actions on files, and editing a file), but the editing experience is not as rich as I'd like. Incorporating CodeMirror is the next step, and is in progress here: https://gerrit-review.googlesource.com/c/plugins/codemirror-editor/+/142430
Thank you Kasper!  Would we want to turn on the feature with the current editing experience and turn on the richer experience later?
Project Member

Comment 29 by kaspern@google.com, Dec 8 2017

Sure thing!

I think that, for now, the minimum requirement for me to be happy setting the editing experience live is a functional CodeMirror editor with working syntax highlighting. As of right now, the editor built into PolyGerrit is mostly just for debugging -- it doesn't properly capture tabs or any keyboard shortcuts, doesn't have syntax highlighting, and doesn't even support saving without navigating away from the page.

It's likely that the version of the editing experience that I set live may not respect preconfigured user preferences. In my opinion, that's the kind of thing that can be added post-hoc.

How does that sound to you?
Ah, totally understand.  I guess my minimum baseline would be:  Does it perform the same/as well as old Gerrit?  If so, then it would be useful as is, if not, then understand holding off.  Thank you again!
Project Member

Comment 31 by kaspern@google.com, Dec 19 2017

Status update!

DONE
- Per-file actions can be performed successfully in the file list (delete, rename, etc etc)
- Codemirror-based editor has been merged and built both upstream and internally
- Modifications to a file made with that editor can be saved (pending https://gerrit-review.googlesource.com/c/gerrit/+/148271)

TODO (probably roughly in this order):
- Enable creation of a change edit in the new UI
- Troubleshoot codemirror-native syntax highlighting not working (and fix)
- Begin adding in QoL improvements to the editor view (keyboard shortcuts, caching of edits to localstorage to guard against dataloss)
- Begin supporting user editor preferences

The list of TODOs is long and gets vague, so the time scale for that is uncertain... But I still expect to hit the goal of allowing edits in PolyGerrit by the new year.
Project Member

Comment 32 by logan@google.com, Dec 28 2017

Labels: Triaged-Yes
Project Member

Comment 33 by logan@google.com, Jan 17 2018

Blocking: 8131
Project Member

Comment 34 by kaspern@google.com, Jan 19 2018

Status: ChangeUnderReview (was: Accepted)
https://gerrit-review.googlesource.com/c/gerrit/+/153252
Project Member

Comment 35 by kaspern@google.com, Jan 23 2018

Status: Submitted (was: ChangeUnderReview)
Project Member

Comment 36 by logan@google.com, Jan 24 2018

ReleasedIn: 444.0
Project Member

Comment 37 by kaspern@google.com, Jan 25 2018

ReleasedIn: 445.0
Status: Released (was: Submitted)
Project Member

Comment 38 by kaspern@google.com, May 31 2018

 Issue 9122  has been merged into this issue.
Project Member

Comment 39 by kaspern@google.com, Aug 7

 Issue 9537  has been merged into this issue.
Project Member

Comment 40 by kaspern@google.com, Sep 27

 Issue 9777  has been merged into this issue.
Project Member

Comment 41 by kaspern@google.com, Oct 11

 Issue 9844  has been merged into this issue.
Project Member

Comment 42 by kaspern@google.com, Oct 11

 Issue 9848  has been merged into this issue.
Labels: FixedIn-2.16

Sign in to add a comment