New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 4278 link

Starred by 20 users

Issue metadata

Status: Released
Owner: ----
Closed: Jan 11
Cc:



Sign in to add a comment

Wrong code snippet in email notifications

Project Member Reported by ekempin@google.com, Jul 19 2016

Issue description

Affected Version: current master (2.12.3-3293-gbcec870)

What steps will reproduce the problem?
1. Upload a change
2. Comment on one word in the commit message, e.g. the word "on" (inline range comment) 
3. Use online edit to replace the word on which the comment was done, e.g. replace "on" with "with"
4. Publish the edit and reply with 'Done' to the inline comment

What is the expected output? What do you see instead?

Expected content in email notification:

"https://gerrit-review.googlesource.com/#/c/80240/1//COMMIT_MSG
Commit Message:

PS1, Line 7: on
with
Done"

Actual content in email notification:

"https://gerrit-review.googlesource.com/#/c/80240/1//COMMIT_MSG
Commit Message:

PS1, Line 7: wi
with
Done"

The code snippet that is given for PS1, Line 7 is wrong, in PS1 the code was still "on" and not "wi".


Please provide any additional information below.

This is the change on which this just happened:
  https://gerrit-review.googlesource.com/#/c/80240/1..2//COMMIT_MSG

 
Project Member

Comment 1 by logan@google.com, Aug 17 2016

Labels: Priority-3
Cc: sop@google.com
 Issue 4519  has been merged into this issue.
Project Member

Comment 3 by andyb...@chromium.org, Nov 2 2016

Labels: Hotlist-Email
 Issue 4943  has been merged into this issue.
Cc: wyatta@google.com
 Issue 6036  has been merged into this issue.
 Issue 6160  has been merged into this issue.
 Issue 6185  has been merged into this issue.
Project Member

Comment 8 by logan@google.com, Jul 25 2017

Cc: logan@google.com
 Issue 6808  has been merged into this issue.
Project Member

Comment 9 by logan@google.com, Jul 25 2017

Labels: -Priority-3 Priority-1
Owner: han...@google.com
Status: Accepted (was: New)
This has been recently escalated by chrome-infra. Is there an easy fix?
Project Member

Comment 10 by wyatta@google.com, Aug 16 2017

 Issue 7037  has been merged into this issue.
Project Member

Comment 11 by wyatta@google.com, Aug 16 2017

Note that online-edit is not needed to repro. This happens when the diff is modified by new patch sets created by either means. (Most issues being merged into this don't list edit in their repro steps.)
Project Member

Comment 12 by wyatta@google.com, Aug 18 2017

Cc: carlosk@chromium.org
 Issue 7051  has been merged into this issue.
Project Member

Comment 13 by aga...@chromium.org, Sep 7 2017

I just experienced this again:

Patch Set #1, Line 25: print 'python-dateutil package required'
> This fails, as logging isn't imported or set up
Oops, done

The context should have said "logging.error('python-dateutil package required')", hence the comment about the logging module not existing.

Given the number of reports of this (8 bugs have been duped into this one) this should be prioritized.
Project Member

Comment 14 by logan@google.com, Sep 7 2017

Filed internally as a P1 (b/65455720) to ensure it gets picked up.
Project Member

Comment 15 by logan@google.com, Jan 5 2018

 Issue 8084  has been merged into this issue.
Project Member

Comment 16 by wyatta@google.com, Mar 13 2018

 Issue 8533  has been merged into this issue.
Project Member

Comment 17 by wyatta@google.com, Aug 17

 Issue 9603  has been merged into this issue.
Please close the issue. It was submitted in 2.16.
Labels: FixedIn-2.16.3
Status: Released (was: Accepted)
Owner: ----

Sign in to add a comment