Monorail Project: gerrit Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user
Status: Released
Owner: ----
Closed: Jun 2016
Cc:



Sign in to add a comment
SubmitWholeTopic does not update subscriptions
Reported by maa...@gmail.com, May 6 2016 Back to list
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.12-rc2

What steps will reproduce the problem?
0. Set submitWholeTopic in config to true
1. Subscribe a subproject to a superproject using submodules
2. Make a change in super project with topic X
3. Make a change in subproject with topic X
4. Submit whole topic

What is the expected output? What do you see instead?
Expected: superproject is updated after the change are submitted to the head of the submodule's branch
What i see: Only the submitted changes are merged in the final branch ... superproject does not link to the head of the subproject any more

Please provide any additional information below.
I know that the setting submitWholeTopic is experimental but it should be fixed sooner or later. I didn't check it with the latest build, just with RC2.

 
Cc: sbeller@google.com
Status: AwaitingInformation
According to the acceptance tests in SubmoduleSubscriptionsWholeTopicMergeIT, this should work as expected.

Status: Accepted
Confirmed with manual test that it does not update the subscription.
I overlooked that the test does not include a change on the superproject when submitting the whole topic.

In [1] I've extended the test to do that, and it now fails.

[1] https://gerrit-review.googlesource.com/77599

Status: ChangeUnderReview
https://gerrit-review.googlesource.com/#/c/77678/
Project Member Comment 5 by sbeller@google.com, Jun 14 2016
Status: Submitted
Project Member Comment 6 by huga...@gmail.com, Aug 9 2016
Labels: FixedIn-2.13
Project Member Comment 7 by huga...@gmail.com, Sep 22 2016
Status: Released
Sign in to add a comment