New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Released
Owner:
Last visit > 30 days ago
Closed: Feb 2016



Sign in to add a comment

add an attribute to the change-info REST response showing the merged date

Project Member Reported by zaro0...@gmail.com, Sep 22 2015 Back to list

Issue description

I would like to get information about when a change was merged using the Gerrit REST API.  The only way to get that info is to use the change-info[1] endpoint which will return a response[2] with a date that goes along with the message "Change has been successfully merged into the git repository."  Parsing for the date info tied to this message is not ideal and can be unreliable, especially since this comment has gone thru changes in various Gerrit releases.  t would be a lot nicer if there was a dedicated attribute like 'merged-date' for this info, maybe right at the top of the json, next to the "status": "MERGED" attribute.

[1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-info
[2] http://paste.openstack.org/show/473565/

 
Project Member

Comment 1 by zaro0...@gmail.com, Sep 22 2015

This can probably be done by adding the hidden 'SUBM' approval info to the REST response.  That label is exposed via the SSH api [3].  Since Gerrit always goes directly from submit to merge then the submit (SUBM) approval 'grantedOn' date is always identical or nearly identical to the merged date for changes that are in "status":"MERGED".

[3] http://paste.openstack.org/show/473629/

 Issue 3580  has been merged into this issue.
Project Member

Comment 3 by zaro0...@gmail.com, Jan 6 2016

Owner: zaro0...@gmail.com
Project Member

Comment 4 by zaro0...@gmail.com, Jan 7 2016

Status: ChangeUnderReview
The submissionId contains the date when a change was submitted.  Proposed change https://gerrit-review.googlesource.com/73650
Project Member

Comment 5 by zaro0...@gmail.com, Jan 7 2016

replaced 73650 with https://gerrit-review.googlesource.com/#/c/73651/
Project Member

Comment 6 by ekempin@google.com, Feb 8 2016

Labels: FixedIn-2.13
Status: Submitted
Project Member

Comment 7 by huga...@gmail.com, Sep 22 2016

Status: Released

Sign in to add a comment