New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Released
Owner:
Email to this user bounced
Closed: Aug 2015
Cc:



Sign in to add a comment
link

Issue 3477: Side-by-side not accessible for changes with current draft PS

Reported by org...@gmail.com, Jul 15 2015

Issue description

Affected Version: 2.11

What steps will reproduce the problem?
1. Push a commit to gerrit
2. Amend the commit and push it as a draft
3. Try to open side-by-side diff for PS1 as a user that is not a reviewer of the change.

What is the expected output? What do you see instead?
Nothing happens. Since PS1 is not a draft, it should be visible.

Please provide any additional information below.
If you add yourself as a reviewer, you can access the diff, and you can access the draft PS (but that's a separate bug).
 

Comment 1 by org...@gmail.com, Aug 2 2015

ping

Comment 2 by david.pu...@sonymobile.com, Aug 3 2015

Owner: david.pu...@sonymobile.com
Will look into this.

Comment 3 by david.pu...@sonymobile.com, Aug 3 2015

Console is showing this error:

Mon Aug 03 18:38:30 GMT+900 2015 Class$S631
SEVERE: (TypeError) : Cannot read property '_number' of undefinedClass$S123: (TypeError) : Cannot read property '_number' of undefined
	at Unknown.$_number_0(gerrit_ui-0.js)
	at Unknown.onSuccess_262(gerrit_ui-2.js)
	at Unknown.onSuccess_263(gerrit_ui-2.js)
	at Unknown.applySuccess(gerrit_ui-0.js)
	at Unknown.apply_2(gerrit_ui-0.js)
	at Unknown.success(gerrit_ui-0.js)
	at Unknown.onSuccess_311(gerrit_ui-0.js)
	at Unknown.onSuccess_316(gerrit_ui-0.js)
	at Unknown.execute_21(gerrit_ui-0.js)
	at Unknown.onResponseReceived_0(gerrit_ui-0.js)
	at Unknown.fireOnResponseReceived(gerrit_ui-0.js)
	at Unknown.onReadyStateChange(gerrit_ui-0.js)
	at Unknown.<anonymous>(gerrit_ui-0.js)
	at Unknown.apply_8(gerrit_ui-0.js)
	at Unknown.entry0(gerrit_ui-0.js)
	at Unknown.<anonymous>(gerrit_ui-0.js)

Comment 5 by david.pu...@sonymobile.com, Aug 3 2015

Cc: david.os...@gmail.com
Status: Accepted

Comment 6 by david.pu...@sonymobile.com, Aug 3 2015

> and you can access the draft PS (but that's a separate bug).

This part is not a bug.  It is intentional that reviewers can see draft patch sets.

Comment 7 by david.pu...@sonymobile.com, Aug 3 2015

Comment 8 by edwin.ke...@gmail.com, Aug 4 2015

Project Member
Labels: FixedIn-2.11.3
Status: Submitted

Comment 9 by david.pu...@sonymobile.com, Aug 21 2015

Status: Released

Sign in to add a comment