New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Released
Owner: ----
Closed: May 2015



Sign in to add a comment

Disabling a plugin doesn't work when running Gerrit on Windows 7

Reported by org...@gmail.com, Apr 16 2015

Issue description

Affected Version: 2.11, running on Windows 7

What steps will reproduce the problem?
1. ssh server plugin rm plugin

What is the expected output? What do you see instead?
It should be disabled, and the jar file should be renamed jar.disabled.

Instead, the plugin is temporarily disabled then re-enabled, and the log reads:

[2015-04-16 16:39:50,511] INFO  com.google.gerrit.server.plugins.PluginLoader : Disabling plugin myplugin
[2015-04-16 16:39:50,512] INFO  com.google.gerrit.server.plugins.PluginLoader : Unloading plugin myplugin
[2015-04-16 16:39:50,736] WARN  com.google.gerrit.server.plugins.PluginLoader : Cannot load disabled plugin myplugin
java.io.FileNotFoundException: C:\Projects\gerrit\plugins\myplugin.jar.disabled (The system cannot find the file specified)
	at java.util.zip.ZipFile.open(Native Method)
	at java.util.zip.ZipFile.<init>(Unknown Source)
	at java.util.zip.ZipFile.<init>(Unknown Source)
	at java.util.jar.JarFile.<init>(Unknown Source)
	at java.util.jar.JarFile.<init>(Unknown Source)
	at com.google.gerrit.server.plugins.JarPluginProvider.getJarPluginName(JarPluginProvider.java:72)
	at com.google.gerrit.server.plugins.JarPluginProvider.getPluginName(JarPluginProvider.java:63)
	at com.google.gerrit.server.plugins.UniversalServerPluginProvider.getPluginName(UniversalServerPluginProvider.java:48)
	at com.google.gerrit.server.plugins.PluginLoader.loadServerPlugin(PluginLoader.java:578)
	at com.google.gerrit.server.plugins.PluginLoader.loadPlugin(PluginLoader.java:554)
	at com.google.gerrit.server.plugins.PluginLoader.disablePlugins(PluginLoader.java:249)
	at com.google.gerrit.sshd.commands.PluginRemoveCommand.run(PluginRemoveCommand.java:47)
	at com.google.gerrit.sshd.SshCommand$1.run(SshCommand.java:35)
	at com.google.gerrit.sshd.BaseCommand$TaskThunk.run(BaseCommand.java:445)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(Unknown Source)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
	at com.google.gerrit.server.git.WorkQueue$Task.run(WorkQueue.java:379)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)
... [plugin initialization logs] ...
[2015-04-16 16:40:45,321] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin myplugin, version 2.11
[2015-04-16 16:40:51,721] WARN  com.google.gerrit.server.plugins.PluginLoader : Cannot delete C:\Projects\gerrit\tmp\plugin_myplugin_150416_1138_4745915026451720768.jar, retrying to delete it on termination of the virtual machine

 
Summary: Disabling a plugin doesn't work when running Gerrit on Windows 7 (was: Disabling a plugin doesn't work)
Status: ChangeUnderReview
https://gerrit-review.googlesource.com/#/c/67197/
Project Member

Comment 4 by edwin.ke...@gmail.com, May 11 2015

Labels: FixedIn-2.11.1
Status: Submitted
Status: Released

Sign in to add a comment