New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Released
Owner:
Last visit > 30 days ago
Closed: Mar 2016



Sign in to add a comment

Stream events do not include the label (vote) info

Project Member Reported by zaro0...@gmail.com, Feb 27 2015 Back to list

Issue description

We use stream events heavily and want info on the votes even if it did not change.  One of our use cases is to automate tasks depending on comments and label info on any event.  An event that encompass the entire data of the event (include the labels) would help.

Affected Version: master

What steps will reproduce the problem?
1. view the Gerrit stream events
2. create a change
3. vote on that change with a Code-Review +1/-1 

Note - the event contains the label info:
"approvals":[{"type":"Code-Review","description":"Code-Review","value":"1"}],"comment":"Patch Set 2: Code-Review+1"}

4. now vote on that change again. This time add a comment but don't change any votes.
Note - the event does not contain the label infos, only the comment that was added.

What is the expected output? What do you see instead?
I would expect the event to contain the label info even if it didn't change. 


 
Project Member

Comment 1 by zaro0...@gmail.com, Feb 27 2015

Owner: zaro0...@gmail.com
Status: ChangeUnderReview
change for this: https://gerrit-review.googlesource.com/#/c/65530
Labels: FixedIn-2.12
Status: Submitted
Project Member

Comment 3 by edwin.ke...@gmail.com, May 19 2015

Labels: -FixedIn-2.12
Status: New
The change was reverted:
  https://gerrit-review.googlesource.com/67973

Comment 4 by icee...@gmail.com, May 21 2015

The problem is, that there are different use cases where the current behaviour seems better. 

E.g. we have a custom label that triggers builds on jenkins (via gerrit-trigger-plugin) if it is set. So we do not want this to appear in the event if a unrelated comment is set on the change.
Project Member

Comment 5 by zaro0...@gmail.com, May 24 2015

@iceelch, Could you please help me understand your use case a little more?  When a comment is added to a change how can you tell if it is unrelated to that change?  The label appearing in the stream event only means that there has been some modification to a vote it does not mean that the associated comments are related to that change.  I think in your use case you still have the data to either trigger or ignore.  In my use case I need both the comment and label data to decide whether I want to trigger a build. 
Project Member

Comment 6 by zaro0...@gmail.com, Jun 1 2015

Status: ChangeUnderReview
Sorry guys, could we please try again?  This change includes a fix for the tests: https://gerrit-review.googlesource.com/#/c/68242
Project Member

Comment 8 by zaro0...@gmail.com, Mar 25 2016

Status: Submitted
Project Member

Comment 9 by ekempin@google.com, Apr 4 2016

Labels: FixedIn-2.13
Project Member

Comment 11 by huga...@gmail.com, Sep 22 2016

Status: Released

Sign in to add a comment