New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Released
Owner: ----
Closed: Feb 2015



Sign in to add a comment

Please don't +2 when I type "LGTM"

Reported by stad...@android.com, Jan 27 2015

Issue description


What steps will reproduce the problem?
1. Review a change
2. Click Reply
3. Click "+1"
4. Type "LGTM after you fix X and Y"
5. Send the reply
6. Note with horror that you accidentally sent +2

Reasons why I think this is not a good idea.

1.  The text when you select +1 is "Looks good to me, but someone else must approve".  In other words, it's false to assume that LGTM means +2 when it could also mean +1

2.  You shouldn't be overriding input I already made (clicking on +1)

3.  If you ever add an "auto submit on +2" feature, this would trigger submit when unintended.


 
Status: ChangeUnderReview
This feature annoys me too, but I suspect there are people who like it.

I've uploaded this change that removes it:

https://gerrit-review.googlesource.com/#/c/63762/

Let's see if anyone objects.
Project Member

Comment 2 by david.os...@gmail.com, Jan 28 2015

> In other words, it's false to assume that LGTM means +2 when it could also mean +1

Just ask gerrit admin to revoke your +2 ACL, and this feature works as expected ,-)

Comment 3 by sop@google.com, Feb 3 2015

Labels: FixedIn-2.11
Status: Submitted
Status: Released

Sign in to add a comment