New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Released
Owner: ----
Closed: Nov 2015



Sign in to add a comment

Be able to remove specific scores from a reviewer while leaving the reviewer still listed on the change

Reported by david.pu...@sonymobile.com, Nov 27 2014 Back to list

Issue description

As discussed in the code review on [1].

We should consider moving the [x] to kill votes onto the votes themselves.

If a reviewer voted multiple time, say VRFY, CRVW & LC. Now someone
removes her VRFY vote. The VRFY is removed but the CRVW and LC stay.

We could then do more fine grained removals of votes in the ACL system. Allow removing a VRFY-1, but not a CRVW-2 for example.

We also want to be able to keep a reviewer as a reviewer on the change, but just kill their scores to work around a blocking vote. This would at present demote them to a CC status, but its better than dropping them entirely off the change where they might not get notifications anymore.

Removing a reviewer is also sensible, and doing so should also drop their votes as no longer relevant to the change.

[1] https://gerrit-review.googlesource.com/#/c/60245/

 
Project Member

Comment 1 by david.os...@gmail.com, Dec 2 2014

Status: Accepted
Project Member

Comment 2 by david.os...@gmail.com, Dec 12 2014

Status: ChangeUnderReview
https://gerrit-review.googlesource.com/62410
Project Member

Comment 3 by ekempin@google.com, Nov 25 2015

Labels: FixedIn-2.13
Status: Submitted
Project Member

Comment 4 by huga...@gmail.com, Sep 22 2016

Status: Released

Sign in to add a comment