New issue
Advanced search Search tips
Starred by 2 users
Status: Released
Owner: ----
Closed: Aug 2016



Sign in to add a comment
Restore ability to go back to change list by keyboard shortcut from diff view
Reported by florent....@intersec.com, Oct 14 2014 Back to list
In the old change screen one could press g+o or g+i, ... to go to some dashboard from the diff view. In the new change screen, those shortcut disappeared.
 
Project Member Comment 1 by zaro0...@gmail.com, Mar 4 2016
Status: AwaitingInformation
From the change screen 'g+i' will take you back to dashboard.  if you are in diff view then you need to do 'u' to get to change screen then 'g+i' will take you back to dashboard.  Is that not what you expect?
With the "old" change screen, "g+i" worked directly form the diff view. This was handy since you didn't have to care about what you were currently. In the new change screen you need to go back to the change screen from the diff view in order to go back to the change list. This lacks of consistency : while some shortcuts are clearly specific to a single page, there is no good reason for the "site navigation" shortcuts not to be available from every existing page.

Moreover, I often inadvertently type "g+i" from the diff view, which, instead of loading the "my changes" dashboard, alter the intra-line diff setting (i toggle that setting).
Fortunately, CodeMirror 4.8 added support for multi-stroke keymaps. I'm restoring this feature in https://gerrit-review.googlesource.com/#/c/76197/
The change to restore this feature has been merged to master.
Nice, thanks!
Project Member Comment 6 by huga...@gmail.com, Aug 9 2016
Labels: FixedIn-2.13
Status: Submitted
Project Member Comment 7 by huga...@gmail.com, Sep 22 2016
Status: Released
Sign in to add a comment