Monorail Project: gerrit Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 44 users
Status: Submitted
Owner: ----
Closed: Sep 2014
Cc:


Sign in to add a comment
arbitrary labels/tags on changes
Reported by nasser@chromium.org, Sep 30 2009 Back to list
A useful feature would be a way for approvers to provide hints about how
rigorous a verification a change should undergo.

For example the ability for an approver to flag a change as "high risk" or
"low risk." High risk changes should be run through more testing than a low
risk change.

This is most useful in an automated environment, possibly one where changes
could be batched together in risk categories.
 
Comment 1 by s...@google.com, Oct 30 2009
Status: Accepted
Summary: arbitrary labels/tags on changes (was: NULL)
See also this discussion on the mailing list:

http://groups.google.com/group/repo-discuss/browse_thread/thread/5767a9bd67fe6634/b7e948f163356f66


If we have generic labels on changes, one could implement risk levels by
tagging changes with Risk-Low or Risk-High, and search for them.
Comment 2 by sop@google.com, Jan 31 2010
Labels: Milestone-2.1.3
Comment 3 by sop@google.com, Apr 26 2010
Labels: -Milestone-2.1.3
What's the status of this? I would really appreciate to be able to add a way to provide more options to a change in Gerrit.
Project Member Comment 5 by nas...@grainawi.org, May 20 2011
Blocking: 738
Project Member Comment 6 by nas...@grainawi.org, May 20 2011
Blocking: 971
Project Member Comment 7 by bklar...@gmail.com, Jun 2 2011
Blocking: 992
Project Member Comment 8 by bklar...@gmail.com, Aug 26 2011
 Issue 1112  has been merged into this issue.
Project Member Comment 10 by choro...@wikimedia.org, Nov 15 2012
Blocking: gerrit:1487
Project Member Comment 11 by bklar...@gmail.com, Mar 4 2013
 Issue 1812  has been merged into this issue.
Project Member Comment 12 by edwin.ke...@gmail.com, Aug 23 2013
 Issue 2085  has been merged into this issue.
Hi, I want to submit an extension (or a clarification) to this issue.

As stated on  Issue 2085 , we'd like to be able to add a custom set of possible values for the label and even multiple selection of those.
Project Member Comment 14 by edwin.ke...@gmail.com, Aug 23 2013
 Issue 2085  has been merged into this issue.
Hello,

Just to make sure we have some generic functionality for custom use cases of automation.

What missing is a free text label to allow adding some metadata into the change set.

Examples:
1. Tests to run.
2. But URLs to resolve when merged.

Multiple instances of a field will be a great feature to have.

A change in label should trigger plugin, so it can respond to the change.

There should be an option to clear if new patch is pushed or leave it as-is.

If that is acceptable, I would also like to suggest to support combobox style with multiple value/display, and to optionally support multi-selection.

This way we can use the underline free text label with easier mean to resolve:

Tests to Run: ______________________V
               Group1/Group 1 tests
              >Group2/Group 2 tests<
              >Group3/Group 3 tests<

Should construct: Group2, Group3

Thank you!
 Issue 992  has been merged into this issue.
Comment 18 by nemow...@gmail.com, Sep 15 2014
> https://gerrit-review.googlesource.com/#/q/topic:hashtags

Thanks for commenting but I'm not sure what you mean here: can topic now be changed after merge?

Our downstream report https://bugzilla.wikimedia.org/35534 asks for "free-form (post-merge) tagging", to replace tags like "todo" reminders applied after merge. https://www.mediawiki.org/wiki/Special:Code/MediaWiki/tag
Does that belong to another report (and is there one already?)?
Topics can be changed on merged changes if the "Force Edit Topic" is set.

From the ACL documentation:

"Whether the topic can be edited on closed changes can be controlled by the 'Force Edit' flag. If this flag is not set the topic can only be edited on open changes."

However, I closed the change since the hashtag feature implements the original request:

> "arbitrary labels/tags on changes".

> "A useful feature would be a way for approvers to provide hints about how
> rigorous a verification a change should undergo.

> For example the ability for an approver to flag a change as "high risk" or
> "low risk." High risk changes should be run through more testing than a low
> risk change.

> This is most useful in an automated environment, possibly one where changes
> could be batched together in risk categories." 


Though these arbitrary labels are now named "Hashtags." to avoid confusion with Git Tags or Review Labels.

This feature allows users to add clickable arbitrary (hahs)tags to changes (opened or closed). It also allows the users to search for these (Hash)tags/labels. There are stream-events, UI, Hooks, plugin support and a RestApi available. But please note that you need to enable the exprimental NoteDB to make it work. It is pretty much a basic way to add additional metadata to a change.

But of course there are many other ways to make use of them.

It looks kinda like this old mockup: http://i.imgur.com/T1azkvk.png 
But the actual implementation is prettier.
Could you add a description or a video which shows how to enable this feature? I've set

[gerrit]
  notedbpath = notedb
[notedb "changes"]
  write = true
  read = true

in the "gerrit.conf" and restarted the server but I don't see a change in the web UI. The release notes [1] describe to "enable the notedb" but it doesn't say how to do this. I search in the packages of Ubuntu with "apt-cache search notedb" but without result. I'm pretty sure I missunderstand something here.

[1] https://gerrit.googlesource.com/gerrit/+/c03196df4d0eda7d85778646e940e62337227c20/ReleaseNotes/ReleaseNotes-2.11.txt#51
Project Member Comment 21 by ekempin@google.com, Oct 21 2015
Have a look at this change:
  https://gerrit-review.googlesource.com/71570
Could we also support the hashtag feature with MySQL please?
Filled here https://bugs.chromium.org/p/gerrit/issues/detail?id=4542 for not requiring notedb to use the hashtag feature 
Sign in to add a comment