New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Released
Owner: ----
Closed: Jul 2014



Sign in to add a comment

Files from reference patchset are missing when comparing 2 patchsets

Reported by org...@gmail.com, Jul 7 2014

Issue description

************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.9

What steps will reproduce the problem?
1. Make a commit that contains changes to file1 and file2
2. Push it to gerrit
3. Revert the change to file1, commit and push again
4. Compare PS1 against PS2

What is the expected output? What do you see instead?
file1 should appear as modified (or deleted, in case it was *added* in PS1). Instead, it doesn't appear at all.

Please provide any additional information below.
Caused by https://gerrit-review.googlesource.com/57086

An example: Open https://gerrit-review.googlesource.com/55673 and notice that PS1 changed SubmitAction.java, which was later reverted. Now choose PS21 and Diff against PS1.
 
Project Member

Comment 1 by edwin.ke...@gmail.com, Jul 7 2014

 > file1 should appear as modified (or deleted, in case it was *added* in PS1). 
 > Instead, it doesn't appear at all.

This behaviour is intended. I initially showed this file, but after feedback from Shawn [1], this got changed and the file now isn't shown anymore. As you can see from the review discussion, personally I do not have a preferences which behaviour is better.

[1] https://gerrit-review.googlesource.com/#/c/57086/4//COMMIT_MSG@10
Project Member

Comment 2 by david.os...@gmail.com, Jul 9 2014

Status: WontFix

Comment 3 by org...@gmail.com, Jul 9 2014

Please reconsider. I spent a few minutes looking for the reverted file, and comparing different baselines, until I realized why it wasn't shown.

For me, it was unexpected behavior.
Project Member

Comment 4 by edwin.ke...@gmail.com, Jun 29 2015

Labels: FixedIn-2.11.2
Status: Submitted
Fixed by:
  https://gerrit-review.googlesource.com/69130
Status: Released
 Issue 3364  has been merged into this issue.

Sign in to add a comment