Monorail Project: gerrit Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 1 user
Status: Released
Owner: ----
Closed: Nov 2014



Sign in to add a comment
New change screen - multiple patchsets and review handling
Reported by duft.mar...@gmail.com, Mar 11 2014 Back to list
Affected Version: 2.8.1

What steps will reproduce the problem?
1. open a change with multiple patchsets, try to perform actions on them.
2. try to vote on the current patchset.

What is the expected output? What do you see instead?
as dicussed in https://groups.google.com/forum/#!topic/repo-discuss/pV3x811pq3w

"[...] Another thing people are missing is the ability to quickly determine how many patchsets there are for a change, and have a look at whether there where comments on the last one, or publishing their own comments on a previous patchset. For most it is absolutely not obvious that the "Reply..." button is the way to publish comments."
 
Project Member Comment 1 by david.os...@gmail.com, Mar 11 2014
Labels: -Type-Bug
Status: AwaitingInformation
If you open a change with multiple patch sets [1] you see drop down in the right upper corner of the CS2:
Patch Set 33/33 in this case, indicating how much ps this change has and what is current ps you are viewing is.

> For most it is absolutely not obvious that the "Reply…"

There is a shortcut for publishing the comment. Click on an arrow in message (under date-time) to answer the specific message. Reply box is opened quoting the original message.   

[1] https://gerrit-review.googlesource.com/52890/
Comment 2 by icee...@gmail.com, Mar 12 2014
Well, the direct reply to a message is a nice thing. There it also makes sense to name it reply (but actually the icons visibility is rather low).

But the global "Reply..." button is serving two functions: adding a comment and supply votes on a change. So naming it "Comment/Vote" or just "Review" seems much more appropriate in my opinion.
I have upgraded to 2.8.2 and I can not see these arrows next to date and time. Do I need to configure anything for them to appear?
This issue resurfaced as #2974. So I've made a proposal patch and will push it as soon as my company's Contributor Agreement is through.
Labels: FixedIn-2.11
Status: Submitted
https://gerrit-review.googlesource.com/#/c/61498/
Status: Released
Sign in to add a comment