New issue
Advanced search Search tips
Starred by 17 users

Issue metadata

Status: Released
Owner: ----
Closed: May 2014



Sign in to add a comment

"git clone" hangs after 100% resolving deltas with git over SSH and putty (plink) 0.63 or tortoisegit/tortoiseplink

Reported by kai.obfu...@gmail.com, Jan 17 2014

Issue description

************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.8.1 and below

What steps will reproduce the problem?
1. Use git for Windows (msysgit) with plink from putty 0.63 to clone a repository from Gerrit over SSH protocol

What is the expected output? What do you see instead?

Expected: The clone is successfully done. Working copy has been checked out. No hanging deltas (can be checked with "git fsck"):

-------------------------------------------
cmd> git clone ssh://username@host:29418/project

Cloning into 'project'...
remote: Counting objects: 136930, done
remote: Finding sources: 100% (136930/136930)
Receiving objects: 100% (136930/136930), 4emote: Total 136930 (delta 64042), reused 136418 (delta 64042)2.80 MiB | 1.23 MiB/s, done.

Resolving deltas: 100% (64042/64042), done.
Checking connectivity... done.
Checking out files: 100% (1205/1205), done.

cmd>
-------------------------------------------

Actual: After the step to resolve the deltas, the clone process hangs at 100%. Manually aborting the operation (CTRL-C) removes the checked out folder agin. Killing the process results in dangling commits ("git fsck") and an empty working folder (except for the .git subfolder):

cmd> git clone ssh://user@host:29418/project
Cloning into 'project'...
remote: Counting objects: 136930, done
remote: Finding sources: 100% (136930/136930)
remote: Total 136930 (delta 64042), reused 136418 (delta 64042)
Receiving objects: 100% (136930/136930), 42.80 MiB | 1.10 MiB/s, done.
Resolving deltas: 100% (64042/64042), done.
(process hangs now)
---------------------------------------------

The reason and a workaround is described here:

https://code.google.com/p/tortoisegit/issues/detail?id=1880#c25

Quote:

After a few email exchanges with the putty folks, it looks like our gerrit server is not respecting the SSH protocol properly. There was a change in putty/plink 0.63 where they do some ssh winadj commands.  They are expecting a reply response from ssh but it never gets sent.  Therefore the plink simply waits until it gets these reply responses. 

It's possible that the latest gerrit server has a fix although I didn't see any note of that on their release notes.  Putty has a workaround though:

1) Run putty for windows 0.63. 
2) Click on "Default Settings" in the Saved Sessions. Click Load
3) Go to Connection -> SSH -> Bugs
4) Set "Chokes on PuTTY's SSH-2 'winadj' requests" to On (instead of Auto)
5) Go Back to Session in the treeview (top of the list)
6) Click on "Default Settings" in the Saved Sessions box.  Click Save.

Now that bug setting will be saved for all running instances of plink/putty and including tortoisegitPlink.

 
Project Member

Comment 1 by jrn@google.com, Jan 17 2014

Sounds like https://issues.apache.org/jira/browse/SSHD-255. Cherry-picking 49ba56e1 ([SSHD-255] sshd does not always? reply to requests with 'want reply', 2013-11-29) into our copy of mina-sshd will probably fix it.
https://issues.apache.org/jira/browse/SSHD-255 has been merged and it's included in release 0.10.0 of Apache SSHD. Just bump the version in Gerrit. Note that it depends on a newer Bouncy Castle build (tested and it works with 1.5.0)

Comment 3 by eng...@gmail.com, Mar 13 2014

It's already reviewed in master branch https://gerrit-review.googlesource.com/#/c/55088/
Project Member

Comment 4 by david.os...@gmail.com, Mar 13 2014

Status: ChangeUnderReview
https://gerrit-review.googlesource.com/55088
Labels: FixedIn-2.8.5
Status: Released

Comment 6 by jyrki...@gmail.com, Dec 17 2014

2.9.3 release notes says: "SSHD version 0.9.0-4-g5967cfd is based on 0.9.0 and includes fixes for SSHD-254 and SSHD-330", and this is fixed in version 0.10.0 of sshd, so we are seeing this again.

Comment 7 by saxo...@gmail.com, Jan 19 2015

Yes, we're seeing this again also with tortoise.

Comment 8 Deleted

Comment 9 by angus...@gmail.com, Jan 23 2015

There is no SSHD version change on 2.9.4, so we are seeing this issue also on 2.9.4.

Sign in to add a comment