New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 41 users

Issue metadata

Status: Released
Owner: ----
Closed: Jul 2018
Cc:
Components:
ReleasedIn: 529.0



Sign in to add a comment
link

Issue 2390: Allow to mark review as read/unread by clicking on some icon and/or button

Reported by marb...@gmail.com, Jan 10 2014

Issue description

Hello.

$subj

IMHO such option may be useful for reviewers and review authors.

As for me there are enough reasons to implement this.
Here is just a simple example to ensure:
1) I give some mark to a review
2) review is marked as read and is not shown as 'bold' on 'My Reviews' (i.e. click on "My", then on "Changes" in menu)
3) then another reviewer gives a mark
4) review becomes bold on 'My Reviews' page
5) I read comments of another reviewer and just want to mark review as 'read'

So it may/should/must be useful:
1) to have 'mark as read'/'mark as unread' icon on 'My Reviews' page
2) and to have a 'Mark As Read'/'Mark as unread' button in the review (near 'Review' button and/or near 'Add Comment' button).

Sincerely,
Maryan Bagnyuk (aka Maryan Bahnyuk)

P.S. This feature looks like marking email as read/unread in email client (Thunderbird, etc.)
 

Comment 1 by oswald.b...@gmx.de, Jun 27 2014

the current behavior is indeed a significant problem for people with busy dashboards who do not want to rely on the notification mails only.

Comment 3 by stephen....@gmail.com, Jan 8 2015

Re comment #2:  Issue 1407  is more of a workaround. I can already add another comment to the review, but that's just spammy. I want a "mark unread" button that doesn't add to the comment list or send any email.

Comment 4 by erik.t.w...@gmail.com, Jan 8 2016

Any progress on this one?

Comment 5 by thomas.m...@gmail.com, Jun 21 2016

FWIW, this is by far the single biggest issue with Gerrit that I have, in particular because rebases without code changes will keep the review score, but mark the CR as bold. There is no way to remove the boldness apart from leaving a dummy comment.

Comment 6 by thomas.m...@gmail.com, Jun 21 2016

As a related issue, I just reported https://bugs.chromium.org/p/gerrit/issues/detail?id=4212, to not mark a CR as unread after a rebase.

Comment 7 by logan@google.com, Aug 17 2016

Project Member
Labels: Priority-3

Comment 8 by creis@chromium.org, Aug 25 2017

Fixing this would make my review dashboard significantly more useful.  I often overlook CLs that I should review because they're mixed in among reviews I'm done with but that are bold because of a later update.

Comment 9 by creis@chromium.org, Nov 8 2017

Cc: jparent@chromium.org aga...@chromium.org creis@chromium.org
Friendly ping.  Can we raise the priority of this?  My dashboard currently has at least 5 CLs in bold that don't require action from me, making it hard to skim for the ones that do need attention.  I essentially have to rely on my inbox and my own to do list instead.

Comment 10 by jpar...@google.com, Nov 8 2017

Logan, can you comment on relative priority of this per your team's other work?  You set it as P3, but I've heard this sentiment from many users, and its 33 star count is compelling.

Comment 11 by jrn@google.com, Nov 8 2017

Project Member
Components: PolyGerrit

Comment 12 by james.jo...@thumbtack.com, Jan 10 2018

This is also an issue that annoys both myself and many other team members here at Thumbtack.  We use Gerrit pretty widely here.  It gets particularly annoying when somebody has a multi-commit branch that I've reviewed (e.g. 10 related CLs in my inbox), and then they rebase the whole thing.  Everything becomes bold, even though I've reviewed it already and my +2 is still in effect.

Alternatively, I'd be quite happy if rebases did not trigger a CL to become unread in the first place.

Comment 13 by andreas....@gmail.com, Jun 13 2018

I have problems with this every day, I think a option to not make rebased commits bold in the review list should be added. That together with the option to make a commit marked as reviewed without adding any comment would be very helpful. And that would then as well not become bold when rebased.

Comment 14 by wyatta@google.com, Jul 30 2018

Project Member
ReleasedIn: 529.0

Comment 15 by wyatta@google.com, Jul 31 2018

Project Member
Status: Released (was: New)

Comment 16 Deleted

Comment 17 by david.pu...@gmail.com, Nov 20

Labels: FixedIn-2.16

Sign in to add a comment