New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Submitted
Owner: ----
Closed: Feb 5
Cc:
Components:



Sign in to add a comment
link

Issue 10366: Unusual characters in topic lead to confusing error message

Reported by patr...@georgi.software, Jan 23

Issue description

Affected Version: 2.16.3

What steps will reproduce the problem?
1. Create a change with a topic that contains the ampersand character, eg "test&try"
2. open the change in polygerrit (at /c/$project/+/$changenumber)

What is the expected output?

Just the UI

What do you see instead?

The UI (fully functional and filled in, except perhaps for the "related changes" section) with a popup titled "An error occurred" and body text

    Error 400: )]}'
    "line 1:22 no viable alternative at character \u0027\u0026\u0027"
    
    Endpoint: /changes/topic:*


What is the output of the JS console log (if applicable)?

gr-app.js:1158
HTTP 200 GET 61ms /changes/change:*

gr-app.js:1158
HTTP 200 GET 62ms /changes/conflicts:*

/changes/?O=10b&q=status%3Aopen%20topic%3Atest%26try:1 Failed to load resource: the server responded with a status of 400 ()
gr-app.js:1158 
HTTP 400 GET 46ms /changes/topic:*

gr-app.js:2609
)]}'
"line 1:22 no viable alternative at character \u0027\u0026\u0027"
(anonymous) @ gr-app.js:2609

gr-app.js:1158
HTTP 200 GET 55ms /changes/*~*/submitted_together?o=NON_VISIBLE_CHANGES

gr-app.js:1158
HTTP 200 GET 58ms /changes/*~*/revisions/*/related
 

Comment 1 by thomasmu...@yahoo.com, Feb 3

Project Member
Status: ChangeUnderReview (was: New)
https://gerrit-review.googlesource.com/c/gerrit/+/212692

Comment 2 by thomasmu...@yahoo.com, Feb 5

Project Member
Labels: FixedIn-2.16.5
Status: Submitted (was: ChangeUnderReview)

Sign in to add a comment