New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Released
Owner: ----
Closed: Jan 18
Cc:
Components:



Sign in to add a comment
link

Issue 10317: "Same Topic" section is shown on change screen when there is only one change (the current change)

Reported by david.pu...@gmail.com, Jan 17 Project Member

Issue description

*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.15

What steps will reproduce the problem?
1. Upload a change for review
2. Add a topic to the change, using a topic name that is not used on any other changes
3.

What is the expected output?

The "Same Topic" tab is not shown.

What do you see instead?

The "Same Topic" tab is shown, containing only one change which is the current change. In this case it does not add any value to show this tab. It would be better to only show the tab when there are multiple changes on the same topic.  If there is only one change on the topic, it's always going to be the currently viewed change.

Please provide any additional information below.

Same issue is present on both GWT and PG.
 

Comment 1 by david.pu...@gmail.com, Jan 17

Cc: thomasmu...@yahoo.com
Fix for GWT: https://gerrit-review.googlesource.com/c/gerrit/+/210653

Comment 2 by thomasmu...@yahoo.com, Jan 17

Project Member
I have some ideas on this. Will try them out later (even possible removing usage of hidden for this too :))

Comment 3 by thomasmu...@yahoo.com, Jan 17

Project Member

Comment 4 by david.pu...@gmail.com, Jan 17

Status: ChangeUnderReview (was: New)

Comment 5 by david.pu...@gmail.com, Jan 18

Labels: FixedIn-2.15.9
Status: Submitted (was: ChangeUnderReview)

Comment 6 by luca.mil...@gmail.com, Jan 22

Project Member
Labels: FixedIn-2.16.4

Comment 7 by luca.mil...@gmail.com, Jan 27

Project Member
Status: Released (was: Submitted)

Sign in to add a comment