New issue
Advanced search Search tips
Starred by 6 users

Issue metadata

Status: Submitted
Owner: ----
Closed: Jan 31
Cc:
Components:



Sign in to add a comment
link

Issue 10279: Syntax highlighting broken for Dart files

Reported by nkors...@google.com, Jan 9

Issue description

Affected Version:

What steps will reproduce the problem?
1. got to https://fuchsia-review.googlesource.com/c/topaz/+/238832
2. see public/dart/widgets/lib/src/model/provider.dart file

What is the expected output?
syntax highlighting works through the entire file

What do you see instead?
half way through the file syntax highlighting is broken
 

Comment 1 by oler@google.com, Jan 10

Project Member
Cc: brohlfs@google.com
Status: AwaitingInformation (was: New)
Hi, thanks for the report. Is this a regression or has this never worked? Is this happening on many files or just this one? We are using a third party library (highlightjs) to do the syntax highlighting, so this would likely have to be fixed upstream [1]. 

We are currently very thinly staffed and won't get to this immediately, but if you could try to reproduce if this is also broken upstream, you can either file an issue against them or let us know that we need to update our version of highlightjs (but I believe we already use their latest version).


[1] https://github.com/highlightjs/highlight.js

Comment 2 by brohlfs@google.com, Jan 10

Project Member
 Issue 10246  has been merged into this issue.

Comment 3 by nkors...@google.com, Jan 10

I think this issue is inconsistent, meaning some CLs are fine and highlight all files correctly while others break half way similar to the one I linked to. So because of that it's hard to say if it's a regression or not.

I'm not sure how to even go about reproducing this upstream, I only use gerrit for this specific project for now.

Comment 4 by oler@google.com, Jan 11

Project Member
Makes sense. We have a big backlog of open issues to look through, and we will hopefully get to it in the next weeks. The suggestion for reproducing it upstream (probably by checking out highlightjs and using it directly) was just if you prefer not to wait on us.

Comment 5 by shyndman@google.com, Jan 14

Comment 6 by oler@google.com, Jan 15

Project Member
Thanks!

Comment 7 by shyndman@google.com, Jan 21

I had a few minutes and wrote up a fix:
https://github.com/highlightjs/highlight.js/pull/1946

Comment 8 by david.os...@gmail.com, Jan 22

Project Member
Status: Accepted (was: AwaitingInformation)
Thanks, the fix was merged upstream, so that we need
to bump highlight JS version to master.

Comment 9 by david.os...@gmail.com, Jan 24

Project Member
Status: Started (was: Accepted)

Comment 10 by david.os...@gmail.com, Jan 24

Project Member
Status: ChangeUnderReview (was: Started)
https://gerrit-review.googlesource.com/c/gerrit/+/211673

Comment 11 by thomasmu...@yahoo.com, Jan 24

Project Member
Labels: Hotlist-SyntaxHighlighting

Comment 12 by thomasmu...@yahoo.com, Jan 31

Project Member
Status: Submitted (was: ChangeUnderReview)

Comment 13 by luca.mil...@gmail.com, Feb 8

Project Member
Labels: FixedIn-2.16.5

Sign in to add a comment