New issue
Advanced search Search tips
Starred by 6 users

Issue metadata

Status: Released
Owner:
Closed: Jan 18
Cc:
Components:



Sign in to add a comment
link

Issue 10151: No way to delete a branch from project branches listing page in the New UI

Reported by andrea.m...@allegorithmic.com, Dec 6

Issue description

Affected Version:

What steps will reproduce the problem?
1. Create a branche for a given project
2. List project branches
=> There is no buttont to delete a branch from the listing

What is the expected output?
As in the old UI, you can select branches and click a button to delete them

What do you see instead?
No way to select branches not a 'Delete' button

What is the output of the JS console log (if applicable)?
[Deprecation] HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.
Failed to execute 'write' on 'Document': It isn't possible to write into a document from an asynchronously-loaded external script unless it is explicitly opened.
goog.DebugLoader.writeScriptSrcNode_ @ gr-app.js:152
[Deprecation] document.registerElement is deprecated and will be removed in M73, around March 2019. Please use window.customElements.define instead. See https://www.chromestatus.com/features/4642138092470272 for more details.
(anonymous) @ gr-app.js:1299
initResin
Use of uninitialized routing
uninitialized @ gr-app.js:2325
lfs install failed: TypeError: self.panel is not a function
Gerrit.install @ gr-app.js:2540
App Started: 633
WebComponentsReady: 668ms
PluginsLoaded: 736ms
The resource http://gerrit.allegorithmic.com/elements/gr-app.js was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded intentionally.
 

Comment 1 by thomasmu...@yahoo.com, Dec 6

Project Member
This is supported in the new UI, which version of gerrit are you using?

Comment 2 by david.pu...@gmail.com, Dec 7

Status: AwaitingInformation (was: New)
We are currently using Gerrit code Review 2.15.2, I don't know which one is the latest one so far
Doing some tests with Andrea, we had more informations.

- If I am owner of this project, DELETE button is correctly displayed.
- If I had rights to remove a branch (all contributors can manage branches in refs/heads/sandbox/*) by navigating to 'branches' or 'tags' DELETE button is never displayed.
- If I had rights to remove a branch and I force a refresh of the page DELETE button is correctly displayed.

REST API return expected results in both case:
> /projects/XXXX/branches?n=26&S=0
> ...
> "can_delete": true (or false)

Looks like an issue browser side.

We migrate to 2.16.1 last night, and this problem is still present.

Comment 5 by thomasmu...@yahoo.com, Jan 10

Project Member
Status: Accepted (was: AwaitingInformation)
Sorry for the late reply. Yup i can reproduce.

Comment 6 by thomasmu...@yahoo.com, Jan 10

Project Member
Cc: brohlfs@google.com

Comment 7 by thomasmu...@yahoo.com, Jan 10

Project Member
Status: ChangeUnderReview (was: Accepted)
https://gerrit-review.googlesource.com/c/gerrit/+/209912

Comment 8 by thomasmu...@yahoo.com, Jan 10

Project Member
Owner: thomasmu...@yahoo.com

Comment 9 by thomasmu...@yahoo.com, Jan 18

Project Member
Status: Submitted (was: ChangeUnderReview)

Comment 10 by david.pu...@gmail.com, Jan 21

Labels: FixedIn-2.16.4

Comment 11 by david.pu...@gmail.com, Jan 22

Labels: FixedIn-2.15.9

Comment 12 by luca.mil...@gmail.com, Jan 27

Project Member
Status: Released (was: Submitted)

Sign in to add a comment