New issue
Advanced search Search tips

Issue 10112 link

Starred by 3 users

Issue metadata

Status: Released
Owner: ----
Closed: Dec 18
Cc:
Components:



Sign in to add a comment

Gerrit doesn't build with Bazel 0.21.0

Project Member Reported by laurentlb@google.com, Nov 29

Issue description

Bazel is switching the flag "incompatible_package_name_is_a_function" to true. This breaks gerrit:

`$ bazel test --incompatible_package_name_is_a_function`


I expect this will be fixed by updating the dependency on protobuf, like we did for other rules (https://github.com/bazelbuild/rules_go/pull/1834/files#diff-fdb6ae35486586f3473cd99b5d4c4815R76).
 
Project Member

Comment 1 by thomasmu...@yahoo.com, Nov 29

Cc: david.pu...@gmail.com david.os...@gmail.com
Components: Build
Project Member

Comment 2 by david.os...@gmail.com, Nov 30

Status: Accepted (was: New)
I fixed it already in rules_closure: [1].

* [1] https://github.com/bazelbuild/rules_closure/pull/313
Project Member

Comment 3 by david.os...@gmail.com, Dec 3

Status: ChangeUnderReview (was: Accepted)
https://gerrit-review.googlesource.com/c/gerrit/+/206093
Summary: Gerrit doesn't build with Bazel 0.20.0 (was: Gerrit doesn't build with future Bazel changes)
Summary: Gerrit doesn't build with Bazel 0.21.0 (was: Gerrit doesn't build with Bazel 0.20.0)
Project Member

Comment 6 by david.os...@gmail.com, Dec 5

It worth noting, there is a trivial workaround:

 $ bazel test --incompatible_package_name_is_a_function=false :release
Project Member

Comment 7 by david.os...@gmail.com, Dec 6

Status: New (was: ChangeUnderReview)
Changing status to new again, because the change linked to this issue doesn't work and was abandoned.
Project Member

Comment 8 by david.os...@gmail.com, Dec 6

Status: ChangeUnderReview (was: New)
https://gerrit-review.googlesource.com/c/gerrit/+/206093
I've put CR+1 on it, but it needs to get the Library-Compliance vote from a googler.
^^ I meant CR+2, of course.
Project Member

Comment 12 by david.os...@gmail.com, Dec 18

Status: Submitted (was: ChangeUnderReview)
Project Member

Comment 13 by luca.mil...@gmail.com, Dec 21

Labels: FixedIn-2.16.2
Status: Released (was: Submitted)

Sign in to add a comment