New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users

Issue metadata

Status: Submitted
Owner: ----
Closed: Feb 8
Cc:
Components:



Sign in to add a comment
link

Issue 10024: go-import plugin causes git fetch to fail

Reported by fastest...@gmail.com, Nov 13

Issue description

Affected Version: 2.16-rc3

What steps will reproduce the problem?
1. Install 2.16-rc3 with latest go-import plugin
2. git fetch against an HTTPS url

What is the expected output?
I expect the fetch to work as normal.

What do you see instead?
A fetch over HTTP will fail with a 501 error.

Please provide any additional information below.

The plugin is failing when it calls:
req.getParameter("go-get")

Nov 13 16:21:40 gunter java[2814]: [2018-11-13 16:21:40,615] [HTTP-84] WARN  org.eclipse.jetty.server.HttpChannel : /a/internal-web/git-upload-pack org.eclipse.jetty.http.BadMessageException: 501: Unsupported Content-Encoding
Nov 13 16:21:40 gunter java[2814]: [2018-11-13 16:21:40,615] [HTTP-84] ERROR com.google.gerrit.pgm.http.jetty.HiddenErrorHandler : Error in POST /a/internal-web/git-upload-pack
Nov 13 16:21:40 gunter java[2814]: org.eclipse.jetty.http.BadMessageException: 501: Unsupported Content-Encoding
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.Request.extractContentParameters(Request.java:460)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.Request.getParameters(Request.java:386)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.Request.getParameter(Request.java:1029)
Nov 13 16:21:40 gunter java[2814]: at javax.servlet.ServletRequestWrapper.getParameter(ServletRequestWrapper.java:153)
Nov 13 16:21:40 gunter java[2814]: at com.ericsson.gerrit.plugins.goimport.GoImportFilter.doFilter(GoImportFilter.java:94)
Nov 13 16:21:40 gunter java[2814]: at com.google.gerrit.httpd.AllRequestFilter$FilterProxy$1.doFilter(AllRequestFilter.java:129)
Nov 13 16:21:40 gunter java[2814]: at com.google.gerrit.httpd.AllRequestFilter$FilterProxy.doFilter(AllRequestFilter.java:135)
Nov 13 16:21:40 gunter java[2814]: at com.google.gerrit.httpd.ProjectBasicAuthFilter.doFilter(ProjectBasicAuthFilter.java:100)
Nov 13 16:21:40 gunter java[2814]: at com.google.gerrit.httpd.ProjectBasicAuthFilter.doFilter(ProjectBasicAuthFilter.java:100)
Nov 13 16:21:40 gunter java[2814]: at com.google.gerrit.httpd.RequestMetricsFilter.doFilter(RequestMetricsFilter.java:57)
Nov 13 16:21:40 gunter java[2814]: at com.google.gerrit.httpd.RequestContextFilter.doFilter(RequestContextFilter.java:69)
Nov 13 16:21:40 gunter java[2814]: at com.google.gerrit.pgm.http.jetty.ProjectQoSFilter.doFilter(ProjectQoSFilter.java:129)
Nov 13 16:21:40 gunter java[2814]: at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:121)
Nov 13 16:21:40 gunter java[2814]: at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:133)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1642)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:533)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:255)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1595)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:255)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1340)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:203)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:473)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1564)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:201)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1242)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:144)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.Server.handleAsync(Server.java:548)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:388)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.server.HttpChannel.run(HttpChannel.java:305)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:765)
Nov 13 16:21:40 gunter java[2814]: at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:683)
Nov 13 16:21:40 gunter java[2814]: at java.lang.Thread.run(Thread.java:745)
 

Comment 1 by marco.mm...@gmail.com, Nov 13

Project Member
Cc: huga...@gmail.com
Can somebody with enough access add a plugins>go-import component to the project, so we can set this issue accordingly?

Comment 2 by david.pu...@gmail.com, Nov 14

Components: plugins>go-import

Comment 3 by marco.mm...@gmail.com, Nov 16

Project Member
Status: Accepted (was: New)

Comment 4 by fastest...@gmail.com, Jan 24

I can fix this is someone can point me in the right direction? Is the issue actually a jetty error? It looks like the plugin is just calling getParameter.

Is https://github.com/eclipse/jetty.project/issues/3030 related? It looks like a fix for that was merged into jetty-9.4.13.v20181111. Can we just upgrade gerrit to 9.14.13 (from 9.14.12) to pull in that fix?

Comment 5 by david.pu...@gmail.com, Jan 24

We can potentially upgrade on the stable-2.16 branch *if* we can definitively say that it fixes this issue.

Comment 6 by fastest...@gmail.com, Jan 25

I'm not sure if I have enough knowledge to say 100% but I'm pretty sure, looking at the commit, that it does. Is there a way via the gerrit-ci that someone could upgrade jetty in a change/branch and then I could download that war and test it out? Then I could confirm before it's merged that it definitely fixes it.

Comment 7 by david.pu...@gmail.com, Jan 25

Status: ChangeUnderReview (was: Accepted)
https://gerrit-review.googlesource.com/c/gerrit/+/211714

Comment 8 by luca.mil...@gmail.com, Feb 8

Project Member
Labels: FixedIn-2.16.5
Status: Submitted (was: ChangeUnderReview)

Sign in to add a comment