New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Accepted
Owner:
OS: ----
Pri: 2
Type: Defect

Blocked on:
issue 62



Sign in to add a comment
link

Issue 61: Split BUILD.gn into sub-files

Reported by senorblanco@chromium.org, Dec 5 Project Member

Issue description

In order to improve modularity, split the root BUILD.gn into multiple files, one per directory.

At a minimum, we should build files for:

examples
dawn
src/dawn_native
src/dawn_wire
src/tests
src/utils
 

Comment 1 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/0a7ddd43d77ca2d7de3a1d08feb62cf5e8a578a6

commit 0a7ddd43d77ca2d7de3a1d08feb62cf5e8a578a6
Author: Stephen White <senorblanco@chromium.org>
Date: Wed Dec 05 22:42:23 2018

Create new src/tests BUILD.gn file.

Move all test-related build stuff into its own BUILD.gn file. This
required moving the dawn_generator template into a common file, so it
can be called by both BUILD.gn and src/tests/BUILD.gn.

Bug: dawn:61

Change-Id: Icaa459270bdaa60306e053b93835812e70dba6f5
Reviewed-on: https://dawn-review.googlesource.com/c/2940
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>

[add] https://crrev.com/0a7ddd43d77ca2d7de3a1d08feb62cf5e8a578a6/generator/dawn_generator.gni
[modify] https://crrev.com/0a7ddd43d77ca2d7de3a1d08feb62cf5e8a578a6/BUILD.gn
[add] https://crrev.com/0a7ddd43d77ca2d7de3a1d08feb62cf5e8a578a6/src/tests/BUILD.gn
[modify] https://crrev.com/0a7ddd43d77ca2d7de3a1d08feb62cf5e8a578a6/scripts/dawn_overrides_with_defaults.gni

Comment 2 by shaobo....@intel.com, Dec 6

Blockedon: 62

Comment 3 by bugdroid1@chromium.org, Dec 6

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/bdd887fce76cd2703f1086b35ad9b9b00b147461

commit bdd887fce76cd2703f1086b35ad9b9b00b147461
Author: Kai Ninomiya <kainino@chromium.org>
Date: Thu Dec 06 06:41:59 2018

Revert "Create new src/tests BUILD.gn file."

This reverts commit 0a7ddd43d77ca2d7de3a1d08feb62cf5e8a578a6.

Reason for revert: Broke compile in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-rel/12314
See also: https://chromium-review.googlesource.com/c/chromium/src/+/1364694

Original change's description:
> Create new src/tests BUILD.gn file.
> 
> Move all test-related build stuff into its own BUILD.gn file. This
> required moving the dawn_generator template into a common file, so it
> can be called by both BUILD.gn and src/tests/BUILD.gn.
> 
> Bug: dawn:61
> 
> Change-Id: Icaa459270bdaa60306e053b93835812e70dba6f5
> Reviewed-on: https://dawn-review.googlesource.com/c/2940
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Reviewed-by: Stephen White <senorblanco@chromium.org>

TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org

Change-Id: If6d8c759f63c12b244471016f10e92c07299303f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: dawn:61
Reviewed-on: https://dawn-review.googlesource.com/c/3000
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>

[delete] https://crrev.com/0a7ddd43d77ca2d7de3a1d08feb62cf5e8a578a6/generator/dawn_generator.gni
[modify] https://crrev.com/bdd887fce76cd2703f1086b35ad9b9b00b147461/BUILD.gn
[delete] https://crrev.com/0a7ddd43d77ca2d7de3a1d08feb62cf5e8a578a6/src/tests/BUILD.gn
[modify] https://crrev.com/bdd887fce76cd2703f1086b35ad9b9b00b147461/scripts/dawn_overrides_with_defaults.gni

Comment 4 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66

commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66
Author: Stephen White <senorblanco@chromium.org>
Date: Fri Dec 07 21:54:48 2018

Create new src/tests BUILD.gn file.

Move all test-related build stuff into its own BUILD.gn file. This
required moving the dawn_generator template into a common file, so it
can be called by both BUILD.gn and src/tests/BUILD.gn.

[This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940
with a fix for mock_dawn.]

Bug: dawn:61
Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d
Reviewed-on: https://dawn-review.googlesource.com/c/3020
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>

[add] https://crrev.com/672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66/src/tests/BUILD.gn
[modify] https://crrev.com/672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66/generator/main.py
[modify] https://crrev.com/672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66/scripts/dawn_overrides_with_defaults.gni
[modify] https://crrev.com/672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66/generator/templates/mock_api.cpp
[add] https://crrev.com/672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66/generator/dawn_generator.gni
[modify] https://crrev.com/672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66/BUILD.gn
[modify] https://crrev.com/672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66/src/tests/unittests/WireTests.cpp

Comment 5 by bugdroid1@chromium.org, Dec 8

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/48a1923afb6a897e2a5445e7e5834f7c4a9ca08a

commit 48a1923afb6a897e2a5445e7e5834f7c4a9ca08a
Author: Corentin Wallez <cwallez@chromium.org>
Date: Sat Dec 08 10:35:53 2018

Revert "Create new src/tests BUILD.gn file."

This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171

Original change's description:
> Create new src/tests BUILD.gn file.
> 
> Move all test-related build stuff into its own BUILD.gn file. This
> required moving the dawn_generator template into a common file, so it
> can be called by both BUILD.gn and src/tests/BUILD.gn.
> 
> [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940
> with a fix for mock_dawn.]
> 
> Bug: dawn:61
> Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d
> Reviewed-on: https://dawn-review.googlesource.com/c/3020
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Commit-Queue: Stephen White <senorblanco@chromium.org>

TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org

Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: dawn:61
Reviewed-on: https://dawn-review.googlesource.com/c/3080
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[delete] https://crrev.com/672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66/src/tests/BUILD.gn
[modify] https://crrev.com/48a1923afb6a897e2a5445e7e5834f7c4a9ca08a/generator/main.py
[modify] https://crrev.com/48a1923afb6a897e2a5445e7e5834f7c4a9ca08a/scripts/dawn_overrides_with_defaults.gni
[modify] https://crrev.com/48a1923afb6a897e2a5445e7e5834f7c4a9ca08a/generator/templates/mock_api.cpp
[delete] https://crrev.com/672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66/generator/dawn_generator.gni
[modify] https://crrev.com/48a1923afb6a897e2a5445e7e5834f7c4a9ca08a/BUILD.gn
[modify] https://crrev.com/48a1923afb6a897e2a5445e7e5834f7c4a9ca08a/src/tests/unittests/WireTests.cpp

Comment 6 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db07c8cc675a07d228219b0ae3f36c7c6afcef14

commit db07c8cc675a07d228219b0ae3f36c7c6afcef14
Author: Stephen White <senorblanco@chromium.org>
Date: Tue Dec 11 20:29:57 2018

Dawn: use Dawn's temporary test targets.

The plan is to move the actual test targets in Dawn to Dawn's
src/test directory. This change makes Chrome temporarily point at
some intermediate proxy targets, so we can move the real ones
without breaking Chrome.

Bug: dawn:61
Change-Id: I3c57af0dfbcff70b5acec30b69f2c013a7a9eb67
Reviewed-on: https://chromium-review.googlesource.com/c/1372320
Commit-Queue: Stephen White <senorblanco@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615647}
[modify] https://crrev.com/db07c8cc675a07d228219b0ae3f36c7c6afcef14/BUILD.gn

Comment 7 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74d46702b56909ad86778c5228257a71095b69e1

commit 74d46702b56909ad86778c5228257a71095b69e1
Author: Stephen White <senorblanco@chromium.org>
Date: Tue Dec 11 23:15:06 2018

Dawn: use Dawn's temporary test targets for isolates.

The plan is to move the actual test targets in Dawn to Dawn's
src/test directory. This change makes Chrome temporarily point at
some intermediate proxy targets, so we can move the real ones
without breaking Chrome.

Bug: dawn:61
Change-Id: I166c17f1689e2a2e71b1607af44f6f9a8c14b6af
Reviewed-on: https://chromium-review.googlesource.com/c/1372709
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615715}
[modify] https://crrev.com/74d46702b56909ad86778c5228257a71095b69e1/testing/buildbot/gn_isolate_map.pyl

Comment 8 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/667e92ed486d1326e4af0c9f1f68d9cb1c3b38d3

commit 667e92ed486d1326e4af0c9f1f68d9cb1c3b38d3
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Wed Dec 12 00:50:57 2018

Revert "Dawn: use Dawn's temporary test targets for isolates."

This reverts commit 74d46702b56909ad86778c5228257a71095b69e1.

Reason for revert: Seems to be causing build breakage: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux

Original change's description:
> Dawn: use Dawn's temporary test targets for isolates.
> 
> The plan is to move the actual test targets in Dawn to Dawn's
> src/test directory. This change makes Chrome temporarily point at
> some intermediate proxy targets, so we can move the real ones
> without breaking Chrome.
> 
> Bug: dawn:61
> Change-Id: I166c17f1689e2a2e71b1607af44f6f9a8c14b6af
> Reviewed-on: https://chromium-review.googlesource.com/c/1372709
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Stephen White <senorblanco@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615715}

TBR=thakis@chromium.org,senorblanco@chromium.org,cwallez@chromium.org

Change-Id: Iec9120066c23710c4b2dbe22a50813a23ad299a2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: dawn:61
Reviewed-on: https://chromium-review.googlesource.com/c/1372107
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615743}
[modify] https://crrev.com/667e92ed486d1326e4af0c9f1f68d9cb1c3b38d3/testing/buildbot/gn_isolate_map.pyl

Comment 9 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10edbbe8c9de9ae6942794d26c778d22ca3b5686

commit 10edbbe8c9de9ae6942794d26c778d22ca3b5686
Author: Stephen White <senorblanco@chromium.org>
Date: Wed Dec 12 15:25:26 2018

Dawn: use Dawn's temporary test targets for isolates.

The plan is to move the actual test targets in Dawn to Dawn's
src/test directory. This change makes Chrome temporarily point at
some intermediate proxy targets, so we can move the real ones
without breaking Chrome.

Bug: dawn:61
Change-Id: I27a66a0daffe212da3fe2a0aaba7d4a250a376ea
Reviewed-on: https://chromium-review.googlesource.com/c/1373892
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615895}
[modify] https://crrev.com/10edbbe8c9de9ae6942794d26c778d22ca3b5686/testing/buildbot/gn_isolate_map.pyl

Comment 10 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a1964b2eb49d08af5584d43bffaeae1abf78021

commit 1a1964b2eb49d08af5584d43bffaeae1abf78021
Author: Stephen White <senorblanco@chromium.org>
Date: Wed Dec 12 17:35:38 2018

Revert "Dawn: use Dawn's temporary test targets for isolates."

This reverts commit 10edbbe8c9de9ae6942794d26c778d22ca3b5686.

Reason for revert: Causing purple on FYI bots:

<The executable does not exist or a dependent library is missing>
<Check for missing .so/.dll in the .isolate or GN file>
e.g., https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Release%20(Intel)/9078

Original change's description:
> Dawn: use Dawn's temporary test targets for isolates.
> 
> The plan is to move the actual test targets in Dawn to Dawn's
> src/test directory. This change makes Chrome temporarily point at
> some intermediate proxy targets, so we can move the real ones
> without breaking Chrome.
> 
> Bug: dawn:61
> Change-Id: I27a66a0daffe212da3fe2a0aaba7d4a250a376ea
> Reviewed-on: https://chromium-review.googlesource.com/c/1373892
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615895}

TBR=thakis@chromium.org,senorblanco@chromium.org,cwallez@chromium.org

Change-Id: Ic5f3778259e37d3818e7dee1a04bb49a66bff27a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: dawn:61
Reviewed-on: https://chromium-review.googlesource.com/c/1374369
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615942}
[modify] https://crrev.com/1a1964b2eb49d08af5584d43bffaeae1abf78021/testing/buildbot/gn_isolate_map.pyl

Sign in to add a comment