New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 0 users

Issue metadata

Status: Accepted
Owner: ----
Cc:
OS: ----
Pri: 2
Type: Defect



Sign in to add a comment
link

Issue 57: WebGPU specific SPIRV validation makes all tests fail.

Reported by cwallez@chromium.org, Nov 28 Project Member

Issue description

SPIRV-Tools recently gained more checks for the WebGPU execution environment that caused all tests to fail because for example it requires the use of the Vulkan memory model.

This is an issue because 1) our test's use of glslang is not set up to produce WebGPU flavored SPIR-V 2) our backends aren't using transformations passes to lower that WebGPU flavored SPIR-V to something drivers know.

While we figure out how to fix these two problems, WebGPU specific validation should be removed and only Vulkan validation should be performed.
 

Comment 1 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/32abaffa73370beacc2932677dfa5ce7ac6d6587

commit 32abaffa73370beacc2932677dfa5ce7ac6d6587
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Nov 28 16:54:31 2018

Roll SPIRV-Tools and temporarily use Vulkan SPIRV validation

New additions to the validation for the WebGPU execution environment
broke all the tests that use shaders because tests don't produce valid
SPIR-V for WebGPU and also backends don't know how to lower
WebGPU-flavored SPIR-V to target languages.

Also rolls SPIRV-Headers to a version compatible with SPIRV-Tools

TBR=kainino@chromium.org
BUG=dawn:57

Change-Id: Icd9a199efc39cf143e38d64841eb4b122c9f54a9
Reviewed-on: https://dawn-review.googlesource.com/c/2706
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/32abaffa73370beacc2932677dfa5ce7ac6d6587/src/dawn_native/ShaderModule.cpp
[modify] https://crrev.com/32abaffa73370beacc2932677dfa5ce7ac6d6587/src/tests/unittests/validation/ShaderModuleValidationTests.cpp
[modify] https://crrev.com/32abaffa73370beacc2932677dfa5ce7ac6d6587/DEPS

Comment 2 by cwallez@chromium.org, Nov 30

Project Member
Summary: WebGPU specific SPIRV validation makes all tests fail. (was: WebGPU specific-validation makes all tests fail.)

Sign in to add a comment