New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Cc:
Components:
OS: ----
Pri: 1
Type: Defect

Blocking:
issue 22



Sign in to add a comment
link

Issue 51: Draw commands don't have the same name as WebGPU

Reported by cwallez@chromium.org, Nov 23 Project Member

Issue description

WebGPU draw commands are called "draw" and "drawIndexed". Dawn should be made to match these names.
 

Comment 1 by cwallez@chromium.org, Nov 27

Project Member
Labels: Pri-1

Comment 2 by jiawei.s...@intel.com, Dec 6

Owner: jiawei.s...@intel.com
Also the parameter "baseVertex" of drawIndexed() in WebGPU IDL[1] is missed in Dawn API drawElements()[2].

I can take this task.

[1] https://github.com/gpuweb/gpuweb/blob/master/design/sketch.webidl#L489
[2] https://dawn.googlesource.com/dawn/+/master/dawn.json#830

Comment 3 by cwallez@chromium.org, Dec 6

Project Member
Thanks for taking this on.

Comment 4 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/c789b84d8d68191d3e1b54e8526d91a512cdc201

commit c789b84d8d68191d3e1b54e8526d91a512cdc201
Author: Jiawei Shao <jiawei.shao@intel.com>
Date: Mon Dec 10 05:20:19 2018

Rename draw commands to match WebGPU IDL

BUG= dawn:51 

Change-Id: I2a78f4e77c54aeae48d3fb78bf4701352ff40529
Reviewed-on: https://dawn-review.googlesource.com/c/3040
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>

[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/tests/end2end/DrawElementsTests.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/tests/end2end/ViewportOrientationTests.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/dawn_native/CommandBuffer.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/tests/end2end/DepthStencilStateTests.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/examples/CppHelloTriangle.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/dawn_native/CommandBufferStateTracker.h
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/tests/end2end/PushConstantTests.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/dawn_native/CommandBufferStateTracker.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/tests/end2end/TextureViewTests.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/tests/end2end/BindGroupTests.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/dawn_native/vulkan/CommandBufferVk.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/dawn_native/Commands.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/tests/end2end/BlendStateTests.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/dawn_native/RenderPassEncoder.h
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/dawn_native/metal/CommandBufferMTL.mm
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/dawn_native/opengl/CommandBufferGL.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/dawn_native/d3d12/CommandBufferD3D12.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/tests/unittests/validation/VertexBufferValidationTests.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/tests/end2end/RenderPassLoadOpTests.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/tests/end2end/ScissorTests.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/examples/CubeReflection.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/tests/end2end/InputStateTests.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/examples/ComputeBoids.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/examples/glTFViewer/glTFViewer.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/tests/end2end/PrimitiveTopologyTests.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/examples/Animometer.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/dawn_native/Commands.h
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/tests/end2end/SamplerTests.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/dawn_native/RenderPassEncoder.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/dawn.json
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/src/tests/end2end/IndexFormatTests.cpp
[modify] https://crrev.com/c789b84d8d68191d3e1b54e8526d91a512cdc201/examples/CHelloTriangle.cpp

Comment 5 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/ff9562f7927b614f16449f3c757c57c70543eb37

commit ff9562f7927b614f16449f3c757c57c70543eb37
Author: Jiawei Shao <jiawei.shao@intel.com>
Date: Thu Dec 13 01:05:26 2018

Implement 'baseVertex' in drawIndexed() on D3D12, Metal and Vulkan

This patch adds the support of the parameter 'baseVertex' of drawIndexed
on D3D12, Metal and Vulkan back-ends.

BUG= dawn:51 
TEST=dawn_end2end_tests

Change-Id: Ibd25884ad2abceaaed744d74c4ee6b0ae6b3fa1b
Reviewed-on: https://dawn-review.googlesource.com/c/3221
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>

[modify] https://crrev.com/ff9562f7927b614f16449f3c757c57c70543eb37/examples/glTFViewer/glTFViewer.cpp
[modify] https://crrev.com/ff9562f7927b614f16449f3c757c57c70543eb37/examples/CppHelloTriangle.cpp
[modify] https://crrev.com/ff9562f7927b614f16449f3c757c57c70543eb37/src/dawn_native/Commands.h
[rename] https://crrev.com/ff9562f7927b614f16449f3c757c57c70543eb37/src/tests/end2end/DrawIndexedTests.cpp
[modify] https://crrev.com/ff9562f7927b614f16449f3c757c57c70543eb37/src/dawn_native/RenderPassEncoder.cpp
[modify] https://crrev.com/ff9562f7927b614f16449f3c757c57c70543eb37/BUILD.gn
[modify] https://crrev.com/ff9562f7927b614f16449f3c757c57c70543eb37/src/dawn_native/RenderPassEncoder.h
[modify] https://crrev.com/ff9562f7927b614f16449f3c757c57c70543eb37/dawn.json
[modify] https://crrev.com/ff9562f7927b614f16449f3c757c57c70543eb37/src/dawn_native/metal/CommandBufferMTL.mm
[modify] https://crrev.com/ff9562f7927b614f16449f3c757c57c70543eb37/examples/CubeReflection.cpp
[modify] https://crrev.com/ff9562f7927b614f16449f3c757c57c70543eb37/src/tests/end2end/IndexFormatTests.cpp
[modify] https://crrev.com/ff9562f7927b614f16449f3c757c57c70543eb37/src/dawn_native/vulkan/CommandBufferVk.cpp
[modify] https://crrev.com/ff9562f7927b614f16449f3c757c57c70543eb37/src/dawn_native/d3d12/CommandBufferD3D12.cpp

Comment 6 by jiawei.s...@intel.com, Dec 13

Status: Fixed (was: Accepted)

Sign in to add a comment