New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 19
Cc:
OS: ----
Pri: 2
Type: Defect



Sign in to add a comment
link

Issue 35: End2end tests and samples cash on MacOS Mojave 10.14

Reported by hao.x...@intel.com, Nov 16 Project Member

Issue description

After I upgraded macOS to 10.14.1, both end2end tests and samples run crash with below error message:


 ./out/Debug/CHelloTriangle 
===
2018-11-16 15:47:13.545 CHelloTriangle[24476:284375] *** Assertion failure in -[GLFWContentView _createLayerAndInitialize], /BuildRoot/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit-1671.10.106/AppKit.subproj/NSView.m:17237
Illegal instruction: 4
===

./out/Debug/dawn_end2end_tests
===
[==========] Running 154 tests from 20 test cases.
[----------] Global test environment set-up.
[----------] 1 test from BasicTests
[ RUN      ] BasicTests.BufferSetSubData/Metal
2018-11-16 15:47:27.521 dawn_end2end_tests[24477:285080] *** Assertion failure in -[GLFWContentView _createLayerAndInitialize], /BuildRoot/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit-1671.10.106/AppKit.subproj/NSView.m:17237
2018-11-16 15:47:27.532 dawn_end2end_tests[24477:285080] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Views must return a valid layer from -makeBackingLayer.'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff3c1aae65 __exceptionPreprocess + 256
	1   libobjc.A.dylib                     0x00007fff68205720 objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff3c1c5ab2 +[NSException raise:format:arguments:] + 98
	3   Foundation                          0x00007fff3e569d1d -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 194
	4   AppKit                              0x00007fff396a8b72 -[NSView(NSInternal) _createLayerAndInitialize] + 565
	5   AppKit                              0x00007fff396a8823 -[NSView _updateLayerBackedness] + 764
	6   AppKit                              0x00007fff3968e5a4 -[NSView didChangeValueForKey:] + 65
	7   dawn_end2end_tests                  0x00000001040dc797 _ZN5utils16SwapChainImplMTL9ConfigureE17dawnTextureFormat19dawnTextureUsageBitjj + 231
	8   dawn_end2end_tests                  0x00000001040dc6a0 _ZZ29CreateSwapChainImplementationIN5utils16SwapChainImplMTLEE27dawnSwapChainImplementationPT_ENKUlPv17dawnTextureFormat19dawnTextureUsageBitjjE_clES5_S6_S7_jj + 64
	9   dawn_end2end_tests                  0x00000001040dc650 _ZZ29CreateSwapChainImplementationIN5utils16SwapChainImplMTLEE27dawnSwapChainImplementationPT_ENUlPv17dawnTextureFormat19dawnTextureUsageBitjjE_8__invokeES5_S6_S7_jj + 48
	10  libdawn_native.dylib                0x00000001043e7d68 _ZN11dawn_native13SwapChainBase9ConfigureEN4dawn13TextureFormatENS1_15TextureUsageBitEjj + 184
	11  libdawn_native.dylib                0x0000000104396799 _ZN11dawn_native12_GLOBAL__N_128ValidatingSwapChainConfigureEPNS_13SwapChainBaseEN4dawn13TextureFormatENS3_15TextureUsageBitEjj + 89
	12  libdawn.dylib                       0x000000010436cc3e dawnSwapChainConfigure + 62
	13  libdawn.dylib                       0x0000000104368c37 _ZNK4dawn9SwapChain9ConfigureENS_13TextureFormatENS_15TextureUsageBitEjj + 55
	14  dawn_end2end_tests                  0x0000000103fd1f1b _ZN8DawnTest5SetUpEv + 4043
	15  dawn_end2end_tests                  0x000000010415681e _ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc + 126
	16  dawn_end2end_tests                  0x00000001041087c2 _ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc + 114
	17  dawn_end2end_tests                  0x00000001041086a4 _ZN7testing4Test3RunEv + 116
	18  dawn_end2end_tests                  0x0000000104109de0 _ZN7testing8TestInfo3RunEv + 224
	19  dawn_end2end_tests                  0x000000010410b1cf _ZN7testing8TestCase3RunEv + 239
	20  dawn_end2end_tests                  0x0000000104120bf6 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 886
	21  dawn_end2end_tests                  0x000000010415a81e _ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc + 126
	22  dawn_end2end_tests                  0x0000000104120802 _ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc + 114
	23  dawn_end2end_tests                  0x00000001041206db _ZN7testing8UnitTest3RunEv + 395
	24  dawn_end2end_tests                  0x00000001040d9501 _Z13RUN_ALL_TESTSv + 17
	25  dawn_end2end_tests                  0x00000001040d94b4 main + 292
	26  libdyld.dylib                       0x00007fff692d408d start + 1
	27  ???                                 0x0000000000000001 0x0 + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
Abort trap: 6
===
 

Comment 1 by jiawei.s...@intel.com, Nov 16

Cc: jiawei.s...@intel.com yang...@intel.com kainino@chromium.org cwallez@chromium.org yunchao@chromium.org

Comment 2 by jiawei.s...@intel.com, Nov 16

Cc: -yunchao@chromium.org yunchao...@intel.com

Comment 3 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/391c8a9224e5bf02690722c06973af8427bdaa6b

commit 391c8a9224e5bf02690722c06973af8427bdaa6b
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon Nov 19 10:21:23 2018

Roll GLFW to pick up macOS Mojave fixes

BUG= dawn:35 

Change-Id: Id9f71ab3a6023b21883d1b3d2f8afcebcf5b2f71
Reviewed-on: https://dawn-review.googlesource.com/c/2480
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>

[modify] https://crrev.com/391c8a9224e5bf02690722c06973af8427bdaa6b/third_party/BUILD.gn
[modify] https://crrev.com/391c8a9224e5bf02690722c06973af8427bdaa6b/DEPS

Comment 4 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a71757dcb58bb0063bbf071c5ad641e50e52547

commit 3a71757dcb58bb0063bbf071c5ad641e50e52547
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon Nov 19 12:37:30 2018

Roll src/third_party/dawn and src/third_party/glfw/src

This rolls both projects at the same time because the GLFW build files
are in the Dawn repository and they had to be changed to account for
renames of GLFW source files.

Roll src/third_party/dawn/ 69b44ee6a..391c8a922 (4 commits)

https://dawn.googlesource.com/dawn.git/+log/69b44ee6a126..391c8a9224e5

$ git log 69b44ee6a..391c8a922 --date=short --no-merges --format='%ad %ae %s'
2018-11-19 cwallez Roll GLFW to pick up macOS Mojave fixes
2018-11-19 cwallez Roll Chromium's build system to fix Windows builds
2018-11-16 cwallez Run win-dawn-rel on the CQ
2018-11-16 jiawei.shao Support cube map and cube map array

Created with:
  roll-dep src/third_party/dawn

TBR=kainino@chromium.org
BUG= dawn:35 

Change-Id: Ied363fe9a74d655c690cefcecdc897c5abcf28ff
Reviewed-on: https://chromium-review.googlesource.com/c/1341830
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609252}
[modify] https://crrev.com/3a71757dcb58bb0063bbf071c5ad641e50e52547/DEPS
[modify] https://crrev.com/3a71757dcb58bb0063bbf071c5ad641e50e52547/third_party/glfw/README.chromium

Comment 5 by cwallez@chromium.org, Nov 19

Project Member
Status: Fixed (was: Accepted)

Sign in to add a comment