New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 5
Components:
OS: Linux
Pri: 1
Type: Task

Blocked on:
issue 2
issue 31

Blocking:
issue 22


Show other hotlists

Hotlists containing this issue:
Dawn-Hotlist


Sign in to add a comment
link

Issue 3: Make bindgroup creation use a descriptor instead of a builder

Reported by cwallez@chromium.org, Sep 11 Project Member

Issue description

WebGPU uses descriptors instead of builders so Dawn should do the same.
 

Comment 1 by cwallez@chromium.org, Sep 11

Project Member
Blockedon: 2
Blocking: -2

Comment 2 by cwallez@chromium.org, Sep 11

Project Member
Owner: ----

Comment 3 by cwallez@chromium.org, Sep 25

Project Member
Blocking: 22

Comment 4 by yunchao...@intel.com, Oct 26

Blockedon: 31

Comment 5 by cwallez@chromium.org, Nov 27

Project Member
Labels: Pri-1

Comment 6 by cwallez@chromium.org, Nov 30

Project Member
Labels: OS-Linux
Owner: cwallez@chromium.org
Status: Started (was: Accepted)

Comment 7 by bugdroid1@chromium.org, Dec 3

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/9ca9435087e06b6825c9d78413797e8b2094c411

commit 9ca9435087e06b6825c9d78413797e8b2094c411
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon Dec 03 09:58:09 2018

Rename BindGroupBinding -> BindGroupLayoutBinding

This makes the name match WebGPU's IDL

BUG= dawn:3 

Change-Id: I1338fa07580ba8c0f6700b7765fb7389018a4126
Reviewed-on: https://dawn-review.googlesource.com/c/2801
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/9ca9435087e06b6825c9d78413797e8b2094c411/src/utils/DawnHelpers.h
[modify] https://crrev.com/9ca9435087e06b6825c9d78413797e8b2094c411/dawn.json
[modify] https://crrev.com/9ca9435087e06b6825c9d78413797e8b2094c411/src/utils/DawnHelpers.cpp
[modify] https://crrev.com/9ca9435087e06b6825c9d78413797e8b2094c411/src/tests/unittests/WireTests.cpp

Comment 8 by bugdroid1@chromium.org, Dec 4

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/f48e6b74b7211f4558e910c98e93c38290d2bf28

commit f48e6b74b7211f4558e910c98e93c38290d2bf28
Author: Corentin Wallez <cwallez@chromium.org>
Date: Tue Dec 04 12:13:03 2018

dawncpp.h: Add nullptr ObjectBase constructor and assignment

BUG= dawn:3 

Change-Id: I9f7ec0ae1c7885809888a603ed056c6565751bec
Reviewed-on: https://dawn-review.googlesource.com/c/2840
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>

[modify] https://crrev.com/f48e6b74b7211f4558e910c98e93c38290d2bf28/src/tests/unittests/ObjectBaseTests.cpp
[modify] https://crrev.com/f48e6b74b7211f4558e910c98e93c38290d2bf28/generator/templates/apicpp.h

Comment 9 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/6f9d21e805424c82c3e41c0b8758ae7771f69bfd

commit 6f9d21e805424c82c3e41c0b8758ae7771f69bfd
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Dec 05 07:18:30 2018

Descriptorize BindGroups.

This commit adds utils::MakeBindGroup to make code craeting bind groups
nicer to read. Additional tests are added that give 100% coverage of
ValidateBindGroupDescriptor.

BUG= dawn:3 

Change-Id: I56e1da8c2952306ad233845b0ec3ec32aef793d9
Reviewed-on: https://dawn-review.googlesource.com/c/2802
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/examples/CubeReflection.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/vulkan/DeviceVk.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/tests/end2end/DepthStencilStateTests.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/vulkan/DeviceVk.h
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/examples/CppHelloTriangle.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/null/NullBackend.h
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/null/NullBackend.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/tests/unittests/validation/CommandBufferValidationTests.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/tests/end2end/PushConstantTests.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/BindGroup.h
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/opengl/DeviceGL.h
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/tests/end2end/TextureViewTests.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/tests/end2end/BindGroupTests.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/Device.h
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/tests/end2end/BlendStateTests.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/tests/unittests/WireTests.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/tests/end2end/ComputeCopyStorageBufferTests.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/d3d12/BindGroupD3D12.h
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/Device.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/metal/DeviceMTL.mm
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/BindGroup.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/d3d12/DeviceD3D12.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/tests/unittests/validation/BindGroupValidationTests.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/d3d12/BindGroupD3D12.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/vulkan/BindGroupVk.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/examples/ComputeBoids.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/examples/glTFViewer/glTFViewer.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/utils/DawnHelpers.h
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/d3d12/DeviceD3D12.h
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/tests/end2end/SamplerTests.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/opengl/DeviceGL.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/utils/DawnHelpers.cpp
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/dawn.json
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/metal/DeviceMTL.h
[modify] https://crrev.com/6f9d21e805424c82c3e41c0b8758ae7771f69bfd/src/dawn_native/vulkan/BindGroupVk.h

Comment 10 by cwallez@chromium.org, Dec 5

Project Member
Status: Fixed (was: Started)

Sign in to add a comment