New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 10
Components:
OS: ----
Pri: 1
Type: Task

Blocked on:
issue 32

Blocking:
issue 22
issue 3



Sign in to add a comment
link

Issue 2: Remove BufferView and have bindgroups take (buffer, offset, size) instead.

Reported by cwallez@chromium.org, Sep 11 Project Member

Issue description

Dawn currently uses BufferView as a way to package (Buffer, offset, size) but that doesn't match the WebGPU API where the BindGroup takes all of these in a descriptor instead.

Change the bindgroup creation to act like WebGPU then remove bufferview.

This is currently blocked on discussions in the group on the shape of the WebGPUBindGroupDescriptor.
 

Comment 1 by cwallez@chromium.org, Sep 11

Project Member
Blockedon: 3

Comment 2 by cwallez@chromium.org, Sep 11

Project Member
Blocking: 3

Comment 3 by cwallez@chromium.org, Sep 11

Project Member
Blockedon: -3

Comment 4 by cwallez@chromium.org, Sep 25

Project Member
Blocking: 22

Comment 5 by yunchao...@intel.com, Oct 26

Blockedon: 32

Comment 6 by cwallez@chromium.org, Nov 27

Project Member
Labels: Pri-1

Comment 7 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/6f0e1f9d8235842e3c1130e4133e92e850166584

commit 6f0e1f9d8235842e3c1130e4133e92e850166584
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Dec 07 12:31:53 2018

Remove BufferView and inline offset/size in BindGroup

BUG= dawn:2 

Change-Id: I811024c4ac3a6167dd0caff05eca3fbb2640e862
Reviewed-on: https://dawn-review.googlesource.com/c/2941
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/Forward.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/vulkan/BindGroupVk.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/CommandBuffer.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/tests/end2end/DepthStencilStateTests.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/vulkan/DeviceVk.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/utils/DawnHelpers.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/null/NullBackend.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/Buffer.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/Buffer.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/null/NullBackend.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/tests/unittests/validation/CommandBufferValidationTests.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/tests/end2end/PushConstantTests.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/d3d12/BufferD3D12.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/BindGroup.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/opengl/DeviceGL.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/metal/BufferMTL.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/vulkan/Forward.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/vulkan/DeviceVk.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/Device.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/tests/end2end/BlendStateTests.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/opengl/BufferGL.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/metal/Forward.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/metal/CommandBufferMTL.mm
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/tests/unittests/WireTests.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/tests/end2end/ComputeCopyStorageBufferTests.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/opengl/Forward.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/opengl/CommandBufferGL.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/metal/DeviceMTL.mm
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/BindGroup.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/d3d12/DeviceD3D12.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/tests/unittests/validation/BindGroupValidationTests.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/metal/BufferMTL.mm
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/tests/end2end/BindGroupTests.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/d3d12/BindGroupD3D12.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/generator/templates/dawn_native/ProcTable.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/examples/CubeReflection.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/opengl/BufferGL.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/examples/ComputeBoids.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/d3d12/Forward.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/ToBackend.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/vulkan/BufferVk.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/d3d12/BufferD3D12.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/opengl/DeviceGL.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/utils/DawnHelpers.cpp
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/d3d12/DeviceD3D12.h
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/dawn.json
[modify] https://crrev.com/6f0e1f9d8235842e3c1130e4133e92e850166584/src/dawn_native/metal/DeviceMTL.h

Comment 8 by cwallez@chromium.org, Dec 10

Project Member
Status: Fixed (was: Accepted)

Sign in to add a comment