New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Components:
OS: ----
Pri: 2
Type: Task



Sign in to add a comment
link

Issue 10: Add helper function to detect the GPU vendor in tests

Reported by cwallez@chromium.org, Sep 11 Project Member

Issue description

We want to skip tests but only on specific GPUs, so we need functions like in ANGLE: IsIntel, IsAMD, ...

To do this an API can be added to DawnNative.h to gather the PCI device and vendor ID.
 

Comment 1 by bugdroid1@chromium.org, Sep 19

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38

commit 58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38
Author: Jiawei Shao <jiawei.shao@intel.com>
Date: Wed Sep 19 00:32:52 2018

Collect GPU device information for end2end tests - Part I

This patch is the first one to support inspecting GPU information for
dawn_end2end_tests.

In this patch, we support collecting the device name, device id and
vendor id on D3D12 and Vulkan. We also support collecting the device
name on OpenGL. The collection on Metal will be supported in the next
patch. Using this information we implement a series of APIs to inspect
the information of both OS and GPU vendor.

We also skip two failed tests on Windows Intel Vulkan backends.

BUG= dawn:10 

Change-Id: If52a960c0bae3922a0b5650500218eff1400d77a
Reviewed-on: https://dawn-review.googlesource.com/1460
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/dawn_native/metal/DeviceMTL.mm
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/dawn_native/opengl/DeviceGL.h
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/dawn_native/d3d12/DeviceD3D12.cpp
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/dawn_native/DawnNative.cpp
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/dawn_native/vulkan/DeviceVk.cpp
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/dawn_native/d3d12/DeviceD3D12.h
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/tests/end2end/BlendStateTests.cpp
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/dawn_native/opengl/DeviceGL.cpp
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/dawn_native/vulkan/DeviceVk.h
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/dawn_native/Device.h
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/tests/end2end/ScissorTests.cpp
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/include/dawn_native/DawnNative.h
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/dawn_native/null/NullBackend.h
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/tests/DawnTest.cpp
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/dawn_native/null/NullBackend.cpp
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/dawn_native/metal/DeviceMTL.h
[modify] https://crrev.com/58809d413bcfe04e4c8a1d8dbb861f4b1dc7ce38/src/tests/DawnTest.h

Comment 2 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/813bfbd061128113dd7b4c7c80321b536597c362

commit 813bfbd061128113dd7b4c7c80321b536597c362
Author: Li Hao <hao.x.li@intel.com>
Date: Thu Nov 29 10:54:03 2018

Collect device information on Metal

Becuase CGDisplayIOServicePort is deprecated in OSX >= 10.9, we create
an alternative function which manually finding a service port with
matching vendor and product IDs.

BUG= dawn:10 
TEST=dawn_end2end_tests

Change-Id: I94ff65911e159c2b7075209d8902c1551560ed47
Reviewed-on: https://dawn-review.googlesource.com/c/2541
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>

[modify] https://crrev.com/813bfbd061128113dd7b4c7c80321b536597c362/BUILD.gn
[modify] https://crrev.com/813bfbd061128113dd7b4c7c80321b536597c362/src/tests/end2end/TextureViewTests.cpp
[modify] https://crrev.com/813bfbd061128113dd7b4c7c80321b536597c362/src/dawn_native/metal/DeviceMTL.mm

Comment 3 by jiawei.s...@intel.com, Dec 11

Status: Fixed (was: Accepted)

Sign in to add a comment