New issue
Advanced search Search tips

Issue 30 link

Starred by 22 users

Issue metadata

Status: Started
Owner:
Cc:
Components:

Blocked on:
issue 229

Blocking:
issue chromium:479283
issue chromium:523514
issue chromium:720301
issue chromium:512477
issue chromium:579534



Sign in to add a comment

Android/Linux client

Project Member Reported by mark@chromium.org, Mar 28 2015

Issue description

Crashpad should have one of these.
 
Showing comments 134 - 233 of 233 Older
Project Member

Comment 134 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/441789be5b83ce7d6c26151436673fd0b01ca6a9

commit 441789be5b83ce7d6c26151436673fd0b01ca6a9
Author: Joshua Peraza <jperaza@chromium.org>
Date: Tue Jan 30 21:01:48 2018

android: Implement Semaphore with a condition variable and mutex

Bionic uses negative values of a semaphore to represent contention.
`sem_timedwait` fails to restore the value to 0 on timeout resulting in
an error (EBUSY) upon calling `sem_destroy`.

Bug: crashpad:30
Change-Id: If1c73a54a879ebd003b0792ebb8f68ceb83ac8bb
Reviewed-on: https://chromium-review.googlesource.com/894106
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/441789be5b83ce7d6c26151436673fd0b01ca6a9/util/synchronization/semaphore.h
[modify] https://crrev.com/441789be5b83ce7d6c26151436673fd0b01ca6a9/util/synchronization/semaphore_posix.cc
[modify] https://crrev.com/441789be5b83ce7d6c26151436673fd0b01ca6a9/util/synchronization/semaphore_test.cc

Project Member

Comment 135 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/3f0371cce2750e8837819b28f383151a22b75fc9

commit 3f0371cce2750e8837819b28f383151a22b75fc9
Author: Joshua Peraza <jperaza@chromium.org>
Date: Wed Jan 31 17:06:59 2018

Define ElfImageReader::Memory()

Bug: crashpad:30
Change-Id: Ibb6c6423736daa9fb248ac0c8d724244906236d4
Reviewed-on: https://chromium-review.googlesource.com/894447
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/3f0371cce2750e8837819b28f383151a22b75fc9/snapshot/elf/elf_image_reader.cc

Project Member

Comment 136 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/574936540df33f434e82fa86565b9a5aabf89e34

commit 574936540df33f434e82fa86565b9a5aabf89e34
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Feb 01 18:50:07 2018

linux: Add CrashpadClient methods to start the handler

This change includes methods to install a signal handler to launch
the handler process at crash time or to launch the handler on behalf
of another process.

Bug: crashpad:30
Change-Id: I503c788cb3648852d09e9e8c1fe5099ca07a0277
Reviewed-on: https://chromium-review.googlesource.com/759406
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/574936540df33f434e82fa86565b9a5aabf89e34/client/BUILD.gn
[modify] https://crrev.com/574936540df33f434e82fa86565b9a5aabf89e34/client/client.gyp
[modify] https://crrev.com/574936540df33f434e82fa86565b9a5aabf89e34/client/crashpad_client.h
[add] https://crrev.com/574936540df33f434e82fa86565b9a5aabf89e34/client/crashpad_client_linux.cc

Project Member

Comment 137 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/38b20ca57efce584afd9c3de206b3ae3dda98b3d

commit 38b20ca57efce584afd9c3de206b3ae3dda98b3d
Author: Joshua Peraza <jperaza@chromium.org>
Date: Fri Feb 09 17:25:45 2018

Relocate CaptureContext to misc and implement on Linux

Previously, the mac version was  under client/ and win under util/win/.
This cl brings them all together under util/misc/ and combines common
test code.

Bug: crashpad:30
Change-Id: Idf0d0158b969d5aa9802dfc8c21f73041b2bcc6c
Reviewed-on: https://chromium-review.googlesource.com/907755
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/client/BUILD.gn
[delete] https://crrev.com/a483e2c599b865d0268d2afd909af284a8ac4d62/client/capture_context_mac.h
[delete] https://crrev.com/a483e2c599b865d0268d2afd909af284a8ac4d62/client/capture_context_mac_test.cc
[modify] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/client/client.gyp
[modify] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/client/client_test.gyp
[modify] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/client/crashpad_client_win.cc
[modify] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/client/simulate_crash_mac.h
[modify] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/client/simulate_crash_win.h
[modify] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/handler/crashpad_handler_test.cc
[modify] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/snapshot/win/crashpad_snapshot_test_crashing_child.cc
[modify] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc
[modify] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/snapshot/win/process_reader_win.cc
[modify] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/util/BUILD.gn
[add] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/util/misc/capture_context.h
[rename] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/util/misc/capture_context_broken.cc
[add] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/util/misc/capture_context_linux.S
[rename] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/util/misc/capture_context_mac.S
[add] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/util/misc/capture_context_test.cc
[add] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/util/misc/capture_context_test_util.h
[add] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/util/misc/capture_context_test_util_linux.cc
[add] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/util/misc/capture_context_test_util_mac.cc
[add] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/util/misc/capture_context_test_util_win.cc
[rename] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/util/misc/capture_context_win.asm
[modify] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/util/util.gyp
[modify] https://crrev.com/38b20ca57efce584afd9c3de206b3ae3dda98b3d/util/util_test.gyp
[delete] https://crrev.com/a483e2c599b865d0268d2afd909af284a8ac4d62/util/win/capture_context.h
[delete] https://crrev.com/a483e2c599b865d0268d2afd909af284a8ac4d62/util/win/capture_context_test.cc

Project Member

Comment 138 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/a8ad3bdbdfb118775b44f69909bd0609c29d8c23

commit a8ad3bdbdfb118775b44f69909bd0609c29d8c23
Author: Joshua Peraza <jperaza@chromium.org>
Date: Fri Feb 09 19:54:42 2018

linux: fix incorrect fallthrough

Previously, an error would have been logged twice.

Bug: crashpad:30
Change-Id: I9445c022550ad14497186c6878863fbf72d8cd59
Reviewed-on: https://chromium-review.googlesource.com/911822
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/a8ad3bdbdfb118775b44f69909bd0609c29d8c23/util/linux/ptracer.cc

Project Member

Comment 139 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/7d5487fc44b3c58e3b02ce83ad2dc6125b1d95fb

commit 7d5487fc44b3c58e3b02ce83ad2dc6125b1d95fb
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Feb 15 01:58:38 2018

minidump: add switch cases to handle linux/android and ARM

Bug: crashpad:30
Change-Id: Ib2ff936451a68415f39f6a19f561d2f536daf8d3
Reviewed-on: https://chromium-review.googlesource.com/920786
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/7d5487fc44b3c58e3b02ce83ad2dc6125b1d95fb/minidump/minidump_system_info_writer.cc

Project Member

Comment 140 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/90cde8e30f7d56e46ce7ba8c57524632591a1632

commit 90cde8e30f7d56e46ce7ba8c57524632591a1632
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Feb 15 21:46:51 2018

Disable upload on Android

Crash report upload is currently the responsibility of the embedding
client (e.g. Chrome) on Android.

Bug: crashpad:30
Change-Id: Ia658ec327783bd6d2ea6d7e279e942f458dd12ef
Reviewed-on: https://chromium-review.googlesource.com/922877
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/90cde8e30f7d56e46ce7ba8c57524632591a1632/handler/crash_report_upload_thread.cc

Project Member

Comment 141 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/5e5b927b38ca7fe75e6e683796b55f1d75266418

commit 5e5b927b38ca7fe75e6e683796b55f1d75266418
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Feb 15 23:51:51 2018

Build crashpad_client_linux.cc on Android

Bug: crashpad:30
Change-Id: I754468766c594c8de3cde6134645041f99864398
Reviewed-on: https://chromium-review.googlesource.com/922934
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/5e5b927b38ca7fe75e6e683796b55f1d75266418/client/client.gyp

Project Member

Comment 142 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/eec1e17ab5588680a3e1d4904f5ba497e24f496b

commit eec1e17ab5588680a3e1d4904f5ba497e24f496b
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Feb 16 00:03:41 2018

Fix two bugs in memset()ing CrashpadInfo on size mismatch

In trying to clear out the end of info when the alleged size is smaller
than the current structure size, we didn't handle the opposite case. We
need to continue the rest of Read() to initialize members, but need to
make sure not to pass a very large (negative -> size_t) length to
memset().

Additionally, I believe it meant to memset from the end of the alleged
size, to the end of the local structure, rather than from the beginning
of the structure.

This repro'd on Fuchsia, but would affect all platforms that use it.

Bug: crashpad:196, crashpad:30
Change-Id: I9c35c834010b5cb26d54156ce8f9bc538dcbf96c
Reviewed-on: https://chromium-review.googlesource.com/923094
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/eec1e17ab5588680a3e1d4904f5ba497e24f496b/snapshot/crashpad_types/crashpad_info_reader.cc

Project Member

Comment 144 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/8b738cd24d59b2863b0f7d1104597d7a51c5fd52

commit 8b738cd24d59b2863b0f7d1104597d7a51c5fd52
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Feb 19 20:01:28 2018

Don't include crash_report_database_generic.cc on Win/Mac

Reported by Mihnea Craciun at
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/crashpad-dev/IvAnF1bisFg/mkmai0vvBgAJ.

Bug: crashpad:30
Change-Id: Ia1bca6e832062d1e454285ac0b3c97b56760c417
Reviewed-on: https://chromium-review.googlesource.com/925449
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/8b738cd24d59b2863b0f7d1104597d7a51c5fd52/client/client.gyp

Project Member

Comment 145 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/d2a866978b89508f9397266bfe0253755383899f

commit d2a866978b89508f9397266bfe0253755383899f
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Feb 19 21:27:28 2018

Makes 'all' build on Linux

I can never remember which targets are buildable; this makes just

  ninja -C out/lin

work, without too much fuss. I think this means we could turn on trybots
too, as I think all the tests that are built also run.

Bug: crashpad:30
Change-Id: I4759bb799dabf977c5b072691f28d00bf92bbebc
Reviewed-on: https://chromium-review.googlesource.com/924564
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/d2a866978b89508f9397266bfe0253755383899f/handler/BUILD.gn
[modify] https://crrev.com/d2a866978b89508f9397266bfe0253755383899f/handler/handler.gyp
[modify] https://crrev.com/d2a866978b89508f9397266bfe0253755383899f/handler/handler_main.cc
[modify] https://crrev.com/d2a866978b89508f9397266bfe0253755383899f/tools/generate_dump.cc

Project Member

Comment 147 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ea419ae3797cfca6278d7c742ff9c3423db6c696

commit ea419ae3797cfca6278d7c742ff9c3423db6c696
Author: Scott Graham <scottmg@chromium.org>
Date: Tue Feb 20 15:28:34 2018

Add Linux and Fuchsia ARM64 bots to client.crashpad

Bot requests at https://crbug.com/813635 and https://crbug.com/813636,
but for now they should multiplex fine onto the existing bot.

Bug: crashpad:30, crashpad:196, crashpad:212
Change-Id: I64b13d48407cac5d9b6e46b73bee6fd194d68827
Reviewed-on: https://chromium-review.googlesource.com/924396
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/ea419ae3797cfca6278d7c742ff9c3423db6c696/masters/master.client.crashpad/builders.pyl

Project Member

Comment 148 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/ebad8bd925c36721afc4a02c55fb9ddf868a5a68

commit ebad8bd925c36721afc4a02c55fb9ddf868a5a68
Author: Joshua Peraza <jperaza@chromium.org>
Date: Tue Feb 20 19:02:29 2018

Don't spawn an upload thread if url is empty

Also automatically stop upload and prune threads on destruction.

Bug: crashpad:30
Change-Id: I45a30944eb3052182da296e00a6d6041691ab772
Reviewed-on: https://chromium-review.googlesource.com/924456
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/ebad8bd925c36721afc4a02c55fb9ddf868a5a68/handler/crash_report_upload_thread.cc
[modify] https://crrev.com/ebad8bd925c36721afc4a02c55fb9ddf868a5a68/handler/crash_report_upload_thread.h
[modify] https://crrev.com/ebad8bd925c36721afc4a02c55fb9ddf868a5a68/handler/handler_main.cc
[modify] https://crrev.com/ebad8bd925c36721afc4a02c55fb9ddf868a5a68/handler/mac/crash_report_exception_handler.cc
[modify] https://crrev.com/ebad8bd925c36721afc4a02c55fb9ddf868a5a68/handler/mac/crash_report_exception_handler.h
[modify] https://crrev.com/ebad8bd925c36721afc4a02c55fb9ddf868a5a68/handler/prune_crash_reports_thread.h
[modify] https://crrev.com/ebad8bd925c36721afc4a02c55fb9ddf868a5a68/handler/win/crash_report_exception_handler.cc
[modify] https://crrev.com/ebad8bd925c36721afc4a02c55fb9ddf868a5a68/handler/win/crash_report_exception_handler.h
[modify] https://crrev.com/ebad8bd925c36721afc4a02c55fb9ddf868a5a68/util/BUILD.gn
[add] https://crrev.com/ebad8bd925c36721afc4a02c55fb9ddf868a5a68/util/thread/stoppable.h
[modify] https://crrev.com/ebad8bd925c36721afc4a02c55fb9ddf868a5a68/util/util.gyp

Project Member

Comment 150 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/38540eaf71cb997779a9c79cdca6b6bc59ea8195

commit 38540eaf71cb997779a9c79cdca6b6bc59ea8195
Author: Joshua Peraza <jperaza@chromium.org>
Date: Tue Feb 20 23:09:02 2018

Add handler options for Linux/Android

Add the options:
--trace-parent-with-exception=<address>
  which traces the handler's parent process which has an
  ExceptionInformation struct at <address>.
--initial-client-fd=<fd>
  which starts the handler server with an already connected client on
  socket <fd>.

Bug: crashpad:30
Change-Id: Ied9760ca125a16f56173afdc56dff5fcb79d2eea
Reviewed-on: https://chromium-review.googlesource.com/922895
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/38540eaf71cb997779a9c79cdca6b6bc59ea8195/handler/crashpad_handler.md
[modify] https://crrev.com/38540eaf71cb997779a9c79cdca6b6bc59ea8195/handler/handler.gyp
[modify] https://crrev.com/38540eaf71cb997779a9c79cdca6b6bc59ea8195/handler/handler_main.cc

Project Member

Comment 152 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/1aae5cedaf1e759fd05270ccb09642224bcfa555

commit 1aae5cedaf1e759fd05270ccb09642224bcfa555
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Feb 21 20:20:43 2018

Refactor ModuleSnapshot(Linux|Fuchsia) into ModuleSnapshotElf

They were largely the same after recent changes, so with a bit at
initialization time the whole class can be de-duplicated.

Bug: crashpad:196, crashpad:30
Change-Id: I2f5df797dfe36e120090e570273b48ee03f660a5
Reviewed-on: https://chromium-review.googlesource.com/927611
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/1aae5cedaf1e759fd05270ccb09642224bcfa555/snapshot/BUILD.gn
[rename] https://crrev.com/1aae5cedaf1e759fd05270ccb09642224bcfa555/snapshot/elf/module_snapshot_elf.cc
[rename] https://crrev.com/1aae5cedaf1e759fd05270ccb09642224bcfa555/snapshot/elf/module_snapshot_elf.h
[delete] https://crrev.com/cab259330f2e73c4862d9d71eae70bcfcd44faa6/snapshot/fuchsia/module_snapshot_fuchsia.cc
[delete] https://crrev.com/cab259330f2e73c4862d9d71eae70bcfcd44faa6/snapshot/fuchsia/module_snapshot_fuchsia.h
[modify] https://crrev.com/1aae5cedaf1e759fd05270ccb09642224bcfa555/snapshot/fuchsia/process_snapshot_fuchsia.cc
[modify] https://crrev.com/1aae5cedaf1e759fd05270ccb09642224bcfa555/snapshot/fuchsia/process_snapshot_fuchsia.h
[modify] https://crrev.com/1aae5cedaf1e759fd05270ccb09642224bcfa555/snapshot/linux/process_snapshot_linux.cc
[modify] https://crrev.com/1aae5cedaf1e759fd05270ccb09642224bcfa555/snapshot/linux/process_snapshot_linux.h
[modify] https://crrev.com/1aae5cedaf1e759fd05270ccb09642224bcfa555/snapshot/snapshot.gyp

Project Member

Comment 153 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2a3edaf1a0b3e8ca46ad4889a1dc9b8770f5b3be

commit 2a3edaf1a0b3e8ca46ad4889a1dc9b8770f5b3be
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Feb 21 20:25:39 2018

Add slaves for Linux and Fuchsia ARM configs

Bots allocated in crbug.com/813635 and crbug.com/813636.

Bug: crashpad:196, crashpad:212, crashpad:30
Change-Id: I27f5548f441337c876bb59884a3eb5b5ae1fbafd
Reviewed-on: https://chromium-review.googlesource.com/929743
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/2a3edaf1a0b3e8ca46ad4889a1dc9b8770f5b3be/masters/master.client.crashpad/builders.pyl

Project Member

Comment 155 by bugdroid1@chromium.org, Feb 22 2018

Project Member

Comment 156 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/2b05eb522fa43501179b31893fb18f8f2ea222e2

commit 2b05eb522fa43501179b31893fb18f8f2ea222e2
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Feb 22 21:33:39 2018

Rename ProcessReader to platform-suffixed versions

Mac's ProcessReader becomes ProcessReaderMac.
Linux/Android's ProcessReader becomes ProcessReaderLinux.
Fuchsia's ProcessReader becomes ProcessReaderFuchsia.

No intended change in behavior.

Bug: crashpad:196, crashpad:30
Change-Id: I7ec8d72f79533bd78189173261ade2ad99010bad
Reviewed-on: https://chromium-review.googlesource.com/930321
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/BUILD.gn
[rename] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/fuchsia/process_reader_fuchsia.cc
[rename] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/fuchsia/process_reader_fuchsia.h
[rename] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/fuchsia/process_reader_fuchsia_test.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/fuchsia/process_snapshot_fuchsia.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/fuchsia/process_snapshot_fuchsia.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/linux/exception_snapshot_linux.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/linux/exception_snapshot_linux.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/linux/exception_snapshot_linux_test.cc
[rename] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/linux/process_reader_linux.cc
[rename] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/linux/process_reader_linux.h
[rename] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/linux/process_reader_linux_test.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/linux/process_snapshot_linux.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/linux/process_snapshot_linux.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/linux/system_snapshot_linux.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/linux/system_snapshot_linux.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/linux/system_snapshot_linux_test.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/linux/thread_snapshot_linux.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/linux/thread_snapshot_linux.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/exception_snapshot_mac.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/exception_snapshot_mac.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/mach_o_image_annotations_reader.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/mach_o_image_annotations_reader.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/mach_o_image_annotations_reader_test.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/mach_o_image_reader.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/mach_o_image_reader.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/mach_o_image_reader_test.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/mach_o_image_segment_reader.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/mach_o_image_segment_reader.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/mach_o_image_symbol_table_reader.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/mach_o_image_symbol_table_reader.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/module_snapshot_mac.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/module_snapshot_mac.h
[rename] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/process_reader_mac.cc
[rename] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/process_reader_mac.h
[rename] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/process_reader_mac_test.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/process_snapshot_mac.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/process_snapshot_mac.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/process_types.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/process_types.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/process_types/custom.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/process_types_test.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/system_snapshot_mac.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/system_snapshot_mac.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/system_snapshot_mac_test.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/thread_snapshot_mac.cc
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/mac/thread_snapshot_mac.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/snapshot.gyp
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/snapshot_test.gyp
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/win/exception_snapshot_win.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/snapshot/win/module_snapshot_win.h
[modify] https://crrev.com/2b05eb522fa43501179b31893fb18f8f2ea222e2/test/mac/dyld.cc

Project Member

Comment 157 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/52a70c0ce929400b3f79f4da988cc866cd0640b7

commit 52a70c0ce929400b3f79f4da988cc866cd0640b7
Author: Scott Graham <scottmg@google.com>
Date: Thu Feb 22 21:57:10 2018

Project Member

Comment 159 by bugdroid1@chromium.org, Feb 23 2018

Project Member

Comment 160 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e57bc6978ba451dcd8eefa8629bff2965d0e998

commit 8e57bc6978ba451dcd8eefa8629bff2965d0e998
Author: Joshua Peraza <jperaza@chromium.org>
Date: Wed Feb 28 17:13:40 2018

Update Crashpad to fa2a03fbdd0f8ca13511f66dded97a09cd08536e

14dbd3531d98 gn win: Get main test binaries building
6cf4f928eb08 gn win: Add auxiliary test binaries used by
             end_to_end_test.py
36679d572ba0 win: Don't assume offsets the same when
             kDoesNotObserveDaylightSavingTime
9ab4fbf1e1a7 win: Improve child crash location test
798f6540435f gn win: Use new toolchain names to support both x86 and x64
83a83c5b0050 Roll mini_chromium to e7e8237
a483e2c599b8 Fix names of Windows trybots after server-side rename
38b20ca57efc Relocate CaptureContext to misc and implement on Linux
a8ad3bdbdfb1 linux: fix incorrect fallthrough
73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
f878f155172b fuchsia: Add flock() stub to get test binaries linking
             again
e5bbdaff87a9 Pass FilePath to Settings in Initialize()
c45ba7920e01 Make NewReport objects own their associated database
             resources
7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
c406797ce620 Add  UploadReport to manage database resources during
             upload
7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
             symtab
8d0d999d9245 Add a cross-platform database implementation
b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
             implementations
6667fa25595a fuchsia: Fixes to TestPaths
90cde8e30f7d Disable upload on Android
4094c2628d33 Address review comments for 8d0d999
a4d7fb4cc390 Use .long for pointers on 32-bit platforms
5e5b927b38ca Build crashpad_client_linux.cc on Android
eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
0429216f59b1 linux: Add CrashReportExceptionHandler
f38af628c9dc fuchsia: Don't fail rename if source == dest
040360239343 Fix
             CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
             ions
10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
             functional
5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
             Settings
4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
             source root
4a9d422652a1 Turn fuchsia trybots on by default
ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
             from SDK
8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
d2a866978b89 Makes 'all' build on Linux
d8d03172c278 arm: Capture context around pc and registers
ebad8bd925c3 Don't spawn an upload thread if url is empty
0520fdff1edc linux: Move ScopedPrSetPtracer to util/
38540eaf71cb Add handler options for Linux/Android
01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
cab259330f2e fuchsia: Pass more data out of module snapshot
1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
             ModuleSnapshotElf
4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
             ProcessSnapshotFuchsia
2290a826af1e Pull (most) platform-specific MemorySnapshots out
3030ae54171a fuchsia: Fix ninja auto-regen after run
61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
             test
c69ba3d52783 non-win: Add
             Multiprocess::SetExpectedChildTerminationBuiltinTrap()
f130822b9f4b linux: Add CrashpadClient tests
2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()

Also:
Add new metrics enums values.
Use new CrashReportDatabase interface.

Bug: crashpad:30
Change-Id: Ibb9e8eafdd3f310e933bd7dab812254efed1b2be
Reviewed-on: https://chromium-review.googlesource.com/935486
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539856}
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/components/browser_watcher/postmortem_report_collector.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/components/browser_watcher/postmortem_report_collector.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/components/browser_watcher/postmortem_report_collector_unittest.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/components/crash/content/app/minidump_with_crashpad_info.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/README.chromium
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/DEPS
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/build/BUILDCONFIG.gn
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/build/run_tests.py
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/BUILD.gn
[delete] https://crrev.com/0ae6f64d0862366948e850cefde6cc2de7e7fe83/third_party/crashpad/crashpad/client/capture_context_mac.h
[delete] https://crrev.com/0ae6f64d0862366948e850cefde6cc2de7e7fe83/third_party/crashpad/crashpad/client/capture_context_mac_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/client.gyp
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/client_test.gyp
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/crash_report_database.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/crash_report_database.h
[delete] https://crrev.com/0ae6f64d0862366948e850cefde6cc2de7e7fe83/third_party/crashpad/crashpad/client/crash_report_database_fuchsia.cc
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/crash_report_database_generic.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/crash_report_database_mac.mm
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/crash_report_database_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/crash_report_database_win.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/crashpad_client.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/crashpad_client_linux.cc
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/crashpad_client_linux_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/crashpad_client_win.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/crashpad_info.cc
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/crashpad_info_note.S
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/prune_crash_reports_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/settings.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/settings.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/settings_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/simulate_crash.h
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/simulate_crash_linux.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/simulate_crash_mac.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/client/simulate_crash_win.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/BUILD.gn
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/crash_report_upload_thread.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/crashpad_handler.md
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/crashpad_handler_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/handler.gyp
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/handler_main.cc
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.cc
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/linux/exception_handler_server_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/prune_crash_reports_thread.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/prune_crash_reports_thread.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/infra/config/cq.cfg
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/minidump/minidump_system_info_writer.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/BUILD.gn
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/capture_memory.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_module.cc
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_note.S
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/crashpad_types/image_annotation_reader_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test_note.S
[rename] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/elf/module_snapshot_elf.cc
[rename] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/elf/module_snapshot_elf.h
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.cc
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.h
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux_test.cc
[delete] https://crrev.com/0ae6f64d0862366948e850cefde6cc2de7e7fe83/third_party/crashpad/crashpad/snapshot/linux/memory_snapshot_linux.cc
[delete] https://crrev.com/0ae6f64d0862366948e850cefde6cc2de7e7fe83/third_party/crashpad/crashpad/snapshot/linux/memory_snapshot_linux.h
[rename] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux.cc
[rename] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux.h
[rename] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.h
[delete] https://crrev.com/0ae6f64d0862366948e850cefde6cc2de7e7fe83/third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.cc
[delete] https://crrev.com/0ae6f64d0862366948e850cefde6cc2de7e7fe83/third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.h
[rename] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/process_reader_mac.cc
[rename] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/process_reader_mac.h
[rename] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/process_reader_mac_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/process_types.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/process_types.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/process_types/custom.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/process_types_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.h
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/memory_snapshot_generic.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/snapshot.gyp
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/snapshot_test.gyp
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/win/process_reader_win.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/snapshot/win/system_snapshot_win_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/test/BUILD.gn
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/test/mac/dyld.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/test/multiprocess.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/test/multiprocess_exec_fuchsia.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/test/multiprocess_exec_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/test/multiprocess_exec_test_child.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/test/multiprocess_posix.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/test/test.gyp
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/test/test_paths.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/tools/crashpad_database_util.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/tools/generate_dump.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/BUILD.gn
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/file/file_io.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/file/file_io_posix.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/file/file_io_test.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/file/filesystem_posix.cc
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/linux/ptracer.cc
[rename] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/linux/scoped_pr_set_ptracer.cc
[rename] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/linux/scoped_pr_set_ptracer.h
[modify] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/linux/scoped_ptrace_attach_test.cc
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/misc/capture_context.h
[rename] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/misc/capture_context_broken.cc
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/misc/capture_context_linux.S
[rename] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/misc/capture_context_mac.S
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/misc/capture_context_test.cc
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/misc/capture_context_test_util.h
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/misc/capture_context_test_util_linux.cc
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/misc/capture_context_test_util_mac.cc
[add] https://crrev.com/8e57bc6978ba451dcd8eefa8629bff2965d0e998/third_party/crashpad/crashpad/util/misc/capture_context_test_util_win.cc
[rename] https:/
Project Member

Comment 161 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/589d075450daa42c4f5b52f13100d3baa6ebc4b2

commit 589d075450daa42c4f5b52f13100d3baa6ebc4b2
Author: Xi Cheng <chengx@chromium.org>
Date: Wed Feb 28 17:40:13 2018

Revert "Update Crashpad to fa2a03fbdd0f8ca13511f66dded97a09cd08536e"

This reverts commit 8e57bc6978ba451dcd8eefa8629bff2965d0e998.

Reason for revert: Broke the build --  https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder%20(dbg)/129796

Original change's description:
> Update Crashpad to fa2a03fbdd0f8ca13511f66dded97a09cd08536e
> 
> 14dbd3531d98 gn win: Get main test binaries building
> 6cf4f928eb08 gn win: Add auxiliary test binaries used by
>              end_to_end_test.py
> 36679d572ba0 win: Don't assume offsets the same when
>              kDoesNotObserveDaylightSavingTime
> 9ab4fbf1e1a7 win: Improve child crash location test
> 798f6540435f gn win: Use new toolchain names to support both x86 and x64
> 83a83c5b0050 Roll mini_chromium to e7e8237
> a483e2c599b8 Fix names of Windows trybots after server-side rename
> 38b20ca57efc Relocate CaptureContext to misc and implement on Linux
> a8ad3bdbdfb1 linux: fix incorrect fallthrough
> 73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
> b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
> f878f155172b fuchsia: Add flock() stub to get test binaries linking
>              again
> e5bbdaff87a9 Pass FilePath to Settings in Initialize()
> c45ba7920e01 Make NewReport objects own their associated database
>              resources
> 7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
> c406797ce620 Add  UploadReport to manage database resources during
>              upload
> 7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
>              symtab
> 8d0d999d9245 Add a cross-platform database implementation
> b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
>              implementations
> 6667fa25595a fuchsia: Fixes to TestPaths
> 90cde8e30f7d Disable upload on Android
> 4094c2628d33 Address review comments for 8d0d999
> a4d7fb4cc390 Use .long for pointers on 32-bit platforms
> 5e5b927b38ca Build crashpad_client_linux.cc on Android
> eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
> 4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
> f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
> 6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
> 0429216f59b1 linux: Add CrashReportExceptionHandler
> f38af628c9dc fuchsia: Don't fail rename if source == dest
> 040360239343 Fix
>              CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
>              ions
> 10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
>              functional
> 5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
>              Settings
> 4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
> 8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
>              source root
> 4a9d422652a1 Turn fuchsia trybots on by default
> ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
>              from SDK
> 8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
> d2a866978b89 Makes 'all' build on Linux
> d8d03172c278 arm: Capture context around pc and registers
> ebad8bd925c3 Don't spawn an upload thread if url is empty
> 0520fdff1edc linux: Move ScopedPrSetPtracer to util/
> 38540eaf71cb Add handler options for Linux/Android
> 01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
> 3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
> cab259330f2e fuchsia: Pass more data out of module snapshot
> 1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
>              ModuleSnapshotElf
> 4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
>              ProcessSnapshotFuchsia
> 2290a826af1e Pull (most) platform-specific MemorySnapshots out
> 3030ae54171a fuchsia: Fix ninja auto-regen after run
> 61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
>              test
> c69ba3d52783 non-win: Add
>              Multiprocess::SetExpectedChildTerminationBuiltinTrap()
> f130822b9f4b linux: Add CrashpadClient tests
> 2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
> fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
> 
> Also:
> Add new metrics enums values.
> Use new CrashReportDatabase interface.
> 
> Bug: crashpad:30
> Change-Id: Ibb9e8eafdd3f310e933bd7dab812254efed1b2be
> Reviewed-on: https://chromium-review.googlesource.com/935486
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#539856}

TBR=jperaza@chromium.org,mark@chromium.org,siggi@chromium.org

Change-Id: Ice1d4a445c2625a3403f0ea6371065db45d7b706
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: crashpad:30
Reviewed-on: https://chromium-review.googlesource.com/941386
Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539865}
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/components/browser_watcher/postmortem_report_collector.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/components/browser_watcher/postmortem_report_collector.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/components/browser_watcher/postmortem_report_collector_unittest.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/components/crash/content/app/minidump_with_crashpad_info.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/README.chromium
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/DEPS
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/build/BUILDCONFIG.gn
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/build/run_tests.py
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/BUILD.gn
[rename] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/capture_context_mac.S
[add] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/capture_context_mac.h
[add] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/capture_context_mac_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/client.gyp
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/client_test.gyp
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/crash_report_database.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/crash_report_database.h
[add] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/crash_report_database_fuchsia.cc
[delete] https://crrev.com/5ad48177e1359d9ba6410f1ece0f4f238f41da84/third_party/crashpad/crashpad/client/crash_report_database_generic.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/crash_report_database_mac.mm
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/crash_report_database_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/crash_report_database_win.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/crashpad_client.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/crashpad_client_linux.cc
[delete] https://crrev.com/5ad48177e1359d9ba6410f1ece0f4f238f41da84/third_party/crashpad/crashpad/client/crashpad_client_linux_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/crashpad_client_win.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/crashpad_info.cc
[delete] https://crrev.com/5ad48177e1359d9ba6410f1ece0f4f238f41da84/third_party/crashpad/crashpad/client/crashpad_info_note.S
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/prune_crash_reports_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/settings.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/settings.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/settings_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/simulate_crash.h
[delete] https://crrev.com/5ad48177e1359d9ba6410f1ece0f4f238f41da84/third_party/crashpad/crashpad/client/simulate_crash_linux.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/simulate_crash_mac.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/client/simulate_crash_win.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/handler/BUILD.gn
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/handler/crash_report_upload_thread.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/handler/crashpad_handler.md
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/handler/crashpad_handler_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/handler/handler.gyp
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/handler/handler_main.cc
[delete] https://crrev.com/5ad48177e1359d9ba6410f1ece0f4f238f41da84/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.cc
[delete] https://crrev.com/5ad48177e1359d9ba6410f1ece0f4f238f41da84/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/handler/linux/exception_handler_server_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/handler/prune_crash_reports_thread.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/handler/prune_crash_reports_thread.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/infra/config/cq.cfg
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/minidump/minidump_system_info_writer.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/BUILD.gn
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/capture_memory.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_module.cc
[delete] https://crrev.com/5ad48177e1359d9ba6410f1ece0f4f238f41da84/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_note.S
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/crashpad_types/image_annotation_reader_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test_note.S
[delete] https://crrev.com/5ad48177e1359d9ba6410f1ece0f4f238f41da84/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.cc
[delete] https://crrev.com/5ad48177e1359d9ba6410f1ece0f4f238f41da84/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.h
[delete] https://crrev.com/5ad48177e1359d9ba6410f1ece0f4f238f41da84/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux_test.cc
[add] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/memory_snapshot_linux.cc
[add] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/memory_snapshot_linux.h
[rename] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/module_snapshot_linux.cc
[rename] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/module_snapshot_linux.h
[rename] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/process_reader.cc
[rename] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/process_reader.h
[rename] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/process_reader_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.h
[add] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.cc
[add] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.h
[rename] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/process_reader.cc
[rename] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/process_reader.h
[rename] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/process_reader_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/process_types.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/process_types.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/process_types/custom.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/process_types_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.h
[delete] https://crrev.com/5ad48177e1359d9ba6410f1ece0f4f238f41da84/third_party/crashpad/crashpad/snapshot/memory_snapshot_generic.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/snapshot.gyp
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/snapshot_test.gyp
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/win/process_reader_win.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/snapshot/win/system_snapshot_win_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/test/BUILD.gn
[rename] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/test/linux/scoped_pr_set_ptracer.cc
[rename] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/test/linux/scoped_pr_set_ptracer.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/test/mac/dyld.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/test/multiprocess.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/test/multiprocess_exec_fuchsia.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/test/multiprocess_exec_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/test/multiprocess_exec_test_child.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/test/multiprocess_posix.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/test/test.gyp
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/test/test_paths.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/tools/crashpad_database_util.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/tools/generate_dump.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/util/BUILD.gn
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/util/file/file_io.h
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/util/file/file_io_posix.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/util/file/file_io_test.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/util/file/filesystem_posix.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/util/linux/ptracer.cc
[modify] https://crrev.com/589d075450daa42c4f5b52f13100d3baa6ebc4b2/third_party/crashpad/crashpad/util/linux/scoped_ptrace_attach_test.cc
[delete] https://crrev.com/5ad48177e1359d9ba6410f1ece0f4f238f41da84/third_party/crashpad/crashpad/util/misc/capture_context.h
[delete] https://crrev.com/5ad48177e1359d9ba6410f1ece0f4f238f41da84/third_party/crashpad/crashpad/util/misc/capture_context_l
Project Member

Comment 162 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/mini_chromium/+/987bde826c04158c11190f3764db6b9f5ce870bb

commit 987bde826c04158c11190f3764db6b9f5ce870bb
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Feb 28 18:56:21 2018

Linux GN: Optionally link statically against libstdc++

This accomodates the sysroot being slightly newer than the old bots that
represent the minspec for Chromium.

Before:

scottmg@around:/work/cp2/crashpad$ ldd -v out/lin/crashpad_client_test
	linux-vdso.so.1 (0x00007ffc103c1000)
	libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fad8917e000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fad88e7a000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fad88c5d000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fad888be000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fad89500000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fad886a7000)

	Version information:
	out/lin/crashpad_client_test:
		libc.so.6 (GLIBC_2.2.5) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.3.4) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.4) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.6) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.14) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.17) => /lib/x86_64-linux-gnu/libc.so.6
		libstdc++.so.6 (GLIBCXX_3.4) => /usr/lib/x86_64-linux-gnu/libstdc++.so.6
		libstdc++.so.6 (GLIBCXX_3.4.15) => /usr/lib/x86_64-linux-gnu/libstdc++.so.6
		libstdc++.so.6 (GLIBCXX_3.4.20) => /usr/lib/x86_64-linux-gnu/libstdc++.so.6
		libstdc++.so.6 (GLIBCXX_3.4.21) => /usr/lib/x86_64-linux-gnu/libstdc++.so.6
		libstdc++.so.6 (CXXABI_1.3) => /usr/lib/x86_64-linux-gnu/libstdc++.so.6
		libpthread.so.0 (GLIBC_2.2.5) => /lib/x86_64-linux-gnu/libpthread.so.0
		libm.so.6 (GLIBC_2.2.5) => /lib/x86_64-linux-gnu/libm.so.6
	/usr/lib/x86_64-linux-gnu/libstdc++.so.6:
		ld-linux-x86-64.so.2 (GLIBC_2.3) => /lib64/ld-linux-x86-64.so.2
		libm.so.6 (GLIBC_2.2.5) => /lib/x86_64-linux-gnu/libm.so.6
		libgcc_s.so.1 (GCC_4.2.0) => /lib/x86_64-linux-gnu/libgcc_s.so.1
		libgcc_s.so.1 (GCC_3.3) => /lib/x86_64-linux-gnu/libgcc_s.so.1
		libgcc_s.so.1 (GCC_3.0) => /lib/x86_64-linux-gnu/libgcc_s.so.1
		libc.so.6 (GLIBC_2.14) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.18) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.3) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.17) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.3.2) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.2.5) => /lib/x86_64-linux-gnu/libc.so.6
	/lib/x86_64-linux-gnu/libm.so.6:
		ld-linux-x86-64.so.2 (GLIBC_PRIVATE) => /lib64/ld-linux-x86-64.so.2
		libc.so.6 (GLIBC_2.2.5) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_PRIVATE) => /lib/x86_64-linux-gnu/libc.so.6
	/lib/x86_64-linux-gnu/libpthread.so.0:
		ld-linux-x86-64.so.2 (GLIBC_2.2.5) => /lib64/ld-linux-x86-64.so.2
		ld-linux-x86-64.so.2 (GLIBC_PRIVATE) => /lib64/ld-linux-x86-64.so.2
		libc.so.6 (GLIBC_2.14) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.3.2) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.2.5) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_PRIVATE) => /lib/x86_64-linux-gnu/libc.so.6
	/lib/x86_64-linux-gnu/libc.so.6:
		ld-linux-x86-64.so.2 (GLIBC_2.3) => /lib64/ld-linux-x86-64.so.2
		ld-linux-x86-64.so.2 (GLIBC_PRIVATE) => /lib64/ld-linux-x86-64.so.2
	/lib/x86_64-linux-gnu/libgcc_s.so.1:
		libc.so.6 (GLIBC_2.14) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.2.5) => /lib/x86_64-linux-gnu/libc.so.6


After with link_libstdcpp_statically=true (noting no libstdc++.so.6):

 scottmg@around:/work/cp2/crashpad$ ldd -v out/lin/crashpad_client_test
	linux-vdso.so.1 (0x00007fff749ab000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fc6e2d6d000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fc6e2b56000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fc6e2939000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fc6e259a000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fc6e3340000)

	Version information:
	out/lin/crashpad_client_test:
		libc.so.6 (GLIBC_2.2.5) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.3) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.3.4) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.4) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.6) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.14) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.17) => /lib/x86_64-linux-gnu/libc.so.6
		libpthread.so.0 (GLIBC_2.2.5) => /lib/x86_64-linux-gnu/libpthread.so.0
		libpthread.so.0 (GLIBC_2.3.2) => /lib/x86_64-linux-gnu/libpthread.so.0
		ld-linux-x86-64.so.2 (GLIBC_2.3) => /lib64/ld-linux-x86-64.so.2
		libgcc_s.so.1 (GCC_3.0) => /lib/x86_64-linux-gnu/libgcc_s.so.1
		libgcc_s.so.1 (GCC_3.3) => /lib/x86_64-linux-gnu/libgcc_s.so.1
		libgcc_s.so.1 (GCC_4.2.0) => /lib/x86_64-linux-gnu/libgcc_s.so.1
		libm.so.6 (GLIBC_2.2.5) => /lib/x86_64-linux-gnu/libm.so.6
	/lib/x86_64-linux-gnu/libm.so.6:
		ld-linux-x86-64.so.2 (GLIBC_PRIVATE) => /lib64/ld-linux-x86-64.so.2
		libc.so.6 (GLIBC_2.2.5) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_PRIVATE) => /lib/x86_64-linux-gnu/libc.so.6
	/lib/x86_64-linux-gnu/libgcc_s.so.1:
		libc.so.6 (GLIBC_2.14) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.2.5) => /lib/x86_64-linux-gnu/libc.so.6
	/lib/x86_64-linux-gnu/libpthread.so.0:
		ld-linux-x86-64.so.2 (GLIBC_2.2.5) => /lib64/ld-linux-x86-64.so.2
		ld-linux-x86-64.so.2 (GLIBC_PRIVATE) => /lib64/ld-linux-x86-64.so.2
		libc.so.6 (GLIBC_2.14) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.3.2) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_2.2.5) => /lib/x86_64-linux-gnu/libc.so.6
		libc.so.6 (GLIBC_PRIVATE) => /lib/x86_64-linux-gnu/libc.so.6
	/lib/x86_64-linux-gnu/libc.so.6:
		ld-linux-x86-64.so.2 (GLIBC_2.3) => /lib64/ld-linux-x86-64.so.2
		ld-linux-x86-64.so.2 (GLIBC_PRIVATE) => /lib64/ld-linux-x86-64.so.2


Bug: crashpad:30, crashpad:79, crashpad:220
Change-Id: Ifa49c284a23009f3685283444f2bf7f52f80c3b3
Reviewed-on: https://chromium-review.googlesource.com/939731
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/987bde826c04158c11190f3764db6b9f5ce870bb/build/BUILD.gn

Project Member

Comment 163 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/746ce1a637038e4dbc2f6d5616d4d233f9d9b47b

commit 746ce1a637038e4dbc2f6d5616d4d233f9d9b47b
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Feb 28 19:07:30 2018

Roll mini_chromium to 987bde8

Includes:
987bde8 Linux GN: Optionally link statically against libstdc++

Bug: crashpad:30, crashpad:79, crashpad:220
Change-Id: If15d2224239166138aa5dcfe531ff269b7ed22fe
Reviewed-on: https://chromium-review.googlesource.com/941543
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/746ce1a637038e4dbc2f6d5616d4d233f9d9b47b/DEPS

Project Member

Comment 164 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/a45e88602b90899d16a1f9b09866f3655a7682f9

commit a45e88602b90899d16a1f9b09866f3655a7682f9
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Feb 28 21:21:44 2018

Skip ELF notes with a p_vaddr of zero

Don't attempt to read data if the note isn't in an allocated segment.
See investigation starting at
https://bugs.chromium.org/p/crashpad/issues/detail?id=220#c27 for
details.

Bug: crashpad:220, crashpad:30, crashpad:196
Change-Id: I60eaacb83ad00ef33bde9079d25cc23a59bdf2c8
Reviewed-on: https://chromium-review.googlesource.com/941507
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/a45e88602b90899d16a1f9b09866f3655a7682f9/snapshot/elf/elf_image_reader.cc

Project Member

Comment 165 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58866fc90d4115660ccf046b5e47fbfc35490880

commit 58866fc90d4115660ccf046b5e47fbfc35490880
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Mar 01 19:32:58 2018

Update Crashpad to 71d90608828da0b6c987f018c96306bfa964a65a

14dbd3531d98 gn win: Get main test binaries building
6cf4f928eb08 gn win: Add auxiliary test binaries used by
             end_to_end_test.py
36679d572ba0 win: Don't assume offsets the same when
             kDoesNotObserveDaylightSavingTime
9ab4fbf1e1a7 win: Improve child crash location test
798f6540435f gn win: Use new toolchain names to support both x86 and x64
83a83c5b0050 Roll mini_chromium to e7e8237
a483e2c599b8 Fix names of Windows trybots after server-side rename
38b20ca57efc Relocate CaptureContext to misc and implement on Linux
a8ad3bdbdfb1 linux: fix incorrect fallthrough
73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
f878f155172b fuchsia: Add flock() stub to get test binaries linking
             again
e5bbdaff87a9 Pass FilePath to Settings in Initialize()
c45ba7920e01 Make NewReport objects own their associated database
             resources
7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
c406797ce620 Add  UploadReport to manage database resources during
             upload
7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
             symtab
8d0d999d9245 Add a cross-platform database implementation
b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
             implementations
6667fa25595a fuchsia: Fixes to TestPaths
90cde8e30f7d Disable upload on Android
4094c2628d33 Address review comments for 8d0d999
a4d7fb4cc390 Use .long for pointers on 32-bit platforms
5e5b927b38ca Build crashpad_client_linux.cc on Android
eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
0429216f59b1 linux: Add CrashReportExceptionHandler
f38af628c9dc fuchsia: Don't fail rename if source == dest
040360239343 Fix
             CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
             ions
10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
             functional
5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
             Settings
4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
             source root
4a9d422652a1 Turn fuchsia trybots on by default
ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
             from SDK
8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
d2a866978b89 Makes 'all' build on Linux
d8d03172c278 arm: Capture context around pc and registers
ebad8bd925c3 Don't spawn an upload thread if url is empty
0520fdff1edc linux: Move ScopedPrSetPtracer to util/
38540eaf71cb Add handler options for Linux/Android
01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
cab259330f2e fuchsia: Pass more data out of module snapshot
1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
             ModuleSnapshotElf
4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
             ProcessSnapshotFuchsia
2290a826af1e Pull (most) platform-specific MemorySnapshots out
3030ae54171a fuchsia: Fix ninja auto-regen after run
61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
             test
c69ba3d52783 non-win: Add
             Multiprocess::SetExpectedChildTerminationBuiltinTrap()
f130822b9f4b linux: Add CrashpadClient tests
2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
cd3afe616e63 Linux: Pull and use clang toolchain in third_party
8e80a575d15f Linux: Pull a sysroot if pulling a local clang
fae18c2fc492 fuchsia: Add implementation of ThreadSnapshot
a869ae18d256 Workaround for death test failure when in threadsafe mode
             on Mac
8a12f5893050 fuchsia: Take bots off CQ pending flake investigation
9affa2a0e72d Optionally stub out the libcurl-based implementation of
             HTTPTransport
dec23bef5769 win gn: reintroduce flags to disable warnings
746ce1a63703 Roll mini_chromium to 987bde8
493e29bc3df0 win: Use correct format specifier
a45e88602b90 Skip ELF notes with a p_vaddr of zero
71d90608828d Add Linux trybots to CQ

Also:
Add new metrics enums values.
Use new CrashReportDatabase interface.

Bug: crashpad:30
Change-Id: I19a858387630409f40e0f42b79f0cf46d9f4e13b
Reviewed-on: https://chromium-review.googlesource.com/941512
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540253}
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/components/browser_watcher/postmortem_report_collector.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/components/browser_watcher/postmortem_report_collector.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/components/browser_watcher/postmortem_report_collector_unittest.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/components/crash/content/app/minidump_with_crashpad_info.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/README.chromium
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/.gitignore
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/DEPS
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/build/BUILDCONFIG.gn
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/build/install_linux_sysroot.py
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/build/run_tests.py
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/BUILD.gn
[delete] https://crrev.com/e6633efca4412abcbd803069587b31de807b36ab/third_party/crashpad/crashpad/client/capture_context_mac.h
[delete] https://crrev.com/e6633efca4412abcbd803069587b31de807b36ab/third_party/crashpad/crashpad/client/capture_context_mac_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/client.gyp
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/client_test.gyp
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/crash_report_database.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/crash_report_database.h
[delete] https://crrev.com/e6633efca4412abcbd803069587b31de807b36ab/third_party/crashpad/crashpad/client/crash_report_database_fuchsia.cc
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/crash_report_database_generic.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/crash_report_database_mac.mm
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/crash_report_database_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/crash_report_database_win.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/crashpad_client.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/crashpad_client_linux.cc
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/crashpad_client_linux_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/crashpad_client_win.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/crashpad_info.cc
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/crashpad_info_note.S
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/prune_crash_reports_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/settings.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/settings.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/settings_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/simple_string_dictionary_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/simulate_crash.h
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/simulate_crash_linux.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/simulate_crash_mac.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/client/simulate_crash_win.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/BUILD.gn
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/crash_report_upload_thread.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/crashpad_handler.md
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/crashpad_handler_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/handler.gyp
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/handler_main.cc
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.cc
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/linux/exception_handler_server_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/prune_crash_reports_thread.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/prune_crash_reports_thread.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/handler/win/loader_lock_dll.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/infra/config/cq.cfg
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/minidump/minidump_system_info_writer.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/BUILD.gn
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/capture_memory.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_module.cc
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_note.S
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/crashpad_types/image_annotation_reader_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test_note.S
[rename] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/elf/module_snapshot_elf.cc
[rename] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/elf/module_snapshot_elf.h
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.cc
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.h
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.h
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/fuchsia/thread_snapshot_fuchsia.cc
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/fuchsia/thread_snapshot_fuchsia.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux_test.cc
[delete] https://crrev.com/e6633efca4412abcbd803069587b31de807b36ab/third_party/crashpad/crashpad/snapshot/linux/memory_snapshot_linux.cc
[delete] https://crrev.com/e6633efca4412abcbd803069587b31de807b36ab/third_party/crashpad/crashpad/snapshot/linux/memory_snapshot_linux.h
[rename] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux.cc
[rename] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux.h
[rename] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.h
[delete] https://crrev.com/e6633efca4412abcbd803069587b31de807b36ab/third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.cc
[delete] https://crrev.com/e6633efca4412abcbd803069587b31de807b36ab/third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.h
[rename] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/process_reader_mac.cc
[rename] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/process_reader_mac.h
[rename] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/process_reader_mac_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/process_types.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/process_types.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/process_types/custom.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/process_types_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.h
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/memory_snapshot_generic.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/snapshot.gyp
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/snapshot_test.gyp
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/win/process_reader_win.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/snapshot/win/system_snapshot_win_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/test/BUILD.gn
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/test/mac/dyld.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/test/multiprocess.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/test/multiprocess_exec_fuchsia.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/test/multiprocess_exec_test.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/test/multiprocess_exec_test_child.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/test/multiprocess_posix.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/test/test.gyp
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/test/test_paths.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/third_party/fuchsia/README.crashpad
[add] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/third_party/linux/README.crashpad
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/tools/crashpad_database_util.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/tools/generate_dump.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/util/BUILD.gn
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/util/file/file_io.h
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/util/file/file_io_posix.cc
[modify] https://crrev.com/58866fc90d4115660ccf046b5e47fbfc35490880/third_party/crashpad/crashpad/util/file/file_io_test.cc
[modify] https:/
Project Member

Comment 166 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68255cbfe41a9b6d934cd2d83e94976a3726af22

commit 68255cbfe41a9b6d934cd2d83e94976a3726af22
Author: Xi Cheng <chengx@chromium.org>
Date: Thu Mar 01 19:51:04 2018

Revert "Update Crashpad to 71d90608828da0b6c987f018c96306bfa964a65a"

This reverts commit 58866fc90d4115660ccf046b5e47fbfc35490880.

Reason for revert: broke the build -- https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder%20(dbg)/63495

Original change's description:
> Update Crashpad to 71d90608828da0b6c987f018c96306bfa964a65a
> 
> 14dbd3531d98 gn win: Get main test binaries building
> 6cf4f928eb08 gn win: Add auxiliary test binaries used by
>              end_to_end_test.py
> 36679d572ba0 win: Don't assume offsets the same when
>              kDoesNotObserveDaylightSavingTime
> 9ab4fbf1e1a7 win: Improve child crash location test
> 798f6540435f gn win: Use new toolchain names to support both x86 and x64
> 83a83c5b0050 Roll mini_chromium to e7e8237
> a483e2c599b8 Fix names of Windows trybots after server-side rename
> 38b20ca57efc Relocate CaptureContext to misc and implement on Linux
> a8ad3bdbdfb1 linux: fix incorrect fallthrough
> 73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
> b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
> f878f155172b fuchsia: Add flock() stub to get test binaries linking
>              again
> e5bbdaff87a9 Pass FilePath to Settings in Initialize()
> c45ba7920e01 Make NewReport objects own their associated database
>              resources
> 7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
> c406797ce620 Add  UploadReport to manage database resources during
>              upload
> 7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
>              symtab
> 8d0d999d9245 Add a cross-platform database implementation
> b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
>              implementations
> 6667fa25595a fuchsia: Fixes to TestPaths
> 90cde8e30f7d Disable upload on Android
> 4094c2628d33 Address review comments for 8d0d999
> a4d7fb4cc390 Use .long for pointers on 32-bit platforms
> 5e5b927b38ca Build crashpad_client_linux.cc on Android
> eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
> 4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
> f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
> 6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
> 0429216f59b1 linux: Add CrashReportExceptionHandler
> f38af628c9dc fuchsia: Don't fail rename if source == dest
> 040360239343 Fix
>              CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
>              ions
> 10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
>              functional
> 5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
>              Settings
> 4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
> 8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
>              source root
> 4a9d422652a1 Turn fuchsia trybots on by default
> ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
>              from SDK
> 8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
> d2a866978b89 Makes 'all' build on Linux
> d8d03172c278 arm: Capture context around pc and registers
> ebad8bd925c3 Don't spawn an upload thread if url is empty
> 0520fdff1edc linux: Move ScopedPrSetPtracer to util/
> 38540eaf71cb Add handler options for Linux/Android
> 01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
> 3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
> cab259330f2e fuchsia: Pass more data out of module snapshot
> 1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
>              ModuleSnapshotElf
> 4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
>              ProcessSnapshotFuchsia
> 2290a826af1e Pull (most) platform-specific MemorySnapshots out
> 3030ae54171a fuchsia: Fix ninja auto-regen after run
> 61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
>              test
> c69ba3d52783 non-win: Add
>              Multiprocess::SetExpectedChildTerminationBuiltinTrap()
> f130822b9f4b linux: Add CrashpadClient tests
> 2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
> fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
> cd3afe616e63 Linux: Pull and use clang toolchain in third_party
> 8e80a575d15f Linux: Pull a sysroot if pulling a local clang
> fae18c2fc492 fuchsia: Add implementation of ThreadSnapshot
> a869ae18d256 Workaround for death test failure when in threadsafe mode
>              on Mac
> 8a12f5893050 fuchsia: Take bots off CQ pending flake investigation
> 9affa2a0e72d Optionally stub out the libcurl-based implementation of
>              HTTPTransport
> dec23bef5769 win gn: reintroduce flags to disable warnings
> 746ce1a63703 Roll mini_chromium to 987bde8
> 493e29bc3df0 win: Use correct format specifier
> a45e88602b90 Skip ELF notes with a p_vaddr of zero
> 71d90608828d Add Linux trybots to CQ
> 
> Also:
> Add new metrics enums values.
> Use new CrashReportDatabase interface.
> 
> Bug: crashpad:30
> Change-Id: I19a858387630409f40e0f42b79f0cf46d9f4e13b
> Reviewed-on: https://chromium-review.googlesource.com/941512
> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540253}

TBR=jperaza@chromium.org,mark@chromium.org,siggi@chromium.org

Change-Id: I0f0866b62d41f53b702d17681b6540c766db98b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: crashpad:30
Reviewed-on: https://chromium-review.googlesource.com/944122
Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540260}
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/components/browser_watcher/postmortem_report_collector.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/components/browser_watcher/postmortem_report_collector.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/components/browser_watcher/postmortem_report_collector_unittest.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/components/crash/content/app/minidump_with_crashpad_info.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/README.chromium
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/.gitignore
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/DEPS
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/build/BUILDCONFIG.gn
[delete] https://crrev.com/d8bcc8fcbc3bac609db86f0d7b2424b35e3f4397/third_party/crashpad/crashpad/build/install_linux_sysroot.py
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/build/run_tests.py
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/BUILD.gn
[rename] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/capture_context_mac.S
[add] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/capture_context_mac.h
[add] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/capture_context_mac_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/client.gyp
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/client_test.gyp
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/crash_report_database.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/crash_report_database.h
[add] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/crash_report_database_fuchsia.cc
[delete] https://crrev.com/d8bcc8fcbc3bac609db86f0d7b2424b35e3f4397/third_party/crashpad/crashpad/client/crash_report_database_generic.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/crash_report_database_mac.mm
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/crash_report_database_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/crash_report_database_win.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/crashpad_client.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/crashpad_client_linux.cc
[delete] https://crrev.com/d8bcc8fcbc3bac609db86f0d7b2424b35e3f4397/third_party/crashpad/crashpad/client/crashpad_client_linux_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/crashpad_client_win.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/crashpad_info.cc
[delete] https://crrev.com/d8bcc8fcbc3bac609db86f0d7b2424b35e3f4397/third_party/crashpad/crashpad/client/crashpad_info_note.S
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/prune_crash_reports_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/settings.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/settings.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/settings_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/simple_string_dictionary_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/simulate_crash.h
[delete] https://crrev.com/d8bcc8fcbc3bac609db86f0d7b2424b35e3f4397/third_party/crashpad/crashpad/client/simulate_crash_linux.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/simulate_crash_mac.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/client/simulate_crash_win.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/BUILD.gn
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/crash_report_upload_thread.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/crashpad_handler.md
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/crashpad_handler_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/handler.gyp
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/handler_main.cc
[delete] https://crrev.com/d8bcc8fcbc3bac609db86f0d7b2424b35e3f4397/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.cc
[delete] https://crrev.com/d8bcc8fcbc3bac609db86f0d7b2424b35e3f4397/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/linux/exception_handler_server_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/prune_crash_reports_thread.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/prune_crash_reports_thread.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/handler/win/loader_lock_dll.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/infra/config/cq.cfg
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/minidump/minidump_system_info_writer.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/BUILD.gn
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/capture_memory.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_module.cc
[delete] https://crrev.com/d8bcc8fcbc3bac609db86f0d7b2424b35e3f4397/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_note.S
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/crashpad_types/image_annotation_reader_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test_note.S
[delete] https://crrev.com/d8bcc8fcbc3bac609db86f0d7b2424b35e3f4397/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.cc
[delete] https://crrev.com/d8bcc8fcbc3bac609db86f0d7b2424b35e3f4397/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.h
[delete] https://crrev.com/d8bcc8fcbc3bac609db86f0d7b2424b35e3f4397/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.h
[delete] https://crrev.com/d8bcc8fcbc3bac609db86f0d7b2424b35e3f4397/third_party/crashpad/crashpad/snapshot/fuchsia/thread_snapshot_fuchsia.cc
[delete] https://crrev.com/d8bcc8fcbc3bac609db86f0d7b2424b35e3f4397/third_party/crashpad/crashpad/snapshot/fuchsia/thread_snapshot_fuchsia.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux_test.cc
[add] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/memory_snapshot_linux.cc
[add] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/memory_snapshot_linux.h
[rename] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/module_snapshot_linux.cc
[rename] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/module_snapshot_linux.h
[rename] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/process_reader.cc
[rename] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/process_reader.h
[rename] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/process_reader_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.h
[add] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.cc
[add] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.h
[rename] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/process_reader.cc
[rename] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/process_reader.h
[rename] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/process_reader_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/process_types.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/process_types.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/process_types/custom.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/process_types_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.h
[delete] https://crrev.com/d8bcc8fcbc3bac609db86f0d7b2424b35e3f4397/third_party/crashpad/crashpad/snapshot/memory_snapshot_generic.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/snapshot.gyp
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/snapshot_test.gyp
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/win/process_reader_win.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/snapshot/win/system_snapshot_win_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/test/BUILD.gn
[rename] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/test/linux/scoped_pr_set_ptracer.cc
[rename] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/test/linux/scoped_pr_set_ptracer.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/test/mac/dyld.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/test/multiprocess.h
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/test/multiprocess_exec_fuchsia.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/test/multiprocess_exec_test.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/test/multiprocess_exec_test_child.cc
[modify] https://crrev.com/68255cbfe41a9b6d934cd2d83e94976a3726af22/third_party/crashpad/crashpad/test/multipr
Project Member

Comment 167 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31fd846e0af04d50d511ea827b35c072b89d9ff6

commit 31fd846e0af04d50d511ea827b35c072b89d9ff6
Author: Mark Mentovai <mark@chromium.org>
Date: Mon Mar 05 19:23:14 2018

Update Crashpad to 4375233ad2dad48f2332ecc20221df10f98b668a

This includes a reland of 58866fc90d41, which was reverted at
68255cbfe41a. The cause for the revert was addressed by upstream
82777cff5848.

14dbd3531d98 gn win: Get main test binaries building
6cf4f928eb08 gn win: Add auxiliary test binaries used by
             end_to_end_test.py
36679d572ba0 win: Don't assume offsets the same when
             kDoesNotObserveDaylightSavingTime
9ab4fbf1e1a7 win: Improve child crash location test
798f6540435f gn win: Use new toolchain names to support both x86 and x64
83a83c5b0050 Roll mini_chromium to e7e8237
a483e2c599b8 Fix names of Windows trybots after server-side rename
38b20ca57efc Relocate CaptureContext to misc and implement on Linux
a8ad3bdbdfb1 linux: fix incorrect fallthrough
73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
f878f155172b fuchsia: Add flock() stub to get test binaries linking
             again
e5bbdaff87a9 Pass FilePath to Settings in Initialize()
c45ba7920e01 Make NewReport objects own their associated database
             resources
7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
c406797ce620 Add  UploadReport to manage database resources during
             upload
7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
             symtab
8d0d999d9245 Add a cross-platform database implementation
b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
             implementations
6667fa25595a fuchsia: Fixes to TestPaths
90cde8e30f7d Disable upload on Android
4094c2628d33 Address review comments for 8d0d999
a4d7fb4cc390 Use .long for pointers on 32-bit platforms
5e5b927b38ca Build crashpad_client_linux.cc on Android
eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
0429216f59b1 linux: Add CrashReportExceptionHandler
f38af628c9dc fuchsia: Don't fail rename if source == dest
040360239343 Fix
             CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
             ions
10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
             functional
5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
             Settings
4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
             source root
4a9d422652a1 Turn fuchsia trybots on by default
ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
             from SDK
8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
d2a866978b89 Makes 'all' build on Linux
d8d03172c278 arm: Capture context around pc and registers
ebad8bd925c3 Don't spawn an upload thread if url is empty
0520fdff1edc linux: Move ScopedPrSetPtracer to util/
38540eaf71cb Add handler options for Linux/Android
01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
cab259330f2e fuchsia: Pass more data out of module snapshot
1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
             ModuleSnapshotElf
4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
             ProcessSnapshotFuchsia
2290a826af1e Pull (most) platform-specific MemorySnapshots out
3030ae54171a fuchsia: Fix ninja auto-regen after run
61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
             test
c69ba3d52783 non-win: Add
             Multiprocess::SetExpectedChildTerminationBuiltinTrap()
f130822b9f4b linux: Add CrashpadClient tests
2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
cd3afe616e63 Linux: Pull and use clang toolchain in third_party
8e80a575d15f Linux: Pull a sysroot if pulling a local clang
fae18c2fc492 fuchsia: Add implementation of ThreadSnapshot
a869ae18d256 Workaround for death test failure when in threadsafe mode
             on Mac
8a12f5893050 fuchsia: Take bots off CQ pending flake investigation
9affa2a0e72d Optionally stub out the libcurl-based implementation of
             HTTPTransport
dec23bef5769 win gn: reintroduce flags to disable warnings
746ce1a63703 Roll mini_chromium to 987bde8
493e29bc3df0 win: Use correct format specifier
a45e88602b90 Skip ELF notes with a p_vaddr of zero
71d90608828d Add Linux trybots to CQ
449506d59c6a Roll mini_chromium to ef0df11
82777cff5848 win: fix warnings when building with clang
23b2156fb694 Don’t read beyond a StringPiece’s bounds in
             StringToNumber()
4375233ad2da win: fix 64-bit build

Also:
Add new metrics enums values.
Use new CrashReportDatabase interface.

Bug: crashpad:30, chromium:817982, chromium:818376
Change-Id: Ib4fcc423f68a4c80907968498264413f3f229c5c
Reviewed-on: https://chromium-review.googlesource.com/947745
Commit-Queue: Chris Palmer <palmer@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540894}
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/components/browser_watcher/postmortem_report_collector.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/components/browser_watcher/postmortem_report_collector.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/components/browser_watcher/postmortem_report_collector_unittest.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/components/crash/content/app/minidump_with_crashpad_info.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/README.chromium
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/.gitignore
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/DEPS
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/build/BUILDCONFIG.gn
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/build/install_linux_sysroot.py
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/build/run_tests.py
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/BUILD.gn
[delete] https://crrev.com/fd91b77da524c9151eacd51709dfe7d6cff874b4/third_party/crashpad/crashpad/client/capture_context_mac.h
[delete] https://crrev.com/fd91b77da524c9151eacd51709dfe7d6cff874b4/third_party/crashpad/crashpad/client/capture_context_mac_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/client.gyp
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/client_test.gyp
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/crash_report_database.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/crash_report_database.h
[delete] https://crrev.com/fd91b77da524c9151eacd51709dfe7d6cff874b4/third_party/crashpad/crashpad/client/crash_report_database_fuchsia.cc
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/crash_report_database_generic.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/crash_report_database_mac.mm
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/crash_report_database_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/crash_report_database_win.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/crashpad_client.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/crashpad_client_linux.cc
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/crashpad_client_linux_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/crashpad_client_win.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/crashpad_info.cc
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/crashpad_info_note.S
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/prune_crash_reports_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/settings.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/settings.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/settings_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/simple_string_dictionary_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/simulate_crash.h
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/simulate_crash_linux.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/simulate_crash_mac.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/client/simulate_crash_win.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/BUILD.gn
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/crash_report_upload_thread.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/crashpad_handler.md
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/crashpad_handler_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/handler.gyp
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/handler_main.cc
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.cc
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/linux/exception_handler_server_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/prune_crash_reports_thread.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/prune_crash_reports_thread.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/win/crash_other_program.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/win/crashy_test_program.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/handler/win/loader_lock_dll.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/infra/config/cq.cfg
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/minidump/minidump_system_info_writer.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/BUILD.gn
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/capture_memory.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_module.cc
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_note.S
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/crashpad_types/image_annotation_reader_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test_note.S
[rename] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/elf/module_snapshot_elf.cc
[rename] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/elf/module_snapshot_elf.h
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.cc
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.h
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.h
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/fuchsia/thread_snapshot_fuchsia.cc
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/fuchsia/thread_snapshot_fuchsia.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux_test.cc
[delete] https://crrev.com/fd91b77da524c9151eacd51709dfe7d6cff874b4/third_party/crashpad/crashpad/snapshot/linux/memory_snapshot_linux.cc
[delete] https://crrev.com/fd91b77da524c9151eacd51709dfe7d6cff874b4/third_party/crashpad/crashpad/snapshot/linux/memory_snapshot_linux.h
[rename] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux.cc
[rename] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux.h
[rename] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.h
[delete] https://crrev.com/fd91b77da524c9151eacd51709dfe7d6cff874b4/third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.cc
[delete] https://crrev.com/fd91b77da524c9151eacd51709dfe7d6cff874b4/third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.h
[rename] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/process_reader_mac.cc
[rename] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/process_reader_mac.h
[rename] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/process_reader_mac_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/process_types.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/process_types.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/process_types/custom.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/process_types_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.h
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/memory_snapshot_generic.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/snapshot.gyp
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/snapshot_test.gyp
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/win/process_reader_win.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/snapshot/win/system_snapshot_win_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/test/BUILD.gn
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/test/mac/dyld.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/test/multiprocess.h
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/test/multiprocess_exec_fuchsia.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/test/multiprocess_exec_test.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/test/multiprocess_exec_test_child.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/test/multiprocess_posix.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/test/test.gyp
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/test/test_paths.cc
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/third_party/fuchsia/README.crashpad
[add] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/third_party/linux/README.crashpad
[modify] https://crrev.com/31fd846e0af04d50d511ea827b35c072b89d9ff6/third_party/crashpad/crashpad/tools/crashpad_database_util.cc
[modi
Project Member

Comment 168 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff

commit db6afd2fb363ffae0c563fb6dee1a5c7469b88ff
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Mar 06 00:42:35 2018

Revert "Update Crashpad to 4375233ad2dad48f2332ecc20221df10f98b668a"

This reverts commit 31fd846e0af04d50d511ea827b35c072b89d9ff6.

This causes debug Windows component builds to not run on Windows, giving the error below. Bruce & Rob tracked it to the change in util/BUILD.gn which adds mincore.lib

---------------------------
chrome.exe - System Error
---------------------------
The program can't start because api-ms-win-power-base-l1-1-0.dll is missing from your computer. Try reinstalling the program to fix this problem."


Original change's description:
> Update Crashpad to 4375233ad2dad48f2332ecc20221df10f98b668a
> 
> This includes a reland of 58866fc90d41, which was reverted at
> 68255cbfe41a. The cause for the revert was addressed by upstream
> 82777cff5848.
> 
> 14dbd3531d98 gn win: Get main test binaries building
> 6cf4f928eb08 gn win: Add auxiliary test binaries used by
>              end_to_end_test.py
> 36679d572ba0 win: Don't assume offsets the same when
>              kDoesNotObserveDaylightSavingTime
> 9ab4fbf1e1a7 win: Improve child crash location test
> 798f6540435f gn win: Use new toolchain names to support both x86 and x64
> 83a83c5b0050 Roll mini_chromium to e7e8237
> a483e2c599b8 Fix names of Windows trybots after server-side rename
> 38b20ca57efc Relocate CaptureContext to misc and implement on Linux
> a8ad3bdbdfb1 linux: fix incorrect fallthrough
> 73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
> b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
> f878f155172b fuchsia: Add flock() stub to get test binaries linking
>              again
> e5bbdaff87a9 Pass FilePath to Settings in Initialize()
> c45ba7920e01 Make NewReport objects own their associated database
>              resources
> 7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
> c406797ce620 Add  UploadReport to manage database resources during
>              upload
> 7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
>              symtab
> 8d0d999d9245 Add a cross-platform database implementation
> b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
>              implementations
> 6667fa25595a fuchsia: Fixes to TestPaths
> 90cde8e30f7d Disable upload on Android
> 4094c2628d33 Address review comments for 8d0d999
> a4d7fb4cc390 Use .long for pointers on 32-bit platforms
> 5e5b927b38ca Build crashpad_client_linux.cc on Android
> eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
> 4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
> f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
> 6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
> 0429216f59b1 linux: Add CrashReportExceptionHandler
> f38af628c9dc fuchsia: Don't fail rename if source == dest
> 040360239343 Fix
>              CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
>              ions
> 10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
>              functional
> 5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
>              Settings
> 4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
> 8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
>              source root
> 4a9d422652a1 Turn fuchsia trybots on by default
> ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
>              from SDK
> 8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
> d2a866978b89 Makes 'all' build on Linux
> d8d03172c278 arm: Capture context around pc and registers
> ebad8bd925c3 Don't spawn an upload thread if url is empty
> 0520fdff1edc linux: Move ScopedPrSetPtracer to util/
> 38540eaf71cb Add handler options for Linux/Android
> 01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
> 3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
> cab259330f2e fuchsia: Pass more data out of module snapshot
> 1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
>              ModuleSnapshotElf
> 4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
>              ProcessSnapshotFuchsia
> 2290a826af1e Pull (most) platform-specific MemorySnapshots out
> 3030ae54171a fuchsia: Fix ninja auto-regen after run
> 61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
>              test
> c69ba3d52783 non-win: Add
>              Multiprocess::SetExpectedChildTerminationBuiltinTrap()
> f130822b9f4b linux: Add CrashpadClient tests
> 2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
> fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
> cd3afe616e63 Linux: Pull and use clang toolchain in third_party
> 8e80a575d15f Linux: Pull a sysroot if pulling a local clang
> fae18c2fc492 fuchsia: Add implementation of ThreadSnapshot
> a869ae18d256 Workaround for death test failure when in threadsafe mode
>              on Mac
> 8a12f5893050 fuchsia: Take bots off CQ pending flake investigation
> 9affa2a0e72d Optionally stub out the libcurl-based implementation of
>              HTTPTransport
> dec23bef5769 win gn: reintroduce flags to disable warnings
> 746ce1a63703 Roll mini_chromium to 987bde8
> 493e29bc3df0 win: Use correct format specifier
> a45e88602b90 Skip ELF notes with a p_vaddr of zero
> 71d90608828d Add Linux trybots to CQ
> 449506d59c6a Roll mini_chromium to ef0df11
> 82777cff5848 win: fix warnings when building with clang
> 23b2156fb694 Don’t read beyond a StringPiece’s bounds in
>              StringToNumber()
> 4375233ad2da win: fix 64-bit build
> 
> Also:
> Add new metrics enums values.
> Use new CrashReportDatabase interface.
> 
> Bug: crashpad:30, chromium:817982, chromium:818376
> Change-Id: Ib4fcc423f68a4c80907968498264413f3f229c5c
> Reviewed-on: https://chromium-review.googlesource.com/947745
> Commit-Queue: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540894}

TBR=palmer@chromium.org,jperaza@chromium.org,mark@chromium.org,siggi@chromium.org

Change-Id: I2fbdde093d12fc1f93bd10478f6022effa0d8d2e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: crashpad:30, chromium:817982, chromium:818376
Reviewed-on: https://chromium-review.googlesource.com/950343
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541006}
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/components/browser_watcher/postmortem_report_collector.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/components/browser_watcher/postmortem_report_collector.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/components/browser_watcher/postmortem_report_collector_unittest.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/components/crash/content/app/minidump_with_crashpad_info.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/README.chromium
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/.gitignore
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/DEPS
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/build/BUILDCONFIG.gn
[delete] https://crrev.com/d82b894ef50199f91fc3a83307b709b13062e5f8/third_party/crashpad/crashpad/build/install_linux_sysroot.py
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/build/run_tests.py
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/BUILD.gn
[rename] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/capture_context_mac.S
[add] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/capture_context_mac.h
[add] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/capture_context_mac_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/client.gyp
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/client_test.gyp
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/crash_report_database.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/crash_report_database.h
[add] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/crash_report_database_fuchsia.cc
[delete] https://crrev.com/d82b894ef50199f91fc3a83307b709b13062e5f8/third_party/crashpad/crashpad/client/crash_report_database_generic.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/crash_report_database_mac.mm
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/crash_report_database_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/crash_report_database_win.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/crashpad_client.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/crashpad_client_linux.cc
[delete] https://crrev.com/d82b894ef50199f91fc3a83307b709b13062e5f8/third_party/crashpad/crashpad/client/crashpad_client_linux_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/crashpad_client_win.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/crashpad_info.cc
[delete] https://crrev.com/d82b894ef50199f91fc3a83307b709b13062e5f8/third_party/crashpad/crashpad/client/crashpad_info_note.S
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/prune_crash_reports_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/settings.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/settings.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/settings_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/simple_string_dictionary_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/simulate_crash.h
[delete] https://crrev.com/d82b894ef50199f91fc3a83307b709b13062e5f8/third_party/crashpad/crashpad/client/simulate_crash_linux.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/simulate_crash_mac.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/client/simulate_crash_win.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/BUILD.gn
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/crash_report_upload_thread.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/crashpad_handler.md
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/crashpad_handler_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/handler.gyp
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/handler_main.cc
[delete] https://crrev.com/d82b894ef50199f91fc3a83307b709b13062e5f8/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.cc
[delete] https://crrev.com/d82b894ef50199f91fc3a83307b709b13062e5f8/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/linux/exception_handler_server_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/prune_crash_reports_thread.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/prune_crash_reports_thread.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/win/crash_other_program.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/win/crashy_test_program.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/handler/win/loader_lock_dll.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/infra/config/cq.cfg
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/minidump/minidump_system_info_writer.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/BUILD.gn
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/capture_memory.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_module.cc
[delete] https://crrev.com/d82b894ef50199f91fc3a83307b709b13062e5f8/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_note.S
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/crashpad_types/image_annotation_reader_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test_note.S
[delete] https://crrev.com/d82b894ef50199f91fc3a83307b709b13062e5f8/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.cc
[delete] https://crrev.com/d82b894ef50199f91fc3a83307b709b13062e5f8/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.h
[delete] https://crrev.com/d82b894ef50199f91fc3a83307b709b13062e5f8/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.h
[delete] https://crrev.com/d82b894ef50199f91fc3a83307b709b13062e5f8/third_party/crashpad/crashpad/snapshot/fuchsia/thread_snapshot_fuchsia.cc
[delete] https://crrev.com/d82b894ef50199f91fc3a83307b709b13062e5f8/third_party/crashpad/crashpad/snapshot/fuchsia/thread_snapshot_fuchsia.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux_test.cc
[add] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/memory_snapshot_linux.cc
[add] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/memory_snapshot_linux.h
[rename] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/module_snapshot_linux.cc
[rename] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/module_snapshot_linux.h
[rename] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/process_reader.cc
[rename] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/process_reader.h
[rename] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/process_reader_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.h
[add] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.cc
[add] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.h
[rename] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/process_reader.cc
[rename] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/process_reader.h
[rename] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/process_reader_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/process_types.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/process_types.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/process_types/custom.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/process_types_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.h
[delete] https://crrev.com/d82b894ef50199f91fc3a83307b709b13062e5f8/third_party/crashpad/crashpad/snapshot/memory_snapshot_generic.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/snapshot.gyp
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/snapshot_test.gyp
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.h
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/win/process_reader_win.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/snapshot/win/system_snapshot_win_test.cc
[modify] https://crrev.com/db6afd2fb363ffae0c563fb6dee1a5c7469b88ff/third_party/crashpad/crashpad/test/BUILD.gn
[rename] https://crrev.c
Project Member

Comment 169 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33d5aa2289aa711214997ecae3e728a4f589598c

commit 33d5aa2289aa711214997ecae3e728a4f589598c
Author: Joshua Peraza <jperaza@chromium.org>
Date: Tue Mar 13 15:21:24 2018

Update Crashpad to c27a1aaea0861852c6d92945b68856586e0cd51d

14dbd3531d98 gn win: Get main test binaries building
6cf4f928eb08 gn win: Add auxiliary test binaries used by
             end_to_end_test.py
36679d572ba0 win: Don't assume offsets the same when
             kDoesNotObserveDaylightSavingTime
9ab4fbf1e1a7 win: Improve child crash location test
798f6540435f gn win: Use new toolchain names to support both x86 and x64
83a83c5b0050 Roll mini_chromium to e7e8237
a483e2c599b8 Fix names of Windows trybots after server-side rename
38b20ca57efc Relocate CaptureContext to misc and implement on Linux
a8ad3bdbdfb1 linux: fix incorrect fallthrough
73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
f878f155172b fuchsia: Add flock() stub to get test binaries linking
             again
e5bbdaff87a9 Pass FilePath to Settings in Initialize()
c45ba7920e01 Make NewReport objects own their associated database
             resources
7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
c406797ce620 Add  UploadReport to manage database resources during
             upload
7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
             symtab
8d0d999d9245 Add a cross-platform database implementation
b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
             implementations
6667fa25595a fuchsia: Fixes to TestPaths
90cde8e30f7d Disable upload on Android
4094c2628d33 Address review comments for 8d0d999
a4d7fb4cc390 Use .long for pointers on 32-bit platforms
5e5b927b38ca Build crashpad_client_linux.cc on Android
eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
0429216f59b1 linux: Add CrashReportExceptionHandler
f38af628c9dc fuchsia: Don't fail rename if source == dest
040360239343 Fix
             CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
             ions
10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
             functional
5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
             Settings
4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
             source root
4a9d422652a1 Turn fuchsia trybots on by default
ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
             from SDK
8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
d2a866978b89 Makes 'all' build on Linux
d8d03172c278 arm: Capture context around pc and registers
ebad8bd925c3 Don't spawn an upload thread if url is empty
0520fdff1edc linux: Move ScopedPrSetPtracer to util/
38540eaf71cb Add handler options for Linux/Android
01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
cab259330f2e fuchsia: Pass more data out of module snapshot
1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
             ModuleSnapshotElf
4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
             ProcessSnapshotFuchsia
2290a826af1e Pull (most) platform-specific MemorySnapshots out
3030ae54171a fuchsia: Fix ninja auto-regen after run
61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
             test
c69ba3d52783 non-win: Add
             Multiprocess::SetExpectedChildTerminationBuiltinTrap()
f130822b9f4b linux: Add CrashpadClient tests
2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
cd3afe616e63 Linux: Pull and use clang toolchain in third_party
8e80a575d15f Linux: Pull a sysroot if pulling a local clang
fae18c2fc492 fuchsia: Add implementation of ThreadSnapshot
a869ae18d256 Workaround for death test failure when in threadsafe mode
             on Mac
8a12f5893050 fuchsia: Take bots off CQ pending flake investigation
9affa2a0e72d Optionally stub out the libcurl-based implementation of
             HTTPTransport
dec23bef5769 win gn: reintroduce flags to disable warnings
746ce1a63703 Roll mini_chromium to 987bde8
493e29bc3df0 win: Use correct format specifier
a45e88602b90 Skip ELF notes with a p_vaddr of zero
71d90608828d Add Linux trybots to CQ
449506d59c6a Roll mini_chromium to ef0df11
82777cff5848 win: fix warnings when building with clang
23b2156fb694 Don’t read beyond a StringPiece’s bounds in
             StringToNumber()
4375233ad2da win: fix 64-bit build
8175825f45fd win: use version.lib instead of mincore.lib
07da37aec70e win: fix crashy test program
c27a1aaea086 win: Fix -Wmicrosoft-cast warning

Also,
Add new metrics enums values.
Use the new CrashReportDatabase interface.

Bug: crashpad:30

Change-Id: I36a6469046983c6ffdb1512436a915ee1a7bb49d
Reviewed-on: https://chromium-review.googlesource.com/959764
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542807}
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/components/browser_watcher/postmortem_report_collector.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/components/browser_watcher/postmortem_report_collector.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/components/browser_watcher/postmortem_report_collector_unittest.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/components/crash/content/app/minidump_with_crashpad_info.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/README.chromium
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/.gitignore
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/DEPS
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/build/BUILDCONFIG.gn
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/build/install_linux_sysroot.py
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/build/run_tests.py
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/BUILD.gn
[delete] https://crrev.com/f8fb4057767edfb03a3a326603d0c4828e2c9187/third_party/crashpad/crashpad/client/capture_context_mac.h
[delete] https://crrev.com/f8fb4057767edfb03a3a326603d0c4828e2c9187/third_party/crashpad/crashpad/client/capture_context_mac_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/client.gyp
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/client_test.gyp
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/crash_report_database.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/crash_report_database.h
[delete] https://crrev.com/f8fb4057767edfb03a3a326603d0c4828e2c9187/third_party/crashpad/crashpad/client/crash_report_database_fuchsia.cc
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/crash_report_database_generic.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/crash_report_database_mac.mm
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/crash_report_database_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/crash_report_database_win.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/crashpad_client.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/crashpad_client_linux.cc
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/crashpad_client_linux_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/crashpad_client_win.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/crashpad_info.cc
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/crashpad_info_note.S
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/prune_crash_reports_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/settings.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/settings.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/settings_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/simple_string_dictionary_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/simulate_crash.h
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/simulate_crash_linux.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/simulate_crash_mac.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/client/simulate_crash_win.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/BUILD.gn
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/crash_report_upload_thread.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/crashpad_handler.md
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/crashpad_handler_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/handler.gyp
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/handler_main.cc
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.cc
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/linux/exception_handler_server_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/prune_crash_reports_thread.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/prune_crash_reports_thread.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/win/crash_other_program.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/win/crashy_test_program.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/handler/win/loader_lock_dll.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/infra/config/cq.cfg
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/minidump/minidump_system_info_writer.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/BUILD.gn
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/capture_memory.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_module.cc
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_note.S
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/crashpad_types/image_annotation_reader_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test_note.S
[rename] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/elf/module_snapshot_elf.cc
[rename] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/elf/module_snapshot_elf.h
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.cc
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.h
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.h
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/fuchsia/thread_snapshot_fuchsia.cc
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/fuchsia/thread_snapshot_fuchsia.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux_test.cc
[delete] https://crrev.com/f8fb4057767edfb03a3a326603d0c4828e2c9187/third_party/crashpad/crashpad/snapshot/linux/memory_snapshot_linux.cc
[delete] https://crrev.com/f8fb4057767edfb03a3a326603d0c4828e2c9187/third_party/crashpad/crashpad/snapshot/linux/memory_snapshot_linux.h
[rename] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux.cc
[rename] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux.h
[rename] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/linux/process_snapshot_linux.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/linux/system_snapshot_linux_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/linux/thread_snapshot_linux.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.h
[delete] https://crrev.com/f8fb4057767edfb03a3a326603d0c4828e2c9187/third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.cc
[delete] https://crrev.com/f8fb4057767edfb03a3a326603d0c4828e2c9187/third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/module_snapshot_mac.h
[rename] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/process_reader_mac.cc
[rename] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/process_reader_mac.h
[rename] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/process_reader_mac_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/process_types.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/process_types.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/process_types/custom.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/process_types_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.h
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/memory_snapshot_generic.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/snapshot.gyp
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/snapshot_test.gyp
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_crashing_child.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_dump_without_crashing.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/win/process_reader_win.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/snapshot/win/system_snapshot_win_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/test/BUILD.gn
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/test/mac/dyld.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/test/multiprocess.h
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/test/multiprocess_exec_fuchsia.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/test/multiprocess_exec_test.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/test/multiprocess_exec_test_child.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/test/multiprocess_posix.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/test/test.gyp
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/test/test_paths.cc
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/third_party/fuchsia/README.crashpad
[modify] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/third_party/gtest/BUILD.gn
[add] https://crrev.com/33d5aa2289aa711214997ecae3e728a4f589598c/third_party/crashpad/crashpad/third_party/linux
Project Member

Comment 170 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/132a610184731dfc9365f3e3b08f72055e884045

commit 132a610184731dfc9365f3e3b08f72055e884045
Author: Joshua Peraza <jperaza@chromium.org>
Date: Fri Mar 16 18:44:06 2018

elf: Use compiler macros in crashpad info note

build/build_config.h sometimes includes other headers which aren't
appropriate for .S files.

Bug: crashpad:30
Change-Id: Ie039e08599137d157c60482c72d6eba6a5566ef5
Reviewed-on: https://chromium-review.googlesource.com/966876
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/132a610184731dfc9365f3e3b08f72055e884045/client/crashpad_info_note.S

Project Member

Comment 171 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/f5b486de7416a50e2460112725ccec43fcc559f4

commit f5b486de7416a50e2460112725ccec43fcc559f4
Author: Joshua Peraza <jperaza@chromium.org>
Date: Fri Mar 16 18:49:05 2018

linux: Make StartHandler methods static

Bug: crashpad:30
Change-Id: I3b9e9f149ea8190c3b725691f4fb320eca9cbad0
Reviewed-on: https://chromium-review.googlesource.com/966887
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/f5b486de7416a50e2460112725ccec43fcc559f4/client/crashpad_client.h
[modify] https://crrev.com/f5b486de7416a50e2460112725ccec43fcc559f4/client/crashpad_client_linux.cc

Project Member

Comment 172 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/cf9e96b856cb19c76a15e4c1bb8f99b0c26f46ee

commit cf9e96b856cb19c76a15e4c1bb8f99b0c26f46ee
Author: Joshua Peraza <jperaza@chromium.org>
Date: Tue Mar 20 22:19:23 2018

elf: Use compiler macros in crashpad info size test note

Bug: crashpad:30
Change-Id: If5bdd15dfc050ef57df0e3b59dd6a5e74d4a9b22
Reviewed-on: https://chromium-review.googlesource.com/972367
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/cf9e96b856cb19c76a15e4c1bb8f99b0c26f46ee/snapshot/crashpad_info_size_test_note.S

Project Member

Comment 173 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/6d4626090db24cc4c05946c3b43962596e522d9a

commit 6d4626090db24cc4c05946c3b43962596e522d9a
Author: Joshua Peraza <jperaza@chromium.org>
Date: Wed Mar 21 20:06:45 2018

linux: Add a second CaptureContext symbol name

glibc 2.26 defines ucontext_t from a struct ucontext_t while Bionic
and older versions of glibc use a struct ucontext.

Bug: crashpad:30
Change-Id: I473c317dbdbbedfad601c7594cfa7df7f7c01cb9
Reviewed-on: https://chromium-review.googlesource.com/972613
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/6d4626090db24cc4c05946c3b43962596e522d9a/util/misc/capture_context_linux.S

Project Member

Comment 174 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c65098c18e0ceef42287451e7dd94dffb4c32d00

commit c65098c18e0ceef42287451e7dd94dffb4c32d00
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Mar 22 15:02:46 2018

Update Crashpad to 6d4626090db24cc4c05946c3b43962596e522d9a

132a61018473 elf: Use compiler macros in crashpad info note
f5b486de7416 linux: Make StartHandler methods static
f5483cb99fd4 linux: Use HANDLE_EINTR for sendmsg and recvmsg
cf9e96b856cb elf: Use compiler macros in crashpad info size test note
6d4626090db2 linux: Add a second CaptureContext symbol name

Bug: crashpad:30
Change-Id: I99d6866bc07bc8fa636f736e29ad5ba94e134ea1
Reviewed-on: https://chromium-review.googlesource.com/971833
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545074}
[modify] https://crrev.com/c65098c18e0ceef42287451e7dd94dffb4c32d00/third_party/crashpad/README.chromium
[modify] https://crrev.com/c65098c18e0ceef42287451e7dd94dffb4c32d00/third_party/crashpad/crashpad/DEPS
[modify] https://crrev.com/c65098c18e0ceef42287451e7dd94dffb4c32d00/third_party/crashpad/crashpad/client/crashpad_client.h
[modify] https://crrev.com/c65098c18e0ceef42287451e7dd94dffb4c32d00/third_party/crashpad/crashpad/client/crashpad_client_linux.cc
[modify] https://crrev.com/c65098c18e0ceef42287451e7dd94dffb4c32d00/third_party/crashpad/crashpad/client/crashpad_info_note.S
[modify] https://crrev.com/c65098c18e0ceef42287451e7dd94dffb4c32d00/third_party/crashpad/crashpad/handler/linux/exception_handler_server.cc
[modify] https://crrev.com/c65098c18e0ceef42287451e7dd94dffb4c32d00/third_party/crashpad/crashpad/snapshot/crashpad_info_size_test_note.S
[modify] https://crrev.com/c65098c18e0ceef42287451e7dd94dffb4c32d00/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux_test.cc
[modify] https://crrev.com/c65098c18e0ceef42287451e7dd94dffb4c32d00/third_party/crashpad/crashpad/util/linux/auxiliary_vector_test.cc
[modify] https://crrev.com/c65098c18e0ceef42287451e7dd94dffb4c32d00/third_party/crashpad/crashpad/util/linux/exception_handler_client.cc
[modify] https://crrev.com/c65098c18e0ceef42287451e7dd94dffb4c32d00/third_party/crashpad/crashpad/util/misc/capture_context_linux.S

Project Member

Comment 175 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/9c89cd99f3357f194f0b2bf873e46bf8b59e1c77

commit 9c89cd99f3357f194f0b2bf873e46bf8b59e1c77
Author: Joshua Peraza <jperaza@chromium.org>
Date: Fri Mar 23 16:50:58 2018

gn: add templates for executables and loadable_modules

When building in chromium, executables and loadable_modules should
depend on:
//build/config:exe_and_shlib_deps
which, among other things, may be needed to introduce a
dependency on a custom libc++.

Bug: crashpad:30
Change-Id: Ic46a3cf5b46bdac09cca22950f9236e0776ba44a
Reviewed-on: https://chromium-review.googlesource.com/974713
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/9c89cd99f3357f194f0b2bf873e46bf8b59e1c77/build/crashpad_buildconfig.gni
[modify] https://crrev.com/9c89cd99f3357f194f0b2bf873e46bf8b59e1c77/handler/BUILD.gn
[modify] https://crrev.com/9c89cd99f3357f194f0b2bf873e46bf8b59e1c77/snapshot/BUILD.gn
[modify] https://crrev.com/9c89cd99f3357f194f0b2bf873e46bf8b59e1c77/test/BUILD.gn
[modify] https://crrev.com/9c89cd99f3357f194f0b2bf873e46bf8b59e1c77/tools/BUILD.gn
[modify] https://crrev.com/9c89cd99f3357f194f0b2bf873e46bf8b59e1c77/util/BUILD.gn

Project Member

Comment 178 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ef32965e82729f2649568020581b34464f049ee

commit 6ef32965e82729f2649568020581b34464f049ee
Author: Joshua Peraza <jperaza@chromium.org>
Date: Tue Mar 27 19:58:55 2018

Update Crashpad to 58e4bbecc246543b60e4bc4bbdccd2e24d3157c9

9c89cd99f335 gn: add templates for executables and loadable_modules
6b23575b34bd linux: verify whether a broker has been successfully forked
5754f608cb57 android: unset source filters to use linux files
58e4bbecc246 win, gn: use new lists when using templated targets

Bug: crashpad:30
Change-Id: I0902c600b7257a419b8b0d770ac4f40fc6a808e6
Reviewed-on: https://chromium-review.googlesource.com/981690
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546219}
[modify] https://crrev.com/6ef32965e82729f2649568020581b34464f049ee/third_party/crashpad/README.chromium
[modify] https://crrev.com/6ef32965e82729f2649568020581b34464f049ee/third_party/crashpad/crashpad/build/crashpad_buildconfig.gni
[modify] https://crrev.com/6ef32965e82729f2649568020581b34464f049ee/third_party/crashpad/crashpad/client/BUILD.gn
[modify] https://crrev.com/6ef32965e82729f2649568020581b34464f049ee/third_party/crashpad/crashpad/handler/BUILD.gn
[modify] https://crrev.com/6ef32965e82729f2649568020581b34464f049ee/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.cc
[modify] https://crrev.com/6ef32965e82729f2649568020581b34464f049ee/third_party/crashpad/crashpad/handler/linux/exception_handler_server.cc
[modify] https://crrev.com/6ef32965e82729f2649568020581b34464f049ee/third_party/crashpad/crashpad/handler/linux/exception_handler_server.h
[modify] https://crrev.com/6ef32965e82729f2649568020581b34464f049ee/third_party/crashpad/crashpad/handler/linux/exception_handler_server_test.cc
[modify] https://crrev.com/6ef32965e82729f2649568020581b34464f049ee/third_party/crashpad/crashpad/snapshot/BUILD.gn
[modify] https://crrev.com/6ef32965e82729f2649568020581b34464f049ee/third_party/crashpad/crashpad/test/BUILD.gn
[modify] https://crrev.com/6ef32965e82729f2649568020581b34464f049ee/third_party/crashpad/crashpad/tools/BUILD.gn
[modify] https://crrev.com/6ef32965e82729f2649568020581b34464f049ee/third_party/crashpad/crashpad/util/BUILD.gn
[modify] https://crrev.com/6ef32965e82729f2649568020581b34464f049ee/third_party/crashpad/crashpad/util/linux/auxiliary_vector_test.cc
[modify] https://crrev.com/6ef32965e82729f2649568020581b34464f049ee/third_party/crashpad/crashpad/util/linux/exception_handler_client.cc

Project Member

Comment 179 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/7bd613e55835de1f8d29f24de4e4271bdb8c01d4

commit 7bd613e55835de1f8d29f24de4e4271bdb8c01d4
Author: Joshua Peraza <jperaza@chromium.org>
Date: Wed Mar 28 15:48:42 2018

linux: prefix args with crashpad and build tools on android

1. Prefix enable_http_transport_libcurl with crashpad for use in
chromium .gn files.
2. Make tools build on Android using http_transport_none.cc

Bug: crashpad:30
Change-Id: I0a9878fe9f5b8fbc13a52f93df273fb1de8160f3
Reviewed-on: https://chromium-review.googlesource.com/984038
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/7bd613e55835de1f8d29f24de4e4271bdb8c01d4/tools/generate_dump.cc
[modify] https://crrev.com/7bd613e55835de1f8d29f24de4e4271bdb8c01d4/util/BUILD.gn
[modify] https://crrev.com/7bd613e55835de1f8d29f24de4e4271bdb8c01d4/util/util.gyp

Project Member

Comment 180 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/246ecc6686f3d8d6d03b8acb7c0812a37e842231

commit 246ecc6686f3d8d6d03b8acb7c0812a37e842231
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Mar 29 16:14:13 2018

linux: disable libcurl when in chromium

Bug: crashpad:30
Change-Id: I12007417d27b482f70879d91743fddc06851140e
Reviewed-on: https://chromium-review.googlesource.com/986503
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/246ecc6686f3d8d6d03b8acb7c0812a37e842231/util/BUILD.gn

Project Member

Comment 181 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/059d94fd9782c71435e9cf46f924137dda925499

commit 059d94fd9782c71435e9cf46f924137dda925499
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Mar 29 23:04:21 2018

Update Crashpad to 246ecc6686f3d8d6d03b8acb7c0812a37e842231

7bd613e55835 linux: prefix args with crashpad and build tools on android
246ecc6686f3 linux: disable libcurl when in chromium

Bug: crashpad:30
Change-Id: I573b784b39f48d40ebbf70ac8efbc978ee86637b
Reviewed-on: https://chromium-review.googlesource.com/984332
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547005}
[modify] https://crrev.com/059d94fd9782c71435e9cf46f924137dda925499/third_party/crashpad/README.chromium
[modify] https://crrev.com/059d94fd9782c71435e9cf46f924137dda925499/third_party/crashpad/crashpad/tools/generate_dump.cc
[modify] https://crrev.com/059d94fd9782c71435e9cf46f924137dda925499/third_party/crashpad/crashpad/util/BUILD.gn
[modify] https://crrev.com/059d94fd9782c71435e9cf46f924137dda925499/third_party/crashpad/crashpad/util/util.gyp

Project Member

Comment 182 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/145cc931490a7c20445cc317bbd03d1f11941e84

commit 145cc931490a7c20445cc317bbd03d1f11941e84
Author: Joshua Peraza <jperaza@chromium.org>
Date: Fri Mar 30 23:18:41 2018

linux, android: add crashpad targets to gn_all

Bug: crashpad:30
Change-Id: I07e2be079c95825c57481ac8b53cf6e790443be1
Reviewed-on: https://chromium-review.googlesource.com/986658
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547312}
[modify] https://crrev.com/145cc931490a7c20445cc317bbd03d1f11941e84/BUILD.gn
[modify] https://crrev.com/145cc931490a7c20445cc317bbd03d1f11941e84/components/crash/core/common/crash_key.h

Project Member

Comment 183 by bugdroid1@chromium.org, Mar 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/912fb6424245d5b11f171c251e19ab271bdf3166

commit 912fb6424245d5b11f171c251e19ab271bdf3166
Author: Joshua Peraza <jperaza@chromium.org>
Date: Sat Mar 31 00:28:07 2018

Add support for crashpad integration in linux-ish clients

This CL implements crash/content/app/crashpad.h for linux but does not
migrate any clients from breakpad to crashpad.

Bug: crashpad:30
Change-Id: I00587795331d39d00c98f36949735c43d3e2e9a4
Reviewed-on: https://chromium-review.googlesource.com/972183
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547336}
[modify] https://crrev.com/912fb6424245d5b11f171c251e19ab271bdf3166/components/crash/content/DEPS
[modify] https://crrev.com/912fb6424245d5b11f171c251e19ab271bdf3166/components/crash/content/app/BUILD.gn
[modify] https://crrev.com/912fb6424245d5b11f171c251e19ab271bdf3166/components/crash/content/app/crash_reporter_client.cc
[modify] https://crrev.com/912fb6424245d5b11f171c251e19ab271bdf3166/components/crash/content/app/crash_reporter_client.h
[modify] https://crrev.com/912fb6424245d5b11f171c251e19ab271bdf3166/components/crash/content/app/crashpad.cc
[modify] https://crrev.com/912fb6424245d5b11f171c251e19ab271bdf3166/components/crash/content/app/crashpad.h
[add] https://crrev.com/912fb6424245d5b11f171c251e19ab271bdf3166/components/crash/content/app/crashpad_linux.cc
[modify] https://crrev.com/912fb6424245d5b11f171c251e19ab271bdf3166/components/crash/content/browser/BUILD.gn
[modify] https://crrev.com/912fb6424245d5b11f171c251e19ab271bdf3166/components/crash/content/browser/crash_handler_host_linux.cc
[modify] https://crrev.com/912fb6424245d5b11f171c251e19ab271bdf3166/components/crash/content/browser/crash_handler_host_linux.h

Project Member

Comment 184 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/d108fd04a5e6ec62740a457ff26380bbd2f244a1

commit d108fd04a5e6ec62740a457ff26380bbd2f244a1
Author: Joshua Peraza <jperaza@chromium.org>
Date: Tue Apr 03 22:08:29 2018

linux: Add PtraceConnection::ReadFileContents

Some files, such as /proc/[pid]/maps, may not be accessible to the
handler. This enables the handler access to the contents of those files
via the broker.

This change reads maps and auxv using ReadFileContents.

Bug: crashpad:30
Change-Id: Ia19b498bae473c616ea794ab51c3f22afd5795be
Reviewed-on: https://chromium-review.googlesource.com/989406
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/snapshot/elf/elf_image_reader_test.cc
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/snapshot/linux/debug_rendezvous_test.cc
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/snapshot/linux/process_reader_linux.cc
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/snapshot/linux/process_reader_linux_test.cc
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/test/linux/fake_ptrace_connection.cc
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/test/linux/fake_ptrace_connection.h
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/util/linux/auxiliary_vector.cc
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/util/linux/auxiliary_vector.h
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/util/linux/auxiliary_vector_test.cc
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/util/linux/direct_ptrace_connection.cc
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/util/linux/direct_ptrace_connection.h
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/util/linux/memory_map.cc
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/util/linux/memory_map.h
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/util/linux/memory_map_test.cc
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/util/linux/ptrace_broker.cc
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/util/linux/ptrace_broker.h
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/util/linux/ptrace_broker_test.cc
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/util/linux/ptrace_client.cc
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/util/linux/ptrace_client.h
[modify] https://crrev.com/d108fd04a5e6ec62740a457ff26380bbd2f244a1/util/linux/ptrace_connection.h

Project Member

Comment 185 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9e60476345958dc5b43124a5028b8f27ec0555d0

commit 9e60476345958dc5b43124a5028b8f27ec0555d0
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Apr 04 21:18:11 2018

Crashpad Linux: Fix name of crashpad_enable_http_transport_libcurl

Renamed in
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/984038/.

Bug: crashpad:30
Change-Id: I11c5fc16cc8c404b35aa06d832f59037f5465339
Reviewed-on: https://chromium-review.googlesource.com/996389
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/9e60476345958dc5b43124a5028b8f27ec0555d0/scripts/slave/recipes/crashpad/build.py
[modify] https://crrev.com/9e60476345958dc5b43124a5028b8f27ec0555d0/scripts/slave/recipes/crashpad/build.expected/crashpad_linux_debug.json

Project Member

Comment 186 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/mini_chromium/+/6e0fdb2e4966ec44b1ce7b8464fd7c80d1b59203

commit 6e0fdb2e4966ec44b1ce7b8464fd7c80d1b59203
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Apr 04 21:48:25 2018

Repair Linux-with-sysroot build after clang update

Clang switched to libc++ by default (apparently?) so force back to
libstdc++ and libgcc_s when building in the limited-minspec-sysroot
environment, as is done on Linux bots.

Carefully selected artisinal flags from
https://clang.llvm.org/docs/Toolchain.html.

Bug: crashpad:30
Change-Id: I2f4251853199e5b0c6950c288aac5e2947ad5c9c
Reviewed-on: https://chromium-review.googlesource.com/996452
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/6e0fdb2e4966ec44b1ce7b8464fd7c80d1b59203/build/BUILD.gn

Project Member

Comment 187 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/ba0bd63254a7dd1dd059380e2746f79832815b5d

commit ba0bd63254a7dd1dd059380e2746f79832815b5d
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Apr 04 22:20:49 2018

Use clang ref:goma instead of ref:latest

This is considered a "stable-latest" by the Fuchsia toolchain team that
maintains this package.

Bug: crashpad:30, crashpad:196
Change-Id: I24a57abc9c0eaaab9b003b204ee56e73fad88f11
Reviewed-on: https://chromium-review.googlesource.com/996308
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/ba0bd63254a7dd1dd059380e2746f79832815b5d/DEPS

Project Member

Comment 188 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/10fd672bde9d8c4283da732b8ac0a58decbcc533

commit 10fd672bde9d8c4283da732b8ac0a58decbcc533
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Apr 05 22:21:46 2018

linux: Enable brokered memory reading

This change:
1. Updates the broker's memory reading protocol to enable short reads.
2. Updates Ptracer to allow short reads.
3. Updates the broker to allow reading from a memory file.
4. Updates the broker's default file root to be "/proc/[pid]/".
5. Adds PtraceConnection::Memory() to produce a suitable memory reader
for a connection type.

Bug: crashpad:30
Change-Id: I8c004016065d981acd1fa74ad1b8e51ce07c7c85
Reviewed-on: https://chromium-review.googlesource.com/991455
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/snapshot/linux/process_reader_linux.cc
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/snapshot/linux/process_reader_linux.h
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/test/linux/fake_ptrace_connection.cc
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/test/linux/fake_ptrace_connection.h
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/util/linux/direct_ptrace_connection.cc
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/util/linux/direct_ptrace_connection.h
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/util/linux/exception_handler_client.cc
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/util/linux/ptrace_broker.cc
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/util/linux/ptrace_broker.h
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/util/linux/ptrace_broker_test.cc
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/util/linux/ptrace_client.cc
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/util/linux/ptrace_client.h
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/util/linux/ptrace_connection.h
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/util/linux/ptracer.cc
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/util/linux/ptracer.h
[modify] https://crrev.com/10fd672bde9d8c4283da732b8ac0a58decbcc533/util/process/process_memory.h

Project Member

Comment 189 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/1bb4c233e3415965d5ff8e738a43275f2a20f76a

commit 1bb4c233e3415965d5ff8e738a43275f2a20f76a
Author: Joshua Peraza <jperaza@chromium.org>
Date: Fri Apr 06 01:45:39 2018

linux: skip zero length mappings in the maps file

A zero-length mapping was observed for a x86 process running on an
x86_64 Android Lollipop (5.0) simulator:

ff3c0000-ff3c0000 ---p 00000000 00:00 0
ff3c0000-ffbbf000 rw-p 00000000 00:00 0  [stack]
ffffe000-fffff000 r-xp 00000000 00:00 0  [vdso]

Bug: crashpad:30
Change-Id: I1c1cb5a0910ddf3f02a93d44803e17bec4071110
Reviewed-on: https://chromium-review.googlesource.com/999112
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/1bb4c233e3415965d5ff8e738a43275f2a20f76a/util/linux/memory_map.cc

Project Member

Comment 190 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/a3ba96c0d4c780ab7f19ade6121266916712baaf

commit a3ba96c0d4c780ab7f19ade6121266916712baaf
Author: Joshua Peraza <jperaza@chromium.org>
Date: Fri Apr 06 02:15:09 2018

linux: Use an empty string for unmapped module names

This may be a bug in the target program or loader, but doesn't seem
like something worth dying over. If a link_entry name is empty,
ProcessReaderLinux::InitializeModules() will fall back to using the
name of the module's mapping. In this case, the main executable's
link entry name pointed into unmapped memory, but the memory map was
able to identify it as app_process32.

Bug: crashpad:30
Change-Id: Ic6df08132271efb809bf0bc28f23a333deb20a67
Reviewed-on: https://chromium-review.googlesource.com/999301
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/a3ba96c0d4c780ab7f19ade6121266916712baaf/snapshot/linux/debug_rendezvous.cc

Project Member

Comment 191 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/914e7f76dd26de8e74caac5d05750beee9b48029

commit 914e7f76dd26de8e74caac5d05750beee9b48029
Author: Joshua Peraza <jperaza@chromium.org>
Date: Mon Apr 09 19:08:13 2018

linux, x86: Read floating point state via mcontext.fpptr

Floating-point content may not begin at the start of __fpregs_mem and
should be located via mcontext.fpptr, which may be `nullptr`.

Bug: crashpad:30
Change-Id: Ie3116339d79f6669d757618e9e592f8480dcdcba
Reviewed-on: https://chromium-review.googlesource.com/1001332
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/914e7f76dd26de8e74caac5d05750beee9b48029/snapshot/linux/cpu_context_linux.cc
[modify] https://crrev.com/914e7f76dd26de8e74caac5d05750beee9b48029/snapshot/linux/cpu_context_linux.h
[modify] https://crrev.com/914e7f76dd26de8e74caac5d05750beee9b48029/snapshot/linux/exception_snapshot_linux.cc
[modify] https://crrev.com/914e7f76dd26de8e74caac5d05750beee9b48029/snapshot/linux/exception_snapshot_linux_test.cc
[modify] https://crrev.com/914e7f76dd26de8e74caac5d05750beee9b48029/snapshot/linux/signal_context.h

Project Member

Comment 192 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/dd4ba4c8a1684d3d0068fbf77638c65f84e1a46b

commit dd4ba4c8a1684d3d0068fbf77638c65f84e1a46b
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Apr 12 23:54:25 2018

linux, x86/x64: set fpregs to nullptr in CaptureContext()

uc_mcontext.fpregs is a pointer to the floating point context, but
CaptureContext() doesn't yet capture floating point context.

This error manages to slip by unit tests when run all together, but
fails when CrashpadClient.SimulateCrash is run by itself.

Bug: crashpad:30
Change-Id: I7adc30648642912d66a7ba8cf9973c9bc0fbd8bc
Reviewed-on: https://chromium-review.googlesource.com/1011504
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/dd4ba4c8a1684d3d0068fbf77638c65f84e1a46b/client/crashpad_client_linux.cc
[modify] https://crrev.com/dd4ba4c8a1684d3d0068fbf77638c65f84e1a46b/util/misc/capture_context_linux.S
[modify] https://crrev.com/dd4ba4c8a1684d3d0068fbf77638c65f84e1a46b/util/misc/capture_context_test_util_linux.cc

Project Member

Comment 193 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/c80bf96001ddaa69ffa910e61537a967eb1c3116

commit c80bf96001ddaa69ffa910e61537a967eb1c3116
Author: Joshua Peraza <jperaza@chromium.org>
Date: Fri Apr 13 16:20:01 2018

Don't record reports as complete if there is no upload thread

This allows clients to use the database to handle uploads themselves,
e.g. on Android, where Crashpad does not yet provide an uploader.

The handler does not launch an upload thread when no url is supplied.
Previously, the handler would move these reports to
completed and record the upload as skipped with kUploadsDisabled.
With this change, these reports would remain pending until pruned,
with no metrics recorded for them in regard to their upload.

Bug: crashpad:30
Change-Id: I4167ab1531634b10e91d03229018ae6aab4103aa
Reviewed-on: https://chromium-review.googlesource.com/1010970
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/c80bf96001ddaa69ffa910e61537a967eb1c3116/client/crashpad_client_linux_test.cc
[modify] https://crrev.com/c80bf96001ddaa69ffa910e61537a967eb1c3116/handler/crashpad_handler_test.cc
[modify] https://crrev.com/c80bf96001ddaa69ffa910e61537a967eb1c3116/handler/linux/crash_report_exception_handler.cc
[modify] https://crrev.com/c80bf96001ddaa69ffa910e61537a967eb1c3116/handler/mac/crash_report_exception_handler.cc
[modify] https://crrev.com/c80bf96001ddaa69ffa910e61537a967eb1c3116/handler/win/crash_report_exception_handler.cc
[modify] https://crrev.com/c80bf96001ddaa69ffa910e61537a967eb1c3116/snapshot/win/end_to_end_test.py

Project Member

Comment 194 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/ca2d7e776a0a276827cfe3144a81c9e1f1500ef0

commit ca2d7e776a0a276827cfe3144a81c9e1f1500ef0
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Apr 13 18:04:20 2018

Pull go toolchain for all host types

To be used to build replacement http test server.

Bug: crashpad:227, crashpad:196, crashpad:30
Change-Id: I8bdd33a629d98af8b149bd83a11edb5965ad6e76
Reviewed-on: https://chromium-review.googlesource.com/1011653
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/ca2d7e776a0a276827cfe3144a81c9e1f1500ef0/.gitignore
[modify] https://crrev.com/ca2d7e776a0a276827cfe3144a81c9e1f1500ef0/DEPS

Project Member

Comment 195 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673

commit 0e5b439e76cd1103acd26a8ffb8e84d51f7c4673
Author: Joshua Peraza <jperaza@chromium.org>
Date: Tue Apr 17 00:29:16 2018

Update Crashpad to 799dcef4c90fe28d67703cad8fec2a98a24aa86f

10fd672bde9d linux: Enable brokered memory reading
3a20d34ac356 Fix build with glibc 2.27
1bb4c233e341 linux: skip zero length mappings in the maps file
a3ba96c0d4c7 linux: Use an empty string for unmapped module names
914e7f76dd26 linux, x86: Read floating point state via mcontext.fpptr
e83103c80503 fuchsia: Implement CaptureContext() for x64
b08165c9e52a Extract BuildHandlerArgvStrings to common shared location
c7fe30dddbb0 fuchsia: Get generate_dump to start attempting process
             dumps
cf55a7ef5506 fuchsia: Implement SnapshotTime()
f5f0aa4a8e84 fuchsia: Implementation of system snapshot
a4f4d6a73659 fuchsia: Small fixes in system and process snapshot hit on
             generate_dump
d9bf38f39c5a fuchsia: More fixes to get a basic minidump written
856339b2d211 fuchsia: Avoid uname() in system snapshot
091308be6aeb gyp: build client_argv_handling
dd4ba4c8a168 linux, x86/x64: set fpregs to nullptr in CaptureContext()
c80bf96001dd Don't record reports as complete if there is no upload
             thread
f5d5a41317be fuchsia: Add implementation of ScopedTaskSuspend
c2583364a36e fuchsia: Capture general purpose registers in thread
             snapshot
eca0ea8427c2 Add limited version of URL cracking
ca2d7e776a0a Pull go toolchain for all host types
799dcef4c90f fuchsia: Fix compilation after hasty review changes

Bug: crashpad:30
Change-Id: Iab7c09aaa390e73129eb0eea308ba8af9eddb668
Reviewed-on: https://chromium-review.googlesource.com/1012446
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551183}
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/headless/lib/headless_browser_browsertest.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/README.chromium
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/.gitignore
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/DEPS
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/client/BUILD.gn
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/client/client.gyp
[add] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/client/client_argv_handling.cc
[add] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/client/client_argv_handling.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/client/crashpad_client_linux.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/client/crashpad_client_linux_test.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/compat/linux/sys/ptrace.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/handler/crashpad_handler_test.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/handler/linux/crash_report_exception_handler.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/minidump/minidump_extensions.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/minidump/minidump_system_info_writer.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/BUILD.gn
[add] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/fuchsia/cpu_context_fuchsia.cc
[add] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/fuchsia/cpu_context_fuchsia.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/fuchsia/process_reader_fuchsia.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia.h
[add] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/fuchsia/system_snapshot_fuchsia.cc
[add] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/fuchsia/system_snapshot_fuchsia.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/fuchsia/thread_snapshot_fuchsia.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/linux/cpu_context_linux.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/linux/cpu_context_linux.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/linux/debug_rendezvous.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/linux/exception_snapshot_linux_test.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/linux/process_reader_linux.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/linux/signal_context.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/mac/cpu_context_mac.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/system_snapshot.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/snapshot/win/end_to_end_test.py
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/test/linux/fake_ptrace_connection.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/test/linux/fake_ptrace_connection.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/tools/generate_dump.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/BUILD.gn
[add] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/fuchsia/koid_utilities.cc
[add] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/fuchsia/koid_utilities.h
[add] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/fuchsia/scoped_task_suspend.cc
[add] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/fuchsia/scoped_task_suspend.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/linux/direct_ptrace_connection.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/linux/direct_ptrace_connection.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/linux/exception_handler_client.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/linux/memory_map.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/linux/ptrace_broker.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/linux/ptrace_broker.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/linux/ptrace_broker_test.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/linux/ptrace_client.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/linux/ptrace_client.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/linux/ptrace_connection.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/linux/ptracer.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/linux/ptracer.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/misc/capture_context.h
[add] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/misc/capture_context_fuchsia.S
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/misc/capture_context_linux.S
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/misc/capture_context_test.cc
[add] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/misc/capture_context_test_util_fuchsia.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/misc/capture_context_test_util_linux.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/net/url.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/net/url.h
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/net/url_test.cc
[modify] https://crrev.com/0e5b439e76cd1103acd26a8ffb8e84d51f7c4673/third_party/crashpad/crashpad/util/process/process_memory.h

Project Member

Comment 196 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/439ba730c5ae031195ae927b5f8d077d2d733e77

commit 439ba730c5ae031195ae927b5f8d077d2d733e77
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Apr 20 20:56:49 2018

Implementation in C++ of HTTPTransport test server

- Pulls in cpp-httplib for test-only usage in third_party/.
- Replaces http_transport_test_server.py with .cc server.
- Remove unnecessary Go toolchain pull. This was planned to be used for
  the test server, but the toolchain integration was too messy when
  covering all target platforms/configs.

Bug: crashpad:196, crashpad:227, crashpad:30
Change-Id: I5990781473dcadfcc036fbe711c02928638ff851
Reviewed-on: https://chromium-review.googlesource.com/1013293
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/439ba730c5ae031195ae927b5f8d077d2d733e77/.gitignore
[modify] https://crrev.com/439ba730c5ae031195ae927b5f8d077d2d733e77/DEPS
[add] https://crrev.com/439ba730c5ae031195ae927b5f8d077d2d733e77/third_party/cpp-httplib/BUILD.gn
[add] https://crrev.com/439ba730c5ae031195ae927b5f8d077d2d733e77/third_party/cpp-httplib/README.crashpad
[add] https://crrev.com/439ba730c5ae031195ae927b5f8d077d2d733e77/third_party/cpp-httplib/cpp-httplib/LICENSE
[add] https://crrev.com/439ba730c5ae031195ae927b5f8d077d2d733e77/third_party/cpp-httplib/cpp-httplib/README.md
[add] https://crrev.com/439ba730c5ae031195ae927b5f8d077d2d733e77/third_party/cpp-httplib/cpp-httplib/httplib.h
[modify] https://crrev.com/439ba730c5ae031195ae927b5f8d077d2d733e77/util/BUILD.gn
[modify] https://crrev.com/439ba730c5ae031195ae927b5f8d077d2d733e77/util/net/http_transport_test.cc
[add] https://crrev.com/439ba730c5ae031195ae927b5f8d077d2d733e77/util/net/http_transport_test_server.cc
[delete] https://crrev.com/a7c30f05016bcbc53ed30387ac1919bbff683859/util/net/http_transport_test_server.py

Project Member

Comment 197 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/0e144fb9aeffc0287c2e4670192938853478833a

commit 0e144fb9aeffc0287c2e4670192938853478833a
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Apr 23 16:54:32 2018

Add missing http_transport_test_server to gyp build

Follow up to https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1013293.

Bug: crashpad:196, crashpad:227, crashpad:30
Change-Id: I87f18dce6a49f537cff5c9f3af2fe78b8d87c2ef
Reviewed-on: https://chromium-review.googlesource.com/1022738
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/0e144fb9aeffc0287c2e4670192938853478833a/util/util_test.gyp

Project Member

Comment 198 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/d051e00cd85a42a0da5de2e44f3b5ac62950a1a6

commit d051e00cd85a42a0da5de2e44f3b5ac62950a1a6
Author: Joshua Peraza <jperaza@chromium.org>
Date: Tue Apr 24 22:51:58 2018

android: name crashpad_handler like a loadable module

There is not any normal way to package native executables in an
Android APK (that I've found). It is normal to package native code as
loadable modules, but Android's APK installer will ignore files not
named like shared objects.

Bug: crashpad:30
Change-Id: I45ea3e4b6dbfaf92d3d174e96aafe377928b9294
Reviewed-on: https://chromium-review.googlesource.com/1026157
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>

[modify] https://crrev.com/d051e00cd85a42a0da5de2e44f3b5ac62950a1a6/handler/BUILD.gn

Project Member

Comment 199 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bb6e15c873eafb5afe9d8438fb143b972c17a81

commit 1bb6e15c873eafb5afe9d8438fb143b972c17a81
Author: Joshua Peraza <jperaza@chromium.org>
Date: Wed Apr 25 20:21:12 2018

Add an observer interface to CrashHandlerHost

This interface allows interested classes, including
AwBrowserTerminator, ChromeStabilityMetricsProvider,
OutOfMemoryReporter, and DataReductionProxyPingbackClientImpl to
distinguish between child process crashes and kills on Android.
Previously, this was done by either passing a file descriptor to the
child process (AwBrowserTerminator) or by observing whether a crash
dump was successfully produced. This eliminates the need for the extra
descriptor for AwBrowserTerminator, as well as providing a more
accurate signal for classes that relied on checking for a crash dump.

Observers can use this interface in combination with observing child
process exits/disconnects. If an observer sees a child process
disconnect without having observed a crash signal for the child, it
can deduce that the child was killed.

Bug: crashpad:30
Change-Id: I6213d31f30d15b30d2a3987fe95229042371938b
Reviewed-on: https://chromium-review.googlesource.com/1026085
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553715}
[modify] https://crrev.com/1bb6e15c873eafb5afe9d8438fb143b972c17a81/components/crash/content/app/crashpad_linux.cc
[modify] https://crrev.com/1bb6e15c873eafb5afe9d8438fb143b972c17a81/components/crash/content/browser/crash_handler_host_linux.cc
[modify] https://crrev.com/1bb6e15c873eafb5afe9d8438fb143b972c17a81/components/crash/content/browser/crash_handler_host_linux.h

Project Member

Comment 200 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/60ae9eeadb4a3a923219ba7b50e663f32dd97d40

commit 60ae9eeadb4a3a923219ba7b50e663f32dd97d40
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Apr 27 04:04:30 2018

Implementation of HTTPTransport via raw socket

Partial implementation: Currently only handles http (i.e. no TLS), only
POST, and only certain response types (only when Content-Length is
specified, and not chunked). Used for Linux and Fuchsia lacking anything
better (that's shippable). Removes libcurl HTTPTransport, since it isn't
available in the Chromium sysroot anyway.

This is an intermediate step until BoringSSL is available in the Fuchsia
SDK. Once that's available, it should be "relatively straightfoward" to
make http_transport_socket.cc secure its socket using BoringSSL or
OpenSSL depending on the platform.

Bug: crashpad:196, crashpad:227, crashpad:30
Change-Id: If33a0d3f11b9000cbc3f52f96cd024ef274a922f
Reviewed-on: https://chromium-review.googlesource.com/1022717
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/60ae9eeadb4a3a923219ba7b50e663f32dd97d40/build/run_tests.py
[modify] https://crrev.com/60ae9eeadb4a3a923219ba7b50e663f32dd97d40/util/BUILD.gn
[delete] https://crrev.com/2ddfb4cd3c79a94aee1f3e4ab0f3ad63a1a05fc4/util/net/http_transport_libcurl.cc
[add] https://crrev.com/60ae9eeadb4a3a923219ba7b50e663f32dd97d40/util/net/http_transport_socket.cc
[modify] https://crrev.com/60ae9eeadb4a3a923219ba7b50e663f32dd97d40/util/net/http_transport_test_server.cc
[modify] https://crrev.com/60ae9eeadb4a3a923219ba7b50e663f32dd97d40/util/util.gyp

Project Member

Comment 201 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/5636102fb418582be671c26c84626ab5aa9e89d4

commit 5636102fb418582be671c26c84626ab5aa9e89d4
Author: Scott Graham <scottmg@chromium.org>
Date: Sat Apr 28 00:08:11 2018

Implement unlengthed response read in HTTPTransport

Of course, as soon as I tried it against the real endpoint on Fuchsia,
the server just spits out raw crash id as a string without specifying
Content-Length.

Bug: crashpad:196, crashpad:30
Change-Id: I22af87589a8801cdfece0a7b862e70e0e7097f1f
Reviewed-on: https://chromium-review.googlesource.com/1024953
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/5636102fb418582be671c26c84626ab5aa9e89d4/client/crash_report_database_generic.cc
[modify] https://crrev.com/5636102fb418582be671c26c84626ab5aa9e89d4/util/file/file_io.cc
[modify] https://crrev.com/5636102fb418582be671c26c84626ab5aa9e89d4/util/file/file_io.h
[modify] https://crrev.com/5636102fb418582be671c26c84626ab5aa9e89d4/util/net/http_transport_socket.cc

Project Member

Comment 202 by scottmg@chromium.org, Apr 30 2018

Blockedon: 229
Project Member

Comment 203 by bugdroid1@chromium.org, May 11

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/19e6087bb2084a3a4729b36d8ceb1c3e392fe747

commit 19e6087bb2084a3a4729b36d8ceb1c3e392fe747
Author: Joshua Peraza <jperaza@chromium.org>
Date: Fri May 11 00:22:06 2018

Don't restrict ImageAnnotationReader to a module's address range

Annotations data structures may be dynamically allocated so could
appear outside a modules's address range. Let ImageAnnotationReader
use a ProcessMemoryRange for the process, rather than the module.

Also add a test for linux.

Bug: crashpad:30
Change-Id: Ibbf1d2fcb2e44b1b70c8a02e86c6f2fbd784535f
Reviewed-on: https://chromium-review.googlesource.com/1054705
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/19e6087bb2084a3a4729b36d8ceb1c3e392fe747/client/BUILD.gn
[modify] https://crrev.com/19e6087bb2084a3a4729b36d8ceb1c3e392fe747/client/client_test.gyp
[modify] https://crrev.com/19e6087bb2084a3a4729b36d8ceb1c3e392fe747/client/crashpad_client_linux_test.cc
[modify] https://crrev.com/19e6087bb2084a3a4729b36d8ceb1c3e392fe747/snapshot/elf/module_snapshot_elf.cc
[modify] https://crrev.com/19e6087bb2084a3a4729b36d8ceb1c3e392fe747/snapshot/elf/module_snapshot_elf.h
[modify] https://crrev.com/19e6087bb2084a3a4729b36d8ceb1c3e392fe747/snapshot/fuchsia/process_snapshot_fuchsia.cc
[modify] https://crrev.com/19e6087bb2084a3a4729b36d8ceb1c3e392fe747/snapshot/fuchsia/process_snapshot_fuchsia.h
[modify] https://crrev.com/19e6087bb2084a3a4729b36d8ceb1c3e392fe747/snapshot/linux/process_snapshot_linux.cc
[modify] https://crrev.com/19e6087bb2084a3a4729b36d8ceb1c3e392fe747/snapshot/linux/process_snapshot_linux.h

Project Member

Comment 204 by bugdroid1@chromium.org, May 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa22c1a0c988ac7efd69e253b79d4aff73e68710

commit aa22c1a0c988ac7efd69e253b79d4aff73e68710
Author: Joshua Peraza <jperaza@chromium.org>
Date: Fri May 11 15:45:11 2018

Remove unused crash_dump_manager_android.h includes

Bug: crashpad:30
Change-Id: Ifd6e5047d3d82c28ac56e83d7bc87e6cfd68a9fc
Reviewed-on: https://chromium-review.googlesource.com/1044500
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557891}
[modify] https://crrev.com/aa22c1a0c988ac7efd69e253b79d4aff73e68710/chromecast/browser/cast_browser_process.cc
[modify] https://crrev.com/aa22c1a0c988ac7efd69e253b79d4aff73e68710/content/shell/browser/layout_test/layout_test_browser_main_parts.cc

Project Member

Comment 205 by bugdroid1@chromium.org, May 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/980ad399dd3d77720805d217f3141fb3c29ca11d

commit 980ad399dd3d77720805d217f3141fb3c29ca11d
Author: Joshua Peraza <jperaza@chromium.org>
Date: Mon May 14 19:16:45 2018

Prepare for Crashpad on Android

This CL includes several minor changes to components/crash/ in
preparation for enabling Crashpad on Android.

- Use std::string instead of char* in GetProductNameAndVersion.
- Set LD_LIBRARY_PATH when building handler args for component builds.
- Update Android handler executable to libcrashpad_handler.so.
- Don't set a url parameter on Android to avoid Crashpad attempting to
  upload reports, which it doesn't yet support.
- Initialize CrashHandlerHost on the first call to GetDeathSignalSocket
  because CrashHandlerHost may be created before it can post tasks to
  the IO thread.

Bug: crashpad:30
Change-Id: I80efa0cf87cb4081773eaa516b1d6eb90fb6f5e8
Reviewed-on: https://chromium-review.googlesource.com/1056320
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558408}
[modify] https://crrev.com/980ad399dd3d77720805d217f3141fb3c29ca11d/components/crash/content/app/crash_reporter_client.cc
[modify] https://crrev.com/980ad399dd3d77720805d217f3141fb3c29ca11d/components/crash/content/app/crash_reporter_client.h
[modify] https://crrev.com/980ad399dd3d77720805d217f3141fb3c29ca11d/components/crash/content/app/crashpad_linux.cc
[modify] https://crrev.com/980ad399dd3d77720805d217f3141fb3c29ca11d/components/crash/content/browser/crash_handler_host_linux.cc
[modify] https://crrev.com/980ad399dd3d77720805d217f3141fb3c29ca11d/components/crash/content/browser/crash_handler_host_linux.h

Project Member

Comment 207 by bugdroid1@chromium.org, May 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/5c17a89644889527d08c8f0946b9e00a1ed0cfc0

commit 5c17a89644889527d08c8f0946b9e00a1ed0cfc0
Author: Scott Graham <scottmg@chromium.org>
Date: Tue May 29 17:51:26 2018

crashpad linux: Remove now-unused gn arg

libcurl is no longer used or mentioned in Crashpad GN build files, so
this is causing a non-fatal warning:

https://build.chromium.org/p/client.crashpad/builders/crashpad_try_linux_rel/builds/235/steps/generate%20build%20files/logs/stdio

Bug: crashpad:30, crashpad:227
Change-Id: I1b46b34231827cd61ac1afb2118f144511adbe73
Reviewed-on: https://chromium-review.googlesource.com/1075768
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/5c17a89644889527d08c8f0946b9e00a1ed0cfc0/scripts/slave/recipes/crashpad/build.py
[modify] https://crrev.com/5c17a89644889527d08c8f0946b9e00a1ed0cfc0/scripts/slave/recipes/crashpad/build.expected/crashpad_linux_debug.json

Project Member

Comment 208 by bugdroid1@chromium.org, May 29

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/5c49c598477c69e642b4feb44c4dd3e8857cd82c

commit 5c49c598477c69e642b4feb44c4dd3e8857cd82c
Author: Scott Graham <scottmg@chromium.org>
Date: Tue May 29 23:19:09 2018

fuchsia: Implement TLS support in HTTPTransportSocket

With use_boringssl_for_http_transport_socket set, this also works on
Linux, however the bots fail during run lacking libcrypto.so.1.1. So,
not enabled on Linux until that's figured out.

(Includes https://github.com/yhirose/cpp-httplib/pull/70, until it lands
and I'll do a full roll of cpp-httplib then.)

Bug: crashpad:30, crashpad:196
Change-Id: I987f6a87f8e47160c15e53fe1ce28611339069ff
Reviewed-on: https://chromium-review.googlesource.com/1075726
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/5c49c598477c69e642b4feb44c4dd3e8857cd82c/test/test_paths.cc
[modify] https://crrev.com/5c49c598477c69e642b4feb44c4dd3e8857cd82c/test/test_paths.h
[modify] https://crrev.com/5c49c598477c69e642b4feb44c4dd3e8857cd82c/third_party/cpp-httplib/cpp-httplib/httplib.h
[modify] https://crrev.com/5c49c598477c69e642b4feb44c4dd3e8857cd82c/util/BUILD.gn
[add] https://crrev.com/5c49c598477c69e642b4feb44c4dd3e8857cd82c/util/net/generate_test_server_key.py
[modify] https://crrev.com/5c49c598477c69e642b4feb44c4dd3e8857cd82c/util/net/http_transport.cc
[modify] https://crrev.com/5c49c598477c69e642b4feb44c4dd3e8857cd82c/util/net/http_transport.h
[modify] https://crrev.com/5c49c598477c69e642b4feb44c4dd3e8857cd82c/util/net/http_transport_socket.cc
[modify] https://crrev.com/5c49c598477c69e642b4feb44c4dd3e8857cd82c/util/net/http_transport_test.cc
[modify] https://crrev.com/5c49c598477c69e642b4feb44c4dd3e8857cd82c/util/net/http_transport_test_server.cc

Project Member

Comment 209 by bugdroid1@chromium.org, Jun 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/mini_chromium/+/d5a36d3c51a7a270afc2c888baaaec2a6e496219

commit d5a36d3c51a7a270afc2c888baaaec2a6e496219
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Jun 01 23:15:16 2018

Various toolchain churn for Linux and Fuchsia

The clang that the Fuchsia team ships now requires -ldl and -lpthread
for host (Linux) binaries, but that must currently be put manually on
the command line.

Additionally, while we were force linking fdio on Fuchsia, we weren't
including zircon. But fdio won't work without zircon, so include it too.

Bug: crashpad:30, crashpad:196
Change-Id: I13fba13acd0380bb18143524336160096bac10a6
Reviewed-on: https://chromium-review.googlesource.com/1083601
Reviewed-by: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/d5a36d3c51a7a270afc2c888baaaec2a6e496219/build/BUILD.gn

Project Member

Comment 210 by bugdroid1@chromium.org, Jun 7

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/9a97daff395a312ae5d15f10a6aa62f483c3d6b5

commit 9a97daff395a312ae5d15f10a6aa62f483c3d6b5
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Jun 07 21:09:53 2018

Add libfuzzer support

Adds the build support for using libfuzzer controlled by setting
`crashpad_use_libfuzzer=true`.

Also adds a first fuzzer (for ElfImageReader). Currently only runs on
Linux, but should work on Fuchsia too with some minor fixes (not sure
yet whether the fixes required are toolchain or in our build setup).

Run as:
  out/lin/elf_image_reader_fuzzer snapshot/elf/elf_image_reader_fuzzer_corpus/
hits an OOM pretty quickly in trying to allocate a giant buffer.

Bug: crashpad:30, crashpad:196, crashpad:233
Change-Id: Idd3ca11fe00319b8b29e029d5e13b17bfd518ea0
Reviewed-on: https://chromium-review.googlesource.com/1083451
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/9a97daff395a312ae5d15f10a6aa62f483c3d6b5/.gitignore
[modify] https://crrev.com/9a97daff395a312ae5d15f10a6aa62f483c3d6b5/DEPS
[modify] https://crrev.com/9a97daff395a312ae5d15f10a6aa62f483c3d6b5/build/BUILD.gn
[modify] https://crrev.com/9a97daff395a312ae5d15f10a6aa62f483c3d6b5/build/BUILDCONFIG.gn
[add] https://crrev.com/9a97daff395a312ae5d15f10a6aa62f483c3d6b5/build/crashpad_fuzzer_test.gni
[modify] https://crrev.com/9a97daff395a312ae5d15f10a6aa62f483c3d6b5/snapshot/BUILD.gn
[add] https://crrev.com/9a97daff395a312ae5d15f10a6aa62f483c3d6b5/snapshot/elf/elf_image_reader_fuzzer.cc
[add] https://crrev.com/9a97daff395a312ae5d15f10a6aa62f483c3d6b5/snapshot/elf/elf_image_reader_fuzzer_corpus/crashpad_snapshot_test_both_dt_hash_styles.so
[add] https://crrev.com/9a97daff395a312ae5d15f10a6aa62f483c3d6b5/snapshot/elf/elf_image_reader_fuzzer_corpus/ret42
[add] https://crrev.com/9a97daff395a312ae5d15f10a6aa62f483c3d6b5/third_party/libfuzzer/BUILD.gn

Project Member

Comment 211 by bugdroid1@chromium.org, Jun 11

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87

commit a42b5269b4b6e6f7b3379bec1f87068eca5c8a87
Author: Joshua Peraza <jperaza@chromium.org>
Date: Mon Jun 11 16:46:29 2018

Add ProcessSnapshotSanitized

A ProcessSnapshotSanitized enables filtering possibly sensitive
information from a snapshot.

WebView has different privacy constraints than Chrome and needs to
avoid collecting data in annotations or from stack memory that may
contain PII. This CL enables:

1. Filtering annotations by name using a whitelist.
2. Filtering for crashes which reference a particular module.
3. Redacting non-essential information from stack memory.

This CL does not provide a client interface to enable sanitization.

Bug: crashpad:30
Change-Id: I8944c70fdcca6d6d4b7955d983320909bf871254
Reviewed-on: https://chromium-review.googlesource.com/1070472
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/snapshot/BUILD.gn
[modify] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/snapshot/cpu_context.cc
[modify] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/snapshot/cpu_context.h
[add] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/snapshot/sanitized/memory_snapshot_sanitized.cc
[add] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/snapshot/sanitized/memory_snapshot_sanitized.h
[add] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/snapshot/sanitized/module_snapshot_sanitized.cc
[add] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/snapshot/sanitized/module_snapshot_sanitized.h
[add] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/snapshot/sanitized/process_snapshot_sanitized.cc
[add] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/snapshot/sanitized/process_snapshot_sanitized.h
[add] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/snapshot/sanitized/process_snapshot_sanitized_test.cc
[add] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/snapshot/sanitized/thread_snapshot_sanitized.cc
[add] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/snapshot/sanitized/thread_snapshot_sanitized.h
[modify] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/snapshot/snapshot.gyp
[modify] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/snapshot/snapshot_test.gyp
[modify] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/util/BUILD.gn
[add] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/util/misc/range_set.cc
[add] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/util/misc/range_set.h
[add] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/util/misc/range_set_test.cc
[modify] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/util/util.gyp
[modify] https://crrev.com/a42b5269b4b6e6f7b3379bec1f87068eca5c8a87/util/util_test.gyp

Project Member

Comment 212 by bugdroid1@chromium.org, Jun 12

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/d1e6a2130da4a6f4005a7729ad12420ce6c9a486

commit d1e6a2130da4a6f4005a7729ad12420ce6c9a486
Author: Joshua Peraza <jperaza@chromium.org>
Date: Tue Jun 12 15:37:11 2018

android/linux: add a client interface to control sanitization

Sanitization is controlled by a SanitizationInformation struct to be
read from the client's memory. The address of this struct is either
passed in a ClientInformation when the client requests a crash dump,
or as a flag to the handler --sanitization_information.

Bug: crashpad:30
Change-Id: I2744f8fb85b4fea7362b2b88faa4bef1da74e36b
Reviewed-on: https://chromium-review.googlesource.com/1083143
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/client/crashpad_client_linux_test.cc
[modify] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/handler/handler_main.cc
[modify] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/handler/linux/crash_report_exception_handler.cc
[modify] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/handler/linux/crash_report_exception_handler.h
[modify] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/handler/linux/exception_handler_server.cc
[modify] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/handler/linux/exception_handler_server.h
[modify] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/handler/linux/exception_handler_server_test.cc
[modify] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/snapshot/BUILD.gn
[add] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/snapshot/sanitized/sanitization_information.cc
[add] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/snapshot/sanitized/sanitization_information.h
[add] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/snapshot/sanitized/sanitization_information_test.cc
[modify] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/snapshot/snapshot.gyp
[modify] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/snapshot/snapshot_test.gyp
[modify] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/util/BUILD.gn
[add] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/util/linux/exception_handler_protocol.cc
[modify] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/util/linux/exception_handler_protocol.h
[modify] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/util/misc/metrics.h
[modify] https://crrev.com/d1e6a2130da4a6f4005a7729ad12420ce6c9a486/util/util.gyp

Project Member

Comment 213 by bugdroid1@chromium.org, Jun 20

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/c0a0d70a2b7a5d973828e6079386cb2a852e5b1c

commit c0a0d70a2b7a5d973828e6079386cb2a852e5b1c
Author: Joshua Peraza <jperaza@chromium.org>
Date: Wed Jun 20 17:03:07 2018

Increase max annotations size

Clank's JavaExceptionReporter attaches up to 5 * 4096 bytes of Java
exceptions to minidumps.

Bug: crashpad:30
Change-Id: I3b6b63b1f1b893225d6f340b03a65edf105ed0be
Reviewed-on: https://chromium-review.googlesource.com/1108337
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/c0a0d70a2b7a5d973828e6079386cb2a852e5b1c/client/annotation.h

Project Member

Comment 215 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db3e2625c21de87066b39dc40f108cc52519b410

commit db3e2625c21de87066b39dc40f108cc52519b410
Author: Joshua Peraza <jperaza@chromium.org>
Date: Tue Jul 10 17:12:58 2018

Rename aw_microdump_crash_reporter to aw_crash_reporter_client

This naming scheme matches the scheme used by other crash reporter
clients and better reflects that it is not used only for microdumps.

Bug: crashpad:30
Change-Id: I01540cb713ce704a5eec9aed0fe34dfd5dd5d6b9
Reviewed-on: https://chromium-review.googlesource.com/1119395
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573783}
[modify] https://crrev.com/db3e2625c21de87066b39dc40f108cc52519b410/android_webview/BUILD.gn
[modify] https://crrev.com/db3e2625c21de87066b39dc40f108cc52519b410/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/db3e2625c21de87066b39dc40f108cc52519b410/android_webview/browser/aw_browser_terminator.cc
[modify] https://crrev.com/db3e2625c21de87066b39dc40f108cc52519b410/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/db3e2625c21de87066b39dc40f108cc52519b410/android_webview/browser/aw_debug.cc
[rename] https://crrev.com/db3e2625c21de87066b39dc40f108cc52519b410/android_webview/common/crash_reporter/aw_crash_reporter_client.cc
[rename] https://crrev.com/db3e2625c21de87066b39dc40f108cc52519b410/android_webview/common/crash_reporter/aw_crash_reporter_client.h
[modify] https://crrev.com/db3e2625c21de87066b39dc40f108cc52519b410/android_webview/lib/aw_main_delegate.cc

Project Member

Comment 216 by bugdroid1@chromium.org, Jul 10

Project Member

Comment 217 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c051f0ac232f997f6c26744303c13796af793ede

commit c051f0ac232f997f6c26744303c13796af793ede
Author: Joshua Peraza <jperaza@chromium.org>
Date: Tue Jul 10 22:48:11 2018

android: Set BuildInfo Crashpad annotations

Bug: crashpad:30
Change-Id: I1a85d5d3428b5f801c570dc1add043f0697ba0e3
Reviewed-on: https://chromium-review.googlesource.com/1119383
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573959}
[modify] https://crrev.com/c051f0ac232f997f6c26744303c13796af793ede/components/crash/content/app/crashpad_linux.cc

Project Member

Comment 218 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/934e5598a289291c79437b9fadb0326f35794d25

commit 934e5598a289291c79437b9fadb0326f35794d25
Author: Joshua Peraza <jperaza@chromium.org>
Date: Wed Jul 18 23:43:11 2018

Rename CrashDumpObserver to ChildExitObserver

CrashDumpObserver is used to observe information about child process
exits, including non-crashes, so ChildExitObserver more accurately
reflects what this class does.

Also move ChildExitObserver and ChildProcessCrashObserver to the
crash_reporter namespace as part of the move away from breakpad.

TBR=sanfin@chromium.org

Bug: crashpad:30
Change-Id: Ib480af7fbf800afd63beccee90bbee01f9ec7610
Reviewed-on: https://chromium-review.googlesource.com/1138727
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576257}
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/android_webview/browser/aw_browser_terminator.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/android_webview/browser/aw_browser_terminator.h
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/chrome/browser/metrics/oom/out_of_memory_reporter_unittest.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/components/crash/content/browser/BUILD.gn
[rename] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/components/crash/content/browser/child_exit_observer_android.cc
[rename] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/components/crash/content/browser/child_exit_observer_android.h
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/components/crash/content/browser/child_process_crash_observer_android.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/components/crash/content/browser/child_process_crash_observer_android.h
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/components/crash/content/browser/crash_dump_manager_android.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/components/crash/content/browser/crash_dump_manager_android.h
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/components/crash/content/browser/crash_dump_manager_android_unittest.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/components/crash/content/browser/crash_metrics_reporter_android.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/components/crash/content/browser/crash_metrics_reporter_android.h
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/components/crash/content/browser/crash_metrics_reporter_android_unittest.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/components/data_reduction_proxy/content/browser/data_reduction_proxy_pingback_client_impl_unittest.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/content/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/934e5598a289291c79437b9fadb0326f35794d25/content/shell/browser/shell_content_browser_client.cc

Project Member

Comment 221 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/2f3a8b8f72dccc7c1738eb496e46e86ee60ec4ed

commit 2f3a8b8f72dccc7c1738eb496e46e86ee60ec4ed
Author: Joshua Peraza <jperaza@chromium.org>
Date: Tue Jul 24 20:37:18 2018

Add CrashSkippedReason::kPrepareForUploadFailed

Bug: crashpad:30
Change-Id: I763c30e261c315b45860c8672d9cffbba4714f32
Reviewed-on: https://chromium-review.googlesource.com/1148895
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/2f3a8b8f72dccc7c1738eb496e46e86ee60ec4ed/handler/crash_report_upload_thread.cc
[modify] https://crrev.com/2f3a8b8f72dccc7c1738eb496e46e86ee60ec4ed/util/misc/metrics.h

Project Member

Comment 222 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1782edbe987616da21aae2f8eb892c43b0bbbfcf

commit 1782edbe987616da21aae2f8eb892c43b0bbbfcf
Author: Joshua Peraza <jperaza@chromium.org>
Date: Wed Jul 25 16:42:02 2018

android: Add ChildProcessCrashObserver.java

ChildProcessCrashObserver.java serves a similar purpose as
CrashDumpManager.java did (which it will replace), except without the
need (or ability) to check for a minidump on the filesystem. Instead of
a minidump path, the process ID of the crashed child is passed to the
callback which it can use to identify the correct crash dump.

Bug: crashpad:30
Change-Id: I718e653acfa35b14ebaa17d0e8c76804f9856dfb
Reviewed-on: https://chromium-review.googlesource.com/1150202
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577935}
[modify] https://crrev.com/1782edbe987616da21aae2f8eb892c43b0bbbfcf/components/crash/android/BUILD.gn
[add] https://crrev.com/1782edbe987616da21aae2f8eb892c43b0bbbfcf/components/crash/android/java/src/org/chromium/components/crash/browser/ChildProcessCrashObserver.java

Project Member

Comment 223 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/753a5614b547eca194c88d3d09e0d0c6b5c3688c

commit 753a5614b547eca194c88d3d09e0d0c6b5c3688c
Author: Joshua Peraza <jperaza@chromium.org>
Date: Wed Jul 25 21:50:37 2018

android: Make ChildExitObserver observe CrashHandlerHost

This change causes a CrashHandlerHost to be instantiated, but
ChildExitObserver won't receive child crash signals until
CrashHandlerHost begins monitoring child processes.

Also fixes compilation of crash_handler_host_linux.* on Android by
not compiling breakpad::CrashHandlerHostLinux, which was never used on
Android.

Bug: crashpad:30
Change-Id: I00d1b1b1e0604056a9d64dc070be5aa9638a6d81
Reviewed-on: https://chromium-review.googlesource.com/1150411
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578081}
[modify] https://crrev.com/753a5614b547eca194c88d3d09e0d0c6b5c3688c/components/crash/content/browser/child_exit_observer_android.cc
[modify] https://crrev.com/753a5614b547eca194c88d3d09e0d0c6b5c3688c/components/crash/content/browser/child_exit_observer_android.h
[modify] https://crrev.com/753a5614b547eca194c88d3d09e0d0c6b5c3688c/components/crash/content/browser/crash_handler_host_linux.cc
[modify] https://crrev.com/753a5614b547eca194c88d3d09e0d0c6b5c3688c/components/crash/content/browser/crash_handler_host_linux.h

Project Member

Comment 224 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/20294e79cc0926b8e3c5413d01d4d1c514874e91

commit 20294e79cc0926b8e3c5413d01d4d1c514874e91
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Jul 26 04:53:54 2018

android: Rename crashpad_handler_module target

Targets suffixed with "_module" are now treated specially in chromium
as dynamic feature modules.

Bug: crashpad:30
Change-Id: I9682a76a0e0fae993bbe7454c49a44ada6c4165b
Reviewed-on: https://chromium-review.googlesource.com/1150851
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/20294e79cc0926b8e3c5413d01d4d1c514874e91/handler/BUILD.gn

Project Member

Comment 225 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/52ff1accbbe81ab3631fdb410f0dd4afd1c91c0d

commit 52ff1accbbe81ab3631fdb410f0dd4afd1c91c0d
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Jul 26 15:33:15 2018

linux: Fix locating modules with multiple mappings from offset 0

The general strategy used by Crashpad to determine loaded modules is to
read the link_map to get the addresses of the dynamic arrays for all
loaded modules. Those addresses can then be used to query the MemoryMap
to locate the module's mappings, and in particular the base mapping
from which Crashpad can parse the entire loaded ELF file.

ELF modules are typically loaded in several mappings with varying
permissions for different segments. The previous strategy used to find
the base mapping for a module was to search backwards from the mapping
for the dynamic array until a mapping from file offset 0 was found for
the same file. This fails when the file is mapped multiple times from
file offset 0, which can happen if the first page of the file contains
a GNU_RELRO segment.

This new strategy queries the MemoryMap for ALL mappings associated
with the dynamic array's mapping, mapped from offset 0. The consumer
(process_reader_linux.cc) can then determine which mapping is the
correct base by attempting to parse a module at that address and
corroborating the PT_DYNAMIC or program header table address from the
parsed module with the values Crashpad gets from the link_map or
auxiliary vector.

Bug: crashpad:30
Change-Id: Ibfcbba512e8fccc8c65afef734ea5640b71e9f70
Reviewed-on: https://chromium-review.googlesource.com/1139396
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/52ff1accbbe81ab3631fdb410f0dd4afd1c91c0d/snapshot/elf/elf_image_reader.cc
[modify] https://crrev.com/52ff1accbbe81ab3631fdb410f0dd4afd1c91c0d/snapshot/elf/elf_image_reader.h
[modify] https://crrev.com/52ff1accbbe81ab3631fdb410f0dd4afd1c91c0d/snapshot/elf/elf_image_reader_test.cc
[modify] https://crrev.com/52ff1accbbe81ab3631fdb410f0dd4afd1c91c0d/snapshot/linux/debug_rendezvous_test.cc
[modify] https://crrev.com/52ff1accbbe81ab3631fdb410f0dd4afd1c91c0d/snapshot/linux/process_reader_linux.cc
[modify] https://crrev.com/52ff1accbbe81ab3631fdb410f0dd4afd1c91c0d/snapshot/linux/process_reader_linux_test.cc
[modify] https://crrev.com/52ff1accbbe81ab3631fdb410f0dd4afd1c91c0d/test/scoped_module_handle.cc
[modify] https://crrev.com/52ff1accbbe81ab3631fdb410f0dd4afd1c91c0d/test/scoped_module_handle.h
[modify] https://crrev.com/52ff1accbbe81ab3631fdb410f0dd4afd1c91c0d/util/linux/memory_map.cc
[modify] https://crrev.com/52ff1accbbe81ab3631fdb410f0dd4afd1c91c0d/util/linux/memory_map.h
[modify] https://crrev.com/52ff1accbbe81ab3631fdb410f0dd4afd1c91c0d/util/linux/memory_map_test.cc

Project Member

Comment 226 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c0fc42d9f2905a615bf865c2da1e7a1a257f603

commit 0c0fc42d9f2905a615bf865c2da1e7a1a257f603
Author: Joshua Peraza <jperaza@chromium.org>
Date: Fri Jul 27 22:52:37 2018

Implement CrashReporterClient methods for Crashpad

This new implementation of GetProductNameAndVersion() will replace the
existing one in the transition to Crashpad.

GetSanitizationInformation() (for webview) will replace
GetCrashKeysWhitelist() and the SanitizationInfo struct passed during
crash reporter initialization.

These new methods are currently unused.

Bug: crashpad:30
Change-Id: Ic60d17cb3af8b4e7997009c23a44fcc8b94915a7
Reviewed-on: https://chromium-review.googlesource.com/1142511
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578843}
[modify] https://crrev.com/0c0fc42d9f2905a615bf865c2da1e7a1a257f603/android_webview/BUILD.gn
[modify] https://crrev.com/0c0fc42d9f2905a615bf865c2da1e7a1a257f603/android_webview/browser/aw_variations_service_client.cc
[add] https://crrev.com/0c0fc42d9f2905a615bf865c2da1e7a1a257f603/android_webview/common/aw_channel.cc
[add] https://crrev.com/0c0fc42d9f2905a615bf865c2da1e7a1a257f603/android_webview/common/aw_channel.h
[modify] https://crrev.com/0c0fc42d9f2905a615bf865c2da1e7a1a257f603/android_webview/common/crash_reporter/aw_crash_reporter_client.cc
[modify] https://crrev.com/0c0fc42d9f2905a615bf865c2da1e7a1a257f603/chrome/app/chrome_crash_reporter_client.cc
[modify] https://crrev.com/0c0fc42d9f2905a615bf865c2da1e7a1a257f603/chrome/app/chrome_crash_reporter_client.h
[modify] https://crrev.com/0c0fc42d9f2905a615bf865c2da1e7a1a257f603/chromecast/app/BUILD.gn
[modify] https://crrev.com/0c0fc42d9f2905a615bf865c2da1e7a1a257f603/chromecast/app/android/cast_crash_reporter_client_android.cc
[modify] https://crrev.com/0c0fc42d9f2905a615bf865c2da1e7a1a257f603/chromecast/app/android/cast_crash_reporter_client_android.h
[modify] https://crrev.com/0c0fc42d9f2905a615bf865c2da1e7a1a257f603/content/shell/app/shell_crash_reporter_client.cc
[modify] https://crrev.com/0c0fc42d9f2905a615bf865c2da1e7a1a257f603/content/shell/app/shell_crash_reporter_client.h

Project Member

Comment 227 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e319752b6385f26164332696dc2704fb562e8ea

commit 3e319752b6385f26164332696dc2704fb562e8ea
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Aug 09 22:25:36 2018

Add CrashReportMimeWriter to MIME encode crashpad minidumps

CrashReportMimeWriter provides a method to call into native code to
rewrite the minidumps as MIME messages. This CL also links that native
code into webview and clank, but makes no functional changes.

Bug: crashpad:30
Change-Id: Ief41d366614a833db3b643f46a0297c52fea495f
Reviewed-on: https://chromium-review.googlesource.com/1115702
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581918}
[modify] https://crrev.com/3e319752b6385f26164332696dc2704fb562e8ea/android_webview/BUILD.gn
[modify] https://crrev.com/3e319752b6385f26164332696dc2704fb562e8ea/android_webview/test/BUILD.gn
[modify] https://crrev.com/3e319752b6385f26164332696dc2704fb562e8ea/chrome/BUILD.gn
[modify] https://crrev.com/3e319752b6385f26164332696dc2704fb562e8ea/chrome/android/BUILD.gn
[modify] https://crrev.com/3e319752b6385f26164332696dc2704fb562e8ea/components/minidump_uploader/BUILD.gn
[modify] https://crrev.com/3e319752b6385f26164332696dc2704fb562e8ea/components/minidump_uploader/DEPS
[modify] https://crrev.com/3e319752b6385f26164332696dc2704fb562e8ea/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
[add] https://crrev.com/3e319752b6385f26164332696dc2704fb562e8ea/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashReportMimeWriter.java
[add] https://crrev.com/3e319752b6385f26164332696dc2704fb562e8ea/components/minidump_uploader/rewrite_minidumps_as_mimes.cc

Project Member

Comment 228 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4b2f2298ed92d776f43f16b477581e97bfb2e6f

commit a4b2f2298ed92d776f43f16b477581e97bfb2e6f
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Aug 09 22:37:37 2018

Add CrashFileManager.getMinidumpSansLogcatForPid()

Bug: crashpad:30
Change-Id: Iff2d508ae265882e6187cdc418a8074b7b6203fd
Reviewed-on: https://chromium-review.googlesource.com/1118910
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581935}
[modify] https://crrev.com/a4b2f2298ed92d776f43f16b477581e97bfb2e6f/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
[modify] https://crrev.com/a4b2f2298ed92d776f43f16b477581e97bfb2e6f/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashFileManagerTest.java

Project Member

Comment 229 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/0204fbd38b729438a8fc2d5586df07141b3a3ea3

commit 0204fbd38b729438a8fc2d5586df07141b3a3ea3
Author: Joshua Peraza <jperaza@chromium.org>
Date: Wed Aug 29 14:41:08 2018

posix: Make DoubleForkAndExec accept an envp parameter

This will be useful to allow setting variables such as CLASSPATH or
LD_LIBRARY_PATH without modifying or depending upon the application's
current environment.

Bug: crashpad:30
Change-Id: I34f31bcc397e51d789b48eb654d80f992a719074
Reviewed-on: https://chromium-review.googlesource.com/1194399
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/0204fbd38b729438a8fc2d5586df07141b3a3ea3/client/crashpad_client_linux.cc
[modify] https://crrev.com/0204fbd38b729438a8fc2d5586df07141b3a3ea3/client/crashpad_client_mac.cc
[modify] https://crrev.com/0204fbd38b729438a8fc2d5586df07141b3a3ea3/util/posix/double_fork_and_exec.cc
[modify] https://crrev.com/0204fbd38b729438a8fc2d5586df07141b3a3ea3/util/posix/double_fork_and_exec.h

Project Member

Comment 230 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/d4d2f8557aac557743edc17b5501eb19c0463aee

commit d4d2f8557aac557743edc17b5501eb19c0463aee
Author: Joshua Peraza <jperaza@chromium.org>
Date: Wed Aug 29 16:11:27 2018

android: Add client methods to start a Java handler

These methods use /system/bin/app_process{32,64} to load a Java class
supplied by the embedding application. It is expected that the
supplied class loads a native library containing Crashpad's handler
code and passes its arguments to crashpad::HandlerMain().

Bug: crashpad:30
Change-Id: Ic0f9a1439007047b06f07f5ec7d5de9a9d4a19a2
Reviewed-on: https://chromium-review.googlesource.com/1194400
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/d4d2f8557aac557743edc17b5501eb19c0463aee/client/client_argv_handling.cc
[modify] https://crrev.com/d4d2f8557aac557743edc17b5501eb19c0463aee/client/client_argv_handling.h
[modify] https://crrev.com/d4d2f8557aac557743edc17b5501eb19c0463aee/client/crashpad_client.h
[modify] https://crrev.com/d4d2f8557aac557743edc17b5501eb19c0463aee/client/crashpad_client_fuchsia.cc
[modify] https://crrev.com/d4d2f8557aac557743edc17b5501eb19c0463aee/client/crashpad_client_linux.cc

Project Member

Comment 231 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0422d67d86ad51de76f5d61731d7a1e66b94d9a7

commit 0422d67d86ad51de76f5d61731d7a1e66b94d9a7
Author: Joshua Peraza <jperaza@chromium.org>
Date: Fri Sep 21 01:39:08 2018

Add base::android::GetPathToBaseApk()

Bug: crashpad:30
Change-Id: I433eba2e734244dd80d9becae84789fd406de25d
Reviewed-on: https://chromium-review.googlesource.com/1202703
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593045}
[modify] https://crrev.com/0422d67d86ad51de76f5d61731d7a1e66b94d9a7/base/android/java/src/org/chromium/base/PathUtils.java
[modify] https://crrev.com/0422d67d86ad51de76f5d61731d7a1e66b94d9a7/base/android/path_utils.cc
[modify] https://crrev.com/0422d67d86ad51de76f5d61731d7a1e66b94d9a7/base/android/path_utils.h

Project Member

Comment 232 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbca191e2c2156f36523b700a239f0753fdf5ae7

commit dbca191e2c2156f36523b700a239f0753fdf5ae7
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Sep 27 20:59:55 2018

Package Crashpad's handler into various APKs

For Chromecast, Content Shell, and non-monochrome Clank/Webview:

The Crashpad handler is a standalone executable, packaged like a
loadable module and named libcrashpad_handler.so in order to not be
ignored by Android's APK installer.

For Monochrome:

The Crashpad handler is linked into libmonochrome.so. At crash-time
/system/bin/app_process{32,64} is exec-ed, running CrashpadMain.java
which loads libmonochrome.so and runs the native HandlerMain().

This strategy is not used for non-monochrome APKs (i.e. pre-N) because
on L, Android's loader is not yet capable of loading native libraries
from the APK. This is normally performed by the Chromium linker which
can't be used by CrashpadMain.java because /system/bin/app_process
doesn't initialize the process like a normal Android application
(specifically, no ContextImpl has been created, so any calls to e.g.
appContext.getApplicationInfo() will segfault).

Binary-Size: MonochromePublic.apk increases in size by 100 KB.
ChromeModernPublic.apk increases in size by 203KB (587 KB
increase in install size because libcrashpad_handler.so is extracted
from the APK). Possible mitigations for this increase are TODO:

For J, K: We could link the handler directly into libchrome.so and let
that be our handler executable. This would de-dup portions of libbase
that are currently linked into both libchrome.so and
libcrashpad_handler.so.

For L, M: It might be possible to get the chromium linker (or Bionic's
linker on M) to dlopen libchrome.so from the APK for a trampoline
libcrashpad_handler.so to de-dup libbase.

Bug: crashpad:30
Change-Id: If5b3752f26455e5c7aef3278b4bd2076ef1b7b65
Reviewed-on: https://chromium-review.googlesource.com/1150774
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594853}
[modify] https://crrev.com/dbca191e2c2156f36523b700a239f0753fdf5ae7/android_webview/BUILD.gn
[modify] https://crrev.com/dbca191e2c2156f36523b700a239f0753fdf5ae7/android_webview/system_webview_apk_tmpl.gni
[modify] https://crrev.com/dbca191e2c2156f36523b700a239f0753fdf5ae7/android_webview/test/BUILD.gn
[modify] https://crrev.com/dbca191e2c2156f36523b700a239f0753fdf5ae7/build/android/gyp/apkbuilder.py
[modify] https://crrev.com/dbca191e2c2156f36523b700a239f0753fdf5ae7/chrome/android/BUILD.gn
[modify] https://crrev.com/dbca191e2c2156f36523b700a239f0753fdf5ae7/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/dbca191e2c2156f36523b700a239f0753fdf5ae7/chromecast/BUILD.gn
[modify] https://crrev.com/dbca191e2c2156f36523b700a239f0753fdf5ae7/components/crash/android/BUILD.gn
[modify] https://crrev.com/dbca191e2c2156f36523b700a239f0753fdf5ae7/components/crash/android/DEPS
[add] https://crrev.com/dbca191e2c2156f36523b700a239f0753fdf5ae7/components/crash/android/crashpad_main.cc
[add] https://crrev.com/dbca191e2c2156f36523b700a239f0753fdf5ae7/components/crash/android/java/src/org/chromium/components/crash/browser/CrashpadMain.java
[modify] https://crrev.com/dbca191e2c2156f36523b700a239f0753fdf5ae7/components/crash/content/app/crashpad_linux.cc
[modify] https://crrev.com/dbca191e2c2156f36523b700a239f0753fdf5ae7/content/shell/android/BUILD.gn

Project Member

Comment 233 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d813754fbb7ed57b376645e1ec02776726b4440b

commit d813754fbb7ed57b376645e1ec02776726b4440b
Author: Joshua Peraza <jperaza@chromium.org>
Date: Thu Sep 27 23:31:17 2018

Revert "Package Crashpad's handler into various APKs"

This reverts commit dbca191e2c2156f36523b700a239f0753fdf5ae7.

Reason for revert: It broke the build.

Original change's description:
> Package Crashpad's handler into various APKs
>
> For Chromecast, Content Shell, and non-monochrome Clank/Webview:
>
> The Crashpad handler is a standalone executable, packaged like a
> loadable module and named libcrashpad_handler.so in order to not be
> ignored by Android's APK installer.
>
> For Monochrome:
>
> The Crashpad handler is linked into libmonochrome.so. At crash-time
> /system/bin/app_process{32,64} is exec-ed, running CrashpadMain.java
> which loads libmonochrome.so and runs the native HandlerMain().
>
> This strategy is not used for non-monochrome APKs (i.e. pre-N) because
> on L, Android's loader is not yet capable of loading native libraries
> from the APK. This is normally performed by the Chromium linker which
> can't be used by CrashpadMain.java because /system/bin/app_process
> doesn't initialize the process like a normal Android application
> (specifically, no ContextImpl has been created, so any calls to e.g.
> appContext.getApplicationInfo() will segfault).
>
> Binary-Size: MonochromePublic.apk increases in size by 100 KB.
> ChromeModernPublic.apk increases in size by 203KB (587 KB
> increase in install size because libcrashpad_handler.so is extracted
> from the APK). Possible mitigations for this increase are TODO:
>
> For J, K: We could link the handler directly into libchrome.so and let
> that be our handler executable. This would de-dup portions of libbase
> that are currently linked into both libchrome.so and
> libcrashpad_handler.so.
>
> For L, M: It might be possible to get the chromium linker (or Bionic's
> linker on M) to dlopen libchrome.so from the APK for a trampoline
> libcrashpad_handler.so to de-dup libbase.
>
> Bug: crashpad:30
> Change-Id: If5b3752f26455e5c7aef3278b4bd2076ef1b7b65
> Reviewed-on: https://chromium-review.googlesource.com/1150774
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594853}

TBR=boliu@chromium.org,torne@chromium.org,agrieve@chromium.org,halliwell@chromium.org,jperaza@chromium.org,mark@chromium.org

Change-Id: I585aea87e7d52fa51097ae9b00a38eddf3a25679
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: crashpad:30
Reviewed-on: https://chromium-review.googlesource.com/1250134
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594917}
[modify] https://crrev.com/d813754fbb7ed57b376645e1ec02776726b4440b/android_webview/BUILD.gn
[modify] https://crrev.com/d813754fbb7ed57b376645e1ec02776726b4440b/android_webview/system_webview_apk_tmpl.gni
[modify] https://crrev.com/d813754fbb7ed57b376645e1ec02776726b4440b/android_webview/test/BUILD.gn
[modify] https://crrev.com/d813754fbb7ed57b376645e1ec02776726b4440b/build/android/gyp/apkbuilder.py
[modify] https://crrev.com/d813754fbb7ed57b376645e1ec02776726b4440b/chrome/android/BUILD.gn
[modify] https://crrev.com/d813754fbb7ed57b376645e1ec02776726b4440b/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/d813754fbb7ed57b376645e1ec02776726b4440b/chromecast/BUILD.gn
[modify] https://crrev.com/d813754fbb7ed57b376645e1ec02776726b4440b/components/crash/android/BUILD.gn
[modify] https://crrev.com/d813754fbb7ed57b376645e1ec02776726b4440b/components/crash/android/DEPS
[delete] https://crrev.com/f887d3bd8659aa49617d4f7d677389978804d43c/components/crash/android/crashpad_main.cc
[delete] https://crrev.com/f887d3bd8659aa49617d4f7d677389978804d43c/components/crash/android/java/src/org/chromium/components/crash/browser/CrashpadMain.java
[modify] https://crrev.com/d813754fbb7ed57b376645e1ec02776726b4440b/components/crash/content/app/crashpad_linux.cc
[modify] https://crrev.com/d813754fbb7ed57b376645e1ec02776726b4440b/content/shell/android/BUILD.gn

Showing comments 134 - 233 of 233 Older

Sign in to add a comment