New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2011
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 99241: Add 3D support flag in app manifest

Reported by rahulrc@chromium.org, Oct 5 2011 Project Member

Issue description

Developers should be able to declare whether their app uses webGL, so that the web store is able to behave appropriately on unsupported configurations.  Currently, users who don't have webGL enabled have a poor experience in the store - they learn about the game not working only after they've installed and launched it.
 

Comment 1 by mihaip@chromium.org, Oct 6 2011

Cc: aa@chromium.org
Labels: Mstone-16
Erik/Aaron: would it make sense to make this into a generic "requirements" field in the manifest? Something like:

"requirements": {
  "webgl": {
    "extensions": ["foo", "bar"]
   },
  "input": {
    "keyboard": true,
    "mouse": true,
    "touch": false
  }
}

(generally, requirements are keys and have a dict as the value with per-requirement details). At least for M16 the client wouldn't actually do any enforcing of the requirements, it'd be up to the store to warn users before downloading items that don't meet requirements. Eventually we could dim (but still allow launching) of icons on the NTP that may not meet requirements, the way we handle non-offline enabled apps.

See http://b/5405899 and http://b/5077194 for background.

Comment 2 by mihaip@chromium.org, Oct 7 2011

Cc: -mihaip@chromium.org
Owner: mihaip@chromium.org
Status: Started

Comment 3 by mihaip@chromium.org, Oct 7 2011

Labels: -Mstone-16 Mstone-15 Merge-Requested
This landed on trunk as http://crrev.com/104582. I'd like to have this merged into the M15 branch, because otherwise hosted apps that try to use this key will not load there (see  bug 98537  for how this happened with the offline_enabled key with M14/M15).

If the release managers find merging the full patch too risky, the only change that strictly needs to be merged is the addition to line 1250 in extension.cc.

Comment 4 by kareng@google.com, Oct 10 2011

hey mihai, this looks like a big change. do you think we could just make the small change and merge that for 874?

Comment 5 by erikkay@chromium.org, Oct 10 2011

Summary: Add 3D support flag in app manifest
This all looks good.  One random note for this is that when we actually add the requirement, it should probably be something more general than "webGL" since an app that requires 3D-CSS or hardware accelerated canvas would also want to express this requirement.  Perhaps just "3D"?  Or "graphics acceleration"?

Comment 6 by erikkay@chromium.org, Oct 10 2011

BTW, Karen, I think this is a pretty small change.  Most of the change is adding unit tests.  The key part of it is a 23 line change in extension.cc and 8 lines in extension_constants.*.  Are you asking whether we can split off the test from the change for the merge?

Comment 7 by kareng@google.com, Oct 11 2011

Labels: -Merge-Requested Merge-Approved

Comment 8 by mihaip@chromium.org, Oct 11 2011

Status: Fixed
Merged into the M15 branch with http://crrev.com/104912.

Comment 9 by bugdroid1@chromium.org, Oct 12 2011

Project Member
Labels: -merge-approved merge-merged-874
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104912

------------------------------------------------------------------------
r104912 | mihaip@chromium.org | Tue Oct 11 10:55:58 PDT 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/test/data/extensions/manifest_tests/init_valid_app_requirements.json?r1=104912&r2=104911&pathrev=104912 (from /trunk/src/chrome/test/data/extensions/manifest_tests/init_valid_app_requirements.json revision 104582)
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/common/extensions/extension_constants.h?r1=104912&r2=104911&pathrev=104912
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/common/extensions/extension.cc?r1=104912&r2=104911&pathrev=104912
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/common/extensions/extension_manifests_unittest.cc?r1=104912&r2=104911&pathrev=104912
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/common/extensions/extension_constants.cc?r1=104912&r2=104911&pathrev=104912
 A http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/test/data/extensions/manifest_tests/init_invalid_requirements_2.json?r1=104912&r2=104911&pathrev=104912 (from /trunk/src/chrome/test/data/extensions/manifest_tests/init_invalid_requirements_2.json revision 104582)
 A http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/test/data/extensions/manifest_tests/init_invalid_requirements_1.json?r1=104912&r2=104911&pathrev=104912 (from /trunk/src/chrome/test/data/extensions/manifest_tests/init_invalid_requirements_1.json revision 104582)

Merge 104582 - Add support for an optional "requirements" section in extension/app manifests.

The expected format is:

"requirements": {
  "requirement1": {
    // requirement details
  },
  "requiement2": {
    // requirement details
  },
  ...
}

Only validation and whitelisting for hosted apps is done, for now only the web
store will use requirements data.

BUG= 99241 
R=yoz@chromium.org

Review URL: http://codereview.chromium.org/8200015

TBR=mihaip@chromium.org
Review URL: http://codereview.chromium.org/8227021
------------------------------------------------------------------------

Comment 10 by bugdroid1@chromium.org, Oct 13 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 11 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-UI -Feature-Apps -Mstone-15 Cr-Platform-Apps Cr-UI M-15

Comment 12 by bugdroid1@chromium.org, Mar 13 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment