Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 7 users
Status: Fixed
Owner:
Closed: May 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 84636
issue 99695
issue 104625
issue 104980
issue 115187
issue 118410
issue 119869

Blocking:
issue 105875

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment
Create Content API
Project Member Reported by jam@chromium.org, Sep 30 2011 Back to list
We want a well defined API around content. See https://sites.google.com/a/chromium.org/dev/developers/content-module/content-api for more information.
 
Project Member Comment 1 by bugdroid1@chromium.org, Oct 1 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=103609

------------------------------------------------------------------------
r103609 | jam@chromium.org | Fri Sep 30 18:24:34 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.cc?r1=103609&r2=103608&pathrev=103609
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/webplugin_delegate_proxy.cc?r1=103609&r2=103608&pathrev=103609
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_renderer_client.h?r1=103609&r2=103608&pathrev=103609
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.h?r1=103609&r2=103608&pathrev=103609
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/pepper_plugin_delegate_impl.cc?r1=103609&r2=103608&pathrev=103609
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/DEPS?r1=103609&r2=103608&pathrev=103609
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_renderer.gypi?r1=103609&r2=103608&pathrev=103609
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/app?r1=103609&r2=103608&pathrev=103609
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common?r1=103609&r2=103608&pathrev=103609
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/mock_content_renderer_client.h?r1=103609&r2=103608&pathrev=103609
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/content_renderer_client.h?r1=103609&r2=103608&pathrev=103609 (from /trunk/src/content/renderer/content_renderer_client.h revision 103561)
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser?r1=103609&r2=103608&pathrev=103609
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webcookiejar_impl.cc?r1=103609&r2=103608&pathrev=103609
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.cc?r1=103609&r2=103608&pathrev=103609
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc?r1=103609&r2=103608&pathrev=103609
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/DEPS?r1=103609&r2=103608&pathrev=103609
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/utility?r1=103609&r2=103608&pathrev=103609
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public?r1=103609&r2=103608&pathrev=103609
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_process_impl.cc?r1=103609&r2=103608&pathrev=103609
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/app/OWNERS?r1=103609&r2=103608&pathrev=103609
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/content_renderer_client.h?r1=103609&r2=103608&pathrev=103609
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/OWNERS?r1=103609&r2=103608&pathrev=103609
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread.cc?r1=103609&r2=103608&pathrev=103609
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_glue.cc?r1=103609&r2=103608&pathrev=103609
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer?r1=103609&r2=103608&pathrev=103609

Start off the Content API by moving content::ContentRendererClient to content\public\renderer.

BUG=98716
Review URL: http://codereview.chromium.org/8100013
------------------------------------------------------------------------
Project Member Comment 2 by bugdroid1@chromium.org, Oct 3 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=103758

------------------------------------------------------------------------
r103758 | jam@chromium.org | Mon Oct 03 12:19:44 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/automation/automation_renderer_helper.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/mhtml_generator.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/devtools_agent.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_load_histograms.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/blocked_plugin.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/autofill/password_autofill_manager.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/geolocation_dispatcher.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/content_settings_observer.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/frame_sniffer.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/malware_dom_details.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/spellchecker/spellcheck_provider.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/malware_dom_details.cc?r1=103758&r2=103757&pathrev=103758
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_view_observer.cc?r1=103758&r2=103757&pathrev=103758 (from /trunk/src/content/renderer/render_view_observer.cc revision 103714)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/frame_sniffer.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/prerender/prerender_helper.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/geolocation_dispatcher.h?r1=103758&r2=103757&pathrev=103758
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_observer_tracker.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/text_input_client_observer.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/intents_dispatcher.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/devtools_agent.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/translate_helper.h?r1=103758&r2=103757&pathrev=103758
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_observer.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.h?r1=103758&r2=103757&pathrev=103758
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_view_observer_tracker.h?r1=103758&r2=103757&pathrev=103758 (from /trunk/src/content/renderer/render_view_observer_tracker.h revision 103714)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/devtools_client.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/media/media_stream_dispatcher.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/prerender/prerender_helper.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/searchbox.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/speech_input_dispatcher.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/spellchecker/spellcheck_provider.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/searchbox.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_click_tracker.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/media/media_stream_dispatcher.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/blocked_plugin.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/devtools_client.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/notification_provider.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/autofill/autofill_agent.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/translate_helper.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_renderer.gypi?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/automation/automation_renderer_helper.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/notification_provider.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/p2p/socket_dispatcher.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/device_orientation_dispatcher.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_helper.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/speech_input_dispatcher.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_helper.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/autofill/password_autofill_manager.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/p2p/socket_dispatcher.cc?r1=103758&r2=103757&pathrev=103758
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_observer.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/mhtml_generator.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/autofill/autofill_agent.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/intents_dispatcher.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/text_input_client_observer.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_accessibility.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_click_tracker.cc?r1=103758&r2=103757&pathrev=103758
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_view_observer.h?r1=103758&r2=103757&pathrev=103758 (from /trunk/src/content/renderer/render_view_observer.h revision 103714)
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/DEPS?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/device_orientation_dispatcher.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/content_settings_observer.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_accessibility.cc?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_classifier_delegate.h?r1=103758&r2=103757&pathrev=103758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_load_histograms.h?r1=103758&r2=103757&pathrev=103758

Move RenderViewObserver and RenderViewObserverTracker to content\public\renderer and put them in the content namespace.

BUG=98716
Review URL: http://codereview.chromium.org/8124001
------------------------------------------------------------------------
Project Member Comment 3 by bugdroid1@chromium.org, Oct 3 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=103796

------------------------------------------------------------------------
r103796 | jam@chromium.org | Mon Oct 03 15:08:36 PDT 2011

Changed paths:
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_process_observer.cc?r1=103796&r2=103795&pathrev=103796
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.cc?r1=103796&r2=103795&pathrev=103796
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_process_bindings.cc?r1=103796&r2=103795&pathrev=103796
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_renderer.gypi?r1=103796&r2=103795&pathrev=103796
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_view_visitor.h?r1=103796&r2=103795&pathrev=103796 (from /trunk/src/content/renderer/render_view_visitor.h revision 103758)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.h?r1=103796&r2=103795&pathrev=103796
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_process_observer.h?r1=103796&r2=103795&pathrev=103796
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/visitedlink_slave.h?r1=103796&r2=103795&pathrev=103796
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc?r1=103796&r2=103795&pathrev=103796
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread.h?r1=103796&r2=103795&pathrev=103796
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_process_observer.cc?r1=103796&r2=103795&pathrev=103796 (from /trunk/src/content/renderer/render_process_observer.cc revision 103758)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/spellchecker/spellcheck.h?r1=103796&r2=103795&pathrev=103796
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_dispatcher.h?r1=103796&r2=103795&pathrev=103796
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_process_observer.h?r1=103796&r2=103795&pathrev=103796
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_visitor.h?r1=103796&r2=103795&pathrev=103796
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_process_observer.h?r1=103796&r2=103795&pathrev=103796 (from /trunk/src/content/renderer/render_process_observer.h revision 103758)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/spellchecker/spellcheck.cc?r1=103796&r2=103795&pathrev=103796
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_process_observer.cc?r1=103796&r2=103795&pathrev=103796
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_classifier_delegate.h?r1=103796&r2=103795&pathrev=103796
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread.cc?r1=103796&r2=103795&pathrev=103796
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/render_view_fake_resources_test.h?r1=103796&r2=103795&pathrev=103796
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/renderer_histogram_snapshots.h?r1=103796&r2=103795&pathrev=103796

Move RenderProcessObserver and RenderViewVisitor to content\public\renderer and put them in the content namespace.

BUG=98716
Review URL: http://codereview.chromium.org/8116009
------------------------------------------------------------------------
Project Member Comment 4 by bugdroid1@chromium.org, Oct 4 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=103826

------------------------------------------------------------------------
r103826 | jam@chromium.org | Mon Oct 03 17:15:32 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/frame_sniffer.cc?r1=103826&r2=103825&pathrev=103826
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.cc?r1=103826&r2=103825&pathrev=103826
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/navigation_state.h?r1=103826&r2=103825&pathrev=103826 (from /trunk/src/content/renderer/navigation_state.h revision 103796)
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/navigation_state.h?r1=103826&r2=103825&pathrev=103826
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/loadtimes_extension_bindings.cc?r1=103826&r2=103825&pathrev=103826
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_renderer.gypi?r1=103826&r2=103825&pathrev=103826
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.h?r1=103826&r2=103825&pathrev=103826
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/navigation_state.cc?r1=103826&r2=103825&pathrev=103826 (from /trunk/src/content/renderer/navigation_state.cc revision 103796)
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/navigation_state.cc?r1=103826&r2=103825&pathrev=103826
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/prerender/prerender_helper.cc?r1=103826&r2=103825&pathrev=103826
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_load_histograms.cc?r1=103826&r2=103825&pathrev=103826
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/render_view_fake_resources_test.cc?r1=103826&r2=103825&pathrev=103826
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc?r1=103826&r2=103825&pathrev=103826
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/content_settings_observer.cc?r1=103826&r2=103825&pathrev=103826
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_load_histograms.h?r1=103826&r2=103825&pathrev=103826

Move NavigationState to content\public\renderer and put it in the content namespace.

BUG=98716
Review URL: http://codereview.chromium.org/8114019
------------------------------------------------------------------------
Project Member Comment 5 by bugdroid1@chromium.org, Oct 4 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=103925

------------------------------------------------------------------------
r103925 | jam@chromium.org | Tue Oct 04 10:01:19 PDT 2011

Changed paths:
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/v8_value_converter.h?r1=103925&r2=103924&pathrev=103925
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/v8_value_converter.h?r1=103925&r2=103924&pathrev=103925
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.cc?r1=103925&r2=103924&pathrev=103925
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/v8_value_converter_impl_unittest.cc?r1=103925&r2=103924&pathrev=103925 (from /trunk/src/content/renderer/v8_value_converter_unittest.cc revision 103818)
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/v8_value_converter_impl.h?r1=103925&r2=103924&pathrev=103925 (from /trunk/src/content/renderer/v8_value_converter.h revision 103818)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/DEPS?r1=103925&r2=103924&pathrev=103925
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_renderer.gypi?r1=103925&r2=103924&pathrev=103925
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/v8_value_converter_impl.cc?r1=103925&r2=103924&pathrev=103925 (from /trunk/src/content/renderer/v8_value_converter.cc revision 103818)
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/v8_value_converter.cc?r1=103925&r2=103924&pathrev=103925
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=103925&r2=103924&pathrev=103925
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/chrome_app_bindings.cc?r1=103925&r2=103924&pathrev=103925
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/event_bindings.cc?r1=103925&r2=103924&pathrev=103925
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_bindings_context_set.cc?r1=103925&r2=103924&pathrev=103925
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/intents_dispatcher.cc?r1=103925&r2=103924&pathrev=103925
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/v8_value_converter_unittest.cc?r1=103925&r2=103924&pathrev=103925

Make V8ValueConverter be an interface and move it to content\public\renderer and put in the content namespace.

BUG=98716
Review URL: http://codereview.chromium.org/8122011
------------------------------------------------------------------------
Project Member Comment 6 by bugdroid1@chromium.org, Oct 4 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=103996

------------------------------------------------------------------------
r103996 | jam@chromium.org | Tue Oct 04 15:21:44 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/web_ui_bindings.cc?r1=103996&r2=103995&pathrev=103996
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.cc?r1=103996&r2=103995&pathrev=103996
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/external_host_bindings.cc?r1=103996&r2=103995&pathrev=103996
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/web_ui_bindings.h?r1=103996&r2=103995&pathrev=103996
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/external_host_bindings.h?r1=103996&r2=103995&pathrev=103996
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.cc?r1=103996&r2=103995&pathrev=103996

Get rid of web_ui_bindings.h include from Chrome's ExternalHostBindings. The ChromeFrame object wasn't using anything from that class except for storing an IPC sender and a route.

BUG=98716
Review URL: http://codereview.chromium.org/8139004
------------------------------------------------------------------------
Project Member Comment 7 by bugdroid1@chromium.org, Oct 5 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104110

------------------------------------------------------------------------
r104110 | jam@chromium.org | Wed Oct 05 09:18:02 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/DEPS?r1=104110&r2=104109&pathrev=104110
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/mock_render_process.cc?r1=104110&r2=104109&pathrev=104110 (from /trunk/src/chrome/renderer/mock_render_process.cc revision 103996)
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/mock_render_process.h?r1=104110&r2=104109&pathrev=104110 (from /trunk/src/chrome/renderer/mock_render_process.h revision 103996)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=104110&r2=104109&pathrev=104110
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/mock_render_process.h?r1=104110&r2=104109&pathrev=104110
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/render_view_test.cc?r1=104110&r2=104109&pathrev=104110
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/render_view_fake_resources_test.cc?r1=104110&r2=104109&pathrev=104110
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_ppb_pdf_impl.cc?r1=104110&r2=104109&pathrev=104110
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/render_view_fake_resources_test.h?r1=104110&r2=104109&pathrev=104110
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=104110&r2=104109&pathrev=104110
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/mock_render_process.cc?r1=104110&r2=104109&pathrev=104110

Get rid of pepper_plugin_delegate_impl.h dependency from chrome (since it's a content implementation file). Also move MockRenderProcess to content. Lock down DEPS from chrome\renderer while RenderThread and RenderView get APIs around them.

BUG=98716
Review URL: http://codereview.chromium.org/8142020
------------------------------------------------------------------------
Project Member Comment 8 by bugdroid1@chromium.org, Oct 6 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104358

------------------------------------------------------------------------
r104358 | jam@chromium.org | Thu Oct 06 13:34:06 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_widget_fullscreen.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_widget.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/chrome_v8_context_set.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/mock_render_thread.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/mock_render_thread.h?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_renderer.gypi?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_widget.h?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/user_script_slave.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_widget_fullscreen.h?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/renderer_histogram_snapshots.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread.h?r1=104358&r2=104357&pathrev=104358
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_thread.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/event_bindings.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_dispatcher.h?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/net/renderer_net_predictor.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/spellchecker/spellcheck.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.h?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_ppb_pdf_impl.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_widget_fullscreen_pepper.h?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/localized_error.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_ppapi_interfaces.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_process_observer.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_dispatcher.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_widget_fullscreen_pepper.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread.cc?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/blocked_plugin.cc?r1=104358&r2=104357&pathrev=104358
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_thread.h?r1=104358&r2=104357&pathrev=104358
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/event_bindings.h?r1=104358&r2=104357&pathrev=104358

Create content::RenderThread interface and make code in chrome use that.

BUG=98716,98375,10837
Review URL: http://codereview.chromium.org/8165013
------------------------------------------------------------------------
Comment 9 by a...@chromium.org, Oct 10 2011
Blockedon: 99695
Project Member Comment 10 by bugdroid1@chromium.org, Oct 10 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104624

------------------------------------------------------------------------
r104624 | jam@chromium.org | Fri Oct 07 18:34:11 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/plugins/npapi/webplugin_impl.h?r1=104624&r2=104623&pathrev=104624
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.cc?r1=104624&r2=104623&pathrev=104624
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.h?r1=104624&r2=104623&pathrev=104624
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/support/webkit_support.cc?r1=104624&r2=104623&pathrev=104624
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_renderer.gypi?r1=104624&r2=104623&pathrev=104624
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_webview_delegate.cc?r1=104624&r2=104623&pathrev=104624
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.cc?r1=104624&r2=104623&pathrev=104624
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_view.h?r1=104624&r2=104623&pathrev=104624
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.h?r1=104624&r2=104623&pathrev=104624
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/plugins/npapi/webplugin_impl.cc?r1=104624&r2=104623&pathrev=104624
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/blocked_plugin.cc?r1=104624&r2=104623&pathrev=104624
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/blocked_plugin.h?r1=104624&r2=104623&pathrev=104624

Add a content::RenderView API. I'll make RenderView use it in a future change. To make chrome not know about PepperPluginDelegateImpl and to remove a duplicated block of code, I've modified the plugin creation code a little in content. This also makes WebPlugin creation simpler since it doesn't get the mime type in two ways and has to know to ignore the one in the struct. 

BUG=98716
Review URL: http://codereview.chromium.org/8200019
------------------------------------------------------------------------
Project Member Comment 11 by bugdroid1@chromium.org, Oct 10 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104625

------------------------------------------------------------------------
r104625 | jam@chromium.org | Fri Oct 07 18:40:13 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/mock_content_renderer_client.cc?r1=104625&r2=104624&pathrev=104625
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.cc?r1=104625&r2=104624&pathrev=104625
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_renderer_client.h?r1=104625&r2=104624&pathrev=104625
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.h?r1=104625&r2=104624&pathrev=104625
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_renderer_client.cc?r1=104625&r2=104624&pathrev=104625
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.cc?r1=104625&r2=104624&pathrev=104625
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/mock_content_renderer_client.h?r1=104625&r2=104624&pathrev=104625
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=104625&r2=104624&pathrev=104625
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/content_renderer_client.h?r1=104625&r2=104624&pathrev=104625

Simplify embedder API around showing custom error pages so that the embedder doesn't have to call content back in its callback. This removes one method from RenderView that we need to expose in its API.

BUG=98716
Review URL: http://codereview.chromium.org/8198021
------------------------------------------------------------------------
Project Member Comment 12 by bugdroid1@chromium.org, Oct 10 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104727

------------------------------------------------------------------------
r104727 | jam@chromium.org | Mon Oct 10 09:20:31 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/automation/automation_renderer_helper.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/mhtml_generator.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_view_visitor.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_load_histograms.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/blocked_plugin.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/chrome_app_bindings.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/event_bindings.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/autofill/password_autofill_manager.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/geolocation_dispatcher.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/content_settings_observer.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/frame_sniffer.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/chrome_v8_extension.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/malware_dom_details.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/spellchecker/spellcheck_provider.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/malware_dom_details.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_view_observer.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_view.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/frame_sniffer.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/prerender/prerender_helper.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_view_fake_resources_test.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_classifier.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/intents_dispatcher.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/devtools_agent.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/chrome_v8_context_set.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/translate_helper.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/content_renderer_client.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_ppb_pdf_impl.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_classifier.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/media/media_stream_dispatcher.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/prerender/prerender_helper.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/searchbox.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_thumbnailer.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/spellchecker/spellcheck_provider.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/external_extension.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/searchbox.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_click_tracker.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/searchbox_extension.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_process_observer.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/blocked_plugin.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/chrome_v8_context.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/chrome_v8_context_set.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/autofill/autofill_agent.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/translate_helper.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/chrome_v8_context.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/automation/automation_renderer_helper.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/notification_provider.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_view_fake_resources_test.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/device_orientation_dispatcher.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_helper.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/speech_input_dispatcher.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_thumbnailer.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_helper.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/autofill/password_autofill_manager.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/p2p/socket_dispatcher.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_process_bindings.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/chrome_webstore_bindings.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/autofill/autofill_agent.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/translate_helper_browsertest.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/text_input_client_observer.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/user_script_idle_scheduler.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_click_tracker.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_view_observer.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/renderer_extension_bindings.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/renderer_extension_bindings.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/chrome_v8_extension.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/content_settings_observer.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper_linux.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/search_extension.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_accessibility.cc?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_classifier_delegate.h?r1=104727&r2=104726&pathrev=104727
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_load_histograms.h?r1=104727&r2=104726&pathrev=104727

Make RenderView inherit from content::RenderView, and add missing functions to the interface. In a future change I'll rename RenderView to RenderViewImpl.

BUG=98716
Review URL: http://codereview.chromium.org/8201029
------------------------------------------------------------------------
Project Member Comment 13 by bugdroid1@chromium.org, Oct 10 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104754

------------------------------------------------------------------------
r104754 | jam@chromium.org | Mon Oct 10 12:06:28 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.cc?r1=104754&r2=104753&pathrev=104754
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webapplicationcachehost_impl.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/mhtml_generator.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/pepper_plugin_delegate_impl.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webapplicationcachehost_impl.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/devtools_agent.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/geolocation_dispatcher.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webcookiejar_impl.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_view_observer.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/geolocation_dispatcher.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webcookiejar_impl.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_view_fake_resources_test.cc?r1=104754&r2=104753&pathrev=104754
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=104754&r2=104753&pathrev=104754 (from /trunk/src/content/renderer/render_view.cc revision 104727)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/text_input_client_observer.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/intents_dispatcher.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webstoragearea_impl.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/devtools_agent.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/devtools_agent_filter.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.cc?r1=104754&r2=104753&pathrev=104754
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/external_popup_menu.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/render_view_test.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/devtools_client.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_linux.cc?r1=104754&r2=104753&pathrev=104754
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.h?r1=104754&r2=104753&pathrev=104754 (from /trunk/src/content/renderer/render_view.h revision 104727)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/media/media_stream_dispatcher.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/speech_input_dispatcher.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/content_settings_observer_browsertest.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/indexed_db_dispatcher.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/media/media_stream_dispatcher.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/devtools_client.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/notification_provider.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/pepper_plugin_delegate_impl.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_renderer.gypi?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/webplugin_delegate_proxy.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/notification_provider.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/p2p/socket_dispatcher.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_view_fake_resources_test.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/device_orientation_dispatcher.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/speech_input_dispatcher.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_process_impl.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/load_progress_tracker.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/p2p/socket_dispatcher.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/render_view_test.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/webplugin_delegate_proxy.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/mhtml_generator.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/p2p/p2p_transport_impl.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/media/audio_renderer_impl.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/translate_helper_browsertest.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/intents_dispatcher.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/text_input_client_observer.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_accessibility.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/DEPS?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/load_progress_tracker.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_view_observer.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/DEPS?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/device_orientation_dispatcher.h?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_accessibility.cc?r1=104754&r2=104753&pathrev=104754
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/external_popup_menu.h?r1=104754&r2=104753&pathrev=104754

Rename RenderView to RenderViewImpl. Update Chrome's DEPS so that it can't include the RenderView implementation.

BUG=98716
Review URL: http://codereview.chromium.org/8220006
------------------------------------------------------------------------
Project Member Comment 14 by bugdroid1@chromium.org, Oct 10 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104781

------------------------------------------------------------------------
r104781 | jam@chromium.org | Mon Oct 10 14:07:09 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/DEPS?r1=104781&r2=104780&pathrev=104781
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_widget_browsertest.h?r1=104781&r2=104780&pathrev=104781 (from /trunk/src/content/renderer/render_widget_browsertest.h revision 104755)
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_widget_browsertest.h?r1=104781&r2=104780&pathrev=104781
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/test/mock_render_process.h?r1=104781&r2=104780&pathrev=104781 (from /trunk/src/content/renderer/mock_render_process.h revision 104755)
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/mock_render_process.cc?r1=104781&r2=104780&pathrev=104781
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/mock_render_process.h?r1=104781&r2=104780&pathrev=104781
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/test/mock_render_process.cc?r1=104781&r2=104780&pathrev=104781 (from /trunk/src/content/renderer/mock_render_process.cc revision 104755)
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_widget_browsertest.cc?r1=104781&r2=104780&pathrev=104781
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_widget_browsertest.cc?r1=104781&r2=104780&pathrev=104781 (from /trunk/src/content/renderer/render_widget_browsertest.cc revision 104755)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=104781&r2=104780&pathrev=104781
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/render_view_test.cc?r1=104781&r2=104780&pathrev=104781
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_thumbnailer_browsertest.cc?r1=104781&r2=104780&pathrev=104781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_view_fake_resources_test.cc?r1=104781&r2=104780&pathrev=104781
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=104781&r2=104780&pathrev=104781

Move some testing classes used by chrome to content\renderer, to match what we're doing with other test classes.

BUG=98716
Review URL: http://codereview.chromium.org/8216019
------------------------------------------------------------------------
Project Member Comment 15 by bugdroid1@chromium.org, Oct 11 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104826

------------------------------------------------------------------------
r104826 | jam@chromium.org | Mon Oct 10 17:05:16 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/autofill/autofill_browsertest.cc?r1=104826&r2=104825&pathrev=104826
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/content_settings_observer_browsertest.cc?r1=104826&r2=104825&pathrev=104826
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper_browsertest.cc?r1=104826&r2=104825&pathrev=104826
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_click_tracker_browsertest.cc?r1=104826&r2=104825&pathrev=104826
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_browsertest.cc?r1=104826&r2=104825&pathrev=104826
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_browsertest_mac.mm?r1=104826&r2=104825&pathrev=104826
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/translate_helper_browsertest.cc?r1=104826&r2=104825&pathrev=104826
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_widget_browsertest.cc?r1=104826&r2=104825&pathrev=104826
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/render_view_test.cc?r1=104826&r2=104825&pathrev=104826
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/safe_browsing/phishing_thumbnailer_browsertest.cc?r1=104826&r2=104825&pathrev=104826
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.h?r1=104826&r2=104825&pathrev=104826
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/external_popup_menu_unittest.cc?r1=104826&r2=104825&pathrev=104826
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/render_view_test.h?r1=104826&r2=104825&pathrev=104826

Don't expose RenderViewImpl to tests which use RenderViewTest through its header. Instead add a few methods to RenderViewTest that Chrome tests need.

BUG=98716
Review URL: http://codereview.chromium.org/8222014
------------------------------------------------------------------------
Project Member Comment 16 by bugdroid1@chromium.org, Oct 12 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104836

------------------------------------------------------------------------
r104836 | jam@chromium.org | Mon Oct 10 19:33:05 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_thread.h?r1=104836&r2=104835&pathrev=104836
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.cc?r1=104836&r2=104835&pathrev=104836
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/DEPS?r1=104836&r2=104835&pathrev=104836
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/mock_render_thread.cc?r1=104836&r2=104835&pathrev=104836
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/mock_render_thread.h?r1=104836&r2=104835&pathrev=104836
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.h?r1=104836&r2=104835&pathrev=104836
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_thread.cc?r1=104836&r2=104835&pathrev=104836
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_dispatcher_delegate.cc?r1=104836&r2=104835&pathrev=104836 (from /trunk/src/content/common/resource_dispatcher_delegate.cc revision 104831)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_dispatcher.cc?r1=104836&r2=104835&pathrev=104836
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/resource_dispatcher_delegate.h?r1=104836&r2=104835&pathrev=104836
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/DEPS?r1=104836&r2=104835&pathrev=104836
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_process_observer.h?r1=104836&r2=104835&pathrev=104836
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_process_observer.cc?r1=104836&r2=104835&pathrev=104836
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_dispatcher.h?r1=104836&r2=104835&pathrev=104836
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_thread.h?r1=104836&r2=104835&pathrev=104836
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=104836&r2=104835&pathrev=104836
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_dispatcher_delegate.h?r1=104836&r2=104835&pathrev=104836 (from /trunk/src/content/common/resource_dispatcher_delegate.h revision 104831)

Revert 104832 - Move ResourceDispatcherHostDelegate to content\public\common. I've added a set delegate function on ChildThread (which will soon be on content::ChildThread interface) so that we don't have to expose ResourceDispatcher to embedders.

BUG=98716
Review URL: http://codereview.chromium.org/8224019

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8226015
------------------------------------------------------------------------
Project Member Comment 17 by bugdroid1@chromium.org, Oct 12 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104917

------------------------------------------------------------------------
r104917 | jam@chromium.org | Tue Oct 11 11:13:21 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/child_process_security_policy.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/DEPS?r1=104917&r2=104916&pathrev=104917
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/bindings_policy.h?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_render_view_host_observer.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/enterprise_enrollment_ui.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/DEPS?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_view.cc?r1=104917&r2=104916&pathrev=104917
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/bindings_policy.h?r1=104917&r2=104916&pathrev=104917 (from /trunk/src/content/common/bindings_policy.h revision 104826)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/webui/web_ui.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_web_ui.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_ui.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=104917&r2=104916&pathrev=104917
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=104917&r2=104916&pathrev=104917

Move BindingsPolicy enum to content\public\common and put it in the content namespace. I've also renamed the value names to match the style that we use in the WebKit API (i.e. all values in an enum start with the enum's name) since it's more readable. As we move other enums to public we should switch them over as well.

BUG=98716
Review URL: http://codereview.chromium.org/8220024
------------------------------------------------------------------------
Project Member Comment 18 by bugdroid1@chromium.org, Oct 12 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104973

------------------------------------------------------------------------
r104973 | jam@chromium.org | Tue Oct 11 18:10:15 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_process_observer.h?r1=104973&r2=104972&pathrev=104973
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.cc?r1=104973&r2=104972&pathrev=104973
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/mock_render_thread.cc?r1=104973&r2=104972&pathrev=104973
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/mock_render_thread.h?r1=104973&r2=104972&pathrev=104973
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.h?r1=104973&r2=104972&pathrev=104973
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_process_observer.cc?r1=104973&r2=104972&pathrev=104973
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_dispatcher_delegate.cc?r1=104973&r2=104972&pathrev=104973
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_dispatcher.h?r1=104973&r2=104972&pathrev=104973
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_thread.h?r1=104973&r2=104972&pathrev=104973
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=104973&r2=104972&pathrev=104973
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/resource_dispatcher_delegate.h?r1=104973&r2=104972&pathrev=104973 (from /trunk/src/content/common/resource_dispatcher_delegate.h revision 104911)
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_dispatcher_delegate.h?r1=104973&r2=104972&pathrev=104973
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_dispatcher.cc?r1=104973&r2=104972&pathrev=104973

Move ResourceDispatcherHostDelegate to content\public\common. I've added a set delegate function on ChildThread (which will soon be on content::ChildThread interface) so that we don't have to expose ResourceDispatcher to embedders. 

BUG=98716
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104832
Review URL: http://codereview.chromium.org/8224019
------------------------------------------------------------------------
Project Member Comment 19 by bugdroid1@chromium.org, Oct 12 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104972

------------------------------------------------------------------------
r104972 | jam@chromium.org | Tue Oct 11 17:51:00 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/benchmarking_extension.cc?r1=104972&r2=104971&pathrev=104972

Make benchmarking_extension.cc use content::RenderThread interface instead of ChildThread, since it's the only chrome user of ChildThread. Thi way we don't have to expose it.

BUG=98716
Review URL: http://codereview.chromium.org/8231014
------------------------------------------------------------------------
Project Member Comment 20 by bugdroid1@chromium.org, Oct 12 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105083

------------------------------------------------------------------------
r105083 | jam@chromium.org | Wed Oct 12 08:53:56 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.h?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_process_bindings.cc?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/background_contents.h?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host_mac.mm?r1=105083&r2=105082&pathrev=105083
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/view_types.h?r1=105083&r2=105082&pathrev=105083 (from /trunk/src/content/common/view_types.h revision 104917)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.h?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_process_manager.h?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details.cc?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_process_manager.cc?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager.cc?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host_mac.h?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_resource_providers.cc?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/background_contents.cc?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.cc?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_delegate.h?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_view_types.cc?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_helper.cc?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=105083&r2=105082&pathrev=105083
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_types.h?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/extension_settings_handler.cc?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_helper.h?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_view_types.h?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_bookmark_manager_api.cc?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_messages.h?r1=105083&r2=105082&pathrev=105083
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=105083&r2=105082&pathrev=105083

Move view_types to content\public\common. Also update the enum values to match the convention that we're using for the Content API.

BUG=98716
Review URL: http://codereview.chromium.org/8232024
------------------------------------------------------------------------
Project Member Comment 21 by bugdroid1@chromium.org, Oct 12 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105128

------------------------------------------------------------------------
r105128 | ananta@chromium.org | Wed Oct 12 11:53:34 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/DEPS?r1=105128&r2=105127&pathrev=105128
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/chrome_content_plugin_client.h?r1=105128&r2=105127&pathrev=105128
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_plugin_client.h?r1=105128&r2=105127&pathrev=105128
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_plugin.gypi?r1=105128&r2=105127&pathrev=105128
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/DEPS?r1=105128&r2=105127&pathrev=105128
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/plugin_carbon_interpose_mac.cc?r1=105128&r2=105127&pathrev=105128 (from /trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc revision 104808)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/plugin_thread.cc?r1=105128&r2=105127&pathrev=105128
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=105128&r2=105127&pathrev=105128
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/plugin/content_plugin_client.h?r1=105128&r2=105127&pathrev=105128 (from /trunk/src/content/plugin/content_plugin_client.h revision 104808)
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/content_plugin_client.h?r1=105128&r2=105127&pathrev=105128
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/plugin?r1=105128&r2=105127&pathrev=105128
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc?r1=105128&r2=105127&pathrev=105128

Move content_plugin_client.h to content\public\plugin.

The plugin_carbon_interpose_mac.cc which intercepts system API's in plugin processes on the Mac has been moved to

content\plugin. The plugin_carbon_interpose shared library target which lives in chrome.gyp refers to this file.

This is a short term workaround while we look into switching the interposing mechanism on the mac.

Changes as part of creating a Content API

BUG=98716
Review URL: http://codereview.chromium.org/8224021
------------------------------------------------------------------------
Project Member Comment 22 by bugdroid1@chromium.org, Oct 13 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105389

------------------------------------------------------------------------
r105389 | jam@chromium.org | Thu Oct 13 15:20:29 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_child_thread.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/intents/intent_injector.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_service.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_widget.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/pepper_plugin_delegate_impl.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_thread.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/zygote_main_linux.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_main_platform_delegate_win.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_policy.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/debug_flags.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/file_system/file_system_browsertest.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_mac.mm?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/backing_store_win.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/app/content_main.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service_browsertest.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/npobject_stub.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_init_wrapper_win.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_process_host.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/indexed_db_context.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/ppapi_plugin/ppapi_broker_main.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/backing_store_manager.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/devtools_agent.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_broker_listener.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/core_location_provider_mac.mm?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/child_process_launcher.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/plugin_thread.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/devtools_client.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/content_settings_handler.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_data_manager.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/dom_storage_uitest.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/indexed_db_browsertest.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_main_platform_delegate_linux.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host.cc?r1=105389&r2=105388&pathrev=105389
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_switches.cc?r1=105389&r2=105388&pathrev=105389 (from /trunk/src/content/common/content_switches.cc revision 105328)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/gpu/webgl_conformance_tests.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/browser_render_process_host.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_view_gtk.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/npapi_uitest.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_view_win.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/ppapi_uitest.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/webworkerclient_proxy.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_init_wrapper_mac.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/worker_thread.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/seccomp_sandbox.h?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/pepper_plugin_registry.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_input_browsertest.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_exe.gypi?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main.cc?r1=105389&r2=105388&pathrev=105389
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/content_switches.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/file_system/browser_file_system_helper.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_process_host.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/webplugin_delegate_stub.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/host_content_settings_map.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/mach_broker_mac.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/ppapi_plugin/ppapi_thread.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/mac/relauncher.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_main.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/utility_main.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/device_orientation/device_orientation_browsertest.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_process_impl.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/win7_location_api_win.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/gpu_channel.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_host.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/plugin_main.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_main.cc?r1=105389&r2=105388&pathrev=105389
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/content_switches.h?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/webkit_thread.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_main_delegate.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_glue.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ppapi_plugin_process_host.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/plugin_channel.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/media/audio_renderer_impl.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/utility/chrome_content_utility_client.cc?r1=105389&r2=105388&pathrev=105389
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_switches.h?r1=105389&r2=105388&pathrev=105389 (from /trunk/src/content/common/content_switches.h revision 105328)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_process_host.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_browsertest.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/handle_enumerator_win.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/utility_process_host.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browsing_instance.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_ppapi_interfaces.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/magic_iframe_browsertest.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_main_platform_delegate_mac.mm?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/content_test_launcher.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_main_delegate.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/ppapi_plugin/ppapi_plugin_main.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_accessibility.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/zygote_host_linux.cc?r1=105389&r2=105388&pathrev=105389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/benchmarking_extension.cc?r1=105389&r2=105388&pathrev=105389

Move content_switches to content\public\common.

BUG=98716
Review URL: http://codereview.chromium.org/8277018
------------------------------------------------------------------------
Project Member Comment 23 by bugdroid1@chromium.org, Oct 13 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105398

------------------------------------------------------------------------
r105398 | ananta@chromium.org | Thu Oct 13 15:51:28 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/utility/chrome_content_utility_client.h?r1=105398&r2=105397&pathrev=105398
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/DEPS?r1=105398&r2=105397&pathrev=105398
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/utility_thread.cc?r1=105398&r2=105397&pathrev=105398
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_utility_client.h?r1=105398&r2=105397&pathrev=105398
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/utility/DEPS?r1=105398&r2=105397&pathrev=105398
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/utility/content_utility_client.h?r1=105398&r2=105397&pathrev=105398 (from /trunk/src/content/utility/content_utility_client.h revision 105122)
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/content_utility_client.h?r1=105398&r2=105397&pathrev=105398
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_utility.gypi?r1=105398&r2=105397&pathrev=105398

Move content_utility_client.h to content\public\utility.

Changes as part of creating a Content API.

BUG=98716
TEST=No change in functionality.
Review URL: http://codereview.chromium.org/8252005
------------------------------------------------------------------------
Project Member Comment 24 by bugdroid1@chromium.org, Oct 14 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105508

------------------------------------------------------------------------
r105508 | jam@chromium.org | Fri Oct 14 10:14:03 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/child_process_security_policy.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/test_url_constants.h?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/child_process_security_policy_unittest.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/base_panel_browser_test.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/webplugin_proxy.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_manager_browsertest.cc?r1=105508&r2=105507&pathrev=105508
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/url_constants.h?r1=105508&r2=105507&pathrev=105508 (from /trunk/src/content/common/url_constants.h revision 105389)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drag_dest_gtk.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_policy.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host_uitest.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_browsertest.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/net/url_request_mock_http_job.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/drag_util.mm?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller_unittest.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_url_handler.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/omnibox/omnibox_view.h?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_glue.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=105508&r2=105507&pathrev=105508
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/url_constants.h?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/about_handler.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tab_contents/web_drag_source.mm?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_permission_set.cc?r1=105508&r2=105507&pathrev=105508
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/url_constants.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/web_socket_proxy_controller.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_content_settings_helpers.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/site_instance.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browsing_instance.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/site_instance_unittest.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.h?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model_unittest.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/web_socket_proxy.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/apps_promo.cc?r1=105508&r2=105507&pathrev=105508
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/url_constants.cc?r1=105508&r2=105507&pathrev=105508 (from /trunk/src/content/common/url_constants.cc revision 105389)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_browsertest.cc?r1=105508&r2=105507&pathrev=105508
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/test/worker_uitest.cc?r1=105508&r2=105507&pathrev=105508

Move url_constansts.h to content/public/common.

BUG=98716
Review URL: http://codereview.chromium.org/8276022
------------------------------------------------------------------------
Project Member Comment 25 by bugdroid1@chromium.org, Oct 14 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105610

------------------------------------------------------------------------
r105610 | ananta@chromium.org | Fri Oct 14 16:29:48 PDT 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/utility/utility_thread.cc?r1=105610&r2=105609&pathrev=105610
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/utility_thread.cc?r1=105610&r2=105609&pathrev=105610
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/utility_main.cc?r1=105610&r2=105609&pathrev=105610
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/utility/utility_thread.h?r1=105610&r2=105609&pathrev=105610
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/utility_thread.h?r1=105610&r2=105609&pathrev=105610
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/utility/DEPS?r1=105610&r2=105609&pathrev=105610
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/utility/chrome_content_utility_client.cc?r1=105610&r2=105609&pathrev=105610
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/utility_thread_impl.cc?r1=105610&r2=105609&pathrev=105610 (from /trunk/src/content/utility/utility_thread.cc revision 105398)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_utility.gypi?r1=105610&r2=105609&pathrev=105610
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/utility_thread_impl.h?r1=105610&r2=105609&pathrev=105610 (from /trunk/src/content/utility/utility_thread.h revision 105122)

Create content::UtilityThread interface and make chrome code use that. This interface is implemented

by the UtilityThreadImpl class in content\utility\utility_thread_impl.cc/.h which are renamed incarnations

of the content\utility\utility_thread.cc/.h files.

Changes as part of creating a content API.

BUG=98716
TEST=No change in functionality.
Review URL: http://codereview.chromium.org/8276026
------------------------------------------------------------------------
Project Member Comment 26 by bugdroid1@chromium.org, Oct 15 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105666

------------------------------------------------------------------------
r105666 | jam@chromium.org | Sat Oct 15 09:20:37 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.cc?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.h?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_load_histograms.cc?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/mock_render_thread.h?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/chrome_v8_extension_handler.cc?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/content_settings_observer.cc?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.cc?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/frame_sniffer.cc?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_click_tracker.cc?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_view_observer.h?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_click_tracker.h?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_process_observer.cc?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/blocked_plugin.cc?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_thread.h?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_load_histograms.h?r1=105666&r2=105665&pathrev=105666
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/mock_render_thread.cc?r1=105666&r2=105665&pathrev=105666

Get rid of view_messages.h includes in chrome\renderer.

BUG=98716
Review URL: http://codereview.chromium.org/8294007
------------------------------------------------------------------------
Project Member Comment 27 by bugdroid1@chromium.org, Oct 17 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105851

------------------------------------------------------------------------
r105851 | jam@chromium.org | Mon Oct 17 11:16:08 PDT 2011

Changed paths:
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/java_bridge_channel.cc?r1=105851&r2=105850&pathrev=105851
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_renderer.gypi?r1=105851&r2=105850&pathrev=105851
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=105851&r2=105850&pathrev=105851
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/java_bridge_channel.h?r1=105851&r2=105850&pathrev=105851 (from /trunk/src/chrome/renderer/java_bridge_channel.h revision 105821)
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/java_bridge_channel_host.cc?r1=105851&r2=105850&pathrev=105851 (from /trunk/src/chrome/browser/renderer_host/java_bridge_channel_host.cc revision 105821)
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/java_bridge_channel_host.h?r1=105851&r2=105850&pathrev=105851 (from /trunk/src/chrome/browser/renderer_host/java_bridge_channel_host.h revision 105821)
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/java_bridge_channel.cc?r1=105851&r2=105850&pathrev=105851 (from /trunk/src/chrome/renderer/java_bridge_channel.cc revision 105821)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_renderer.gypi?r1=105851&r2=105850&pathrev=105851
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=105851&r2=105850&pathrev=105851
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/java_bridge_channel.h?r1=105851&r2=105850&pathrev=105851
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/java_bridge_channel_host.h?r1=105851&r2=105850&pathrev=105851
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/java_bridge_channel_host.cc?r1=105851&r2=105850&pathrev=105851

Move the java channel code to content. As discussed, we don't want to expose the plugin and npobject internals to embedders.

BUG=98716
Review URL: http://codereview.chromium.org/8317010
------------------------------------------------------------------------
Project Member Comment 28 by bugdroid1@chromium.org, Oct 17 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105956

------------------------------------------------------------------------
r105956 | jam@chromium.org | Mon Oct 17 16:19:57 PDT 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_sandbox_support_impl_linux.h?r1=105956&r2=105955&pathrev=105956 (from /trunk/src/content/common/child_process_sandbox_support_linux.h revision 105884)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/DEPS?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/support/webkit_support_glue.cc?r1=105956&r2=105955&pathrev=105956
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_sandbox_support_impl_linux.cc?r1=105956&r2=105955&pathrev=105956 (from /trunk/src/content/common/child_process_sandbox_support_linux.cc revision 105884)
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webkit_glue.h?r1=105956&r2=105955&pathrev=105956
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/child_process_sandbox_support_linux.h?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_listener.cc?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell.cc?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_ppb_pdf_impl.cc?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/content_settings_observer.cc?r1=105956&r2=105955&pathrev=105956
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_sandbox_support_linux.cc?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_view_test.h?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/DEPS?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/DEPS?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/content_settings_observer_browsertest.cc?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_mock_render_thread.cc?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/ppapi_plugin/ppapi_webkitplatformsupport_impl.cc?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_view_test.cc?r1=105956&r2=105955&pathrev=105956
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_sandbox_support_linux.h?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=105956&r2=105955&pathrev=105956
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_glue.cc?r1=105956&r2=105955&pathrev=105956

Create a public header with the child_process_sandbox_support_linux functions that are used in chrome. Also move everything to the content namespace, now that we have one. This gets rid of the last content/common includes from chrome/renderer and so I've tightened up the DEPS.

Also get rid of the webkit_glue versions of the font functions since they weren't used anymore.

BUG=98716
Review URL: http://codereview.chromium.org/8319017
------------------------------------------------------------------------
Project Member Comment 29 by bugdroid1@chromium.org, Oct 18 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106028

------------------------------------------------------------------------
r106028 | jam@chromium.org | Mon Oct 17 21:29:16 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_notification_types.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_message_service.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/auto_login_prompter.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_bubble_controller.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/notification_registrar.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prefs/pref_change_registrar_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/wrench_menu.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_change_processor.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/notification_service_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/notification_service.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_resource_tracker.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/tab_first_render_watcher.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/accessibility/renderer_accessibility_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/accessibility_events.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.h?r1=106028&r2=106027&pathrev=106028
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/content_notification_types.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/crash_recovery_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/render_view_devtools_agent_host.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertest.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/download/download_started_animation_mac.mm?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_service.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/web_applications/web_app_ui.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/search_provider_install_state_message_filter.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/oom_priority_manager_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_cloud.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/content_settings_handler.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_host.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_notification_tracker.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/status/input_method_menu.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/download/download_started_animation_win.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/notification_service.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_save_page_api.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/core_options_handler.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/file_select_helper.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drag_source_win.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/options_ui.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/dom_view_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/mhtml_generation_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/theme_change_processor.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/history_quick_provider.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/info_bubble_window.mm?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tab_contents_container_gtk.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/panels/panel_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/login_performer.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_navigator_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/DEPS?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/status/clock_menu_button.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_html_dialog_observer.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/locale_change_guard.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_process_host.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/thumbnail_generator_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prefs/pref_observer_mock.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_host.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/input_method/input_method_manager.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/in_process_browser_test.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/template_url_fetcher_ui_callbacks.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_processes_api.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/media/media_player.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/user_style_sheet_watcher.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/accessibility/accessibility_win_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/notification_observer_mock.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/data_type_manager_mock.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/login_html_dialog.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_resource/web_resource_service.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/personal_data_manager_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/DEPS?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_install_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/off_the_record_profile_impl_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/oom_priority_manager.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/background/background_mode_manager.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/content_setting_bubble_gtk.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/web_ui_test_handler.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/user_metrics.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/web_intent_picker_gtk.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_manager_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/profile_image_downloader.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/webdata/autofill_profile_syncable_service.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_id_map.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/offline/offline_load_page.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/host_zoom_map.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_process_host.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/notifications/balloon_view.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_navigator_browsertest.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/status/memory_menu_button.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_test_util.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/cros_settings.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/file_manager_dialog_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/content_setting_bubble_contents.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/visitedlink/visitedlink_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/html_dialog_view.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_blocking_page.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/web_socket_proxy.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/wrench_menu_model.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/sync_backend_host_mock.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/popup_menu_helper_mac.mm?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/app_controller_mac.mm?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/test_navigation_observer.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_omnibox_apitest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/omnibox_search_hint.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_view_win.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/repost_form_warning_gtk.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/background/background_application_list_model_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/media/media_internals_proxy.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_input_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/wizard_controller.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/typed_url_change_processor.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/mach_broker_mac.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/tab_contents_container.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/base_bubble_controller.mm?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/worker_devtools_manager.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/base_login_display_host.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/advanced_options_handler.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cookies_tree_model_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/dragged_tab_controller.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/cloud_print_signin_dialog.cc?r1=106028&r2=106027&pathrev=106028
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/notification_types.h?r1=106028&r2=106027&pathrev=106028 (from /trunk/src/content/common/content_notification_types.h revision 105938)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ppapi_plugin_process_host.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/save_page_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/enterprise_extension_observer.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prefs/pref_set_observer.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/visitedlink/visitedlink_event_listener.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_cloud_uitest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/mhtml_generation_manager.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/options_ui.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/appcache/chrome_appcache_service.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/wizard_accessibility_handler.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/site_instance.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/password_change_processor.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/extension_settings_handler.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/cert_store.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.h?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/repost_form_warning_controller.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/restore_tab_helper.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_host_impl.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_cloud_unittest.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/download/download_started_animation_gtk.cc?r1=106028&r2=106027&pathrev=106028
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=106028&r2=106027&pathrev=106028

Move content_notification_types.h from content\common to content\public\browser. I dropped the "content" from the name to match other files whose chrome version adds a "chrome_" prefix. I also moved it to the browser directory since notifications are only used in the browser process. I will move the other notification files in future changes.

BUG=98716
Review URL: http://codereview.chromium.org/8331001
------------------------------------------------------------------------
Project Member Comment 30 by bugdroid1@chromium.org, Oct 18 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106029

------------------------------------------------------------------------
r106029 | jam@chromium.org | Mon Oct 17 21:37:24 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/language_state.cc?r1=106029&r2=106028&pathrev=106029
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/navigation_types.h?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/eula_view.h?r1=106029&r2=106028&pathrev=106029
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/navigation_types.h?r1=106029&r2=106028&pathrev=106029 (from /trunk/src/content/common/navigation_types.h revision 105956)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_active_document.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_view.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller_unittest.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.h?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_details.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/eula_view.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.h?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.h?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/automation_messages_internal.h?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller_unittest.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.h?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_details.h?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_screen.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_screen.h?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_tab_contents_delegate.h?r1=106029&r2=106028&pathrev=106029
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_browsertest.cc?r1=106029&r2=106028&pathrev=106029

Move navigation_types.h from content/common to content/public/browser, and put it in the content namespace. There was no reason for it to be in common since it's only used by browser. I also updated the enum names to match the rest of the enums in the Content API.


BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8339006
------------------------------------------------------------------------
Project Member Comment 31 by bugdroid1@chromium.org, Oct 18 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106054

------------------------------------------------------------------------
r106054 | nkostylev@chromium.org | Tue Oct 18 04:24:00 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/language_state.cc?r1=106054&r2=106053&pathrev=106054
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/navigation_types.h?r1=106054&r2=106053&pathrev=106054 (from /trunk/src/content/common/navigation_types.h revision 106028)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/eula_view.h?r1=106054&r2=106053&pathrev=106054
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/navigation_types.h?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_active_document.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_view.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller_unittest.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.h?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_details.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/eula_view.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.h?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.h?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/automation_messages_internal.h?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller_unittest.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.h?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_details.h?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_screen.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_screen.h?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_tab_contents_delegate.h?r1=106054&r2=106053&pathrev=106054
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_browsertest.cc?r1=106054&r2=106053&pathrev=106054

Revert 106029
Broke http://build.chromium.org/p/chromium.perf/console
Move navigation_types.h from content/common to content/public/browser, and put it in the content namespace. There was no reason for it to be in common since it's only used by browser. I also updated the enum names to match the rest of the enums in the Content API.


BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8339006

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8333018
------------------------------------------------------------------------
Project Member Comment 32 by bugdroid1@chromium.org, Oct 18 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106070

------------------------------------------------------------------------
r106070 | jam@chromium.org | Tue Oct 18 09:35:08 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/language_state.cc?r1=106070&r2=106069&pathrev=106070
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/navigation_types.h?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/eula_view.h?r1=106070&r2=106069&pathrev=106070
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/navigation_types.h?r1=106070&r2=106069&pathrev=106070 (from /trunk/src/content/common/navigation_types.h revision 106062)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_active_document.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_view.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller_unittest.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.h?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_details.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/eula_view.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.h?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.h?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/automation_messages_internal.h?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller_unittest.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.h?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_details.h?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_screen.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_screen.h?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_tab_contents_delegate.h?r1=106070&r2=106069&pathrev=106070
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_browsertest.cc?r1=106070&r2=106069&pathrev=106070

Move navigation_types.h from content/common to content/public/browser, and put it in the content namespace. There was no reason for it to be in common since it's only used by browser. I also updated the enum names to match the rest of the enums in the Content API.


BUG=98716
TBR=joi
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106029
Review URL: http://codereview.chromium.org/8339006
------------------------------------------------------------------------
Project Member Comment 33 by bugdroid1@chromium.org, Oct 18 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106076

------------------------------------------------------------------------
r106076 | jam@chromium.org | Tue Oct 18 10:08:53 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.cc?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_browser_tests.cc?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/automation/tab_proxy.h?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/automation/tab_proxy.cc?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/automation_messages_internal.h?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller_unittest.cc?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/automation_messages.h?r1=106076&r2=106075&pathrev=106076
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/page_type.h?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry.cc?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model.cc?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.h?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry_unittest.cc?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry.h?r1=106076&r2=106075&pathrev=106076
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/page_type.h?r1=106076&r2=106075&pathrev=106076 (from /trunk/src/content/common/page_type.h revision 106029)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106076&r2=106075&pathrev=106076
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/automation_messages.cc?r1=106076&r2=106075&pathrev=106076

Move the PageType enum to content/public/common, put it into the content namespace, and also make it conform to the Content API enum naming convention.

BUG=98716
TBR=ananta
Review URL: http://codereview.chromium.org/8336013
------------------------------------------------------------------------
Project Member Comment 34 by bugdroid1@chromium.org, Oct 18 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106167

------------------------------------------------------------------------
r106167 | joi@chromium.org | Tue Oct 18 16:35:38 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_child_thread.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/net/fake_external_tab.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/arbitrator_dependency_factory.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_service.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_client.h?r1=106167&r2=106166&pathrev=106167
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/content_client.cc?r1=106167&r2=106166&pathrev=106167
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/content_client.h?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/test_render_view_host.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/pepper_plugin_registry.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/webplugin_proxy.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_policy.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/webworker_proxy.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/webplugin_delegate_stub.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.cc?r1=106167&r2=106166&pathrev=106167
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_client.h?r1=106167&r2=106166&pathrev=106167 (from /trunk/src/content/common/content_client.h revision 106163)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/content_browser_client.h?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/swapped_out_messages.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/gpu_channel.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/npobject_stub.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_manager.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_glue.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/accessibility/browser_accessibility_cocoa.mm?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/sync_backend_host.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_content_client.h?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/plugin/content_plugin_client.h?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/content_renderer_client.h?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_url_request_context.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/content_test_suite.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_content_client.h?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/webworker_stub.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_data_manager.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/site_instance.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browsing_instance.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/site_instance_unittest.cc?r1=106167&r2=106166&pathrev=106167
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_client.cc?r1=106167&r2=106166&pathrev=106167 (from /trunk/src/content/common/content_client.cc revision 106163)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_main_delegate.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/http_bridge.cc?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/utility/content_utility_client.h?r1=106167&r2=106166&pathrev=106167
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/chromeos/about_page_handler.cc?r1=106167&r2=106166&pathrev=106167

Move content_client.h into content/public.

TBR=jam@chromium.org
BUG=98716
TEST=it builds

Review URL: http://codereview.chromium.org/8336007
------------------------------------------------------------------------
Project Member Comment 35 by bugdroid1@chromium.org, Oct 19 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106203

------------------------------------------------------------------------
r106203 | jam@chromium.org | Tue Oct 18 20:07:55 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/history_quick_provider.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/background/background_application_list_model.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/status/clock_menu_button.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_container.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_storage.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/content_settings_policy_provider.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/content_settings_default_provider.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/frame/layout_mode_button.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/shortcuts_backend.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webstore_private_api.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/importer_host.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/profile_image_downloader.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/host_content_settings_map.cc?r1=106203&r2=106202&pathrev=106203
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/notification_source.h?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_tab_tracker.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_resource_tracker.h?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/tab_first_render_watcher.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/locale_change_guard.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/preferences.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_process_apitest.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/enterprise_extension_observer.h?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_installer.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_browser_tracker.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/chrome_download_manager_delegate.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/keyword_provider.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/cros_settings.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/media/media_player.h?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/in_memory_history_backend.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/personal_data_manager.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/notifications/notification_panel.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/wizard_accessibility_handler.h?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_html_writer.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager.cc?r1=106203&r2=106202&pathrev=106203
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/notification_source.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/content_settings_pref_provider.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/wizard_accessibility_handler.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_updater.cc?r1=106203&r2=106202&pathrev=106203
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_infobar_delegate.cc?r1=106203&r2=106202&pathrev=106203

Move notification_source from content/common to content/browser/public and put it into the content namespace.

BUG=98716
------------------------------------------------------------------------
Project Member Comment 36 by bugdroid1@chromium.org, Oct 19 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106323

------------------------------------------------------------------------
r106323 | joi@chromium.org | Wed Oct 19 11:07:44 PDT 2011

Changed paths:
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/window_container_type.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/mock_content_browser_client.h?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_input_dispatcher_host.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main_unittest.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_client_auth_handler.cc?r1=106323&r2=106322&pathrev=106323
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/window_container_type.cc?r1=106323&r2=106322&pathrev=106323 (from /trunk/src/content/common/window_container_type.cc revision 106320)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/x509_user_cert_resource_handler.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/buffered_resource_handler.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_policy.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_process_host.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/render_view_devtools_agent_host.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/extensions/extension_view.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/child_process_launcher.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_manager_unittest.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.h?r1=106323&r2=106322&pathrev=106323
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/window_container_type.h?r1=106323&r2=106322&pathrev=106323 (from /trunk/src/content/common/window_container_type.h revision 106320)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/clipboard_message_filter.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_item.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_browser_client.h?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/socket_stream_dispatcher_host.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/arbitrator_dependency_factory.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/browser_render_process_host.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/background/background_contents_service.h?r1=106323&r2=106322&pathrev=106323
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/content_browser_client.h?r1=106323&r2=106322&pathrev=106323 (from /trunk/src/content/browser/content_browser_client.h revision 106320)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_view_win.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_messages.h?r1=106323&r2=106322&pathrev=106323
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/window_container_type.h?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=106323&r2=106322&pathrev=106323
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/content_browser_client.h?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_url_handler.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_netlog_observer.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_manager.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.h?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/background_contents.h?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_delegate.h?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/webui/web_ui_factory.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/web_drag_source_gtk.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_process_host.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/appcache/chrome_appcache_service.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_unittest.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/utility_process_host.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/site_instance.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browsing_instance.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_helper.h?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/notifications/balloon_view_host.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/base_file.cc?r1=106323&r2=106322&pathrev=106323
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/zygote_host_linux.cc?r1=106323&r2=106322&pathrev=106323

Move content_browser_client.h to public, and while at it, move
window_container_type.h as well since it is included by
content_browser_client.h

BUG=98716
TEST=it builds + existing tests

Review URL: http://codereview.chromium.org/8346017
------------------------------------------------------------------------
Project Member Comment 37 by bugdroid1@chromium.org, Oct 20 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106456

------------------------------------------------------------------------
r106456 | joi@chromium.org | Wed Oct 19 22:24:17 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.cc?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_file_manager.cc?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/chrome_download_manager_delegate.h?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager.cc?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager.h?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.h?r1=106456&r2=106455&pathrev=106456
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/download_manager_delegate.h?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/mock_download_manager_delegate.h?r1=106456&r2=106455&pathrev=106456
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/resource_dispatcher_host_delegate.h?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/sync_resource_handler.cc?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_download_manager_delegate.h?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/mock_download_manager.h?r1=106456&r2=106455&pathrev=106456
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host_delegate.h?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/buffered_resource_handler.cc?r1=106456&r2=106455&pathrev=106456
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager_delegate.h?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/async_resource_handler.cc?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_item.cc?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_context.h?r1=106456&r2=106455&pathrev=106456
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h?r1=106456&r2=106455&pathrev=106456

Move ResourceDispatcherHostDelegate and DownloadManagerDelegate to /public/.

To avoid proliferation of folders, drop the /download/ and
/render_host/ bits of those files' original paths when moving to
/public/.

BUG=98716
TEST=it builds


Review URL: http://codereview.chromium.org/8352023
------------------------------------------------------------------------
Project Member Comment 38 by bugdroid1@chromium.org, Oct 20 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106549

------------------------------------------------------------------------
r106549 | joi@chromium.org | Thu Oct 20 12:57:05 PDT 2011

Changed paths:
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/app/content_main_delegate.cc?r1=106549&r2=106548&pathrev=106549
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/DEPS?r1=106549&r2=106548&pathrev=106549
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/app/content_main_delegate.h?r1=106549&r2=106548&pathrev=106549 (from /trunk/src/content/app/content_main_delegate.h revision 106544)
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/app/content_main_delegate.h?r1=106549&r2=106548&pathrev=106549
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/app/content_main.cc?r1=106549&r2=106548&pathrev=106549
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_app.gypi?r1=106549&r2=106548&pathrev=106549
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_main_delegate.cc?r1=106549&r2=106548&pathrev=106549
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_main_delegate.cc?r1=106549&r2=106548&pathrev=106549
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_main_delegate.h?r1=106549&r2=106548&pathrev=106549
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_main_delegate.h?r1=106549&r2=106548&pathrev=106549

Move ContentMainDelegate to content/public/.

Mostly a trivial move since the implementation for the class (now
deleted) was do-nothing and the only subclass that didn't have a full
implementation was ShellMainDelegate.

BUG=98716
TEST=it builds + existing tests

Review URL: http://codereview.chromium.org/8356025
------------------------------------------------------------------------
Project Member Comment 39 by bugdroid1@chromium.org, Oct 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106637

------------------------------------------------------------------------
r106637 | jam@chromium.org | Thu Oct 20 16:56:55 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_child_thread.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gpu_pixel_browsertest.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_child_thread.h?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/gpu_message_filter.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_blacklist_unittest.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_process_host.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_blacklist.h?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_dx_diagnostics_win.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/child_process_logging_linux.cc?r1=106637&r2=106636&pathrev=106637
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/gpu_info.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_client.h?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/child_process_logging_mac.mm?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/gpu_info_unittest.cc?r1=106637&r2=106636&pathrev=106637
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/gpu_info.h?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_blacklist.cc?r1=106637&r2=106636&pathrev=106637
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/dx_diag_node.cc?r1=106637&r2=106636&pathrev=106637 (from /trunk/src/content/common/dx_diag_node.cc revision 106527)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_data_manager.h?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_info_collector_linux.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_content_client.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106637&r2=106636&pathrev=106637
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/dx_diag_node.h?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_info_collector_mac.mm?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/child_process_logging.h?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_content_client.cc?r1=106637&r2=106636&pathrev=106637
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/gpu_info.cc?r1=106637&r2=106636&pathrev=106637 (from /trunk/src/content/common/gpu/gpu_info.cc revision 106527)
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/gpu_info.h?r1=106637&r2=106636&pathrev=106637 (from /trunk/src/content/common/gpu/gpu_info.h revision 106527)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_content_client.h?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/child_process_logging_win.cc?r1=106637&r2=106636&pathrev=106637
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/dx_diag_node.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/gpu_channel_manager.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_content_client.h?r1=106637&r2=106636&pathrev=106637
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/dx_diag_node.h?r1=106637&r2=106636&pathrev=106637 (from /trunk/src/content/common/dx_diag_node.h revision 106527)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_data_manager.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/flash_ui.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_info_collector.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/gpu/gpu_channel_host.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_info_collector_win.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/gpu/gpu_channel_host.h?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/gpu_messages.h?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_info_collector_unittest.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_info_collector.h?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_info_collector_unittest_win.cc?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_process_host.h?r1=106637&r2=106636&pathrev=106637
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc?r1=106637&r2=106636&pathrev=106637

Move GPUInfo to content/public/common and put it into the content namespace.

BUG=98716
Review URL: http://codereview.chromium.org/8363007
------------------------------------------------------------------------
Project Member Comment 40 by bugdroid1@chromium.org, Oct 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106642

------------------------------------------------------------------------
r106642 | jam@chromium.org | Thu Oct 20 17:15:04 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_browser_tests.cc?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/automation/tab_proxy.h?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/automation/tab_proxy.cc?r1=106642&r2=106641&pathrev=106642
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/security_style.h?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/automation_messages_internal.h?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/automation_messages.h?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_active_document.cc?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.cc?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry.cc?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model.cc?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_blocking_page.cc?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.h?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_policy.cc?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=106642&r2=106641&pathrev=106642
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/security_style.h?r1=106642&r2=106641&pathrev=106642 (from /trunk/src/content/common/security_style.h revision 106532)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry_unittest.cc?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry.h?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_content_client.cc?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106642&r2=106641&pathrev=106642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/automation_messages.cc?r1=106642&r2=106641&pathrev=106642

Move SecurityStyle enum into content/public/common and put it into the content namespace.BUG=98716
Review URL: http://codereview.chromium.org/8361019
------------------------------------------------------------------------
Project Member Comment 41 by bugdroid1@chromium.org, Oct 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106731

------------------------------------------------------------------------
r106731 | jam@chromium.org | Fri Oct 21 10:33:52 PDT 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/pepper_plugin_info.h?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ppapi_plugin_process_host.cc?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_content_client.cc?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_client.h?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/pepper_plugin_delegate_impl.cc?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_client.cc?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/component_updater/pepper_flash_component_installer.cc?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_content_client.h?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ppapi_plugin_process_host.h?r1=106731&r2=106730&pathrev=106731
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/pepper_plugin_info.cc?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/pepper_plugin_registry.cc?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_content_client.h?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.cc?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service.cc?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_client.h?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service.h?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_content_client.cc?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106731&r2=106730&pathrev=106731
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/pepper_plugin_registry.h?r1=106731&r2=106730&pathrev=106731

Move PepperPluginInfo to content/public/common and put it into the content namespace.

BUG=98716
Review URL: http://codereview.chromium.org/8366027
------------------------------------------------------------------------
Project Member Comment 42 by bugdroid1@chromium.org, Oct 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106744

------------------------------------------------------------------------
r106744 | jam@chromium.org | Fri Oct 21 11:28:15 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/service_process_util_mac.mm?r1=106744&r2=106743&pathrev=106744
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/service_process_util.cc?r1=106744&r2=106743&pathrev=106744

Get rid of ChildProcessHost usage from chrome/common. The service process code didn't use any of the logic in ChildProcessHost to get the path of the current binary, so it can go directly to PathService.

BUG=98716
Review URL: http://codereview.chromium.org/8364029
------------------------------------------------------------------------
Project Member Comment 43 by bugdroid1@chromium.org, Oct 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106766

------------------------------------------------------------------------
r106766 | jam@chromium.org | Fri Oct 21 13:00:41 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/profile_import_process_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/pepper_file_messages.h?r1=106766&r2=106765&pathrev=106766
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/webkit_param_traits.h?r1=106766&r2=106765&pathrev=106766 (from /trunk/src/content/common/webkit_param_traits.h revision 106741)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/clipboard_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_messages.cc?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=106766&r2=106765&pathrev=106766
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/common_param_traits.h?r1=106766&r2=106765&pathrev=106766
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/common_param_traits.cc?r1=106766&r2=106765&pathrev=106766 (from /trunk/src/content/common/common_param_traits.cc revision 106741)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/webblob_messages.h?r1=106766&r2=106765&pathrev=106766
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/webkit_param_traits.cc?r1=106766&r2=106765&pathrev=106766
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/webkit_param_traits.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/java_bridge_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_unpacker.cc?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/drag_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_utility_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/java_bridge_dispatcher.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/dom_storage_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/common_param_traits_unittest.cc?r1=106766&r2=106765&pathrev=106766
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/webkit_param_traits.cc?r1=106766&r2=106765&pathrev=106766 (from /trunk/src/content/common/webkit_param_traits.cc revision 106741)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/file_utilities_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/media/video_capture_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_common.gypi?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/automation_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/autofill_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/utility_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/gpu_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/mime_registry_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/plugin_messages.h?r1=106766&r2=106765&pathrev=106766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/mac/attributed_string_coder.mm?r1=106766&r2=106765&pathrev=106766
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/common_param_traits.cc?r1=106766&r2=106765&pathrev=106766
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/common_param_traits.h?r1=106766&r2=106765&pathrev=106766 (from /trunk/src/content/common/common_param_traits.h revision 106741)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_messages.h?r1=106766&r2=106765&pathrev=106766

Move common_param_traits and webkit_param_traits to content/public/common.

BUG=98716
Review URL: http://codereview.chromium.org/8368004
------------------------------------------------------------------------
Project Member Comment 44 by bugdroid1@chromium.org, Oct 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106781

------------------------------------------------------------------------
r106781 | jam@chromium.org | Fri Oct 21 14:37:47 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/indexed_db_messages.h?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webidbobjectstore_impl.cc?r1=106781&r2=106780&pathrev=106781
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/serialized_script_value.h?r1=106781&r2=106780&pathrev=106781 (from /trunk/src/content/common/serialized_script_value.h revision 106756)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/indexed_db_param_traits.h?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/idbbindingutilities_browsertest.cc?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/utility_thread_impl.h?r1=106781&r2=106780&pathrev=106781
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/serialized_script_value.cc?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/indexed_db_key_utility_client.cc?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/utility_messages.h?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/indexed_db_dispatcher.h?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webidbcursor_impl.cc?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webidbcursor_impl.h?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/indexed_db_dispatcher.cc?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/indexed_db_key_utility_client.h?r1=106781&r2=106780&pathrev=106781
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/serialized_script_value.h?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/utility_thread_impl.cc?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_utility_messages.h?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/indexed_db_dispatcher_host.h?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/indexed_db_param_traits.cc?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/browser_webkitplatformsupport_impl.cc?r1=106781&r2=106780&pathrev=106781
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/indexed_db_callbacks.cc?r1=106781&r2=106780&pathrev=106781
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/serialized_script_value.cc?r1=106781&r2=106780&pathrev=106781 (from /trunk/src/content/common/serialized_script_value.cc revision 106756)

Move SerializedScriptValue to content/public/common and put it into the content namespace.

BUG=98716
Review URL: http://codereview.chromium.org/8372009
------------------------------------------------------------------------
Project Member Comment 45 by bugdroid1@chromium.org, Oct 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106783

------------------------------------------------------------------------
r106783 | jam@chromium.org | Fri Oct 21 14:44:38 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/content_message_generator.h?r1=106783&r2=106782&pathrev=106783
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106783&r2=106782&pathrev=106783
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/pepper_messages.cc?r1=106783&r2=106782&pathrev=106783

Make pepper_messages.h be included by content's message_generator instead of all_messages.h in chrome.

BUG=98716
Review URL: http://codereview.chromium.org/8365023
------------------------------------------------------------------------
Project Member Comment 46 by bugdroid1@chromium.org, Oct 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106795

------------------------------------------------------------------------
r106795 | jam@chromium.org | Fri Oct 21 15:26:14 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/gtk_key_bindings_handler_unittest.cc?r1=106795&r2=106794&pathrev=106795
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/net/fake_external_tab.cc?r1=106795&r2=106794&pathrev=106795
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/mac/relauncher.cc?r1=106795&r2=106794&pathrev=106795
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/app/content_main.cc?r1=106795&r2=106794&pathrev=106795
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_paths.h?r1=106795&r2=106794&pathrev=106795 (from /trunk/src/content/common/content_paths.h revision 106767)
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/content_paths.h?r1=106795&r2=106794&pathrev=106795
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_main_delegate.cc?r1=106795&r2=106794&pathrev=106795
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_host.cc?r1=106795&r2=106794&pathrev=106795
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/content_test_suite.cc?r1=106795&r2=106794&pathrev=106795
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106795&r2=106794&pathrev=106795
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/service_process_util.cc?r1=106795&r2=106794&pathrev=106795
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/chrome_test_suite.cc?r1=106795&r2=106794&pathrev=106795
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/content_paths.cc?r1=106795&r2=106794&pathrev=106795

Move content_paths.h to content/public/common.

BUG=98716
TBR=avi
Review URL: http://codereview.chromium.org/8375007
------------------------------------------------------------------------
Project Member Comment 47 by bugdroid1@chromium.org, Oct 24 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106949

------------------------------------------------------------------------
r106949 | jam@chromium.org | Mon Oct 24 11:18:34 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/download_protection_service.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/image_downloader.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/customization_document.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_browsertest.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/auth_response_handler.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/profile_image_downloader.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/spelling_menu_observer.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/apps_promo.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/testing_policy_url_fetcher_factory.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/spelling_menu_observer.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher_unittest.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_download_helper.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/issue_response_handler.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/customization_document.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/intranet_redirect_detector.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/client_login_response_handler.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_url_fetcher_factory.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/toolbar_importer.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/search_provider.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_service.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_service.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/image_downloader.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/download_protection_service.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/client_login_response_handler.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/alternate_nav_url_fetcher.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker_unittest.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_install_helper.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/protocol_manager.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/network_location_request.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/issue_response_handler.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/http_bridge.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/gaia/service_gaia_authenticator.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/template_url_fetcher.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_notify_channel_setup.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/testing_policy_url_fetcher_factory.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/cookie_fetcher.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/apps_promo.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_updater.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/gaia/service_gaia_authenticator.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/http_bridge.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/protocol_manager.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/alternate_nav_url_fetcher.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_service.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/test/integration/sync_test.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_service_unittest.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher_unittest.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_service.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_url_fetcher_factory.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognition_request.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/mock_url_fetchers.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/cloud_print_url_fetcher.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_resource/web_resource_service.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details_cache.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/cookie_fetcher.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bug_report_util.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/gaia/gaia_oauth_fetcher.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/profile_image_downloader.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/cloud_print_url_fetcher.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_test.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_backend_impl.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/mock_url_fetchers.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_install_helper.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognition_request.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/component_updater/component_updater_service.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/search_provider.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/toolbar_importer.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_service_browsertest.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_common.gypi?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/intranet_redirect_detector.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_host_impl.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_download_helper.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_updater.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_download.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/gaia/gaia_oauth_fetcher.h?r1=106949&r2=106948&pathrev=106949
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/url_fetcher_delegate.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_oauth_client_unittest.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_oauth_client.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/signin_manager_unittest.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_notify_channel_setup.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details_cache.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_download.h?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_host_impl.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_management_browsertest.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/network_location_request.cc?r1=106949&r2=106948&pathrev=106949
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_browsertest.cc?r1=106949&r2=106948&pathrev=106949

Convert URLFetcher::Delegates to use an interface in content/public/common. Also remove the old URLFetcher delegate callback while I'm touching all of them.BUG=98716,83592
Review URL: http://codereview.chromium.org/8373021
------------------------------------------------------------------------
Project Member Comment 48 by bugdroid1@chromium.org, Oct 25 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107061

------------------------------------------------------------------------
r107061 | jam@chromium.org | Mon Oct 24 21:46:55 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/web_cache_manager_browsertest.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/browser_render_process_host.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_list.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/uninstall.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/google_chrome_distribution.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_views.cc?r1=107061&r2=107060&pathrev=107061
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/result_codes.h?r1=107061&r2=107060&pathrev=107061 (from /trunk/src/content/common/result_codes.h revision 107012)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/zygote_main_linux.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_process_host.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_crash_recovery_browsertest.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_watchdog_thread.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_exe_main_win.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/chrome_process_util.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run/first_run_import_observer.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/process_singleton_win.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/process_watcher_win.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_result_codes.h?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/child_process_security_policy_browsertest.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/hung_renderer_dialog.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/child_process_launcher.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_process_host.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run/first_run_gtk.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_child_process_host.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/handle_enumerator_win.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main_mac.mm?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/hung_renderer_view.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_message_filter.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/hung_renderer_controller.mm?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/database_message_filter.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host.cc?r1=107061&r2=107060&pathrev=107061
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/result_codes.h?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/hang_monitor/hung_window_detector.cc?r1=107061&r2=107060&pathrev=107061
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/zygote_host_linux.cc?r1=107061&r2=107060&pathrev=107061

Move resource_codes to content/public/common.

BUG=98716
Review URL: http://codereview.chromium.org/8382021
------------------------------------------------------------------------
Project Member Comment 49 by bugdroid1@chromium.org, Oct 25 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107128

------------------------------------------------------------------------
r107128 | jam@chromium.org | Tue Oct 25 09:08:52 PDT 2011

Changed paths:
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/nacl_fork_delegate_linux.h?r1=107128&r2=107127&pathrev=107128
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/zygote_fork_delegate_linux.h?r1=107128&r2=107127&pathrev=107128 (from /trunk/src/content/common/zygote_fork_delegate_linux.h revision 107023)
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/zygote_fork_delegate_linux.h?r1=107128&r2=107127&pathrev=107128
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/app/content_main_delegate.h?r1=107128&r2=107127&pathrev=107128
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/app/content_main.cc?r1=107128&r2=107127&pathrev=107128
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_fork_delegate_linux.cc?r1=107128&r2=107127&pathrev=107128
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_main_delegate.cc?r1=107128&r2=107127&pathrev=107128
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/zygote_main_linux.cc?r1=107128&r2=107127&pathrev=107128
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nacl_fork_delegate_linux.cc?r1=107128&r2=107127&pathrev=107128 (from /trunk/src/chrome/nacl/nacl_fork_delegate_linux.cc revision 107023)
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nacl_fork_delegate_linux.h?r1=107128&r2=107127&pathrev=107128 (from /trunk/src/chrome/common/nacl_fork_delegate_linux.h revision 107023)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_main_delegate.cc?r1=107128&r2=107127&pathrev=107128
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_main_delegate.h?r1=107128&r2=107127&pathrev=107128
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl.gypi?r1=107128&r2=107127&pathrev=107128
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=107128&r2=107127&pathrev=107128
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_main_delegate.h?r1=107128&r2=107127&pathrev=107128

Move ZygoteForkDelegateLinux to content/public/common.

BUG=98716
Review URL: http://codereview.chromium.org/8381029
------------------------------------------------------------------------
Project Member Comment 50 by bugdroid1@chromium.org, Oct 25 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107151

------------------------------------------------------------------------
r107151 | jam@chromium.org | Tue Oct 25 10:56:12 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/download_protection_service.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/image_downloader.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/customization_document.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_browsertest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/auth_response_handler.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/profile_image_downloader.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/spelling_menu_observer.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/apps_promo.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/spelling_menu_observer.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher_unittest.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_download_helper.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/issue_response_handler.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/customization_document.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/intranet_redirect_detector.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognition_request_unittest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/client_login_response_handler.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_url_fetcher_factory.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/toolbar_importer.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/search_provider.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_service.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_service.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/image_downloader.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/download_protection_service.cc?r1=107151&r2=107150&pathrev=107151
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/url_fetcher.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/sdch_dictionary_fetcher.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/client_login_response_handler.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/alternate_nav_url_fetcher.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_install_helper.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/job_status_updater.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/protocol_manager.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/network_location_request.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/issue_response_handler.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/http_bridge.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/cloud_print_proxy_backend.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/gaia/service_gaia_authenticator.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_updater_unittest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/template_url_fetcher.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/printer_job_handler.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_notify_channel_setup.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/testing_policy_url_fetcher_factory.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/cookie_fetcher_unittest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/cookie_fetcher.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/apps_promo.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_download_unittest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_updater.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/gaia/service_gaia_authenticator.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/http_bridge.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/protocol_manager.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognizer_unittest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/alternate_nav_url_fetcher.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_service.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/test/integration/sync_test.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_service_unittest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher_unittest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_service.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_url_fetcher_factory.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/network_location_provider_unittest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognition_request.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/mock_url_fetchers.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/cloud_print_url_fetcher.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_resource/web_resource_service.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details_cache.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/cookie_fetcher.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bug_report_util.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/gaia/gaia_oauth_fetcher.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/profile_image_downloader.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/cloud_print_url_fetcher.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_test.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_backend_impl.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/mock_url_fetchers.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/job_status_updater.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_install_helper.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognition_request.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/component_updater/component_updater_service.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/search_provider.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/toolbar_importer.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_service_browsertest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/component_updater/component_updater_service_unittest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/intranet_redirect_detector.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_host_impl.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_download_helper.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_updater.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_download.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/gaia/gaia_oauth_fetcher.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/url_fetcher_delegate.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_oauth_client_unittest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_oauth_client.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/printer_job_handler.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_notify_channel_setup.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details_cache.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_download.h?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_host_impl.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_management_browsertest.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/network_location_request.cc?r1=107151&r2=107150&pathrev=107151
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_browsertest.cc?r1=107151&r2=107150&pathrev=107151

Create a content::UrlFetcher interface that lives in content/public/common and convert users to it. I have added a static create function, but will switch instantiations to use it in another change since this has grown a lot. Basically this change converts function names away from unix_hacker style, which they shouldn't have been using anyways since some are virtual, and made all of the other functions virtual.

BUG=98716
Review URL: http://codereview.chromium.org/8375039
------------------------------------------------------------------------
Project Member Comment 51 by bugdroid1@chromium.org, Oct 25 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107174

------------------------------------------------------------------------
r107174 | jam@chromium.org | Tue Oct 25 12:13:22 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/utility/utility_thread.h?r1=107174&r2=107173&pathrev=107174
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/utility/DEPS?r1=107174&r2=107173&pathrev=107174
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/utility/chrome_content_utility_client.cc?r1=107174&r2=107173&pathrev=107174
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/utility_thread_impl.cc?r1=107174&r2=107173&pathrev=107174
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/utility_thread_impl.h?r1=107174&r2=107173&pathrev=107174

Make chrome/utility not depend on content/common. Enforce with DEPS.

BUG=98716
Review URL: http://codereview.chromium.org/8351028
------------------------------------------------------------------------
Project Member Comment 52 by bugdroid1@chromium.org, Oct 26 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107264

------------------------------------------------------------------------
r107264 | jam@chromium.org | Tue Oct 25 17:57:22 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=107264&r2=107263&pathrev=107264
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_common.gypi?r1=107264&r2=107263&pathrev=107264
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/native_window_notification_source.h?r1=107264&r2=107263&pathrev=107264 (from /trunk/src/chrome/common/native_window_notification_source.h revision 107174)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.cc?r1=107264&r2=107263&pathrev=107264
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_window_tracker.cc?r1=107264&r2=107263&pathrev=107264
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/native_window_notification_source.h?r1=107264&r2=107263&pathrev=107264

Move native_window_notification_source.h from common to browser.

BUG=98716
Review URL: http://codereview.chromium.org/8341038
------------------------------------------------------------------------
Project Member Comment 53 by bugdroid1@chromium.org, Oct 26 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107268

------------------------------------------------------------------------
r107268 | jam@chromium.org | Tue Oct 25 18:12:22 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_service.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/active_downloads_ui.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/profile_image_downloader.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_resource/web_resource_service.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details_cache.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/cookie_fetcher.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bug_report_util.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/gaia/gaia_oauth_fetcher.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/spelling_menu_observer.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_backend_impl.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/customization_document.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/intranet_redirect_detector.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_install_helper.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/component_updater/component_updater_service.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/toolbar_importer.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_service.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/image_downloader.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/download_protection_service.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/search_provider.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/client_login_response_handler.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/url_fetcher.h?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/protocol_manager.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/issue_response_handler.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_download_helper.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/template_url_fetcher.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_download.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_notify_channel_setup.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_oauth_client.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/apps_promo.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_updater.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/http_bridge.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_host_impl.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/media/media_player.cc?r1=107268&r2=107267&pathrev=107268
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/alternate_nav_url_fetcher.cc?r1=107268&r2=107267&pathrev=107268

Convert chrome callers of UrlFetcher to use the interface. I'll switch tests to use composition instead of inheritence in a future change.

BUG=98716
Review URL: http://codereview.chromium.org/8395023
------------------------------------------------------------------------
Project Member Comment 54 by bugdroid1@chromium.org, Oct 26 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107468

------------------------------------------------------------------------
r107468 | jam@chromium.org | Wed Oct 26 16:39:59 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_url_fetcher_factory.h?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher.cc?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher.h?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_url_fetcher_factory.cc?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/url_fetcher.h?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/mock_url_fetchers.cc?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/cloud_print_url_fetcher.h?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_oauth_client_unittest.cc?r1=107468&r2=107467&pathrev=107468
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/url_fetcher_factory.h?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/testing_policy_url_fetcher_factory.cc?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/testing_policy_url_fetcher_factory.h?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_download_unittest.cc?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/cloud_print_url_fetcher.cc?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher_unittest.h?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/mock_url_fetchers.h?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=107468&r2=107467&pathrev=107468
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognition_request_unittest.cc?r1=107468&r2=107467&pathrev=107468

Make test URLFetcher implementations not derive from the URLFetcher implementation, since we want to hide that from chrome completely.

SetBackoffDelayForTesting moves from content::UrlFetcher to TestURLFetcher, now that the test objects derive from it.

BUG=98716
Review URL: http://codereview.chromium.org/8395038
------------------------------------------------------------------------
Project Member Comment 55 by bugdroid1@chromium.org, Oct 27 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107531

------------------------------------------------------------------------
r107531 | jam@chromium.org | Wed Oct 26 21:23:46 PDT 2011

Changed paths:
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/download_protection_service_unittest.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/test/integration/sync_test.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_process.cc?r1=107531&r2=107530&pathrev=107531
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher_unittest.cc?r1=107531&r2=107530&pathrev=107531
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher.h?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_url_fetcher_factory.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognition_request.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/cloud_print_url_fetcher.h?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/google_authenticator_unittest.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/cloud_print_url_fetcher.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher_unittest.h?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_test.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/cloud_policy_subsystem_unittest.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/sync_backend_host_unittest.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/component_updater/component_updater_service_unittest.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_service_browsertest.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker_unittest.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/cloud_print_helpers.cc?r1=107531&r2=107530&pathrev=107531
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher_impl_unittest.cc?r1=107531&r2=107530&pathrev=107531 (from /trunk/src/content/common/net/url_fetcher_unittest.cc revision 107469)
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher_impl.h?r1=107531&r2=107530&pathrev=107531 (from /trunk/src/content/common/net/url_fetcher.h revision 107469)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_oauth_client_unittest.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/cookie_fetcher_unittest.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.h?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/gaia/service_gaia_authenticator.cc?r1=107531&r2=107530&pathrev=107531
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher_impl.cc?r1=107531&r2=107530&pathrev=107531 (from /trunk/src/content/common/net/url_fetcher.cc revision 107469)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_management_browsertest.cc?r1=107531&r2=107530&pathrev=107531
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/network_location_request.cc?r1=107531&r2=107530&pathrev=107531

Rename URLFetcher to be URLFetcherImpl, now that we have the content::URLFetcher interface.

BUG=98716
Review URL: http://codereview.chromium.org/8403017
------------------------------------------------------------------------
Project Member Comment 56 by bugdroid1@chromium.org, Oct 27 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107614

------------------------------------------------------------------------
r107614 | jam@chromium.org | Thu Oct 27 13:07:40 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/DEPS?r1=107614&r2=107613&pathrev=107614
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/OWNERS?r1=107614&r2=107613&pathrev=107614

Enforce that chrome/common doesn't depend on content/common through DEPS. Also add a comment in the public dir of content.

BUG=98716
Review URL: http://codereview.chromium.org/8417001
------------------------------------------------------------------------
Project Member Comment 57 by bugdroid1@chromium.org, Oct 28 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107665

------------------------------------------------------------------------
r107665 | jam@chromium.org | Thu Oct 27 17:40:48 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/test/integration/sync_test.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/device_management_service_unittest.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_url_fetcher_factory.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/network_location_provider_unittest.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_browsertest.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/mock_url_fetchers.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/profile_image_downloader.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details_cache.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/mock_auth_response_handler.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/cookie_fetcher.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bug_report_util.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/gaia/gaia_oauth_fetcher.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/cloud_print/cloud_print_url_fetcher.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/customization_document.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/intranet_redirect_detector.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognition_request_unittest.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/sdch_dictionary_fetcher.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_url_fetcher_factory.h?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/search_provider_unittest.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_service.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/image_downloader.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/test/integration/sync_test.h?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/url_fetcher.h?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/protocol_manager.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher_impl.h?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_download_helper.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_updater_unittest.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_oauth_client_unittest.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/testing_policy_url_fetcher_factory.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/net/gaia/gaia_auth_fetcher.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_updater.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/net/url_fetcher_impl.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/network_location_request.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_browsertest.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognizer_unittest.cc?r1=107665&r2=107664&pathrev=107665
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/alternate_nav_url_fetcher.cc?r1=107665&r2=107664&pathrev=107665

Handle additional feedback from http://codereview.chromium.org/8395038/.
-rename URLFetcherFactory to URLFetcherImplFactory
-rename GetUrl to GetURL and GetOriginalUrl to GetOriginalURL
-get rid of request_type in TestURLFetcher's constructor

BUG=98716
Review URL: http://codereview.chromium.org/8416020
------------------------------------------------------------------------
Project Member Comment 58 by bugdroid1@chromium.org, Oct 28 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107755

------------------------------------------------------------------------
r107755 | joi@chromium.org | Fri Oct 28 11:20:24 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_thread_impl.cc?r1=107755&r2=107754&pathrev=107755

Quick fix for memory race inherent to all subclasses of base::Thread.

This is a local fix because TSAN is complaining only about this
particular case.  A follow-up change (which will likely take more
time) will make sure this is OK across the code-base.

BUG=98716,102134


Review URL: http://codereview.chromium.org/8343062
------------------------------------------------------------------------
Project Member Comment 59 by bugdroid1@chromium.org, Oct 28 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107804

------------------------------------------------------------------------
r107804 | jam@chromium.org | Fri Oct 28 15:02:48 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_messages.h?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_win.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/common_param_traits.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_active_document.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/external_tab.h?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/webplugin_delegate_stub.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/external_tab_test.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=107804&r2=107803&pathrev=107804
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/page_zoom.h?r1=107804&r2=107803&pathrev=107804 (from /trunk/src/content/common/page_zoom.h revision 107754)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/app/content_main.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_frame_automation.h?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/default_plugin/plugin_installer_base.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=107804&r2=107803&pathrev=107804
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_constants.h?r1=107804&r2=107803&pathrev=107804 (from /trunk/src/content/common/content_constants.h revision 107754)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/external_tab.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=107804&r2=107803&pathrev=107804
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/content_constants.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/default_plugin/plugin_impl_gtk.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/webkit_param_traits.cc?r1=107804&r2=107803&pathrev=107804
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/page_zoom.h?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/cfproxy_support.cc?r1=107804&r2=107803&pathrev=107804
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/content_constants.h?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.h?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry.cc?r1=107804&r2=107803&pathrev=107804
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_constants.cc?r1=107804&r2=107803&pathrev=107804 (from /trunk/src/content/common/content_constants.cc revision 107754)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.h?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host.h?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_frame_automation.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/cfproxy.h?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/site_instance_unittest.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/cfproxy_private.h?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=107804&r2=107803&pathrev=107804
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/default_plugin/plugin_impl_aura.cc?r1=107804&r2=107803&pathrev=107804

Move PageZoom enum into content/public/common and into the content namespace. Also move content_costants to content/public/common.

BUG=98716
Review URL: http://codereview.chromium.org/8413051
------------------------------------------------------------------------
Project Member Comment 60 by bugdroid1@chromium.org, Oct 29 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107863

------------------------------------------------------------------------
r107863 | jam@chromium.org | Fri Oct 28 20:44:44 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_main_platform_delegate.h?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/message_pump_libevent.cc?r1=107863&r2=107862&pathrev=107863
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_init_wrapper_linux.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_main.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/gpu/command_buffer/client/mapped_memory_unittest.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main_unittest.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/app/startup_helper_win.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/base_panel_browser_test.cc?r1=107863&r2=107862&pathrev=107863
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/sandbox_init.h?r1=107863&r2=107862&pathrev=107863 (from /trunk/src/content/common/sandbox_init_wrapper.h revision 107639)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_main_platform_delegate_win.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/test/test_suite.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/app/content_main.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_app_browsertest.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/simple_host_process.cc?r1=107863&r2=107862&pathrev=107863
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_init_wrapper_win.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_main.cc?r1=107863&r2=107862&pathrev=107863
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_init_mac.cc?r1=107863&r2=107862&pathrev=107863 (from /trunk/src/content/common/sandbox_init_wrapper_mac.cc revision 107639)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/pyautolib/pyautolib.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/ppapi_plugin/ppapi_broker_main.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/message_pump_default.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/gpu/command_buffer/service/gpu_scheduler_unittest.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/pyautolib/pyautolib.h?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_app.gypi?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main_loop.cc?r1=107863&r2=107862&pathrev=107863
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/app/startup_helper_win.h?r1=107863&r2=107862&pathrev=107863 (from /trunk/src/content/app/startup_helper_win.h revision 107639)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_main.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_view_test.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/gpu/command_buffer/client/fenced_allocator_test.cc?r1=107863&r2=107862&pathrev=107863
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/app/startup_helper_win.h?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/gpu/command_buffer/client/cmd_buffer_helper_test.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/mac/scoped_nsautorelease_pool.h?r1=107863&r2=107862&pathrev=107863
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_init_wrapper_mac.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/shared_memory_unittest.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_exe.gypi?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main.cc?r1=107863&r2=107862&pathrev=107863
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_init_wrapper.h?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_exe_win_64.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/ppapi_plugin/ppapi_thread.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_exe_main_win.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_main.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/utility_main.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/browser_test_base.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/plugin_main.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_main.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/in_process_browser_test.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/run_all_tests.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_main_platform_delegate_mac.mm?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/chrome_test_launcher.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/gpu/command_buffer/client/ring_buffer_test.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/content_browser_test.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/service_process_util.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/webdriver/commands/command.h?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_view_test.h?r1=107863&r2=107862&pathrev=107863
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_init_win.cc?r1=107863&r2=107862&pathrev=107863 (from /trunk/src/content/common/sandbox_init_wrapper_win.cc revision 107639)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_launcher.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/sandbox/src/sandbox_types.h?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_main_platform_delegate_win.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/DEPS?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_main_platform_delegate_mac.mm?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/content_test_launcher.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/worker_main.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/main_function_params.h?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/ppapi_plugin/ppapi_plugin_main.cc?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/DEPS?r1=107863&r2=107862&pathrev=107863
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/chrome_test_suite.cc?r1=107863&r2=107862&pathrev=107863

Expose the sandbox related code through the content API. I did a bit of cleanup while I was doing this.

-got rid of SandboxInitWrapper, since I didn't see a need to expose given that we can just expose sandbox::SandboxInterfaceInfo
-got rid of the duplicated code to initialize the broker
-since I made MainFunctionParams only have the sandbox struct on Windows, I also made the mac specific auto release pool behind an ifdef as well. It seemed odd to make something so mac specific compile on all platforms to save some #ifdefs.

BUG=98716
Review URL: http://codereview.chromium.org/8414020
------------------------------------------------------------------------
Project Member Comment 61 by bugdroid1@chromium.org, Oct 31 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107964

------------------------------------------------------------------------
r107964 | joi@chromium.org | Mon Oct 31 09:28:03 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/webkit_context_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/media/video_capture_manager_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/dom_storage_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/media/audio_input_device_manager_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/media/video_capture_host_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_loader_posix_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/media/audio_renderer_host_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/base_file_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/gps_location_provider_unittest_linux.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/site_instance_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_id_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_queue_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_file_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/appcache/chrome_appcache_service_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/resolve_proxy_msg_helper_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc?r1=107964&r2=107963&pathrev=107964
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognizer_unittest.cc?r1=107964&r2=107963&pathrev=107964

Switch content tests to use BrowserThreadImpl directly.

BUG=98716


Review URL: http://codereview.chromium.org/8400060
------------------------------------------------------------------------
Project Member Comment 62 by bugdroid1@chromium.org, Oct 31 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=108004

------------------------------------------------------------------------
r108004 | jam@chromium.org | Mon Oct 31 13:25:18 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_main_platform_delegate.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main_win.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/mock_content_browser_client.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_main.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_main.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main_unittest.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.h?r1=108004&r2=108003&pathrev=108004
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/main_function_params.h?r1=108004&r2=108003&pathrev=108004 (from /trunk/src/content/common/main_function_params.h revision 107906)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/zygote_main_linux.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_main_platform_delegate_win.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/chrome_browser_main_chromeos.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main_posix.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_main_delegate.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/app/content_main.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main_mac.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/ppapi_plugin/ppapi_broker_main.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_main.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main_linux.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main_loop.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_main.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_main_platform_delegate_linux.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_main_platform_delegate.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_view_test.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_browser_client.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/chrome_browser_main_chromeos.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main_posix.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main_linux.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/content_browser_client.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_exe_win_64.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/mac/relauncher.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_main.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/utility/utility_main.cc?r1=108004&r2=108003&pathrev=108004
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_restriction.h?r1=108004&r2=108003&pathrev=108004 (from /trunk/src/content/common/content_restriction.h revision 107906)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_message_handler.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/browser_test_base.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/plugin_main.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_main.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_helper_linux.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_main_delegate.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_main_platform_delegate_linux.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_main_platform_delegate_mac.mm?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/mock_content_browser_client.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main_win.h?r1=108004&r2=108003&pathrev=108004
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/content_restriction.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_main_delegate.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_browser_client.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_view_test.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main_mac.mm?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/mac/relauncher.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_main_platform_delegate_win.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/app/content_main_delegate.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_main_platform_delegate_mac.mm?r1=108004&r2=108003&pathrev=108004
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/main_function_params.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/worker_main.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_main_delegate.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/ppapi_plugin/ppapi_plugin_main.cc?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main_loop.h?r1=108004&r2=108003&pathrev=108004
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main.h?r1=108004&r2=108003&pathrev=108004

Move content_restriction.h and main_function_params.h to content/public/common, and put them in the content namespace.

BUG=98716
Review URL: http://codereview.chromium.org/8387039
------------------------------------------------------------------------
Project Member Comment 63 by bugdroid1@chromium.org, Nov 3 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=108452

------------------------------------------------------------------------
r108452 | joi@chromium.org | Thu Nov 03 06:04:40 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/sync_backend_host_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_item_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/notifier/non_blocking_invalidation_notifier_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_protocol/external_protocol_handler_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/component_updater/component_updater_service_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_startup_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/http_bridge_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/util/extensions_activity_monitor_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/template_url_service_test_util.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_browser_thread.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_browser_thread.h?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_download_unittest.cc?r1=108452&r2=108451&pathrev=108452
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc?r1=108452&r2=108451&pathrev=108452

Switch to composition for TestBrowserThread.

This avoids exposing BrowserThreadImpl internals outside of content/,
and goes most of the way to not exposing the fact that underneath, it
is a base::Thread.  There are only three test files that use the
TestBrowserThread::DeprecatedGetThreadObject method.

TBR=owners
BUG=98716

Review URL: http://codereview.chromium.org/8440039
------------------------------------------------------------------------
Project Member Comment 64 by bugdroid1@chromium.org, Nov 3 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=108462

------------------------------------------------------------------------
r108462 | joi@chromium.org | Thu Nov 03 07:54:21 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/unpacked_installer.cc?r1=108462&r2=108461&pathrev=108462
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/installed_loader.cc?r1=108462&r2=108461&pathrev=108462
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_item_unittest.cc?r1=108462&r2=108461&pathrev=108462
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_installer.cc?r1=108462&r2=108461&pathrev=108462
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/webdata/autocomplete_syncable_service.cc?r1=108462&r2=108461&pathrev=108462
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager.cc?r1=108462&r2=108461&pathrev=108462
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_thread.h?r1=108462&r2=108461&pathrev=108462

Remove 'using' from browser_thread.h, and make things compile.

BUG=98716

Review URL: http://codereview.chromium.org/8438045
------------------------------------------------------------------------
Project Member Comment 65 by bugdroid1@chromium.org, Nov 4 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=108608

------------------------------------------------------------------------
r108608 | ananta@chromium.org | Thu Nov 03 18:15:11 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_manager_unittest.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details_win.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_notification_resource_provider.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_message_handler.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_blocking_page.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_init.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details_mac.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_util.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/pdf_unsupported_feature.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_id_map.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/file_select_helper.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/login/login_prompt.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/desktop_notification_service.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/login/login_prompt_win.cc?r1=108608&r2=108607&pathrev=108608
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_util.cc?r1=108608&r2=108607&pathrev=108608

Remove needless include of the content/browser/render_process_host.h header file.

Part 1 of upcoming changes to move RPH/BRPH to a public interface.

BUG=98716
Review URL: http://codereview.chromium.org/8451012
------------------------------------------------------------------------
Project Member Comment 66 by bugdroid1@chromium.org, Nov 10 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=109468

------------------------------------------------------------------------
r109468 | jam@chromium.org | Thu Nov 10 10:51:43 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.h?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/notifications/balloon_controller.mm?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.h?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.cc?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.cc?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.cc?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_notification_resource_provider.cc?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/notifications/balloon_view_host_mac.mm?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/notifications/balloon_view_host.cc?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/notifications/balloon_view_host.h?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_observer.h?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_observer.cc?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/notifications/balloon_view_host.cc?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/notifications/balloon_view_host.h?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/notifications/balloon_view_host_mac.h?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/notifications/balloon_view.cc?r1=109468&r2=109467&pathrev=109468
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.h?r1=109468&r2=109467&pathrev=109468

Make BalloonHost use TabContents instead of RenderViewHost.

BUG=99700,98716
Review URL: http://codereview.chromium.org/8439021
------------------------------------------------------------------------
Project Member Comment 67 by bugdroid1@chromium.org, Nov 12 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=109746

------------------------------------------------------------------------
r109746 | jam@chromium.org | Fri Nov 11 16:45:35 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=109746&r2=109745&pathrev=109746
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.h?r1=109746&r2=109745&pathrev=109746
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/mock_content_browser_client.cc?r1=109746&r2=109745&pathrev=109746
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/content_browser_client.h?r1=109746&r2=109745&pathrev=109746
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/mock_content_browser_client.h?r1=109746&r2=109745&pathrev=109746
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/workers_ui.cc?r1=109746&r2=109745&pathrev=109746
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=109746&r2=109745&pathrev=109746
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=109746&r2=109745&pathrev=109746
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_browser_client.h?r1=109746&r2=109745&pathrev=109746
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_process_host.h?r1=109746&r2=109745&pathrev=109746
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_worker_message_filter.cc?r1=109746&r2=109745&pathrev=109746
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_browser_client.cc?r1=109746&r2=109745&pathrev=109746
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_process_host.cc?r1=109746&r2=109745&pathrev=109746
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_worker_message_filter.h?r1=109746&r2=109745&pathrev=109746

Remove includes of worker_messages.h from chrome code, since that's an internal detail of content.

BUG=98716
Review URL: http://codereview.chromium.org/8514004
------------------------------------------------------------------------
Project Member Comment 68 by bugdroid1@chromium.org, Nov 12 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=109757

------------------------------------------------------------------------
r109757 | jam@chromium.org | Fri Nov 11 17:59:17 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.h?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/mock_content_browser_client.cc?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/content_browser_client.h?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/mock_content_browser_client.h?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/notification_provider.cc?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/desktop_notification_service.h?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_browser_client.cc?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc?r1=109757&r2=109756&pathrev=109757
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/show_desktop_notification_params.cc?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.h?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/desktop_notifications_unittest.cc?r1=109757&r2=109756&pathrev=109757
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/show_desktop_notification_params.h?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/desktop_notifications_unittest.h?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_browser_client.h?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/notifications/desktop_notifications_unittest.h?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_browsertest.cc?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/desktop_notification_service.cc?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=109757&r2=109756&pathrev=109757
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/desktop_notification_messages.h?r1=109757&r2=109756&pathrev=109757

Move the struct used when showing a desktop notification to content/public/common, so that chrome code doesn't include desktop_notification_messages.h which is an internal detail of content.

BUG=98716
Review URL: http://codereview.chromium.org/8511075
------------------------------------------------------------------------
Project Member Comment 69 by bugdroid1@chromium.org, Nov 16 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=110324

------------------------------------------------------------------------
r110324 | jam@chromium.org | Wed Nov 16 10:18:23 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.cc?r1=110324&r2=110323&pathrev=110324
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_tracker.cc?r1=110324&r2=110323&pathrev=110324
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc?r1=110324&r2=110323&pathrev=110324
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h?r1=110324&r2=110323&pathrev=110324
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/resource_dispatcher_host_delegate.h?r1=110324&r2=110323&pathrev=110324

Get rid of resource_messages.h include from chrome, since that's an internal detail of content.

BUG=98716
Review URL: http://codereview.chromium.org/8511080
------------------------------------------------------------------------
Comment 70 by jam@chromium.org, Nov 17 2011
Blockedon: 104625
Project Member Comment 71 by bugdroid1@chromium.org, Nov 17 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=110522

------------------------------------------------------------------------
r110522 | jam@chromium.org | Thu Nov 17 09:57:36 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/cloud_print_signin_dialog.cc?r1=110522&r2=110521&pathrev=110522
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=110522&r2=110521&pathrev=110522
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_installer_infobar_delegate.cc?r1=110522&r2=110521&pathrev=110522
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_observer.cc?r1=110522&r2=110521&pathrev=110522
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_tab_helper.cc?r1=110522&r2=110521&pathrev=110522
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_render_view_host_observer.cc?r1=110522&r2=110521&pathrev=110522
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.cc?r1=110522&r2=110521&pathrev=110522
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/pdf_unsupported_feature.cc?r1=110522&r2=110521&pathrev=110522
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_views.cc?r1=110522&r2=110521&pathrev=110522
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/background_contents.cc?r1=110522&r2=110521&pathrev=110522
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_win.cc?r1=110522&r2=110521&pathrev=110522

Remove some unnecessary includes of view_messages.h.

BUG=98716
TBR=ananta
Review URL: http://codereview.chromium.org/8590033
------------------------------------------------------------------------
Project Member Comment 72 by bugdroid1@chromium.org, Nov 17 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=110530

------------------------------------------------------------------------
r110530 | jam@chromium.org | Thu Nov 17 10:31:54 PST 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_data_remover_impl.cc?r1=110530&r2=110529&pathrev=110530 (from /trunk/src/chrome/browser/plugin_data_remover.cc revision 110324)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=110530&r2=110529&pathrev=110530
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browsing_data_remover.cc?r1=110530&r2=110529&pathrev=110530
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browsing_data_remover.h?r1=110530&r2=110529&pathrev=110530
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_data_remover_impl.h?r1=110530&r2=110529&pathrev=110530 (from /trunk/src/chrome/browser/plugin_data_remover.h revision 110324)
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_data_remover_impl_browsertest.cc?r1=110530&r2=110529&pathrev=110530 (from /trunk/src/chrome/browser/plugin_data_remover_browsertest.cc revision 110324)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_data_remover_helper.h?r1=110530&r2=110529&pathrev=110530
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=110530&r2=110529&pathrev=110530
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/in_process_browser_test.h?r1=110530&r2=110529&pathrev=110530
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_data_remover.cc?r1=110530&r2=110529&pathrev=110530
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_data_remover_browsertest.cc?r1=110530&r2=110529&pathrev=110530
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/workers_ui.cc?r1=110530&r2=110529&pathrev=110530
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=110530&r2=110529&pathrev=110530
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_data_remover.h?r1=110530&r2=110529&pathrev=110530
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_clear_api.cc?r1=110530&r2=110529&pathrev=110530
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/in_process_browser_test.cc?r1=110530&r2=110529&pathrev=110530
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=110530&r2=110529&pathrev=110530
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=110530&r2=110529&pathrev=110530
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/plugin_data_remover.h?r1=110530&r2=110529&pathrev=110530
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_data_remover_helper.cc?r1=110530&r2=110529&pathrev=110530

Move the PluginDataRemover class to content, and remove the chrome pieces from it. This class really belongs in content because it's part of the web platform. I've also wrapped it with an interface that is used by chrome.

BUG=98716
Review URL: http://codereview.chromium.org/8590016
------------------------------------------------------------------------
Project Member Comment 73 by bugdroid1@chromium.org, Nov 17 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=110539

------------------------------------------------------------------------
r110539 | jam@chromium.org | Thu Nov 17 12:02:21 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.h?r1=110539&r2=110538&pathrev=110539
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm?r1=110539&r2=110538&pathrev=110539
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=110539&r2=110538&pathrev=110539
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_message_enums.h?r1=110539&r2=110538&pathrev=110539
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel.cc?r1=110539&r2=110538&pathrev=110539
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_messages.h?r1=110539&r2=110538&pathrev=110539
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=110539&r2=110538&pathrev=110539
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.cc?r1=110539&r2=110538&pathrev=110539
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=110539&r2=110538&pathrev=110539
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.h?r1=110539&r2=110538&pathrev=110539

Remove the flags to RenderViewHost::EnablePreferredSizeMode since it's not used after http://crbug.com/44850 was fixed.

BUG=98716
Review URL: http://codereview.chromium.org/8586032
------------------------------------------------------------------------
Project Member Comment 74 by bugdroid1@chromium.org, Nov 18 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=110615

------------------------------------------------------------------------
r110615 | ananta@chromium.org | Thu Nov 17 16:34:30 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_manager.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/mock_render_process_host.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/mock_content_browser_client.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_permissions_api.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_list.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_message_service.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/backing_store_gtk.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/DEPS?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_policy.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/webui/web_ui.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/backing_store_win.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/pepper_file_message_filter.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/web_cache_manager.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_plugin_service_filter.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/render_view_devtools_agent_host.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/mock_render_process_host.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_service.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_service.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_process_apitest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_view.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/search_provider_install_state_message_filter.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_helper.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/site_instance_unittest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_save_page_api.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_fullscreen_host.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_message_filter.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/backing_store.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_browser_client.h?r1=110615&r2=110614&pathrev=110615
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host.h?r1=110615&r2=110614&pathrev=110615
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/browser_render_process_host.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/content_browser_client.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_host.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/backing_store_skia.h?r1=110615&r2=110614&pathrev=110615
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_message_handler.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_crash_recovery_browsertest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_request_handle.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_about_handler.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_util.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_purger.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_shutdown.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/background_printing_manager.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/in_process_browser_test.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_helper.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_permissions_api.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/test_render_view_host.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/mock_content_browser_client.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc?r1=110615&r2=110614&pathrev=110615
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/browser_render_process_host.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_render_message_filter.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_process_host_ui_shim.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_processes_api.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_host_impl.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_browsertest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_purger.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_unittest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_fullscreen_host.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc?r1=110615&r2=110614&pathrev=110615
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.h?r1=110615&r2=110614&pathrev=110615 (from /trunk/src/content/browser/renderer_host/browser_render_process_host.h revision 109505)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/site_instance.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/hung_renderer_controller.mm?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/pdf_unsupported_feature.cc?r1=110615&r2=110614&pathrev=110615
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/render_process_host.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_main_delegate.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prefs/browser_prefs.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_profile_unittest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/text_input_client_mac_unittest.mm?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/backing_store_mac.mm?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/net/fake_external_tab.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/oom_priority_manager.cc?r1=110615&r2=110614&pathrev=110615
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/render_process_host_factory.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_resource_providers.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/backing_store_win.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/tracking_synchronizer.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_id_map.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/host_zoom_map.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_event_router.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/pepper_message_filter.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/backing_store_skia.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webrequest_api.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webrequest_api.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/status/memory_menu_button.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/field_trial_synchronizer.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_extension_api.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/visitedlink/visitedlink_unittest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_event_router.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_view_mac.mm?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_blocking_page.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details_unittest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/histogram_synchronizer.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/web_cache_manager_browsertest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/test_backing_store.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_view_win.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/isolated_app_browsertest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/test_render_view_host.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_render_view_host_observer.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/backing_store_mac.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/media/media_internals_proxy.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/background_printing_manager.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/mach_broker_mac.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/user_script_master.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/net/browser_online_state_observer.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/backing_store_gtk.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_impl.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/geolocation_dispatcher_host.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/child_process_security_policy_browsertest.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/test_backing_store.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/visitedlink/visitedlink_event_listener.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_notification_resource_provider.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_container.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/mhtml_generation_manager.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_browser_client.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/user_script_master.h?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_plugin_message_filter.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/hung_renderer_view.cc?r1=110615&r2=110614&pathrev=110615
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=110615&r2=110614&pathrev=110615 (from /trunk/src/content/browser/renderer_host/browser_render_process_host.cc revision 109505)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/site_instance.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/extension_settings_handler.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_file_browser_private_api.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/cert_store.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager_impl.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=110615&r2=110614&pathrev=110615
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_host_impl.cc?r1=110615&r2=110614&pathrev=110615

Define the public interface for content browser RenderProcessHost. This interface is implemented by the RenderProcessHostImpl class which lives in content\browser\renderer_host\render_process_host_impl.cc/.h. The RenderProcessHostImpl class is a consolidation of the RenderProcessHost and BrowserRenderProcessHost classes.

The RenderProcessHost public interface was created from the now deleted RenderProcessHost class defined in content\browser\renderer_host\render_process_host.h. 
Additional methods have been added to the interface to ensure that it works correctly with the MockRenderProcessHost class used by unit tests. I had to implement a number of overrides in the MockRenderProcessHost  class to ensure that tests work correctly. This was because of assumptions in the tests that the MockRPH class was a real RPH which it was till now.

Added a TODO for the methods which could potentially be removed from this interface. Will revisit that in a subsequent CL.

BUG=98716
TEST=No change in functionality. Hopefully it all compiles and works.
Review URL: http://codereview.chromium.org/8515027
------------------------------------------------------------------------
Project Member Comment 75 by bugdroid1@chromium.org, Nov 18 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=110635

------------------------------------------------------------------------
r110635 | ananta@chromium.org | Thu Nov 17 18:00:03 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=110635&r2=110634&pathrev=110635
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/mock_render_process_host.cc?r1=110635&r2=110634&pathrev=110635
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.h?r1=110635&r2=110634&pathrev=110635

Provide a way for RenderProcessHosts to register themselves in the global host map.
This is in the form of static RegisterHost/UnregisterHost functions in the RenderProcessHostImpl class.

BUG=98716
TEST=No change in functionality. Hopefully it all compiles and works.
Review URL: http://codereview.chromium.org/8597005
------------------------------------------------------------------------
Project Member Comment 76 by bugdroid1@chromium.org, Nov 18 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=110747

------------------------------------------------------------------------
r110747 | jam@chromium.org | Fri Nov 18 12:50:39 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.cc?r1=110747&r2=110746&pathrev=110747
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/testing_browser_process.h?r1=110747&r2=110746&pathrev=110747
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=110747&r2=110746&pathrev=110747
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/about_ipc_controller.mm?r1=110747&r2=110746&pathrev=110747
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/about_ipc_controller_unittest.mm?r1=110747&r2=110746&pathrev=110747
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.h?r1=110747&r2=110746&pathrev=110747
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/content_ipc_logging.cc?r1=110747&r2=110746&pathrev=110747
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process.h?r1=110747&r2=110746&pathrev=110747
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/about_ipc_dialog.cc?r1=110747&r2=110746&pathrev=110747
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/content_ipc_logging.h?r1=110747&r2=110746&pathrev=110747

Move enabling IPC logging for all child processes to the Content API.

BUG=98716
Review URL: http://codereview.chromium.org/8574070
------------------------------------------------------------------------
Project Member Comment 77 by bugdroid1@chromium.org, Nov 19 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=110802

------------------------------------------------------------------------
r110802 | jam@chromium.org | Fri Nov 18 17:05:38 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/gpu_process_launch_causes.h?r1=110802&r2=110801&pathrev=110802
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_about_handler.cc?r1=110802&r2=110801&pathrev=110802
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_process_host_ui_shim.cc?r1=110802&r2=110801&pathrev=110802
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_process_host_ui_shim.h?r1=110802&r2=110801&pathrev=110802

Get rid of last gpu_messages.h dependency in chrome by having chrome ask the GPUProcessHostUIShim to hang/crash/clean the gpu process.

BUG=98716
Review URL: http://codereview.chromium.org/8548014
------------------------------------------------------------------------
Project Member Comment 78 by bugdroid1@chromium.org, Nov 19 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=110846

------------------------------------------------------------------------
r110846 | jam@chromium.org | Sat Nov 19 14:42:27 PST 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/idbbindingutilities_browsertest.cc?r1=110846&r2=110845&pathrev=110846 (from /trunk/src/chrome/browser/idbbindingutilities_browsertest.cc revision 110802)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc?r1=110846&r2=110845&pathrev=110846
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=110846&r2=110845&pathrev=110846
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_browsertest.cc?r1=110846&r2=110845&pathrev=110846
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=110846&r2=110845&pathrev=110846
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/idbbindingutilities_browsertest.cc?r1=110846&r2=110845&pathrev=110846

Enforce that most content messages files can't be included by chrome.

BUG=98716
Review URL: http://codereview.chromium.org/8470006
------------------------------------------------------------------------
Comment 79 by jam@chromium.org, Nov 21 2011
Blockedon: 104980
Project Member Comment 80 by bugdroid1@chromium.org, Nov 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=110963

------------------------------------------------------------------------
r110963 | jam@chromium.org | Mon Nov 21 10:29:36 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/intents/intent_injector.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_manager.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/constrained_window_tab_helper.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/constrained_window_tab_helper.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/ipc/struct_destructor_macros.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_manager.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_messages.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_tab_helper.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/ipc/param_traits_read_macros.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/ipclist/ipcfuzz.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/intents/web_intent_picker_controller.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/search_engine_tab_helper.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=110963&r2=110962&pathrev=110963
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/frame_navigate_params.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.cc?r1=110963&r2=110962&pathrev=110963
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/frame_navigate_params.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/bookmarks/bookmark_tab_helper.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_observer.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/search_engine_tab_helper.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/ipc/param_traits_log_macros.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_tab_helper.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/ipc/param_traits_write_macros.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_helper.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/ipc/ipc_message_macros.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_helper.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/intents/intent_injector.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_tab_helper.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/ipc/struct_constructor_macros.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_tab_helper.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_observer.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/ipc/ipc_message_null_macros.h?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/applescript/tab_applescript.mm?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_tab_helper.cc?r1=110963&r2=110962&pathrev=110963
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_browsertest.cc?r1=110963&r2=110962&pathrev=110963

Get rid of a bunch of view_messages.h includes from chrome by making the TabContentsObserver interface not use a struct from it. Instead, the interface uses a new struct, content::FrameNavigateParams, that's in the public directory. The IPC message's struct derives from it.

BUG=98716
Review URL: http://codereview.chromium.org/8603015
------------------------------------------------------------------------
Project Member Comment 81 by bugdroid1@chromium.org, Nov 22 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111086

------------------------------------------------------------------------
r111086 | jam@chromium.org | Mon Nov 21 18:45:23 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.h?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.h?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.cc?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_messages.h?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_delegate.h?r1=111086&r2=111085&pathrev=111086
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/file_chooser_params.cc?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.h?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/file_select_helper.h?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.h?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_message_enums.h?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/file_select_helper.cc?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=111086&r2=111085&pathrev=111086
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=111086&r2=111085&pathrev=111086
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/file_chooser_params.h?r1=111086&r2=111085&pathrev=111086

Get rid of view_messages.h include from chrome since TabContentsDelegate used a struct from it (ViewHostMsg_RunFileChooser_Params). Moved that to a struct in content/public/common.

BUG=98716

Review URL: http://codereview.chromium.org/8622005
------------------------------------------------------------------------
Project Member Comment 82 by bugdroid1@chromium.org, Nov 22 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111236

------------------------------------------------------------------------
r111236 | jam@chromium.org | Tue Nov 22 14:39:43 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_render_view_host_observer.h?r1=111236&r2=111235&pathrev=111236
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_render_view_host_observer.cc?r1=111236&r2=111235&pathrev=111236
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=111236&r2=111235&pathrev=111236
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_observer.h?r1=111236&r2=111235&pathrev=111236
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_observer.cc?r1=111236&r2=111235&pathrev=111236

Make RenderViewHostObserver interface not use a struct from view_messages.h

BUG=98716
Review URL: http://codereview.chromium.org/8636023
------------------------------------------------------------------------
Project Member Comment 83 by bugdroid1@chromium.org, Nov 23 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111266

------------------------------------------------------------------------
r111266 | jam@chromium.org | Tue Nov 22 16:58:23 PST 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/base/property_bag_unittest.cc?r1=111266&r2=111265&pathrev=111266 (from /trunk/src/content/common/property_bag_unittest.cc revision 111170)
 A http://src.chromium.org/viewvc/chrome/trunk/src/base/property_bag.h?r1=111266&r2=111265&pathrev=111266 (from /trunk/src/content/common/property_bag.h revision 111170)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc?r1=111266&r2=111265&pathrev=111266
 A http://src.chromium.org/viewvc/chrome/trunk/src/base/property_bag.cc?r1=111266&r2=111265&pathrev=111266 (from /trunk/src/content/common/property_bag.cc revision 111170)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/tab_contents_wrapper.h?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/constrained_html_ui.cc?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/base.gyp?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_ui.h?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.cc?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/omnibox/omnibox_view_win.cc?r1=111266&r2=111265&pathrev=111266
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/property_bag_unittest.cc?r1=111266&r2=111265&pathrev=111266
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/property_bag.h?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host.h?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_omnibox_api.cc?r1=111266&r2=111265&pathrev=111266
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/property_bag.cc?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.h?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/omnibox/omnibox_view_views.cc?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_ui.cc?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/constrained_html_ui.h?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc?r1=111266&r2=111265&pathrev=111266
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/base.gypi?r1=111266&r2=111265&pathrev=111266

Move PropertyBag to base. Originally this was in chrome\common because only chrome used it. Now that chrome and content use it, and that we want to only expose interface through the content API, this belongs in base.

BUG=98716
Review URL: http://codereview.chromium.org/8652002
------------------------------------------------------------------------
Project Member Comment 84 by bugdroid1@chromium.org, Nov 23 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111363

------------------------------------------------------------------------
r111363 | jam@chromium.org | Wed Nov 23 09:37:27 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_render_message_filter.h?r1=111363&r2=111362&pathrev=111363
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/dom_storage_messages.h?r1=111363&r2=111362&pathrev=111363
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=111363&r2=111362&pathrev=111363
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.h?r1=111363&r2=111362&pathrev=111363
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_render_message_filter.cc?r1=111363&r2=111362&pathrev=111363
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=111363&r2=111362&pathrev=111363
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/common_param_traits.h?r1=111363&r2=111362&pathrev=111363
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/content_settings_observer.cc?r1=111363&r2=111362&pathrev=111363

Don't use the DOMStorageType for a chrome IPC, so that we can get rid of that content include from chrome. We change a bool to it, only to change it back to a bool, so no need for it.

BUG=98716
Review URL: http://codereview.chromium.org/8667004
------------------------------------------------------------------------
Project Member Comment 85 by bugdroid1@chromium.org, Nov 23 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111371

------------------------------------------------------------------------
r111371 | jam@chromium.org | Wed Nov 23 10:32:00 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_mac.mm?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/printer_manager_dialog_linux.cc?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/child_process_launcher.cc?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.cc?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/zygote_main_linux.cc?r1=111371&r2=111370&pathrev=111371
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/process_watcher_mac.cc?r1=111371&r2=111370&pathrev=111371
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/process_watcher_unittest.cc?r1=111371&r2=111370&pathrev=111371
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/process_watcher.h?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_posix.cc?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/platform_util_linux.cc?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_unittest.cc?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util.h?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_win.cc?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/advanced_options_utils_x11.cc?r1=111371&r2=111370&pathrev=111371
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/process_watcher_posix.cc?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/platform_util_chromeos.cc?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/zygote_host_linux.cc?r1=111371&r2=111370&pathrev=111371
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=111371&r2=111370&pathrev=111371
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/process_watcher_win.cc?r1=111371&r2=111370&pathrev=111371

Move the ProcessWatcher methods out of content/common/process_watcher into base/process_util, alongside the other process methods.

The only non-trivial move change is to the Windows implementation, where I changed KillProcess to use an exit code of kProcessKilledExitCode instead of content::RESULT_CODE_HUNG. cpu said that the existing code was incorrect, since GetTerminationStatus() should be mapping that result to TERMINATION_STATUS_PROCESS_WAS_KILLED. So I changed the exit code to kProcessKilledExitCode. This might make the UMA stats for killed processes to go up (and crashed to go down), but that will be an accounting change and should be zero-sum.

BUG=98716
Review URL: http://codereview.chromium.org/8674003
------------------------------------------------------------------------
Project Member Comment 86 by bugdroid1@chromium.org, Nov 23 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111374

------------------------------------------------------------------------
r111374 | jam@chromium.org | Wed Nov 23 10:40:30 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.h?r1=111374&r2=111373&pathrev=111374
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/stop_find_action.h?r1=111374&r2=111373&pathrev=111374
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_message_enums.h?r1=111374&r2=111373&pathrev=111374
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_messages.h?r1=111374&r2=111373&pathrev=111374
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=111374&r2=111373&pathrev=111374
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=111374&r2=111373&pathrev=111374
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=111374&r2=111373&pathrev=111374
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.h?r1=111374&r2=111373&pathrev=111374
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=111374&r2=111373&pathrev=111374
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_tab_helper.cc?r1=111374&r2=111373&pathrev=111374

Get rid of view_message_enums.h dependency in Chrome by moving the enum for find-stopping to content/public/common.

BUG=98716
Review URL: http://codereview.chromium.org/8670006
------------------------------------------------------------------------
Project Member Comment 87 by bugdroid1@chromium.org, Nov 23 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111417

------------------------------------------------------------------------
r111417 | jam@chromium.org | Wed Nov 23 13:51:19 PST 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/sensors.h?r1=111417&r2=111416&pathrev=111417 (from /trunk/src/content/common/sensors.h revision 111374)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=111417&r2=111416&pathrev=111417
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/dbus/sensors_client.cc?r1=111417&r2=111416&pathrev=111417
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_about_handler.cc?r1=111417&r2=111416&pathrev=111417
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/sensors_listener.h?r1=111417&r2=111416&pathrev=111417 (from /trunk/src/content/common/sensors_listener.h revision 111374)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/aura/screen_orientation_listener.h?r1=111417&r2=111416&pathrev=111417
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/sensors/sensors_provider.h?r1=111417&r2=111416&pathrev=111417
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/sensors/sensors_provider_impl.h?r1=111417&r2=111416&pathrev=111417
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sensors.h?r1=111417&r2=111416&pathrev=111417
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sensors_listener.h?r1=111417&r2=111416&pathrev=111417
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=111417&r2=111416&pathrev=111417
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/sensors/sensors_provider_impl.cc?r1=111417&r2=111416&pathrev=111417
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/aura/screen_orientation_listener.cc?r1=111417&r2=111416&pathrev=111417

Move sensors interface into content/public/browser (since it's only used by browser directory). Move everything into the content namespace and make the enums conform to the Content API convention.

BUG=98716
Review URL: http://codereview.chromium.org/8678019
------------------------------------------------------------------------
Project Member Comment 88 by bugdroid1@chromium.org, Nov 24 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111471

------------------------------------------------------------------------
r111471 | jam@chromium.org | Wed Nov 23 17:23:34 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/load_timing_observer.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/offline_resource_handler.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_file_resource_handler.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_netlog_observer.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/sync_resource_handler.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/cross_site_resource_handler.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_dispatcher.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/redirect_to_file_resource_handler.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/x509_user_cert_resource_handler.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/buffered_resource_handler.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/async_resource_handler.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_throttling_resource_handler.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/async_resource_handler.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_dispatcher_unittest.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_dispatcher.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/cross_site_resource_handler.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/render_view_fake_resources_test.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_netlog_observer.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_file_resource_handler.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/offline_resource_handler.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.cc?r1=111471&r2=111470&pathrev=111471
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/resource_response.h?r1=111471&r2=111470&pathrev=111471 (from /trunk/src/content/common/resource_response.h revision 111374)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host_unittest.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/load_timing_observer.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/resource_dispatcher_host_delegate.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_handler.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_resource_handler.cc?r1=111471&r2=111470&pathrev=111471
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_response.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_throttling_resource_handler.cc?r1=111471&r2=111470&pathrev=111471
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_response.cc?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_resource_handler.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/x509_user_cert_resource_handler.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/buffered_resource_handler.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/redirect_to_file_resource_handler.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/sync_resource_handler.h?r1=111471&r2=111470&pathrev=111471
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_messages.h?r1=111471&r2=111470&pathrev=111471

Move ResourceResponse struct into the Content API, since it's used in Chrome. While at it, I also made the ResourceResponse wrapper just derive from ResourceResponseHead, so that the parameters are accessed directly, instead of having to go through a member variable.

BUG=98716
Review URL: http://codereview.chromium.org/8680036
------------------------------------------------------------------------
Project Member Comment 89 by bugdroid1@chromium.org, Nov 25 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111604

------------------------------------------------------------------------
r111604 | tfarina@chromium.org | Fri Nov 25 10:28:19 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/render_view_devtools_agent_host.cc?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function.cc?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_render_view_host_observer.h?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_render_view_host_observer.cc?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function.h?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/DEPS?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/render_view_devtools_agent_host.h?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/webui_login_view.cc?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.cc?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_manager_browsertest.cc?r1=111604&r2=111603&pathrev=111604
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_observer.cc?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.h?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_message_handler.cc?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_render_view_host_observer.h?r1=111604&r2=111603&pathrev=111604
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/render_view_host_observer.cc?r1=111604&r2=111603&pathrev=111604 (from /trunk/src/content/browser/renderer_host/render_view_host_observer.cc revision 111603)
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/render_view_host_observer.h?r1=111604&r2=111603&pathrev=111604 (from /trunk/src/content/browser/renderer_host/render_view_host_observer.h revision 111603)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_render_view_host_observer.cc?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_message_handler.h?r1=111604&r2=111603&pathrev=111604
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_observer.h?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.h?r1=111604&r2=111603&pathrev=111604
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/test_navigation_observer.cc?r1=111604&r2=111603&pathrev=111604

Move RenderViewHostObserver to content/public/browser/ and put it into the content namespace.

BUG=98716
R=jam@chromium.org

Review URL: http://codereview.chromium.org/8676032
------------------------------------------------------------------------
Project Member Comment 90 by bugdroid1@chromium.org, Nov 28 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111695

------------------------------------------------------------------------
r111695 | joi@chromium.org | Mon Nov 28 04:51:39 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/net/fake_external_tab.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_thread_impl.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_list.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_main.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_thread_impl.h?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.h?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.h?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/net/fake_external_tab.h?r1=111695&r2=111694&pathrev=111695
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_shutdown.h?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/webui_screen_locker.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/memcheck/suppressions.txt?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_process_sub_thread.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_main_parts.h?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_browser_thread.h?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_shutdown.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_main.h?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/views/accessible_pane_view.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/tools/DEPS?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/gtk_util.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/login_utils_browsertest.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_frame.gyp?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main_loop.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_shutdown.h?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_context.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_browser_thread.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.h?r1=111695&r2=111694&pathrev=111695
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_thread_delegate.h?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main_loop.h?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_thread.h?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/input_method/xkeyboard.cc?r1=111695&r2=111694&pathrev=111695
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/profiles/generate_profile.cc?r1=111695&r2=111694&pathrev=111695

Have content/ create and destroy its own threads.

Change embedding API and embedders to allow for this.

Push inheritance of base::Thread down to content::BrowserThreadImpl so
that content::BrowserThread is just a namespace for API functions.

This change temporarily disables chrome_frame_net_tests as agreed by the CF lead, see bug 105435.

TBR=ben@chromium.org (IWYU change only)
BUG=98716,104578,105435

Review URL: http://codereview.chromium.org/8477004
------------------------------------------------------------------------
Project Member Comment 91 by bugdroid1@chromium.org, Nov 28 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111698

------------------------------------------------------------------------
r111698 | joi@chromium.org | Mon Nov 28 06:00:36 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/net/fake_external_tab.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_thread_impl.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_list.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_main.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_thread_impl.h?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.h?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.h?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/net/fake_external_tab.h?r1=111698&r2=111697&pathrev=111698
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_shutdown.h?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/webui_screen_locker.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/memcheck/suppressions.txt?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_process_sub_thread.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_main_parts.h?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_browser_thread.h?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_shutdown.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_main.h?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/views/accessible_pane_view.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/tools/DEPS?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/gtk_util.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/login_utils_browsertest.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_frame.gyp?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main_loop.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_shutdown.h?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_context.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_browser_thread.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.h?r1=111698&r2=111697&pathrev=111698
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_thread_delegate.h?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main_loop.h?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_thread.h?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/input_method/xkeyboard.cc?r1=111698&r2=111697&pathrev=111698
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/profiles/generate_profile.cc?r1=111698&r2=111697&pathrev=111698

Revert 111695 - Have content/ create and destroy its own threads.
Reason: Problems on official builders.

Change embedding API and embedders to allow for this.

Push inheritance of base::Thread down to content::BrowserThreadImpl so
that content::BrowserThread is just a namespace for API functions.

This change temporarily disables chrome_frame_net_tests as agreed by the CF lead, see bug 105435.

TBR=ben@chromium.org (IWYU change only)
BUG=98716,104578,105435

Review URL: http://codereview.chromium.org/8477004

TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/8718012
------------------------------------------------------------------------
Project Member Comment 92 by bugdroid1@chromium.org, Nov 28 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111705

------------------------------------------------------------------------
r111705 | joi@chromium.org | Mon Nov 28 07:56:41 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/net/fake_external_tab.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_thread_impl.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_list.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_main.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_thread_impl.h?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.h?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.h?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/net/fake_external_tab.h?r1=111705&r2=111704&pathrev=111705
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_shutdown.h?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/webui_screen_locker.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/memcheck/suppressions.txt?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_process_sub_thread.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_main_parts.h?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_browser_thread.h?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_shutdown.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/tools/sync_listen_notifications.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_main.h?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/views/accessible_pane_view.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/tools/DEPS?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/gtk_util.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/login_utils_browsertest.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_frame.gyp?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main_loop.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_shutdown.h?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_context.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_browser_thread.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.h?r1=111705&r2=111704&pathrev=111705
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_thread_delegate.h?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main_loop.h?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_thread.h?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/input_method/xkeyboard.cc?r1=111705&r2=111704&pathrev=111705
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/profiles/generate_profile.cc?r1=111705&r2=111704&pathrev=111705

Have content/ create and destroy its own threads.  (Re-land)

Change embedding API and embedders to allow for this.

Push inheritance of base::Thread down to content::BrowserThreadImpl so
that content::BrowserThread is just a namespace for API functions.

This change temporarily disables chrome_frame_net_tests as agreed by the CF lead, see bug 105435.

TBR=ben@chromium.org (IWYU change only)
BUG=98716,104578,105435

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111695
Reverted (problems on official bot): r111698

Review URL: http://codereview.chromium.org/8477004
------------------------------------------------------------------------
Project Member Comment 93 by bugdroid1@chromium.org, Nov 28 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111803

------------------------------------------------------------------------
r111803 | jam@chromium.org | Mon Nov 28 15:08:03 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognizer.h?r1=111803&r2=111802&pathrev=111803
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/speech_input_result.h?r1=111803&r2=111802&pathrev=111803 (from /trunk/src/content/common/speech_input_result.h revision 111644)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_input_dispatcher_host.h?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_input_dispatcher_host.cc?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognizer.cc?r1=111803&r2=111802&pathrev=111803
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/speech_input_result.cc?r1=111803&r2=111802&pathrev=111803 (from /trunk/src/content/common/speech_input_result.cc revision 111644)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognition_request.cc?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_input_browsertest.cc?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_extension_manager.cc?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_extension_apitest.cc?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_input_manager.h?r1=111803&r2=111802&pathrev=111803
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/speech_input_result.h?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/speech_input_dispatcher.h?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/chrome_speech_input_manager.cc?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/chrome_speech_input_manager.h?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/speech_input_dispatcher.cc?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_input_manager.cc?r1=111803&r2=111802&pathrev=111803
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/speech_input_result.cc?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_extension_manager.h?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognition_request_unittest.cc?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognition_request.h?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognizer_unittest.cc?r1=111803&r2=111802&pathrev=111803
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/speech_input_messages.h?r1=111803&r2=111802&pathrev=111803

Move SpeechInputResult into content/public since it's used in chrome. Also make the enums match the Content API naming convention.

BUG=98716
Review URL: http://codereview.chromium.org/8664006
------------------------------------------------------------------------
Project Member Comment 94 by bugdroid1@chromium.org, Nov 28 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111813

------------------------------------------------------------------------
r111813 | jam@chromium.org | Mon Nov 28 15:33:12 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=111813&r2=111812&pathrev=111813
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc?r1=111813&r2=111812&pathrev=111813
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=111813&r2=111812&pathrev=111813
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/webplugin_proxy.cc?r1=111813&r2=111812&pathrev=111813
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/section_util_win.h?r1=111813&r2=111812&pathrev=111813
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/section_util_win.cc?r1=111813&r2=111812&pathrev=111813
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=111813&r2=111812&pathrev=111813

Remove section_util_win since it had two functions that were used in three places. Also, all the other places in the code that use DuplicateHandle call it directly. If we want to have a wrapper around it, it should probably go into base and we should convert all users at the same time.

BUG=98716
Review URL: http://codereview.chromium.org/8729002
------------------------------------------------------------------------
Project Member Comment 95 by bugdroid1@chromium.org, Nov 29 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111951

------------------------------------------------------------------------
r111951 | jam@chromium.org | Tue Nov 29 08:12:24 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/external_process_importer_bridge.h?r1=111951&r2=111950&pathrev=111951
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/external_process_importer_bridge.cc?r1=111951&r2=111950&pathrev=111951
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/utility/chrome_content_utility_client.cc?r1=111951&r2=111950&pathrev=111951

Remove ChildThread dependency from Chrome. In the future we might want to expose it as an interface, but for now that's not required.

BUG=98716
Review URL: http://codereview.chromium.org/8726023
------------------------------------------------------------------------
Project Member Comment 96 by bugdroid1@chromium.org, Nov 29 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111957

------------------------------------------------------------------------
r111957 | jam@chromium.org | Tue Nov 29 09:02:39 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details.cc?r1=111957&r2=111956&pathrev=111957
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_about_handler.cc?r1=111957&r2=111956&pathrev=111957
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_info.cc?r1=111957&r2=111956&pathrev=111957
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/system/syslogs_provider.cc?r1=111957&r2=111956&pathrev=111957
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_info.h?r1=111957&r2=111956&pathrev=111957
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details.h?r1=111957&r2=111956&pathrev=111957
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=111957&r2=111956&pathrev=111957

Move the RendererProcessType enum out of ChildProcessInfo. It's actually never set on that object, and is only used/set by chrome, so moved it out to memory_details.h:ProcessMemoryInformation.

BUG=98716
Review URL: http://codereview.chromium.org/8726022
------------------------------------------------------------------------
Project Member Comment 97 by bugdroid1@chromium.org, Nov 29 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111959

------------------------------------------------------------------------
r111959 | jam@chromium.org | Tue Nov 29 09:03:35 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=111959&r2=111958&pathrev=111959

Tighten up chrome/browser's DEPS so that we don't have any more includes from content/common while we remove the last ones.

BUG=98716
Review URL: http://codereview.chromium.org/8727035
------------------------------------------------------------------------
Project Member Comment 98 by bugdroid1@chromium.org, Nov 29 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112024

------------------------------------------------------------------------
r112024 | jam@chromium.org | Tue Nov 29 13:11:47 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service.h?r1=112024&r2=112023&pathrev=112024
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=112024&r2=112023&pathrev=112024
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.cc?r1=112024&r2=112023&pathrev=112024

Remove chrome dependency on PepperPluginRegistry. This was used only by extension code to add additional mimetypes for the NaCl plugin. Since the Chrome code is what added the NaCl plugin, it doesn't need to ask content to get the list from it. As for the --register-pepper-plugins, I've been told this isn't necessary anymore.

BUG=98716
Review URL: http://codereview.chromium.org/8725042
------------------------------------------------------------------------
Project Member Comment 99 by bugdroid1@chromium.org, Nov 30 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112085

------------------------------------------------------------------------
r112085 | jam@chromium.org | Tue Nov 29 16:49:21 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context.cc?r1=112085&r2=112084&pathrev=112085
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/geolocation_dispatcher_host.cc?r1=112085&r2=112084&pathrev=112085
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=112085&r2=112084&pathrev=112085
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/isolated_app_browsertest.cc?r1=112085&r2=112084&pathrev=112085
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc?r1=112085&r2=112084&pathrev=112085
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context.h?r1=112085&r2=112084&pathrev=112085
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=112085&r2=112084&pathrev=112085
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/geolocation_permission_context.cc?r1=112085&r2=112084&pathrev=112085
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc?r1=112085&r2=112084&pathrev=112085
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/geolocation_permission_context.h?r1=112085&r2=112084&pathrev=112085
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_context.cc?r1=112085&r2=112084&pathrev=112085

Hide geolocation_messages.h from chrome. It was only used in a test. Instead of having the GeolocationPermissionContext implementation have to call a static method in the interface, give it a callback when requesting permission. That way in tests we can just give a different callback. Also removed two trivial includes in this change.

BUG=98716
Review URL: http://codereview.chromium.org/8662041
------------------------------------------------------------------------
Comment 100 by a...@chromium.org, Nov 30 2011
Blocking: 105875
Project Member Comment 101 by bugdroid1@chromium.org, Nov 30 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112259

------------------------------------------------------------------------
r112259 | jam@chromium.org | Wed Nov 30 10:56:17 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.cc?r1=112259&r2=112258&pathrev=112259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/nacl/nacl_main.cc?r1=112259&r2=112258&pathrev=112259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=112259&r2=112258&pathrev=112259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=112259&r2=112258&pathrev=112259
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main.cc?r1=112259&r2=112258&pathrev=112259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=112259&r2=112258&pathrev=112259

Remove child_process.h includes from chrome (specifically WaitForDebugger). I moved the browser process usage to content. For the NaCl usage, it wasn't working anyways since it wasn't being passed to the process (and if it was, the message box wouldn't work on Windows because of sandbox). When this is needed again, we can figure out a good way of doing it.

BUG=98716
Review URL: http://codereview.chromium.org/8686014
------------------------------------------------------------------------
Project Member Comment 102 by bugdroid1@chromium.org, Nov 30 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112290

------------------------------------------------------------------------
r112290 | stevenjb@chromium.org | Wed Nov 30 13:20:21 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.cc?r1=112290&r2=112289&pathrev=112290
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main_extra_parts.h?r1=112290&r2=112289&pathrev=112290

Fixup ordering of new thread init parts

This fixes some ordering from http://codereview.chromium.org/8477004

Change-Id: Icf945d0ebfbb766f7f9315a39f5469dee03873e1

BUG=98716, 104578, 105435
TEST=Run tests on all platforms


Review URL: http://codereview.chromium.org/8755001
------------------------------------------------------------------------
Project Member Comment 103 by bugdroid1@chromium.org, Nov 30 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112312

------------------------------------------------------------------------
r112312 | jam@chromium.org | Wed Nov 30 14:31:51 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_child_process_host.h?r1=112312&r2=112311&pathrev=112312
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_child_process_host.cc?r1=112312&r2=112311&pathrev=112312
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_utility_process_host.cc?r1=112312&r2=112311&pathrev=112312

Don't make ServiceChildProcessHost derive from ChildProcessInfo. It didn't really need to. This is needed since code in chrome will only be able to see interfaces from content's public API.

BUG=98716
Review URL: http://codereview.chromium.org/8755002
------------------------------------------------------------------------
Project Member Comment 104 by bugdroid1@chromium.org, Dec 1 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112353

------------------------------------------------------------------------
r112353 | jam@chromium.org | Wed Nov 30 16:39:12 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_service.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_view_win.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details_win.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_resource_providers.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/nacl_host/nacl_broker_service_win.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_message_filter.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_policy.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host_request_info.h?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/debug_flags.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/about_ui.cc?r1=112353&r2=112352&pathrev=112353
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/process_type.h?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_process_host.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/tracking_synchronizer.h?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_info.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/worker_devtools_manager.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/tracking_synchronizer.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/nacl_host/nacl_broker_host_win.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_process_host.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host_request_info.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service_unittest.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service.h?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ppapi_plugin_process_host.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/automation/proxy_launcher.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host_unittest.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details.h?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_render_message_filter.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_process_host.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details_linux.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/network_delay_listener_unittest.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/gview_request_interceptor_unittest.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/utility_process_host.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details_mac.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_info.h?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/workers_ui.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_worker_resource_provider.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_queue_unittest.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/debug_flags.h?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/nacl_host/nacl_process_host.cc?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_message_filter.h?r1=112353&r2=112352&pathrev=112353
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.h?r1=112353&r2=112352&pathrev=112353

Move the ProcessType enum out to its own file. This is in preparation for getting rid of ChildProcessInfo.

BUG=98716
Review URL: http://codereview.chromium.org/8760011
------------------------------------------------------------------------
Project Member Comment 105 by bugdroid1@chromium.org, Dec 1 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112361

------------------------------------------------------------------------
r112361 | jam@chromium.org | Wed Nov 30 16:50:11 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=112361&r2=112360&pathrev=112361
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.h?r1=112361&r2=112360&pathrev=112361
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.h?r1=112361&r2=112360&pathrev=112361
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=112361&r2=112360&pathrev=112361
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.h?r1=112361&r2=112360&pathrev=112361
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_details.h?r1=112361&r2=112360&pathrev=112361
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/navigation_types.h?r1=112361&r2=112360&pathrev=112361
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/navigation_type.h?r1=112361&r2=112360&pathrev=112361 (from /trunk/src/content/public/browser/navigation_types.h revision 112318)

Rename navigation_types.h to navigation_type.h to match the rest of the enum files.

BUG=98716
Review URL: http://codereview.chromium.org/8758011
------------------------------------------------------------------------
Project Member Comment 106 by bugdroid1@chromium.org, Dec 1 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112365

------------------------------------------------------------------------
r112365 | jam@chromium.org | Wed Nov 30 17:04:39 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host_mac.mm?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_process_manager.h?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_resource_providers.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/background_contents.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webkit_preferences.h?r1=112365&r2=112364&pathrev=112365
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_view_type.h?r1=112365&r2=112364&pathrev=112365 (from /trunk/src/chrome/common/chrome_view_types.h revision 112301)
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_view_types.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_helper.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_manager_extension_api.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_helper.h?r1=112365&r2=112364&pathrev=112365
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_view_type.cc?r1=112365&r2=112364&pathrev=112365 (from /trunk/src/chrome/common/chrome_view_types.cc revision 112301)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_messages.h?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/schema_generated_bindings.cc?r1=112365&r2=112364&pathrev=112365
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/view_types.h?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_process_manager.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=112365&r2=112364&pathrev=112365
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/view_type.h?r1=112365&r2=112364&pathrev=112365 (from /trunk/src/content/public/common/view_types.h revision 112301)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_delegate.h?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_common.gypi?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/network_delay_listener_unittest.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/extension_settings_handler.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_input_manager.cc?r1=112365&r2=112364&pathrev=112365
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/network_delay_listener.cc?r1=112365&r2=112364&pathrev=112365
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_view_types.h?r1=112365&r2=112364&pathrev=112365

Move view_types.h to view_type.h, since that's the standard name for enums.

BUG=98716
Review URL: http://codereview.chromium.org/8760012
------------------------------------------------------------------------
Project Member Comment 107 by bugdroid1@chromium.org, Dec 1 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112408

------------------------------------------------------------------------
r112408 | jam@chromium.org | Wed Nov 30 21:13:41 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details.cc?r1=112408&r2=112407&pathrev=112408
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_info.cc?r1=112408&r2=112407&pathrev=112408
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_info.h?r1=112408&r2=112407&pathrev=112408
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=112408&r2=112407&pathrev=112408
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/tracking_synchronizer.cc?r1=112408&r2=112407&pathrev=112408
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=112408&r2=112407&pathrev=112408
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/process_type.cc?r1=112408&r2=112407&pathrev=112408
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=112408&r2=112407&pathrev=112408
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/process_type.h?r1=112408&r2=112407&pathrev=112408

Move GetProcessTypeNameInEnglish beside the ProcessType enum where it belongs. This also helps reduce the dependencies on child_process_info.h from chrome, in preparation for removing the class altogether.

BUG=98716
Review URL: http://codereview.chromium.org/8757014
------------------------------------------------------------------------
Project Member Comment 108 by bugdroid1@chromium.org, Dec 1 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112455

------------------------------------------------------------------------
r112455 | joi@chromium.org | Thu Dec 01 05:09:04 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_item_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_tab_strip_model_observer.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_notification_manager_sync_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/webdata/autofill_profile_syncable_service_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_quota_service_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/redirect_to_file_resource_handler.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_notification_storage_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browsing_data_file_system_helper_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/search_engine_dialog_controller.mm?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/internal_auth_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/enumerate_modules_model_win.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_gtk.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/load_timing_observer_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/gaia/token_service_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/gaia/token_service_unittest.h?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/theme_source_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/disks/disk_mount_manager.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_browser_window_gtk.h?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/printer_manager_dialog_linux.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prefs/pref_service_mock_builder.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/url_blacklist_manager.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/owner_manager.h?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/ownership_service_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/network_action_predictor_database_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/signed_settings_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/signed_settings.h?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/encoding_menu_controller_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/cocoa_profile_test.h?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browsing_data_quota_helper_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/power_save_blocker_linux.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/cookie_fetcher_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/select_file_dialog_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/web_socket_proxy.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/enterprise_metrics_browsertest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_download_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/shortcuts_backend_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_thread.h?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_ui.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tts_apitest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_manager_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/omnibox_search_hint.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_notification_manager_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/notifier/non_blocking_invalidation_notifier_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_protocol/external_protocol_handler_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/extensions/extension_popup.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_special_storage_policy_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_info_cache_unittest.h?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/repost_form_warning_ui.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_tracker_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_manager_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/signed_settings_helper_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/component_updater/component_installers_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_settings_state_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/cookie_settings_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cookies_tree_model_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/proxy_service_factory.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_test.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_menu_manager_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/config_dir_policy_provider_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/component_updater/component_updater_service_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/owner_manager_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/ownership_service.h?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/constrained_window_gtk.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sync_prefs_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_about_handler_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.h?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/host_content_settings_map_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_host_impl.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_cloud_unittest.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc?r1=112455&r2=112454&pathrev=112455
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/content_settings_default_provider_unittest.cc?r1=112455&r2=112454&pathrev=112455

Switch to IWYU for files that previously were getting a bunch of
header files via io_thread.h or browser_thread.h

TBR=owners (previously approved on codereview 8477004)
BUG=98716

Review URL: http://codereview.chromium.org/8746023
------------------------------------------------------------------------
Project Member Comment 109 by bugdroid1@chromium.org, Dec 1 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112492

------------------------------------------------------------------------
r112492 | jam@chromium.org | Thu Dec 01 10:48:41 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ppapi_plugin_process_host.cc?r1=112492&r2=112491&pathrev=112492
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.cc?r1=112492&r2=112491&pathrev=112492
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/font_cache_dispatcher_win.h?r1=112492&r2=112491&pathrev=112492
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=112492&r2=112491&pathrev=112492
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.h?r1=112492&r2=112491&pathrev=112492
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/font_cache_dispatcher_win.cc?r1=112492&r2=112491&pathrev=112492
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ppapi_plugin_process_host.h?r1=112492&r2=112491&pathrev=112492
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_utility_process_host.h?r1=112492&r2=112491&pathrev=112492
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_host.cc?r1=112492&r2=112491&pathrev=112492
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=112492&r2=112491&pathrev=112492
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_host.h?r1=112492&r2=112491&pathrev=112492
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_utility_process_host.cc?r1=112492&r2=112491&pathrev=112492

Dispatch the Windows font caching IPCs in one filter. This avoids having the code that calls those functions be duplicated and also makes the chrome service code not know about internal content IPCs. It also cleans up ChildProcessHost a bit, which will be useful when it gets an interface around it for the Content API.

BUG=98716
Review URL: http://codereview.chromium.org/8759013
------------------------------------------------------------------------
Project Member Comment 110 by bugdroid1@chromium.org, Dec 1 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112500

------------------------------------------------------------------------
r112500 | jam@chromium.org | Thu Dec 01 11:56:32 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=112500&r2=112499&pathrev=112500
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_resource_providers.h?r1=112500&r2=112499&pathrev=112500
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_info.h?r1=112500&r2=112499&pathrev=112500
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_resource_providers.cc?r1=112500&r2=112499&pathrev=112500

Make TaskManager not use ChildProcessInfo. After this change, I will make BrowserChildProcessHost not derive from ChildProcessInfo, and just remove that struct completely.

BUG=98716
Review URL: http://codereview.chromium.org/8764021
------------------------------------------------------------------------
Project Member Comment 111 by bugdroid1@chromium.org, Dec 2 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112597

------------------------------------------------------------------------
r112597 | jam@chromium.org | Thu Dec 01 17:57:53 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/notification_types.h?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ppapi_plugin_process_host.cc?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_resource_providers.h?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_data_remover_impl.cc?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/mock_render_process_host.cc?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host_unittest.cc?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.h?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_resource_providers.cc?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service.cc?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.cc?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_host.h?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/mach_broker_mac.cc?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=112597&r2=112596&pathrev=112597
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_info.cc?r1=112597&r2=112596&pathrev=112597
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_info.h?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/workers_ui.cc?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_worker_resource_provider.cc?r1=112597&r2=112596&pathrev=112597
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/child_process_data.h?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_host.cc?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_process_host.cc?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=112597&r2=112596&pathrev=112597
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.h?r1=112597&r2=112596&pathrev=112597

Get rid of the ChildProcessInfo class. It was carrying unnecessary data, and the fact that some processes inherited from it was confusing. There's now a simpler struct, content::ChildProcessData. BrowserChildProcessHost uses composition instead of inheritence.

BUG=98716
Review URL: http://codereview.chromium.org/8770027
------------------------------------------------------------------------
Project Member Comment 112 by bugdroid1@chromium.org, Dec 2 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112682

------------------------------------------------------------------------
r112682 | joi@chromium.org | Fri Dec 02 05:00:16 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.cc?r1=112682&r2=112681&pathrev=112682
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.cc?r1=112682&r2=112681&pathrev=112682
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_main.cc?r1=112682&r2=112681&pathrev=112682
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.h?r1=112682&r2=112681&pathrev=112682
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browsing_data_local_storage_helper_browsertest.cc?r1=112682&r2=112681&pathrev=112682
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main_loop.h?r1=112682&r2=112681&pathrev=112682
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/webkit_thread_unittest.cc?r1=112682&r2=112681&pathrev=112682
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/webkit_thread.cc?r1=112682&r2=112681&pathrev=112682
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/webkit_thread.h?r1=112682&r2=112681&pathrev=112682
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main_loop.cc?r1=112682&r2=112681&pathrev=112682

Start/stop WebKitThread from BrowserMainLoop like other BrowserThreads.

Move WebKitThread to the content namespace.

Re-order thread objects in BrowserMainLoop declaration to match instantiation order.

BUG=98716


Review URL: http://codereview.chromium.org/8776007
------------------------------------------------------------------------
Project Member Comment 113 by bugdroid1@chromium.org, Dec 2 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112697

------------------------------------------------------------------------
r112697 | joi@chromium.org | Fri Dec 02 06:47:42 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.cc?r1=112697&r2=112696&pathrev=112697
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/testing_browser_process.h?r1=112697&r2=112696&pathrev=112697
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_thread_impl.cc?r1=112697&r2=112696&pathrev=112697
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.cc?r1=112697&r2=112696&pathrev=112697
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/process_singleton_linux.cc?r1=112697&r2=112696&pathrev=112697
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/testing_browser_process.cc?r1=112697&r2=112696&pathrev=112697
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.h?r1=112697&r2=112696&pathrev=112697
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.h?r1=112697&r2=112696&pathrev=112697
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/proxy_service_factory.cc?r1=112697&r2=112696&pathrev=112697
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process.h?r1=112697&r2=112696&pathrev=112697
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_thread.h?r1=112697&r2=112696&pathrev=112697

Remove IOThread::message_loop().

Instead introduce BrowserThread::UnsafeGetMessageLoop which is used in
a couple of places.  This will be removed in a follow-up change.  I
could have used UnsafeGetBrowserThread(id)->message_loop() but this is
even easier to search for.

Also, remove a couple of BrowserProcess accessors that aren't used by anybody, and that were using UnsafeGetBrowserThread.

TBR=battre@chromium.org
BUG=98716


Review URL: http://codereview.chromium.org/8775014
------------------------------------------------------------------------
Project Member Comment 114 by bugdroid1@chromium.org, Dec 2 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112732

------------------------------------------------------------------------
r112732 | jam@chromium.org | Fri Dec 02 10:05:20 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=112732&r2=112731&pathrev=112732
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/intents/web_intent_picker_controller.cc?r1=112732&r2=112731&pathrev=112732

Trim chrome/browser/DEPS after the recent refactorings.

BUG=98716
Review URL: http://codereview.chromium.org/8776040
------------------------------------------------------------------------
Project Member Comment 115 by bugdroid1@chromium.org, Dec 2 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112769

------------------------------------------------------------------------
r112769 | jam@chromium.org | Fri Dec 02 12:24:49 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ppapi_plugin_process_host.cc?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_data_remover_impl.cc?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ppapi_plugin_process_host.h?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_utility_process_host.h?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/nacl_host/nacl_process_host.h?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.cc?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_process_host.h?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_process_host.cc?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_host.h?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_process_host.cc?r1=112769&r2=112768&pathrev=112769
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_child_process_host.cc?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/utility_process_host.cc?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.cc?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/utility_process_host.h?r1=112769&r2=112768&pathrev=112769
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_child_process_host.h?r1=112769&r2=112768&pathrev=112769
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/child_process_host_delegate.h?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_process_host.h?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_host.cc?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/nacl_host/nacl_broker_host_win.cc?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_process_host.cc?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_loader_posix.cc?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/nacl_host/nacl_process_host.cc?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.h?r1=112769&r2=112768&pathrev=112769
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_utility_process_host.cc?r1=112769&r2=112768&pathrev=112769

Don't make classes derive from ChildProcessHost, and instead have them use it through composition. This cleans up the code and makes it easier to understand (as well as more closely conform to the Google C++ style guide). It also makes it possible to add an interface around ChildProcessHost in a future change.

BUG=98716
Review URL: http://codereview.chromium.org/8774040
------------------------------------------------------------------------
Project Member Comment 116 by bugdroid1@chromium.org, Dec 3 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112877

------------------------------------------------------------------------
r112877 | jam@chromium.org | Fri Dec 02 22:57:47 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/notification_types.h?r1=112877&r2=112876&pathrev=112877
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/nacl_host/nacl_process_host.h?r1=112877&r2=112876&pathrev=112877
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.cc?r1=112877&r2=112876&pathrev=112877
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/nacl_host/nacl_process_host.cc?r1=112877&r2=112876&pathrev=112877
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.h?r1=112877&r2=112876&pathrev=112877

Simplify BrowserChildProcessHost in preparation for refactoring it so that consumers embed it in their class instead of deriving from it. The GetChildTerminationStatus override in NaclProcessHost seemed unnecessary since that's what the default implementation does. NaClProcessHost::OnChildDied can be done in the destructor.

BUG=98716
Review URL: http://codereview.chromium.org/8771041
------------------------------------------------------------------------
Project Member Comment 117 by bugdroid1@chromium.org, Dec 3 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112878

------------------------------------------------------------------------
r112878 | jam@chromium.org | Fri Dec 02 23:10:44 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ppapi_plugin_process_host.cc?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_data_remover_impl.cc?r1=112878&r2=112877&pathrev=112878
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_host_impl.cc?r1=112878&r2=112877&pathrev=112878 (from /trunk/src/content/common/child_process_host.cc revision 112775)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/mock_render_process_host.cc?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host_unittest.cc?r1=112878&r2=112877&pathrev=112878
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_host_impl.h?r1=112878&r2=112877&pathrev=112878 (from /trunk/src/content/common/child_process_host.h revision 112775)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_utility_process_host.h?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.cc?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/service/service_process_control.cc?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_process_host.cc?r1=112878&r2=112877&pathrev=112878
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_host.h?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_process_host.cc?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/utility_process_host.cc?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.cc?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/gpu/gpu_process_host.h?r1=112878&r2=112877&pathrev=112878
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process_host.cc?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/nacl_host/nacl_broker_host_win.cc?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_process_host.cc?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_loader_posix.cc?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/nacl_host/nacl_process_host.cc?r1=112878&r2=112877&pathrev=112878
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/child_process_host.h?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_child_process_host.h?r1=112878&r2=112877&pathrev=112878
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/service/service_utility_process_host.cc?r1=112878&r2=112877&pathrev=112878

Make ChildProcessHost be used through an interface in content/public, instead of by inheritence.

BUG=98716
Review URL: http://codereview.chromium.org/8787004
------------------------------------------------------------------------
Project Member Comment 118 by bugdroid1@chromium.org, Dec 5 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112987

------------------------------------------------------------------------
r112987 | jam@chromium.org | Mon Dec 05 08:43:55 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_messages_browsertest.cc?r1=112987&r2=112986&pathrev=112987
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/chrome_render_view_test.cc?r1=112987&r2=112986&pathrev=112987
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/mock_render_thread.h?r1=112987&r2=112986&pathrev=112987
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/mock_render_thread.cc?r1=112987&r2=112986&pathrev=112987
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_browsertest.cc?r1=112987&r2=112986&pathrev=112987

Get rid of view_messages.h dependency in extension_messages_browsertest.cc by adding a method to MockRenderThread instead.

BUG=98716
Review URL: http://codereview.chromium.org/8801001
------------------------------------------------------------------------
Project Member Comment 119 by bugdroid1@chromium.org, Dec 5 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=112988

------------------------------------------------------------------------
r112988 | jam@chromium.org | Mon Dec 05 08:51:41 PST 2011

Changed paths:
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/accessibility/browser_accessibility_win_unittest.cc?r1=112988&r2=112987&pathrev=112988
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/accessibility/browser_accessibility_manager_unittest.cc?r1=112988&r2=112987&pathrev=112988
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/accessibility/renderer_accessibility_browsertest.cc?r1=112988&r2=112987&pathrev=112988
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=112988&r2=112987&pathrev=112988
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/accessibility/browser_accessibility_win_unittest.cc?r1=112988&r2=112987&pathrev=112988 (from /trunk/src/chrome/browser/accessibility/browser_accessibility_win_unittest.cc revision 112987)
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/accessibility/browser_accessibility_manager_unittest.cc?r1=112988&r2=112987&pathrev=112988 (from /trunk/src/chrome/browser/accessibility/browser_accessibility_manager_unittest.cc revision 112878)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=112988&r2=112987&pathrev=112988
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/accessibility/renderer_accessibility_browsertest.cc?r1=112988&r2=112987&pathrev=112988 (from /trunk/src/chrome/browser/accessibility/renderer_accessibility_browsertest.cc revision 112878)

Move a bunch of accessibility tests in chrome that have no chrome dependencies to content. We want code that tests content to live alongside the code its testing. Also, some of these depend on view_messages.h, which is internal to content.

BUG=98716
Review URL: http://codereview.chromium.org/8804001
------------------------------------------------------------------------
Project Member Comment 120 by bugdroid1@chromium.org, Dec 5 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=113006

------------------------------------------------------------------------
r113006 | jam@chromium.org | Mon Dec 05 12:29:53 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc?r1=113006&r2=113005&pathrev=113006
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/test_tab_contents.h?r1=113006&r2=113005&pathrev=113006
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc?r1=113006&r2=113005&pathrev=113006
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/test_tab_contents.cc?r1=113006&r2=113005&pathrev=113006
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_manager_unittest.cc?r1=113006&r2=113005&pathrev=113006
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager_unittest.cc?r1=113006&r2=113005&pathrev=113006
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc?r1=113006&r2=113005&pathrev=113006
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/offline/offline_load_page_unittest.cc?r1=113006&r2=113005&pathrev=113006

Make TestTabContents::TestDidNavigate not take a ViewHostMsg_FrameNavigate_Params, since that's an internal content IPC struct.

BUG=98716
Review URL: http://codereview.chromium.org/8801003
------------------------------------------------------------------------
Project Member Comment 121 by bugdroid1@chromium.org, Dec 5 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=113015

------------------------------------------------------------------------
r113015 | chrome-bot@google.com | Mon Dec 05 13:00:01 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.cc?r1=113015&r2=113014&pathrev=113015
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.h?r1=113015&r2=113014&pathrev=113015
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=113015&r2=113014&pathrev=113015
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/notification_types.h?r1=113015&r2=113014&pathrev=113015
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_focus_uitest.cc?r1=113015&r2=113014&pathrev=113015
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=113015&r2=113014&pathrev=113015
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.h?r1=113015&r2=113014&pathrev=113015
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=113015&r2=113014&pathrev=113015

Remove OnMessageReceived that was using internal content IPCs in a chrome test. Dispatch the IPC in RenderViewHost instead of TabContents to solve this (it's only used by tests anyways). Remove test_utils methods that weren't being used.

BUG=98716
Review URL: http://codereview.chromium.org/8801002
------------------------------------------------------------------------
Project Member Comment 122 by bugdroid1@chromium.org, Dec 5 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=113017

------------------------------------------------------------------------
r113017 | jam@chromium.org | Mon Dec 05 12:56:16 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/OWNERS?r1=113017&r2=113016&pathrev=113017
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/OWNERS?r1=113017&r2=113016&pathrev=113017
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/OWNERS?r1=113017&r2=113016&pathrev=113017

Add avi and joi as OWNERS for content\public. Please add me as a reviewer for new interfaces until browser is done. Also add avi as owner for common and renderer.

BUG=98716
Review URL: http://codereview.chromium.org/8799014
------------------------------------------------------------------------
Project Member Comment 123 by bugdroid1@chromium.org, Dec 5 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=113025

------------------------------------------------------------------------
r113025 | avi@chromium.org | Mon Dec 05 13:20:11 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc?r1=113025&r2=113024&pathrev=113025
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/test_tab_contents.h?r1=113025&r2=113024&pathrev=113025
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc?r1=113025&r2=113024&pathrev=113025
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/test_tab_contents.cc?r1=113025&r2=113024&pathrev=113025
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_manager_unittest.cc?r1=113025&r2=113024&pathrev=113025
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager_unittest.cc?r1=113025&r2=113024&pathrev=113025
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc?r1=113025&r2=113024&pathrev=113025
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/offline/offline_load_page_unittest.cc?r1=113025&r2=113024&pathrev=113025

Revert 113006 - Make TestTabContents::TestDidNavigate not take a ViewHostMsg_FrameNavigate_Params, since that's an internal content IPC struct.

BUG=98716
Review URL: http://codereview.chromium.org/8801003

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8799015
------------------------------------------------------------------------
Project Member Comment 124 by bugdroid1@chromium.org, Dec 5 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=113050

------------------------------------------------------------------------
r113050 | jam@chromium.org | Mon Dec 05 14:57:16 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc?r1=113050&r2=113049&pathrev=113050
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/test_tab_contents.h?r1=113050&r2=113049&pathrev=113050
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc?r1=113050&r2=113049&pathrev=113050
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/test_tab_contents.cc?r1=113050&r2=113049&pathrev=113050
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_manager_unittest.cc?r1=113050&r2=113049&pathrev=113050
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager_unittest.cc?r1=113050&r2=113049&pathrev=113050
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc?r1=113050&r2=113049&pathrev=113050
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/offline/offline_load_page_unittest.cc?r1=113050&r2=113049&pathrev=113050

Make TestTabContents::TestDidNavigate not take a ViewHostMsg_FrameNavigate_Params, since that's an internal content IPC struct.

BUG=98716
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113006
Review URL: http://codereview.chromium.org/8801003
------------------------------------------------------------------------
Project Member Comment 125 by bugdroid1@chromium.org, Dec 6 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=113110

------------------------------------------------------------------------
r113110 | sail@chromium.org | Mon Dec 05 20:34:04 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.cc?r1=113110&r2=113109&pathrev=113110
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.h?r1=113110&r2=113109&pathrev=113110
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=113110&r2=113109&pathrev=113110
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/notification_types.h?r1=113110&r2=113109&pathrev=113110
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_focus_uitest.cc?r1=113110&r2=113109&pathrev=113110
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=113110&r2=113109&pathrev=113110
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.h?r1=113110&r2=113109&pathrev=113110
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=113110&r2=113109&pathrev=113110

Revert 113015 - speculative revert to see if this fixes the interactive test breakage
Remove OnMessageReceived that was using internal content IPCs in a chrome test. Dispatch the IPC in RenderViewHost instead of TabContents to solve this (it's only used by tests anyways). Remove test_utils methods that weren't being used.

BUG=98716
Review URL: http://codereview.chromium.org/8801002

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8817007
------------------------------------------------------------------------
Project Member Comment 126 by bugdroid1@chromium.org, Dec 6 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=113118

------------------------------------------------------------------------
r113118 | sail@chromium.org | Mon Dec 05 22:12:56 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.cc?r1=113118&r2=113117&pathrev=113118
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.h?r1=113118&r2=113117&pathrev=113118
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=113118&r2=113117&pathrev=113118
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/notification_types.h?r1=113118&r2=113117&pathrev=113118
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_focus_uitest.cc?r1=113118&r2=113117&pathrev=113118
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=113118&r2=113117&pathrev=113118
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.h?r1=113118&r2=113117&pathrev=113118
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=113118&r2=113117&pathrev=113118

Revert 113110 - backing out 113015 didn't fix the interactive test bot. Restoring the CL
Revert 113015 - speculative revert to see if this fixes the interactive test breakage
Remove OnMessageReceived that was using internal content IPCs in a chrome test. Dispatch the IPC in RenderViewHost instead of TabContents to solve this (it's only used by tests anyways). Remove test_utils methods that weren't being used.

BUG=98716
Review URL: http://codereview.chromium.org/8801002

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8817007

TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/8821005
------------------------------------------------------------------------
Project Member Comment 127 by bugdroid1@chromium.org, Dec 6 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=113285

------------------------------------------------------------------------
r113285 | jam@chromium.org | Tue Dec 06 15:36:55 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/test_render_view_host.h?r1=113285&r2=113284&pathrev=113285
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/test_render_view_host.cc?r1=113285&r2=113284&pathrev=113285
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/thumbnail_generator_unittest.cc?r1=113285&r2=113284&pathrev=113285

Get rid of the last view_messages.h include in chrome, other than tab_contents_views_mac.mm and render_view_host_delegate_helper.cc, both of which Avi is working on. I added a test method to fake a UpdateRect IPC message for the thumbnail test.

BUG=98716

Review URL: http://codereview.chromium.org/8819005
------------------------------------------------------------------------
Project Member Comment 128 by bugdroid1@chromium.org, Dec 7 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=113367

------------------------------------------------------------------------
r113367 | jam@chromium.org | Wed Dec 07 01:19:06 PST 2011

Changed paths:
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc?r1=113367&r2=113366&pathrev=113367
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_unittest.cc?r1=113367&r2=113366&pathrev=113367 (from /trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc revision 113050)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prefs/pref_service_unittest.cc?r1=113367&r2=113366&pathrev=113367
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=113367&r2=113366&pathrev=113367
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=113367&r2=113366&pathrev=113367

Move web_contents_unittest.cc to content, where it belongs next to TabContents. Also rename it to tab_contents_unittests.cc. I've moved the one part that depended on PrefService to the pref service test.

BUG=98716
Review URL: http://codereview.chromium.org/8802024
------------------------------------------------------------------------
Project Member Comment 129 by bugdroid1@chromium.org, Dec 7 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=113377

------------------------------------------------------------------------
r113377 | joi@chromium.org | Wed Dec 07 04:03:42 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_protocol/external_protocol_handler.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/testing_browser_process.h?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_thread_impl.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/base_session_service.h?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/base_session_service.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/testing_browser_process.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.h?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/version_loader.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process.h?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_url_request_context.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_context.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/advanced_options_utils_win.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_init.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/proxy_service_factory.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_thread.h?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_url_request_context.h?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/printer_manager_dialog_win.cc?r1=113377&r2=113376&pathrev=113377
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/boot_times_loader.cc?r1=113377&r2=113376&pathrev=113377

Remove BrowserThread::UnsafeGetBrowserThread, add UnsafeGetMessageLoopForThread.

This also removes several accessors on BrowserProcess that are no longer used.

I wanted to remove all retrieval of MessageLoop objects via BrowserThread, but this proved harder than it looked, because several net:: classes use MessageLoop and have fairly deep assumptions that it is a real MessageLoop, e.g. they use MessageLoopForIO with its IO observers and so forth.  Therefore, we now have UnsafeGetMessageLoopForThread but UnsafeGetBrowserThread is gone.

TBR=abodenha@chromium.org
BUG=98716


Review URL: http://codereview.chromium.org/8769013
------------------------------------------------------------------------
Project Member Comment 130 by bugdroid1@chromium.org, Dec 13 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=114217

------------------------------------------------------------------------
r114217 | joi@chromium.org | Tue Dec 13 08:01:46 PST 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/DEPS?r1=114217&r2=114216&pathrev=114217

Add DEPS file disallowing content/public to depend back to content/.

BUG=98716


Review URL: http://codereview.chromium.org/8890075
------------------------------------------------------------------------
Project Member Comment 131 by bugdroid1@chromium.org, Dec 13 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=114288

------------------------------------------------------------------------
r114288 | joi@chromium.org | Tue Dec 13 14:18:59 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.h?r1=114288&r2=114287&pathrev=114288

Update comment on IOThread to point people to the right place if they
want some of the functionality that used to be there.

BUG=98716

Review URL: http://codereview.chromium.org/8905010
------------------------------------------------------------------------
Project Member Comment 132 by bugdroid1@chromium.org, Dec 14 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=114416

------------------------------------------------------------------------
r114416 | joi@chromium.org | Wed Dec 14 05:23:38 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/installed_loader.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/screen_locker_views.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/background/background_mode_manager.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_manager.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/file_manager_util.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/about_chrome_view.cc?r1=114416&r2=114415&pathrev=114416
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/user_metrics.h?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/user_metrics.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/themes/theme_service.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/wrench_menu.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/system_key_event_listener.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/browser_toolbar_gtk.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/content_settings/content_setting_bubble_model.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ntp/new_tab_ui.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_metrics_module.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/screen_locker.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/history_ui.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ntp/most_visited_handler.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/metrics_handler.cc?r1=114416&r2=114415&pathrev=114416
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/user_metrics.h?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run/first_run.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/omnibox/omnibox_view_win.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/content_settings_handler.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/flash_ui.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/language_options_handler_common.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/importer/import_lock_dialog_view.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_message_filter.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/importer/import_lock_dialog_gtk.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/keyword_editor_controller.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/wrench_menu_model.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/edit_search_engine_controller.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/content_settings_pref_provider.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/core_options_handler.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/app_controller_mac.mm?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/media/media_player.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browsing_data_remover.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/login_performer.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/content_settings_default_provider.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/first_run_bubble.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/file_system/file_system_dispatcher_host.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/chromeos/stats_options_handler.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/default_tab_drag_controller.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/cookie_settings.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_resource/web_resource_service.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/toolbar_view.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/host_content_settings_map.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/downloads_dom_handler.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/appcache/appcache_dispatcher_host.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_observer.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/gtk_theme_service.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/external_metrics.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_manager.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/advanced_options_handler.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/template_url.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_impl.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/locale_change_guard.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/critical_notification_bubble_view.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/pdf/pdf_unsupported_feature.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/language_options_handler.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/conflicts_ui.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_resource/notification_promo.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/browser_options_handler.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/extract_actions.py?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/options_ui.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_process_host.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run/first_run_win.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/database_message_filter.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/personal_options_handler.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/status/input_method_menu.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/back_forward_menu_model.cc?r1=114416&r2=114415&pathrev=114416
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm?r1=114416&r2=114415&pathrev=114416

Split UserMetrics into API vs. implementation. Move API to content/public.

TBR=davemoore@chromium.org
BUG=98716

Review URL: http://codereview.chromium.org/8919017
------------------------------------------------------------------------
Project Member Comment 133 by bugdroid1@chromium.org, Dec 14 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=114454

------------------------------------------------------------------------
r114454 | tfarina@chromium.org | Wed Dec 14 10:17:22 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_test_util.cc?r1=114454&r2=114453&pathrev=114454
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/webdata/web_database.cc?r1=114454&r2=114453&pathrev=114454
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/notification_service_impl.cc?r1=114454&r2=114453&pathrev=114454
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_store_mac.cc?r1=114454&r2=114453&pathrev=114454
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_test_util.h?r1=114454&r2=114453&pathrev=114454
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/typed_url_change_processor.cc?r1=114454&r2=114453&pathrev=114454
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/location_bar/page_action_image_view.cc?r1=114454&r2=114453&pathrev=114454
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/notification_service.h?r1=114454&r2=114453&pathrev=114454
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/util/extensions_activity_monitor_unittest.cc?r1=114454&r2=114453&pathrev=114454

Hide the process of instantiating NotificationServiceImpl from embedders.

Make NotificationService handle the process of instantiating NotificationServiceImpl instead.

BUG=98716
R=jam@chromium.org
TBR=akalin@chromium.org

Review URL: http://codereview.chromium.org/8913009
------------------------------------------------------------------------
Project Member Comment 134 by bugdroid1@chromium.org, Dec 15 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=114632

------------------------------------------------------------------------
r114632 | tfarina@chromium.org | Thu Dec 15 06:17:30 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=114632&r2=114631&pathrev=114632

Enfore through chrome/browser/DEPS that it can't include notification_service_impl.h anymore.

BUG=98716
R=jam@chromium.org

Review URL: http://codereview.chromium.org/8910011
------------------------------------------------------------------------
Project Member Comment 135 by bugdroid1@chromium.org, Dec 15 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=114651

------------------------------------------------------------------------
r114651 | joi@chromium.org | Thu Dec 15 08:55:11 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.cc?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_context.h?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile.h?r1=114651&r2=114650&pathrev=114651
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_context.h?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/drag_download_file.cc?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.cc?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browsing_instance.cc?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_request_handle.cc?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_browser_context.h?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_context.h?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_download_manager_delegate.cc?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager_impl.cc?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/pepper_file_message_filter.cc?r1=114651&r2=114650&pathrev=114651
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_policy_backend.cc?r1=114651&r2=114650&pathrev=114651

Trivial move of content::BrowserContext to content/public.

R=avi@chromium.org
TBR=rlp@chromium.org
BUG=98716
TEST=

Review URL: http://codereview.chromium.org/8921021
------------------------------------------------------------------------
Project Member Comment 136 by bugdroid1@chromium.org, Dec 16 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=114758

------------------------------------------------------------------------
r114758 | joi@chromium.org | Thu Dec 15 19:00:09 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/device_orientation/message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/plugin_info_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/media/video_capture_host.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/printing_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_resource_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_benchmarking_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/p2p/socket_dispatcher_host.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/media/audio_renderer_host.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/blob_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/clipboard_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/trace_message_filter.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/text_input_client_message_filter.mm?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/blob_message_filter.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/profiler_message_filter.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/resolve_proxy_msg_helper.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/gamepad_browser_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_input_dispatcher_host.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webrequest_api.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/file_utilities_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/geolocation_dispatcher_host.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/trace_controller.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/media/video_capture_host.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/media/media_stream_dispatcher_host.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/gamepad_browser_message_filter.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/mime_registry_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/p2p/socket_dispatcher_host.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/worker_devtools_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/file_system/file_system_dispatcher_host.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/search_provider_install_state_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_resource_message_filter.cc?r1=114758&r2=114757&pathrev=114758
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_message_filter.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_platform_mac.mm?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_message_filter.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/socket_stream_dispatcher_host.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/file_system/file_system_dispatcher_host.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/pepper_file_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/appcache/appcache_dispatcher_host.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_plugin_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/media/audio_input_renderer_host.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/media/audio_renderer_host.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/indexed_db_dispatcher_host.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/media/media_stream_dispatcher_host.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_render_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/dom_storage_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker/spellcheck_platform_mac.h?r1=114758&r2=114757&pathrev=114758
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/dom_storage_message_filter.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/pepper_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/profiler_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/media/audio_input_renderer_host.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/database_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/text_input_client_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_message_filter.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/quota_dispatcher_host.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/trace_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/database_message_filter.cc?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/appcache/appcache_dispatcher_host.h?r1=114758&r2=114757&pathrev=114758
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/gpu_message_filter.h?r1=114758&r2=114757&pathrev=114758

Move BrowserMessageFilter to public, and into content namespace.

TBR=abodenha@chromium.org for chrome/browser/printing/OWNERS
BUG=98716


Review URL: http://codereview.chromium.org/8912009
------------------------------------------------------------------------
Project Member Comment 137 by bugdroid1@chromium.org, Dec 16 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=114796

------------------------------------------------------------------------
r114796 | tfarina@chromium.org | Fri Dec 16 04:40:14 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/net/fake_external_tab.cc?r1=114796&r2=114795&pathrev=114796

chrome_frame: Include notification_service.h instead of notification_service_impl.h.

BUG=98716
R=jam@chromium.org

Review URL: http://codereview.chromium.org/8949017
------------------------------------------------------------------------
Project Member Comment 138 by bugdroid1@chromium.org, Dec 19 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=114992

------------------------------------------------------------------------
r114992 | joi@chromium.org | Mon Dec 19 08:09:43 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/arbitrator_dependency_factory.cc?r1=114992&r2=114991&pathrev=114992
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/access_token_store_browsertest.cc?r1=114992&r2=114991&pathrev=114992
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/access_token_store.cc?r1=114992&r2=114991&pathrev=114992
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/location_arbitrator.cc?r1=114992&r2=114991&pathrev=114992
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/location_arbitrator_unittest.cc?r1=114992&r2=114991&pathrev=114992
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/location_arbitrator.h?r1=114992&r2=114991&pathrev=114992
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/access_token_store.h?r1=114992&r2=114991&pathrev=114992
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/fake_access_token_store.h?r1=114992&r2=114991&pathrev=114992
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_access_token_store.cc?r1=114992&r2=114991&pathrev=114992
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/geolocation_provider_unittest.cc?r1=114992&r2=114991&pathrev=114992
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/fake_access_token_store.cc?r1=114992&r2=114991&pathrev=114992
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_access_token_store.h?r1=114992&r2=114991&pathrev=114992

Switch to PostTaskAndReply for AccessTokenStore.

This removes the only usage of the CancelableRequest class in
content/, and is in preparation for moving the class back to
chrome/browser.

The ability to cancel requests to the AccessTokenStore was never used in production, so the interface now changes to a simpler non-cancelable one, and the browsertest GeolocationAccessTokenStoreTest.CancelRequest which tested the functionality is removed.

BUG=98716

Review URL: http://codereview.chromium.org/8996006
------------------------------------------------------------------------
Project Member Comment 139 by bugdroid1@chromium.org, Dec 19 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=114994

------------------------------------------------------------------------
r114994 | tfarina@chromium.org | Mon Dec 19 08:21:05 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/off_the_record_profile_impl_unittest.cc?r1=114994&r2=114993&pathrev=114994
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm?r1=114994&r2=114993&pathrev=114994
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/testing_browser_process.h?r1=114994&r2=114993&pathrev=114994
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/testing_browser_process.cc?r1=114994&r2=114993&pathrev=114994
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_resource/promo_resource_service_unittest.cc?r1=114994&r2=114993&pathrev=114994
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/profiles/generate_profile.cc?r1=114994&r2=114993&pathrev=114994
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_info_cache_unittest.cc?r1=114994&r2=114993&pathrev=114994

Go through NotificationService interface in the remaining places.

BUG=98716
R=jam@chromium.org
TBR=mirandac@chromium.org

Review URL: http://codereview.chromium.org/8963033
------------------------------------------------------------------------
Project Member Comment 140 by bugdroid1@chromium.org, Dec 19 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=114997

------------------------------------------------------------------------
r114997 | joi@chromium.org | Mon Dec 19 08:55:12 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/arbitrator_dependency_factory.cc?r1=114997&r2=114996&pathrev=114997
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/access_token_store_browsertest.cc?r1=114997&r2=114996&pathrev=114997
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/access_token_store.cc?r1=114997&r2=114996&pathrev=114997
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/location_arbitrator.cc?r1=114997&r2=114996&pathrev=114997
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/location_arbitrator_unittest.cc?r1=114997&r2=114996&pathrev=114997
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/location_arbitrator.h?r1=114997&r2=114996&pathrev=114997
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/access_token_store.h?r1=114997&r2=114996&pathrev=114997
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/fake_access_token_store.h?r1=114997&r2=114996&pathrev=114997
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_access_token_store.cc?r1=114997&r2=114996&pathrev=114997
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/geolocation_provider_unittest.cc?r1=114997&r2=114996&pathrev=114997
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/fake_access_token_store.cc?r1=114997&r2=114996&pathrev=114997
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_access_token_store.h?r1=114997&r2=114996&pathrev=114997

Revert 114992 - Switch to PostTaskAndReply for AccessTokenStore.

This removes the only usage of the CancelableRequest class in
content/, and is in preparation for moving the class back to
chrome/browser.

The ability to cancel requests to the AccessTokenStore was never used in production, so the interface now changes to a simpler non-cancelable one, and the browsertest GeolocationAccessTokenStoreTest.CancelRequest which tested the functionality is removed.

BUG=98716

Review URL: http://codereview.chromium.org/8996006

TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/8992018
------------------------------------------------------------------------
Project Member Comment 141 by bugdroid1@chromium.org, Dec 20 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115043

------------------------------------------------------------------------
r115043 | jam@chromium.org | Mon Dec 19 16:04:51 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/html_dialog_window_controller.mm?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_container.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_manager.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/drag_data.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/background_contents.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_win.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/constrained_html_ui.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/default_tab_drag_controller.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/create_application_shortcut_view.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/web_intent_picker_gtk.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/aura/app_list_window.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_view.cc?r1=115043&r2=115042&pathrev=115043
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_page.h?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/html_dialog_gtk.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/omnibox/omnibox_view_views.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_ui.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/aeropeek_manager.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate_unittest.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/constrained_html_delegate_views.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller_unittest.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/constrained_html_delegate_mac.mm?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_manager_unittest.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_container.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_view_win.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/webui_login_view.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/omnibox/omnibox_view_win.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/html_dialog_view.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_unload_handler.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/constrained_html_delegate_gtk.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/applescript/tab_applescript.mm?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/child_process_data.h?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115043&r2=115042&pathrev=115043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc?r1=115043&r2=115042&pathrev=115043

Start creating the content::WebPage interface around TabContents. This is just the start of moving 4 very commonly used unix_hacker functions into CamelCase. I've added the interface with just these methods, it's not actually used yet.

The long term plan is that TabContentsWrapper would become TabContents, while TabContents will become WebPageImpl

BUG=98716
Review URL: http://codereview.chromium.org/8997020
------------------------------------------------------------------------
Project Member Comment 142 by bugdroid1@chromium.org, Dec 20 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115137

------------------------------------------------------------------------
r115137 | jam@chromium.org | Tue Dec 20 08:48:17 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/download/download_item_view.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/off_the_record_profile_impl.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_item_unittest.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/mock_download_item.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/off_the_record_profile_impl.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_file_manager.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_close_browsertest.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/download/download_item_gtk.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_unittest.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_state_info.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_applications/web_app.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_shelf_context_menu.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_file_unittest.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/download/download_item_controller.h?r1=115137&r2=115136&pathrev=115137
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_file.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_download_manager_delegate.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/download/download_shelf_gtk.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_crx_util.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/imageburner/webui_handler.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_extension_test.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/mock_download_file.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_item_model.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_history.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/download/download_shelf_controller.mm?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_util.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_browsertest.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/mock_download_file.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/download_database.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/profiler_ui.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/active_downloads_ui.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_test_observer.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/DEPS?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_test_observer.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/download/download_item_mac.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/mock_download_manager_delegate.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_file_impl.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_manager_unittest.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/mock_download_manager.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_request_handle.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_prefs.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_shelf_context_menu.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_service.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_item_model.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_query_unittest.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_query.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_installer.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_item_impl.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/chrome_download_manager_delegate.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_query.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_service.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_file_picker.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/workers_ui.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/testing_profile.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_resource_handler.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_history.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/mock_download_manager.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/mock_download_manager_delegate.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_file_manager.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/download_protection_service.h?r1=115137&r2=115136&pathrev=115137
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/download/download_item_view.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/active_downloads_ui.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_persistent_store_info.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager_impl.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_download_manager_delegate.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/download/download_item_mac.mm?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/advanced_options_handler.cc?r1=115137&r2=115136&pathrev=115137
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/download_item.h?r1=115137&r2=115136&pathrev=115137 (from /trunk/src/content/browser/download/download_item.h revision 115005)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host_unittest.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/download_protection_service.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_extension_api.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_impl.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/download/download_in_progress_dialog_view.cc?r1=115137&r2=115136&pathrev=115137
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_file.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/custom_drag.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/testing_profile.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_id_unittest.cc?r1=115137&r2=115136&pathrev=115137
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_item.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/download/download_in_progress_dialog_gtk.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_persistent_store_info.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_extension_api.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/app_controller_mac.mm?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/media/media_player.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/tracing_ui.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/download_protection_service_unittest.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/chrome_download_manager_delegate.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/browser_window_gtk.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browsing_data_remover.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_crx_util.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc?r1=115137&r2=115136&pathrev=115137
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/download_file.h?r1=115137&r2=115136&pathrev=115137 (from /trunk/src/content/browser/download/download_file.h revision 115005)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_browsertest.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_context.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/downloads_dom_handler.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/drag_download_file.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_browser_context.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/download/download_util_mac.mm?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_prefs.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_file_picker.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/advanced_options_handler.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/drag_download_file.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/test_browser_context.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_impl.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_file_impl.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/download/download_item_gtk.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/save_page_browsertest.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_item_impl.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/download_manager_delegate.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_create_info.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/download/download_item_cell.mm?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/downloads_ui.cc?r1=115137&r2=115136&pathrev=115137
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_item.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/download/download_shelf_view.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/download/download_item_controller.mm?r1=115137&r2=115136&pathrev=115137
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/download_manager.h?r1=115137&r2=115136&pathrev=115137 (from /trunk/src/content/browser/download/download_manager.h revision 115005)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_resource_handler.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_request_handle.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_util.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/custom_drag.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/save_package_file_picker.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/downloads_dom_handler.h?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager_impl.cc?r1=115137&r2=115136&pathrev=115137
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115137&r2=115136&pathrev=115137

Move DownloadFile/DownloadItem/DownloadManager interfaces into content/public/browser, and also put them into the content namespace.

BUG=98716
Review URL: http://codereview.chromium.org/9004005
------------------------------------------------------------------------
Project Member Comment 143 by bugdroid1@chromium.org, Dec 20 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115141

------------------------------------------------------------------------
r115141 | jam@chromium.org | Tue Dec 20 09:13:03 PST 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=115141&r2=115140&pathrev=115141 (from /trunk/src/content/public/browser/web_page.h revision 115043)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=115141&r2=115140&pathrev=115141
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_page.h?r1=115141&r2=115140&pathrev=115141
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115141&r2=115140&pathrev=115141

Rename content::WebPage to content::WebContents

BUG=98716,105875
Review URL: http://codereview.chromium.org/9004010
------------------------------------------------------------------------
Project Member Comment 144 by bugdroid1@chromium.org, Dec 20 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115200

------------------------------------------------------------------------
r115200 | jam@chromium.org | Tue Dec 20 14:32:52 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/intents/intent_injector.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_resource_request_policy_apitest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_application_mac.mm?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_manager.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_message_service.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/chrome_app_api_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/content_settings/content_setting_bubble_model.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_frontend_host.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/webui/web_ui.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_observer.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/net_internals_ui_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/workers_ui_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/aeropeek_manager.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/webui/edit_search_engine_dialog_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/browser_action_apitest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_browser_tests.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_process_apitest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/execute_code_in_tab_function.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_view_win.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_cloud.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_external_delegate.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/webui/hung_renderer_dialog_ui_test-inl.h?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/offline/offline_load_page_unittest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/in_process_webkit/indexed_db_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/web_drag_dest_mac.mm?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drag_source_win.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_nacl_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gpu_pixel_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/find_bar_host.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_win.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/accessibility/accessibility_util.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/pdf/pdf_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_util.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager_unittest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/web_drag_source_mac.mm?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/login/login_prompt_win.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_devtools_bridge.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_list_unittest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_helper.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabpose_window.mm?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_tab_observer.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_json.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/accessibility/accessibility_win_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_unload_handler.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/hung_renderer_controller.mm?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_view_manager.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/applescript/tab_applescript.mm?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/content_script_apitest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_debugger_api.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_install_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_resource_providers.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview_handler.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_tab_helper.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/web_ui_test_handler.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_manager_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/file_system/file_system_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/aura/app_list_window.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/task_manager_handler.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_id_map.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_dom_clipboard_apitest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/find_bar_gtk.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_tab_helper.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_http_handler_impl.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/gtk_util.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_startup_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_apitest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_devtools_browsertests.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/dragged_view_gtk.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_blocking_page.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details_unittest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/prefs/prefs_tab_helper.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/chrome_tab_contents_view_wrapper_gtk.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/tracing_ui.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/browser_window_gtk.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/constrained_window_tab_helper.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/isolated_app_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/test_render_view_host.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/web_drag_dest_gtk.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_input_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/background_printing_manager.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webrequest_apitest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_icon_source_apitest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_unittest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_keyevents_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/browser_with_test_window_test.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/webui/certificate_viewer_ui_test-inl.h?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_manager_impl.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/pdf/pdf_unsupported_feature.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/cloud_print_signin_dialog.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_focus_uitest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager_delegate_impl.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_tab_helper_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller_unittest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/hung_renderer_dialog.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_notification_resource_provider.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_incognito_apitest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_cloud_uitest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/mhtml_generation_manager.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/web_drag_source_gtk.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/media/media_internals_handler.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/hung_renderer_view.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/web_ui_unittest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/extension_settings_handler.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/magic_iframe_browsertest.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/notifications/balloon_view_host.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/restore_tab_helper.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager_impl.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115200&r2=115199&pathrev=115200
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/alternate_error_tab_observer.cc?r1=115200&r2=115199&pathrev=115200

Rename TabContents::render_view_host() to GetRenderViewHost and put it into the WebContents interface.

BUG=98716
Review URL: http://codereview.chromium.org/9007026
------------------------------------------------------------------------
Project Member Comment 145 by bugdroid1@chromium.org, Dec 20 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115213

------------------------------------------------------------------------
r115213 | tfarina@chromium.org | Tue Dec 20 15:00:42 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_manager.cc?r1=115213&r2=115212&pathrev=115213
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_tab_helper.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/intents_host.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/create_application_shortcut_view.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/content_settings/content_setting_bubble_model.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/history_ui.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/html_dialog_gtk.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/webui_login_view.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/default_tab_drag_controller.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/aeropeek_manager.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/notification_options_menu_model.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_container.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate_unittest.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_navigator.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_container.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_manager_unittest.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_view_win.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/html_dialog_gtk.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/html_dialog_view.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_screen.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/notifications/balloon_view_host.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_tab_contents_delegate.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/file_chooser_params.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_container.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/drag_data.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/DEPS?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/default_tab_drag_controller.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/registration_screen.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter.cc?r1=115213&r2=115212&pathrev=115213
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.cc?r1=115213&r2=115212&pathrev=115213 (from /trunk/src/content/browser/tab_contents/tab_contents_delegate.cc revision 115211)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/options_ui2.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_observer.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_view.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/html_page_screen.cc?r1=115213&r2=115212&pathrev=115213
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.h?r1=115213&r2=115212&pathrev=115213 (from /trunk/src/content/browser/tab_contents/tab_contents_delegate.h revision 115211)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/login/login_prompt_gtk.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/notification_types.h?r1=115213&r2=115212&pathrev=115213
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/background_contents.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/drag_data.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller_unittest.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/options_ui.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_screen.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_unload_handler.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_view.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/aura/app_list_window.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/html_dialog_view.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/applescript/tab_applescript.mm?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/web_intent_picker_gtk.h?r1=115213&r2=115212&pathrev=115213
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/registration_screen.h?r1=115213&r2=115212&pathrev=115213

Move TabContentsDelegate to content/public/browser and put it in the content namespace.

- Rename TabContentsDelegate to WebContentsDelegate and move it to web_contents_delegate.*

BUG=98716,105875
R=jam@chromium.org
TBR=avi@chromium.org

Review URL: http://codereview.chromium.org/9008013
------------------------------------------------------------------------
Project Member Comment 146 by bugdroid1@chromium.org, Dec 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115259

------------------------------------------------------------------------
r115259 | jam@chromium.org | Tue Dec 20 18:39:38 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/pdf/pdf_unsupported_feature.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/plugins_ui.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_prefs.cc?r1=115259&r2=115258&pathrev=115259
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/plugin_service.h?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/component_updater/pepper_flash_component_installer.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/plugin_info_message_filter.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/content_setting_bubble_gtk.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/file_manager_util.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/content_setting_bubble_contents.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/about_ui.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/component_updater/npapi_flash_component_installer.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/flash_ui.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/gview_request_interceptor_unittest.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service.h?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/gview_request_interceptor.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_content_settings_api.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/drag_util.mm?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_loader_posix.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_plugin_service_filter.cc?r1=115259&r2=115258&pathrev=115259
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_data_remover_helper.cc?r1=115259&r2=115258&pathrev=115259

Create an API around PluginService and use it from Chrome.

BUG=98716
Review URL: http://codereview.chromium.org/9006036
------------------------------------------------------------------------
Project Member Comment 147 by bugdroid1@chromium.org, Dec 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115276

------------------------------------------------------------------------
r115276 | jam@chromium.org | Tue Dec 20 21:09:04 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/html_dialog_window_controller.mm?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_manager.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_message_service.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/background_contents.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/auto_login_prompter.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/intents/web_intent_picker_controller.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_util.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/html_dialog_gtk.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/crash_recovery_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_controller.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_override_apitest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_browser_tests.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/notifications/balloon_controller.mm?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_navigator.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/constrained_html_delegate_views.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_process_apitest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/web_applications/web_app_ui.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/background/background_contents_service.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/constrained_html_delegate_mac.mm?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_cloud.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model_unittest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/location_bar_view_gtk.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_web_ui.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/alternate_nav_url_fetcher.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/pinned_tab_codec.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_page_actions_module.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_html_dialog_observer.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_win.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_feedback_infobar_delegate.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webstore_private_api.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/pdf/pdf_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_crash_recovery_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager_unittest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/boot_times_loader.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/errorpage_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/constrained_html_delegate_gtk.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/bug_report_ui.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/applescript/tab_applescript.mm?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/web_ui_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/sad_tab_view.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_tab_strip_model_observer.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/active_downloads_ui.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview_handler.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_tab_helper.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_url_rewrite_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/web_intent_picker_gtk.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_event_router.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/collected_cookies_infobar_delegate.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/dom_view.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/login/login_prompt.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/notifications/balloon_view.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/tab_restore_service.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_http_handler_impl.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_error_handler.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_blocking_page.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/test_tab_contents.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/options_menu_model.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_tab_helper.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/login/login_prompt_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/omnibox_search_hint.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/isolated_app_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/test_render_view_host.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_input_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/search_engine_tab_helper.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/browser_with_test_window_test.h?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/tab_contents_container.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bug_report_util.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_delegate.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_infobar_delegate.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_unittest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_keyevents_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/browser_with_test_window_test.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_commands_unittest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/cloud_print_signin_dialog.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/sync/tab_contents_wrapper_synced_tab_delegate.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_tab_helper.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_focus_uitest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager_delegate_impl.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/child_process_security_policy_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller_unittest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_container.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/location_bar/click_handler.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_bar_controller.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/web_ui_unittest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/repost_form_warning_controller.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115276&r2=115275&pathrev=115276
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/back_forward_menu_model.cc?r1=115276&r2=115275&pathrev=115276

Rename TabContents::controller() to GetController and put it into the WebContents namespace.

BUG=98716
TBR=dpranke
Review URL: http://codereview.chromium.org/8956050
------------------------------------------------------------------------
Project Member Comment 148 by bugdroid1@chromium.org, Dec 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115278

------------------------------------------------------------------------
r115278 | jam@chromium.org | Tue Dec 20 21:41:21 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/tracing_ui.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/browser_window_gtk.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_navigator_browsertest.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/external_protocol_dialog.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/find_bar_host.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/constrained_window_mac.mm?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/web_intent_picker_gtk.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/sad_tab_observer.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/advanced_options_utils_win.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_init.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/advanced_options_handler.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/advanced_options_utils_win.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/certificate_manager_handler.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/cloud_print_signin_dialog.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/advanced_options_handler.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/extensions/extension_view.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_focus_uitest.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_bubble_mac.mm?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_container.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/certificate_manager_handler.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_view_win.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_cloud.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/notifications/balloon_view_host_mac.mm?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/web_drag_source_gtk.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/constrained_window_gtk.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/extensions/extension_view_gtk.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/extension_settings_handler.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=115278&r2=115277&pathrev=115278
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115278&r2=115277&pathrev=115278

Rename TabContents::view() to GetView() and put it in the WebContents interface.

BUG=98716
TBR=tburkard
Review URL: http://codereview.chromium.org/8999005
------------------------------------------------------------------------
Project Member Comment 149 by bugdroid1@chromium.org, Dec 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115279

------------------------------------------------------------------------
r115279 | jam@chromium.org | Tue Dec 20 22:00:56 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/net/fake_external_tab.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ppapi_plugin_process_host.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_data_remover_impl.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_nacl_browsertest.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_prefs_unittest.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/plugin_service.h?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_browser_main.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/ppapi_uitest.cc?r1=115279&r2=115278&pathrev=115279
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service_impl.cc?r1=115279&r2=115278&pathrev=115279 (from /trunk/src/content/browser/plugin_service.cc revision 115259)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_loader_posix_unittest.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_loader_posix.h?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/enterprise_metrics_enrollment_browsertest.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=115279&r2=115278&pathrev=115279
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service_impl_browsertest.cc?r1=115279&r2=115278&pathrev=115279 (from /trunk/src/content/browser/plugin_service_browsertest.cc revision 115259)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/gview_request_interceptor_unittest.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/buffered_resource_handler.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=115279&r2=115278&pathrev=115279
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service.cc?r1=115279&r2=115278&pathrev=115279
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service.h?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.h?r1=115279&r2=115278&pathrev=115279
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service_browsertest.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service_unittest.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_process_host.cc?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=115279&r2=115278&pathrev=115279
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_loader_posix.cc?r1=115279&r2=115278&pathrev=115279
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/plugin_service_impl.h?r1=115279&r2=115278&pathrev=115279 (from /trunk/src/content/browser/plugin_service.h revision 115269)

Rename PluginService to PluginServiceImpl.

BUG=98716
Review URL: http://codereview.chromium.org/9019004
------------------------------------------------------------------------
Project Member Comment 150 by bugdroid1@chromium.org, Dec 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115325

------------------------------------------------------------------------
r115325 | joi@chromium.org | Wed Dec 21 05:41:19 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/arbitrator_dependency_factory.cc?r1=115325&r2=115324&pathrev=115325
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/access_token_store_browsertest.cc?r1=115325&r2=115324&pathrev=115325
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/access_token_store.cc?r1=115325&r2=115324&pathrev=115325
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/location_arbitrator.cc?r1=115325&r2=115324&pathrev=115325
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/location_arbitrator_unittest.cc?r1=115325&r2=115324&pathrev=115325
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/location_arbitrator.h?r1=115325&r2=115324&pathrev=115325
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/access_token_store.h?r1=115325&r2=115324&pathrev=115325
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/fake_access_token_store.h?r1=115325&r2=115324&pathrev=115325
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_access_token_store.cc?r1=115325&r2=115324&pathrev=115325
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/geolocation_provider_unittest.cc?r1=115325&r2=115324&pathrev=115325
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/fake_access_token_store.cc?r1=115325&r2=115324&pathrev=115325
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_access_token_store.h?r1=115325&r2=115324&pathrev=115325

Switch to PostTaskAndReply for AccessTokenStore.

This removes the only usage of the CancelableRequest class in
content/, and is in preparation for moving the class back to
chrome/browser.

The ability to cancel requests to the AccessTokenStore was never used in production, so the interface now changes to a simpler non-cancelable one, and the browsertest GeolocationAccessTokenStoreTest.CancelRequest which tested the functionality is removed.

BUG=98716

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114992
Reverted (ThreadChecker DCHECK on debug bots): r114997

Review URL: http://codereview.chromium.org/8996006
------------------------------------------------------------------------
Project Member Comment 151 by bugdroid1@chromium.org, Dec 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115326

------------------------------------------------------------------------
r115326 | joi@chromium.org | Wed Dec 21 05:43:51 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/cancelable_request.h?r1=115326&r2=115325&pathrev=115326
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=115326&r2=115325&pathrev=115326
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cancelable_request.cc?r1=115326&r2=115325&pathrev=115326 (from /trunk/src/content/browser/cancelable_request.cc revision 115325)
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cancelable_request.h?r1=115326&r2=115325&pathrev=115326 (from /trunk/src/content/browser/cancelable_request.h revision 115325)
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/DEPS?r1=115326&r2=115325&pathrev=115326
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=115326&r2=115325&pathrev=115326
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/cancelable_request.cc?r1=115326&r2=115325&pathrev=115326

Move CancelableRequest to chrome/browser.

This does not update the include paths used in existing code.  I will
later TBR a trivial change that removes the redirect header
(content/browser/cancelable_request.h) and updates all includes of
cancelable_request.h (and sorts headers correctly).

BUG=98716

Review URL: http://codereview.chromium.org/8974012
------------------------------------------------------------------------
Project Member Comment 152 by bugdroid1@chromium.org, Dec 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115335

------------------------------------------------------------------------
r115335 | joi@chromium.org | Wed Dec 21 07:04:47 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/arbitrator_dependency_factory.cc?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.h?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/access_token_store_browsertest.cc?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/content_browser_client.h?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/network_location_provider_unittest.cc?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/arbitrator_dependency_factory.h?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/network_location_provider.h?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/fake_access_token_store.h?r1=115335&r2=115334&pathrev=115335
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/access_token_store.cc?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_access_token_store.h?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/location_arbitrator.cc?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/arbitrator_dependency_factories_for_test.cc?r1=115335&r2=115334&pathrev=115335
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/access_token_store.cc?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/location_arbitrator_unittest.cc?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/location_arbitrator.h?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/arbitrator_dependency_factories_for_test.h?r1=115335&r2=115334&pathrev=115335
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/access_token_store.h?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_access_token_store.cc?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/location_provider.h?r1=115335&r2=115334&pathrev=115335
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/access_token_store.h?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/geolocation_provider_unittest.cc?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/network_location_provider.cc?r1=115335&r2=115334&pathrev=115335
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/geolocation/fake_access_token_store.cc?r1=115335&r2=115334&pathrev=115335

Move AccessTokenStore to Content API, now that it is a pure-virtual class.

BUG=98716


Review URL: http://codereview.chromium.org/8997008
------------------------------------------------------------------------
Project Member Comment 153 by bugdroid1@chromium.org, Dec 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115346

------------------------------------------------------------------------
r115346 | thakis@chromium.org | Wed Dec 21 09:36:30 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/html_dialog_window_controller.mm?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_manager.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_message_service.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/background_contents.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/auto_login_prompter.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/intents/web_intent_picker_controller.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_util.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/html_dialog_gtk.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/crash_recovery_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_controller.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_override_apitest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_browser_tests.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/notifications/balloon_controller.mm?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_navigator.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/constrained_html_delegate_views.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_process_apitest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/web_applications/web_app_ui.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/background/background_contents_service.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/constrained_html_delegate_mac.mm?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_cloud.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model_unittest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/location_bar_view_gtk.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_web_ui.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/alternate_nav_url_fetcher.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/pinned_tab_codec.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_page_actions_module.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_html_dialog_observer.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_win.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_feedback_infobar_delegate.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webstore_private_api.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/pdf/pdf_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_crash_recovery_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager_unittest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/boot_times_loader.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/errorpage_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/constrained_html_delegate_gtk.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/bug_report_ui.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/applescript/tab_applescript.mm?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/web_ui_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/sad_tab_view.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_tab_strip_model_observer.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/active_downloads_ui.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview_handler.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_tab_helper.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_url_rewrite_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/web_intent_picker_gtk.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_event_router.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/collected_cookies_infobar_delegate.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/dom_view.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/login/login_prompt.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/notifications/balloon_view.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/tab_restore_service.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_http_handler_impl.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_error_handler.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_blocking_page.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/test_tab_contents.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/options_menu_model.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_tab_helper.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/login/login_prompt_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/omnibox_search_hint.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/isolated_app_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/test_render_view_host.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_input_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/search_engine_tab_helper.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/browser_with_test_window_test.h?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/tab_contents_container.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bug_report_util.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_delegate.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_infobar_delegate.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_unittest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_keyevents_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/browser_with_test_window_test.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_commands_unittest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/cloud_print_signin_dialog.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/sync/tab_contents_wrapper_synced_tab_delegate.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_tab_helper.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_focus_uitest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager_delegate_impl.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/child_process_security_policy_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller_unittest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_container.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/location_bar/click_handler.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_bar_controller.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/web_ui_unittest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler2.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/repost_form_warning_controller.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115346&r2=115345&pathrev=115346
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/back_forward_menu_model.cc?r1=115346&r2=115345&pathrev=115346

Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests
on win,linux,mac.

Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace.

BUG=98716
TBR=dpranke
Review URL: http://codereview.chromium.org/8956050

TBR=jam

Review URL: http://codereview.chromium.org/9018016
------------------------------------------------------------------------
Project Member Comment 154 by bugdroid1@chromium.org, Dec 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115428

------------------------------------------------------------------------
r115428 | jam@chromium.org | Wed Dec 21 14:35:56 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/html_dialog_window_controller.mm?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_manager.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_message_service.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/background_contents.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/auto_login_prompter.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/intents/web_intent_picker_controller.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_util.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/html_dialog_gtk.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/crash_recovery_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_controller.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_override_apitest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_browser_tests.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/notifications/balloon_controller.mm?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_navigator.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/constrained_html_delegate_views.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_process_apitest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/web_applications/web_app_ui.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/background/background_contents_service.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/constrained_html_delegate_mac.mm?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_cloud.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model_order_controller.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model_unittest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/location_bar_view_gtk.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_web_ui.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/alternate_nav_url_fetcher.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/pinned_tab_codec.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_page_actions_module.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_html_dialog_observer.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_win.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_feedback_infobar_delegate.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webstore_private_api.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/pdf/pdf_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_crash_recovery_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager_unittest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/boot_times_loader.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/errorpage_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/constrained_html_delegate_gtk.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/bug_report_ui.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/applescript/tab_applescript.mm?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/web_ui_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/sad_tab_view.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_tab_strip_model_observer.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/active_downloads_ui.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview_handler.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_tab_helper.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_url_rewrite_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/web_intent_picker_gtk.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_event_router.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/collected_cookies_infobar_delegate.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/dom_view.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/login/login_prompt.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/notifications/balloon_view.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/tab_restore_service.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_http_handler_impl.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_error_handler.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_blocking_page.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/test_tab_contents.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/options_menu_model.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_tab_helper.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/login/login_prompt_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/omnibox_search_hint.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/isolated_app_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/test_render_view_host.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_input_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/search_engine_tab_helper.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/browser_with_test_window_test.h?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/tab_contents_container.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bug_report_util.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_delegate.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_infobar_delegate.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_unittest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_keyevents_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/browser_with_test_window_test.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_commands_unittest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/cloud_print_signin_dialog.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/sync/tab_contents_wrapper_synced_tab_delegate.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_tab_helper.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_focus_uitest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager_delegate_impl.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/child_process_security_policy_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller_unittest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_container.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/location_bar/click_handler.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_bar_controller.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/web_ui_unittest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler2.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/repost_form_warning_controller.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115428&r2=115427&pathrev=115428
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/back_forward_menu_model.cc?r1=115428&r2=115427&pathrev=115428

Revert 115346. The change didn't break anything, the test was faulty. Will disable in a followup. - Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests
on win,linux,mac.

Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace.

BUG=98716
TBR=dpranke
Review URL: http://codereview.chromium.org/8956050

TBR=jam

Review URL: http://codereview.chromium.org/9018016

TBR=thakis@chromium.org
------------------------------------------------------------------------
Project Member Comment 155 by bugdroid1@chromium.org, Dec 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115435

------------------------------------------------------------------------
r115435 | jam@chromium.org | Wed Dec 21 14:55:30 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/gpu_internals_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_manager.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/login/enterprise_oauth_enrollment_screen_handler.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/flags_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/sync_internals_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/auto_login_prompter.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_util.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ntp/new_tab_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/history_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_change_processor.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/plugins_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chrome_web_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/background/background_contents_service.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_bubble_views.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_backend_unittest.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_bubble_gtk.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_web_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/profiler_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/input_window_dialog_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/infobars/infobar_gtk.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/task_manager_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/chrome_interstitial_page.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/media/media_internals_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/options_ui2.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/crashes_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_util.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/edit_search_engine_dialog_ui_webui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/conflicts_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_helper.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/chrome_download_manager_delegate.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/user_style_sheet_watcher.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/extensions/extensions_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/bug_report_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/workers_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chrome_web_ui_factory.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/devtools_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/bookmarks_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_debugger_api.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_manager.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_browsertest.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/policy_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/active_downloads_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/advanced_options_handler2.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_tab_helper.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/about_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/quota_internals_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/certificate_viewer_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/register_page_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_event_router.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_handler_unittest.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/offline/offline_load_page.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_tab_helper.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/personal_options_handler2.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/flash_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/test_chrome_web_ui_factory.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/dragged_view_gtk.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/test_tab_contents.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/options_menu_model.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/keyboard_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_util.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/tracing_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/isolated_app_browsertest.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/search_engine_tab_helper.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/drag_download_file.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_tab_helper.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_infobar_delegate.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/advanced_options_handler.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_unittest.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/locale_change_guard.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/hung_renderer_dialog_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/system_info_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/aura/app_list_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_container.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/downloads_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_win.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_content_browser_client.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/options_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/top_sites.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/uber/uber_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/web_ui_unittest.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/sessions_ui.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/save_package_file_picker.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/personal_options_handler.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager_impl.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/back_forward_menu_model.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete_history_manager.cc?r1=115435&r2=115434&pathrev=115435
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=115435&r2=115434&pathrev=115435

Rename TabContents::browser_context() to GetBrowserContext and put it into the WebContents interface. 

BUG=98716
Review URL: http://codereview.chromium.org/9021022
------------------------------------------------------------------------
Project Member Comment 156 by bugdroid1@chromium.org, Dec 22 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115495

------------------------------------------------------------------------
r115495 | jam@chromium.org | Wed Dec 21 22:55:31 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/oom_priority_manager.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/browser_window_gtk.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/test_render_view_host.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_navigator_browsertest.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_browsertest.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/default_tab_drag_controller.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_manager_browsertest.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview_ui_unittest.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/aura/app_list_window.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_policy.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_unittest.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_manager_extension_api.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/browser_titlebar.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_message_handler.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/browser_with_test_window_test.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager_unittest.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/web_drag_source_mac.mm?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/webkit_browsertest.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/cloud_print_signin_dialog.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_browser_tests.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/sync/tab_contents_wrapper_synced_tab_delegate.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/save_page_browsertest.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_navigator.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_process_apitest.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/webui_login_view.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/core_tab_helper.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/web_drag_source_gtk.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/web_ui_unittest.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/applescript/window_applescript.mm?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/prefs/prefs_tab_helper.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_view_manager.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview_ui.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/wrench_menu_model.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/web_ui_browsertest.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115495&r2=115494&pathrev=115495
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview_handler_unittest.cc?r1=115495&r2=115494&pathrev=115495

Move a bunch of methods from TabContents into the WebContents interface. This change either moves CamelCase functions into the interface, or renames existing unix_hacker functions to CamelCase.

BUG=98716
Review URL: http://codereview.chromium.org/8949061
------------------------------------------------------------------------
Project Member Comment 157 by bugdroid1@chromium.org, Dec 22 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115498

------------------------------------------------------------------------
r115498 | jam@chromium.org | Wed Dec 21 23:39:00 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/language_state.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/omnibox_search_hint.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/constrained_window_tab_helper.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_list.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_manager.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_tab_helper.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_quota_permission_context.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_feedback_infobar_delegate.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/keystone_infobar_delegate.mm?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115498&r2=115497&pathrev=115498
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/navigation_details.h?r1=115498&r2=115497&pathrev=115498 (from /trunk/src/content/browser/tab_contents/navigation_details.h revision 115435)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_init.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_delegate.cc?r1=115498&r2=115497&pathrev=115498
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/navigation_details.cc?r1=115498&r2=115497&pathrev=115498 (from /trunk/src/content/browser/tab_contents/navigation_details.cc revision 115435)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_infobar_delegate.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_unittest.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_observer.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_settings_state_unittest.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_id_map.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/workers_ui_browsertest.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller_unittest.cc?r1=115498&r2=115497&pathrev=115498
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_details.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_helper.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller_unittest.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=115498&r2=115497&pathrev=115498
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_details.h?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/confirm_infobar_delegate.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/top_sites.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_bar_controller.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_settings_state.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=115498&r2=115497&pathrev=115498
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_browsertest.cc?r1=115498&r2=115497&pathrev=115498

Move navigation_details.h to content/public/browser.

BUG=98716
Review URL: http://codereview.chromium.org/8949066
------------------------------------------------------------------------
Project Member Comment 158 by bugdroid1@chromium.org, Dec 22 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115560

------------------------------------------------------------------------
r115560 | jam@chromium.org | Thu Dec 22 10:19:27 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/DEPS?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_resource_providers.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/wrench_menu.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_unittest.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager.h?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/metrics_handler.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_browser_tests.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.h?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_view_win.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/applescript/window_applescript.mm?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/web_drag_dest_mac.mm?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_view_manager.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager_impl.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115560&r2=115559&pathrev=115560
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc?r1=115560&r2=115559&pathrev=115560

Move the remaining TabContents methods to the WebContents interface, switching unix_hacker to CamelCase as necessary. I've moved the WebContents definitions to be in the same order as the declarations.

BUG=98716
TBR=dpranke
Review URL: http://codereview.chromium.org/8958003
------------------------------------------------------------------------
Project Member Comment 159 by bugdroid1@chromium.org, Dec 22 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115599

------------------------------------------------------------------------
r115599 | jam@chromium.org | Thu Dec 22 12:51:25 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/intents/intent_injector.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_manager.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/constrained_window_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_manager.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/background_contents.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/alternate_error_tab_observer.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/restore_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_view_manager.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/prefs/prefs_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_observer.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/intents/web_intents_dispatcher_impl.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_observer.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/snapshot_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/search_engine_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_http_handler_impl.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/intents/intent_injector.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/tab_contents_wrapper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/core_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter_observer.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/constrained_html_ui_browsertest.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/prefs/prefs_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_browsertest.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_page_capture_api.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/constrained_window_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/DEPS?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete_history_manager.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/snapshot_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/search_engine_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/pdf/pdf_tab_observer.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/sad_tab_observer.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller_browsertest.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/frame_navigate_params.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/intents/web_intents_dispatcher_impl.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_observer.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/bookmarks/bookmark_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/thumbnail_generator.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/sad_tab_observer.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_message_handler.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter_observer.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/hung_renderer_dialog.h?r1=115599&r2=115598&pathrev=115599
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_observer.cc?r1=115599&r2=115598&pathrev=115599 (from /trunk/src/content/browser/tab_contents/tab_contents_observer.cc revision 115560)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/background_contents.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/execute_code_in_tab_function.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_observer.h?r1=115599&r2=115598&pathrev=115599 (from /trunk/src/content/browser/tab_contents/tab_contents_observer.h revision 115560)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/hung_renderer_dialog.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_protocol/external_protocol_observer.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/file_select_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_message_handler.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/hung_renderer_view.cc?r1=115599&r2=115598&pathrev=115599
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_observer.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/hung_renderer_controller.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/hung_renderer_controller.mm?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_view_manager.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/pdf/pdf_tab_observer.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/restore_tab_helper.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_protocol/external_protocol_observer.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/core_tab_helper.h?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete_history_manager.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/alternate_error_tab_observer.cc?r1=115599&r2=115598&pathrev=115599
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=115599&r2=115598&pathrev=115599

Move TabContentsObserver to content/public, rename it to WebContentsObserver, and put it into the content namespace.

BUG=98716
TBR=tburkard
Review URL: http://codereview.chromium.org/9026011
------------------------------------------------------------------------
Project Member Comment 160 by bugdroid1@chromium.org, Dec 22 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115617

------------------------------------------------------------------------
r115617 | tfarina@chromium.org | Thu Dec 22 13:55:29 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/notification_types.h?r1=115617&r2=115616&pathrev=115617
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.cc?r1=115617&r2=115616&pathrev=115617
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/default_tab_drag_controller.cc?r1=115617&r2=115616&pathrev=115617

Rename notification to NOTIFICATION_WEB_CONTENTS_DELEGATE_DESTROYED.

BUG=98716
R=jam@chromium.org

Review URL: http://codereview.chromium.org/9022014
------------------------------------------------------------------------
Project Member Comment 161 by bugdroid1@chromium.org, Dec 23 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115653

------------------------------------------------------------------------
r115653 | tfarina@chromium.org | Thu Dec 22 17:04:08 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.cc?r1=115653&r2=115652&pathrev=115653
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.h?r1=115653&r2=115652&pathrev=115653

Get rid of all the empty functions in the source file for WebContentsDelegate.

BUG=98716
R=jam@chromium.org

Review URL: http://codereview.chromium.org/9024020
------------------------------------------------------------------------
Project Member Comment 162 by bugdroid1@chromium.org, Dec 23 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115664

------------------------------------------------------------------------
r115664 | jam@chromium.org | Thu Dec 22 17:36:47 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_notification_types.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/intents/intent_injector.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_context_menu_model.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_manager.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/mock_tab_event_observer.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/constrained_window_tab_helper.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/constrained_window_tab_helper.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_manager.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/location_bar/page_action_with_badge_view.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_quota_permission_context.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/location_bar/page_action_image_view.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_util.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/snapshot_tab_helper.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/pdf/pdf_tab_observer.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller_browsertest.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/pdf/pdf_browsertest.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/select_file_dialog.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/intents/web_intents_dispatcher_impl.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/prefs/prefs_tab_helper.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/intents/web_intents_dispatcher_impl.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_id_map.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/snapshot_tab_helper.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter_observer.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/location_bar/page_action_image_view.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_http_handler_impl.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/hung_renderer_dialog.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_observer.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_add_cert_handler.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/intents/intent_injector.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_tab_helper_unittest.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/hung_renderer_dialog.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_observer.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/tab_contents_wrapper.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_tab_helper.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_cookies_helpers.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter_observer.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/constrained_html_ui_browsertest.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_plugin_message_filter.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/hung_renderer_view.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/prefs/prefs_tab_helper.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/hung_renderer_controller.mm?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/retargeting_details.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_util.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.h?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/desktop_notification_service.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_tab_helper.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=115664&r2=115663&pathrev=115664
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc?r1=115664&r2=115663&pathrev=115664

Change most of the methods of WebContentsObserver to take a content::WebContents instead of a TabContents, and update all the dependent code.

BUG=98716
Review URL: http://codereview.chromium.org/9022023
------------------------------------------------------------------------
Project Member Comment 163 by bugdroid1@chromium.org, Dec 25 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115766

------------------------------------------------------------------------
r115766 | jam@chromium.org | Sat Dec 24 19:59:51 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/language_state.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.h?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details_win.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview_handler.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_tab_helper.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_url_rewrite_browsertest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_policy.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_event_router.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/offline/offline_load_page.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_model_associator.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/tab_restore_service.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_http_handler_impl.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_override_apitest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_process_apitest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_unittest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details_mac.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/test_tab_contents.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/location_bar_view_gtk.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service_unittest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/options_menu_model.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_types.h?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/pinned_tab_codec.cc?r1=115766&r2=115765&pathrev=115766
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/navigation_entry.h?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/omnibox_search_hint.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_page_actions_module.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/tab_restore_service_browsertest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/constrained_window_tab_helper.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/test_render_view_host.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/search_engine_tab_helper.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_handler.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/navigation_details.h?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_delegate.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_unittest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_infobar_delegate.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.h?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/browser_with_test_window_test.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/render_view_host_manager_unittest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry_unittest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry.h?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_commands_unittest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_navigation_observer.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_installer.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/rlz/rlz.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/base_session_service.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_controller_unittest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_types.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_container.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/location_bar/click_handler.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/back_forward_menu_model.h?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_bar_controller.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/top_sites.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/download/download_shelf_view.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu_browsertest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_settings_state.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/bug_report_ui.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/applescript/tab_applescript.mm?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/back_forward_menu_model.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details_history.cc?r1=115766&r2=115765&pathrev=115766
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_browsertest.cc?r1=115766&r2=115765&pathrev=115766

Create a Content API around NavigationEntry that's in content/public/browser. NavigationEntry will be renamed to NavigationEntryImpl in a later change. It now derives from content::NavigationEntry. Most of this change is changing unix_hacker functions to CamelCase and updating callers.

BUG=98716
TBR=brettw
Review URL: http://codereview.chromium.org/9007043
------------------------------------------------------------------------
Project Member Comment 164 by bugdroid1@chromium.org, Dec 25 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115777

------------------------------------------------------------------------
r115777 | jam@chromium.org | Sun Dec 25 13:37:09 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_notification_types.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_manager.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_extension_api.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tab_contents_container_gtk.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/insecure_content_infobar_delegate.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/auto_login_prompter.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_bubble_controller.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_menu_manager.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_util.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/content_settings/content_setting_bubble_model.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_change_processor.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/search_engine_tab_helper.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_menu_manager.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/content_setting_bubble_gtk.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/extensions/extension_dialog.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/render_view_devtools_agent_host.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_navigator.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/download/download_started_animation_mac.mm?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_helper.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/tab_contents_wrapper.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/certificate_dialogs.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_window.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function_test_utils.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/file_select_helper.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_tab_helper.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/alternate_nav_url_fetcher.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tab_contents_container_gtk.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_manager.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/default_search_view.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/infobars/infobar_gtk.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/DEPS?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_win.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_feedback_infobar_delegate.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webstore_private_api.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_init.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_observer.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_manager_extension_api.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_browsertest.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_message_handler.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter_observer.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/auto_login_prompter.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/boot_times_loader.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/template_url_fetcher_ui_callbacks.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_helper.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/interstitial_page.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_started_animation.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/file_select_helper.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_view_manager.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_manager.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_resource_providers.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_tab_helper.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/template_url_fetcher_ui_callbacks.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/content_setting_bubble_gtk.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sidebar/sidebar_manager.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_sidebar_api.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_event_router.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/collected_cookies_infobar_delegate.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_ssl_helper.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/devtools_agent_host_registry.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/search_engine_tab_helper_delegate.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_tab_helper.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_tab_helper.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/content_setting_bubble_contents.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_installer_infobar_delegate.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/tab_contents_container.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/select_file_dialog.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_infobar_delegate.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/options_menu_model.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/content_setting_bubble_contents.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/certificate_dialogs.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/default_tab_drag_controller.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/background_printing_manager.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_inline_installer.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/search_engine_tab_helper.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_contents/tab_contents_container.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/select_file_dialog.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_tab_helper.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/base_bubble_controller.mm?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function_dispatcher.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_delegate.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_infobar_delegate.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_sidebar_api.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/download/download_started_animation_views.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_observer.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/notification_types.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_tab_helper.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/default_search_view.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_observer.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_file_browser_private_api.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_util.h?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/download/download_started_animation_gtk.cc?r1=115777&r2=115776&pathrev=115777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=115777&r2=115776&pathrev=115777

Convert a bunch of WebContentsObservers to use web_contents() instead of tab_contents(), as well as all the dependent code.

BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8982008
------------------------------------------------------------------------
Project Member Comment 165 by bugdroid1@chromium.org, Dec 26 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115800

------------------------------------------------------------------------
r115800 | jam@chromium.org | Mon Dec 26 11:06:17 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/ui_test_utils.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_notification_types.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/sad_tab_view.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/intents/intent_injector.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/constrained_window_tab_helper.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_manager.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/alternate_error_tab_observer.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/snapshot_tab_helper.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/sad_tab_observer.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/intents/web_intents_dispatcher_impl.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_observer.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/prefs/prefs_tab_helper.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/thumbnail_generator.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_tab_helper.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_delegate.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/notification_types.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/sad_tab_view.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_delegate.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/core_tab_helper.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/find_bar/find_bar_controller.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/find_bar_host_interactive_uitest.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/thumbnail_generator.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/prefs/prefs_tab_helper.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/malware_details.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/core_tab_helper.h?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_tab_helper.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/alternate_error_tab_observer.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=115800&r2=115799&pathrev=115800
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc?r1=115800&r2=115799&pathrev=115800

Move most of the remaining users of WebContentsObserver::tab_contents() to use web_contents().

BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9030010
------------------------------------------------------------------------
Project Member Comment 166 by bugdroid1@chromium.org, Dec 26 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115801

------------------------------------------------------------------------
r115801 | jam@chromium.org | Mon Dec 26 13:18:26 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/sad_tab_gtk.h?r1=115801&r2=115800&pathrev=115801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc?r1=115801&r2=115800&pathrev=115801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/hung_renderer_view.cc?r1=115801&r2=115800&pathrev=115801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/sad_tab_observer.cc?r1=115801&r2=115800&pathrev=115801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=115801&r2=115800&pathrev=115801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/sad_tab_gtk.cc?r1=115801&r2=115800&pathrev=115801
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_observer.h?r1=115801&r2=115800&pathrev=115801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm?r1=115801&r2=115800&pathrev=115801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h?r1=115801&r2=115800&pathrev=115801
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm?r1=115801&r2=115800&pathrev=115801

Get rid of WebContentsObserver::tab_contents().

BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9043001
------------------------------------------------------------------------
Project Member Comment 167 by bugdroid1@chromium.org, Dec 27 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115810

------------------------------------------------------------------------
r115810 | jam@chromium.org | Mon Dec 26 23:39:20 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/html_dialog_window_controller.mm?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_manager.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/background_contents.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/notifications/balloon_view.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_bubble_controller.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_bubble.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/test_html_dialog_ui_delegate.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/task_manager_dialog.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/html_dialog_gtk.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ssl_client_certificate_selector_webui.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_bubble_browsertest.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_bubble_controller_unittest.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/notifications/balloon_view.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents_delegate_unittest.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/notifications/balloon_controller.mm?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/constrained_html_delegate_views.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/sim_dialog_delegate.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/sim_dialog_delegate.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/cloud_print/cloud_print_setup_flow.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_container.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_tab_helper.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_bubble_mac.mm?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_bubble_views.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/input_window_dialog_webui.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_cloud.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/notifications/balloon_view_host_mac.mm?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/html_dialog_gtk.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ssl_client_certificate_selector_webui.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/html_dialog_view.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/keyboard_overlay_delegate.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_cloud_internal.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/choose_mobile_network_dialog.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/keyboard_overlay_delegate.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_bubble_gtk.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_util.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_container.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/html_dialog_window_controller_unittest.mm?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_util.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/edit_search_engine_dialog_webui.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/certificate_viewer_webui.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/login_html_dialog.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/choose_mobile_network_dialog.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/test_html_dialog_ui_delegate.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/edit_search_engine_dialog_webui.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/input_window_dialog_webui.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/cloud_print_signin_dialog.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/hung_renderer_dialog.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/background_contents.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/infobars/infobar_tab_helper.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/notifications/balloon_host.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/hung_renderer_dialog.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_notification_resource_provider.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/collected_cookies_ui_delegate.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/html_dialog_ui.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/login/login_prompt_ui.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_unload_handler.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/speech/speech_input_bubble.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/html_dialog_view.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/certificate_viewer_webui.h?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/login_html_dialog.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/notifications/balloon_view_host.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_cloud_unittest.cc?r1=115810&r2=115809&pathrev=115810
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc?r1=115810&r2=115809&pathrev=115810

Convert SpeechInputBubble and BalloonHost to use WebContents instead of TabContents, as well as all the dependent code.

BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9016038
------------------------------------------------------------------------
Project Member Comment 168 by bugdroid1@chromium.org, Dec 27 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115822

------------------------------------------------------------------------
r115822 | joi@chromium.org | Tue Dec 27 06:05:24 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_service.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/base_session_service.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_manager.cc?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browsing_data_remover.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/download/download_item_view.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.cc?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/download/download_item_mac.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor.cc?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/icon_manager.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/boot_times_loader.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/jumplist_win.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_marshaling.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_browsertest.cc?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/system/timezone_settings.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_store_consumer.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_model.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ntp/most_visited_handler.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/DEPS?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_handler.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/top_sites.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/version_loader.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/certificate_manager_handler.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/history_menu_bridge.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ntp/app_launcher_handler.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/system/syslogs_provider.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/test/integration/typed_urls_helper.cc?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/history_model_worker.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/top_sites_backend.h?r1=115822&r2=115821&pathrev=115822
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/cancelable_request.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_finder.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/history_ui.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/top_sites_extension_api.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_store.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_history.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/global_history_menu.h?r1=115822&r2=115821&pathrev=115822
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/certificate_manager_handler2.h?r1=115822&r2=115821&pathrev=115822

Remove temporary redirect header and DEPS exception for cancelable_request.h

TBR=jam@chromium.org
BUG=98716

Review URL: http://codereview.chromium.org/9021017
------------------------------------------------------------------------
Project Member Comment 169 by bugdroid1@chromium.org, Dec 27 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115830

------------------------------------------------------------------------
r115830 | dhollowa@chromium.org | Tue Dec 27 08:42:41 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/memcheck/suppressions.txt?r1=115830&r2=115829&pathrev=115830

Valgrind leak reported for BalloonHost::Init

Adds suppression for BalloonHost::Init.  The leak report started with
r115810 due to refactoring.  Appears to be a singleton report.

BUG=98716
TEST=Valgrind goes green on Chromium OS Bot
R=jam@chromium.org

Review URL: http://codereview.chromium.org/9046006
------------------------------------------------------------------------
Project Member Comment 170 by bugdroid1@chromium.org, Dec 27 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115847

------------------------------------------------------------------------
r115847 | jam@chromium.org | Tue Dec 27 13:38:17 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/language_state.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview_handler.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_tab_helper.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_url_rewrite_browsertest.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tab_util.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_policy.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/save_package.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_handler_unittest.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/browser_dialogs.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/page_info_bubble_view.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/page_info_bubble_gtk.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/tab_restore_service.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/debugger/devtools_http_handler_impl.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_override_apitest.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_browser_tests.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/app_process_apitest.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/browser_window_gtk.h?r1=115847&r2=115846&pathrev=115847
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/ssl_status.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_dialog_cloud.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/page_info_bubble_view.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_window.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry.cc?r1=115847&r2=115846&pathrev=115847
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/favicon_status.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ssl/ssl_blocking_page.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_window.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/test_tab_contents.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/wrench_menu_model.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/location_bar_view_gtk.cc?r1=115847&r2=115846&pathrev=115847
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/favicon_status.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/options_menu_model.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_tab_helper.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/pinned_tab_codec.cc?r1=115847&r2=115846&pathrev=115847
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/ssl_status.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/navigation_entry.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/browser_window_gtk.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/omnibox_search_hint.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/constrained_window_tab_helper.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/test_render_view_host.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_cocoa.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/DEPS?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/browser_feature_extractor.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/instant/instant_loader.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/language_state.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/ssl/ssl_manager.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/login/login_prompt_mac.mm?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/search_engines/search_engine_tab_helper.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/favicon/favicon_handler.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/pdf/pdf_browsertest.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_infobar_delegate.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_mac.mm?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry_unittest.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/page_info_bubble_controller.mm?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/page_info_bubble.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/login/login_prompt_gtk.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/client_side_detection_host.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/cloud_print_signin_dialog.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_cocoa.mm?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_installer.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/location_bar/click_handler.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/web_drag_source_gtk.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_browser_window.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu_browsertest.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel.h?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/bug_report_ui.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager_worker_resource_provider.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/back_forward_menu_model.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/download/download_started_animation_gtk.cc?r1=115847&r2=115846&pathrev=115847
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager_browsertest.cc?r1=115847&r2=115846&pathrev=115847

Move FaviconStatus and SSLStatus out of NavigationEntry into their own files in content/public and in the content namespace. I've also made them structs instead of classes. This was because I didn't want to wrap them with Content API for what were really a collection of member variables. The one exception was SSLStatus::content_status which had helper functions around it to set and get the bitfield. Each of the two setter helpers were only called in one non-test code, and read in a few places, so I just converted them to do it directly.

BUG=98716
Review URL: http://codereview.chromium.org/9048002
------------------------------------------------------------------------
Project Member Comment 171 by bugdroid1@chromium.org, Dec 28 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=115858

------------------------------------------------------------------------
r115858 | jam@chromium.org | Tue Dec 27 17:29:20 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/webui/generic_handler.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/insecure_content_infobar_delegate.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_utils.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/test/integration/performance/sessions_sync_perf_test.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_shelf_context_menu.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_utils.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/safe_browsing_resource_handler.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/crash_recovery_browsertest.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_navigator.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/oom_priority_manager_browsertest.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/page_info_bubble_view.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/global_history_menu.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ntp/ntp_login_handler.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_settings_menu_model.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/web_drag_dest_mac.mm?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model_unittest.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/instant_confirm_view.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/location_bar_view_gtk.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/network_delay_listener.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/window_open_apitest.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/google/google_url_tracker.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/alternate_nav_url_fetcher.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/user_script_listener_unittest.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/panels/panel_browsertest.cc?r1=115858&r2=115857&pathrev=115858
 A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/page_navigator.cc?r1=115858&r2=115857&pathrev=115858 (from /trunk/src/content/browser/tab_contents/page_navigator.cc revision 115810)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/user_script_listener.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/external_tab_container_win.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/sad_tab_gtk.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/accessibility/renderer_accessibility_browsertest.cc?r1=115858&r2=115857&pathrev=115858
 D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/page_navigator.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_init.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_observer.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_browsertest.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/page_info_bubble_controller.mm?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/navigation_entry.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/resource_dispatcher_host.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_navigator.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_delegate.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/network_delay_listener.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/accessibility/accessibility_win_browsertest.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_resource_handler.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/applescript/tab_applescript.mm?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/web_intent_picker_gtk.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/registration_screen.h?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_drop_target_win.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/sad_tab_view.cc?r1=115858&r2=115857&pathrev=115858
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation