Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 98456 third_party/psutil fails licensecheck
Starred by 1 user Project Member Reported by phajdan.jr@chromium.org, Sep 28 2011 Back to list
Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2011
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 28291

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment
$ tools/checklicenses/checklicenses.py --ignore-suppressions third_party/psutil/
'third_party/psutil/setup.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/_psposix.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/_psutil_mswindows.h' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/_psutil_bsd.c' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/_pslinux.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/_psosx.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/arch/bsd/process_info.h' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/arch/bsd/process_info.c' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/arch/mswindows/security.h' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/arch/mswindows/process_handles.c' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/arch/mswindows/process_info.h' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/arch/mswindows/process_handles.h' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/arch/mswindows/security.c' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/arch/mswindows/process_info.c' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/arch/osx/process_info.h' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/arch/osx/process_info.c' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/_psutil_osx.c' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/_psmswindows.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/error.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/_psutil_osx.h' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/_psbsd.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/compat.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/__init__.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/_psutil_bsd.h' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/psutil/_psutil_mswindows.c' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/test/_osx.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/test/test_memory_leaks.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/test/test_psutil.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/test/_bsd.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/test/_windows.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/test/_posix.py' has non-whitelisted license 'UNKNOWN'
'third_party/psutil/test/_linux.py' has non-whitelisted license 'UNKNOWN'

Please make sure those files have license headers and make third_party/devscripts/licensecheck.pl recognize them. Patches to that script should be submitted upstream. Please also remove the suppression from tools/checklicenses/checklicenses.py
 
Blocking: 28291
Cc: nirnimesh@chromium.org
Owner: imasaki@chromium.org
Kenji added psutil. Reassigning.
Status: ExternalDependency
http://code.google.com/p/psutil/issues/detail?id=212 is filed.

A clarifying update:

1. Make sure all files in question have license headers that identify the license. It doesn't have to contain full text of the license, but it should identify the license type precisely enough, e.g. "APSL" or "BSD (3-clause)".

   - if the project in question is developed by Google, there is no excuse; go and fix it
   - if it's a third party project, we should ask them to add license headers (a bug should be filed); then you can put the third party bug link in the Chromium bug and change the Chromium bug status to ExternalDependency

2. We don't add the license headers ourselves to code we didn't write. Added because people asked about that.

3. If the files have license headers but they're still not recognized, third_party/devscripts/licensecheck.pl should be patched. Please remember to also update chromium-1.patch (you can get original licensecheck.pl by reverse-applying that patch). You _don't_ need to upstream your changes, I'll take care of that. In fact, if you don't feel like messing with perl or reverse-applying things, just send me your regular expressions (make sure they're good).

4. Finnally, the suppression should be removed from tools/checklicenses/checklicenses.py . Please respect OWNERS of that file.

That should be it, thank you for your feedback and work on the bugs (11 bugs have already been fixed).
I have submitted patch in psutils. It is being reviewed.

Cc: phajdan.jr@chromium.org dennisjeffrey@chromium.org
Status: Started
http://codereview.chromium.org/8159001/ is submitted for this fix.

Comment 7 Deleted
Project Member Comment 9 by bugdroid1@chromium.org, Oct 13 2012
Blocking: -chromium:28291 chromium:28291
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 10 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-Internals Cr-Internals
Sign in to add a comment